Commit Graph

3920 Commits

Author SHA1 Message Date
Zachary Anderson
e2bb119248 Fix Platform.localeName by setting _Platform._localeClosure (flutter/engine#4450) 2017-12-12 15:01:13 -08:00
Michael Goderbauer
9e95f34064 Roll forward: Parameters for SemanticActions; a11y text selection (flutter/engine#4452)
Reverts the revert in #4448 with fixes to pass on the bot.

This change will require framework changes in flutter/flutter#13490.
2017-12-12 14:25:45 -08:00
Siva Chandra
61bb8c8535 Roll dart to 962c18b627c76f22166cd0bb8ab9e1b21d3c7305 (flutter/engine#4451)
* Roll dart to 962c18b627c76f22166cd0bb8ab9e1b21d3c7305.

* Update travis/licenses_golden/licenses_third_party
2017-12-12 14:06:28 -08:00
najeira
0c188ca473 Map iOS touches to Flutter view coordinate system (flutter/engine#4425)
This change ensures that touches are mapped to the Flutter view
co-ordinate system. In the case of a Flutter view that doesn't share the
same origin and orientation as the screen co-ordinate system, touches
were appled in the wrong location. This bug affected Flutter views whose
origin was not the screen origin and Flutter apps running with the
in-call status bar on iPhones other than the iPhone X.
2017-12-12 13:22:53 -08:00
Chris Bracken
7f0f66cf1a Model Android keyboard height as view inset (flutter/engine#4447)
Model top and side system insets as padding and bottom (keyboard) as a
view inset. This avoids applying system insets twice (once as an inset,
once as padding).
2017-12-12 11:04:42 -08:00
Michael Goderbauer
4cc04bfe16 Revert " Add parameters to SemanticActions; implement extend selection for a11y (#4444)" (flutter/engine#4448)
This reverts commit 4fc00d4735.
2017-12-12 10:53:15 -08:00
Michael Goderbauer
4fc00d4735 Add parameters to SemanticActions; implement extend selection for a11y (flutter/engine#4444) 2017-12-12 10:06:04 -08:00
Jason Simmons
6e8a6af1f8 Check for a detached FlutterNativeView before sending messages (flutter/engine#4445)
Fixes https://github.com/flutter/flutter/issues/13481
2017-12-11 17:15:21 -08:00
Jason Simmons
b2f8ce750a libtxt: track the font metrics of each run in order to calculate heights in GetRectsForRange (flutter/engine#4442)
Previously GetRectsForRange was assigning each rectangle a height matching the
height of the entire line.  If the line includes multiple text styles, callers
will expect each span's rectangle to reflect the height of that span.
(see text_painter_rtl_test.dart)
2017-12-11 14:38:17 -08:00
Vyacheslav Egorov
95058cefa9 Update VM entry points list to include some previous omitted entries. (flutter/engine#4440)
This fixes obfuscated snapshot mode.
2017-12-11 11:27:23 -08:00
Zachary Anderson
83e44abb94 Roll Dart to d8ae797298c3a6cf8dc9f4558707bd2672224d3e (flutter/engine#4439) 2017-12-11 09:33:32 -08:00
Chris Bracken
fd36bd7b22 Support iOS scroll-to-top tap on iPhone X (flutter/engine#4436)
This adds support for scrolling the primary scroll view to the top on
status bar touches, on the iPhone X.

Notes:
1. The iPhone X status bar doesn't change height when in in-call/etc.
   mode, and unlike other iPhones, does scroll to top when in in-call mode.
2. No matter which model of iOS device, the top safe area inset doesn't
   change when in in-call mode. In in-call mode, the OS reduces the app
   view height by 20px off the top, and the double-height 'in-call' status
   bar covers this new inset (outside the view) and there continues to be a
   20px safe area in the app.

On iOS 11, rather than comparing status bar height to a hardcoded 20px
'standard height' we now compare to the top safe area inset (which is
always the standard status bar height, regardless of device). On iOS
versions prior to iOS 11, we use the previous logic.

Fixes flutter/flutter#13439
2017-12-08 19:36:53 -08:00
Ben Konyi
889bf73002 Rolled forward buildroot to fix Windows build issues. (flutter/engine#4435) 2017-12-08 17:16:25 -08:00
Ben Konyi
6bc54d490c Fixed failure on Windows in paragraph.cc which was surfaced by enabling (flutter/engine#4434)
Fixed failure on Windows in paragraph.cc which was surfaced by enabling flutter_tester.exe build on bots.
2017-12-08 16:27:47 -08:00
Chinmay Garde
003e3cce17 Add macros to mark APIs as being deprecated or unavailable. (flutter/engine#4401) 2017-12-08 13:30:45 -08:00
Jason Simmons
161f3faa33 Exclude Skia's copy of libjpeg-turbo from the license crawl (flutter/engine#4432) 2017-12-08 11:50:13 -08:00
Ben Konyi
d023506388 Fixed errors introduced in landing of fml changes for Windows. (flutter/engine#4431) 2017-12-08 11:17:48 -08:00
Ben Konyi
5ff8528682 Updated fml to build on Windows. (flutter/engine#4415) 2017-12-08 10:40:10 -08:00
Brian Osman
adf6949757 Remove SkToBool usage (flutter/engine#4429) 2017-12-08 13:28:06 -05:00
Chris Bracken
34b9f8685b Expose keyboard height as view inset on iOS (flutter/engine#4428)
Keyboard height is now treated as a view inset, which could be used to
shrink the content area of the app as is done in the Material Scaffold,
rather than padding, which is used to indicate content areas where user
interaction should be avoided.
2017-12-07 18:37:46 -08:00
Jason Simmons
271d4be92e Do not report a cursor location if there is no active selection (flutter/engine#4427)
Fixes https://github.com/flutter/flutter/issues/13398
2017-12-07 17:43:51 -08:00
Ryan Macnak
61df6c5122 Roll Dart to a38ac7cf127f4611c873c2f2d523c06ce06b1342. (flutter/engine#4422) 2017-12-06 16:48:37 -08:00
Michael Goderbauer
d07e420443 Fix typo (flutter/engine#4424) 2017-12-06 16:14:04 -08:00
Michael Goderbauer
18e6fd711d A11y cursor movements for text fields on Android (flutter/engine#4419)
* a11y cursor movement by character

* focus fixes

* doc fixes
2017-12-06 15:46:35 -08:00
Chris Bracken
c3a99d4fbb Fix an extra paren in locale_test.dart (flutter/engine#4423) 2017-12-06 15:38:40 -08:00
Jason Simmons
c159071c43 libtxt: implement GetWordBoundary using the ICU word breaker (flutter/engine#4421) 2017-12-06 15:23:40 -08:00
Chris Bracken
cfc2cf4c3a Set window.viewInsets.bottom to keyboard height on iOS (flutter/engine#4420)
This allows for us to start migrating framework classes (notably
Scaffold) to use window.viewInsets.bottom to get the keyboard height.
Once framework updates have landed, we will land an engine patch to
expose the iOS bottom safe area inset as padding.

This change is already landed for Android.

Related issue: flutter/flutter#12098
2017-12-06 15:06:12 -08:00
Jason Simmons
4d46c62401 libtxt: handle lines containing both LTR and RTL text runs (flutter/engine#4416)
* Call the ICU bidi API to divide the text into LTR/RTL runs and merge
  them with the styled runs defined by the application
* Maintain a list of glyph positions sorted by the order of the corresponding
  code units in the text, as well as a list of glyphs sorted by x/y coordinates
  in the layout
2017-12-06 14:46:03 -08:00
Ian Hickson
e900158d72 Make Locale know about the deprecated Hebrew language code. (flutter/engine#4411)
...by making it know about ALL the deprecated language and region codes.
2017-12-06 12:17:30 -08:00
Chris Bracken
cac7eba5ea Update the iOS mark region on setTextInputState (flutter/engine#4418)
Previously, we failed to clear/update the mark text range on updates
from the framework. This resulted in a crash if the incoming text value
was shorter than the current mark range when iOS attempts to extract the
mark range substring from the text.

Fixes flutter/flutter#12585
2017-12-06 11:30:14 -08:00
Ben Konyi
ed302e6512 Dart SDK roll for 2017/12/08. (flutter/engine#4417) 2017-12-05 19:56:47 -05:00
Brian Osman
49808d7687 Disable linear blending on iOS simulator (flutter/engine#4413)
Fixes flutter/flutter#13308

Overlooked this case when I previously removed linear blending. MakeS32 creates a surface with a color space attached (triggering the linear blending behavior). MakeN32 creates a legacy surface (no color space), which matches what the other backend bindings do (including the GL surface factory, and the raster cache).
2017-12-05 08:38:53 -05:00
Alexander Markov
8c8c058d48 Roll Dart SDK to d4cfecb1065d322d3670df7e9ec9a0cc2d4b90f0 (flutter/engine#4414) 2017-12-04 13:46:45 -08:00
Adam Barth
e76704006f [fuchsia] Sandbox Flutter runner (flutter/engine#4410) 2017-12-04 12:35:38 -08:00
Alexander Markov
e7d9371831 Front-end server: use VM-specific package:vm/kernel_front_end (flutter/engine#4412)
* Use the VM-specific wrapper for the kernel front-end to support VM-specific kernel transformations.
* Also, pass a flag to distinguish AOT mode from JIT mode to enable whole-program optimizations.
2017-12-02 17:37:32 -08:00
xster
9d2403ff10 Block image decoding on iOS in the background (flutter/engine#4384)
* Add synchronization to ResourceContext usage

* debug

* Use unique ptr factory

* formatting

* left more notes for future readers
2017-12-01 12:09:00 -08:00
Alexander Aprelev
e05c8cc2d8 Roll dart to 48a927acb2dc4178691b4ddfa817e87043e30b01 (flutter/engine#4409)
* Roll dart to f5fc335a4cdfcf96ae550044c64044ffe599e595

* Update license hash

* Roll a little further to pick up a revert

* Update hash
2017-12-01 11:13:31 -08:00
Ben Konyi
576964aa79 ifdef'd out unused code on non-Windows platforms (flutter/engine#4408) 2017-11-30 20:04:42 -05:00
Ben Konyi
31f0a6055c Changes to assets/ build/ flow/ runtime/ and shell/ to allow for compilation on Windows (flutter/engine#4407)
Made changes to assets/ build/ flow/ runtime/ and shell/ to allow for
compilation on Windows.
2017-11-30 19:47:20 -05:00
Ben Konyi
3f795be2a2 Added Windows support for libtxt in order to build flutter_tester.exe (flutter/engine#4395)
* Added Windows support for libtxt in order to build flutter_tester.exe.

Relatively minor changes were needed to get libtxt building on Windows
(missing/incompatiable headers, the odd syscall, path separators, etc.).
Windows doesn't render text in the same way as other platforms, so some tests
that checked for specific pixel offsets are disabled.
2017-11-30 16:35:32 -05:00
Zachary Anderson
c79fb5a400 [Android] Extract the PluginRegistry from the FlutterActivity (flutter/engine#4393) 2017-11-30 11:05:55 -08:00
Chris Bracken
6ae141180c Use WindowPadding class to represent view insets (flutter/engine#4406)
This drops the ViewInsets class in favour of the existing WindowPadding
class for representing the view insets.
2017-11-30 10:47:14 -08:00
Siva
a8d051c664 Roll dart version in flutter engine. (flutter/engine#4402)
* Roll dart version in flutter engine.

* Update license file.
2017-11-30 08:13:16 -08:00
Chris Bracken
5b3d343de6 Expose Window.viewInsets in dart:ui (flutter/engine#4403)
Window.viewInsets is the set of window-relative insets that describe the
area of the window that an application may want to treat as effectively
reducing the size of the content. Typically this is due to system UI
that fully obscures underlying content, such as the keyboard.

This area differs from padding in that padding is the set of insets that
describe the area of the window that may be partially (or fully)
obscured by system UI or physical intrusions into the view area (e.g.
iPhone X sensor housing, status bar, or the iPhone X home indicator
widget).

This patch does not yet enable the iOS bottom edge safe area. Once the
framework has been updated to use viewInsets for bottom-edge occlusions
(today, the keyboard), the bottom safe area will be enabled and
framework patches that depend on it, landed.
2017-11-29 16:27:15 -08:00
Ben Konyi
3e17abfaf5 Updated sky directory to compile on Windows. (flutter/engine#4399) 2017-11-29 18:53:48 -05:00
Jason Simmons
59c2536d34 Set a pending dimension change in the animator only if the viewport's physical width/height changed (flutter/engine#4400)
Fixes https://github.com/flutter/flutter/issues/13183
2017-11-29 10:55:45 -08:00
Ben Konyi
76cf72a8c3 Added Semaphore implementation for Windows. (flutter/engine#4396) 2017-11-29 13:41:49 -05:00
Alexander Aprelev
35acd03c15 Run frontend server from temp directory to force absolute URIs in Kernel file. (flutter/engine#4394)
* Run frontend server from temp directory to force absolute URIs in Kernel file.

* Create special directory to cwd into to avoid conflicts with app sources in temp folder

* Make variable final
2017-11-28 13:58:51 -08:00
ethanblake4
955b41aaba Fix: use firstRequestedOrientation in fallthrough case (flutter/engine#4392) 2017-11-27 00:09:56 -08:00
P.Y. Laligand
b97185b2ca [fuchsia] Updated path to package template. (flutter/engine#4390) 2017-11-22 18:57:26 -08:00