firka/flutter
3
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Set window.viewInsets.bottom to keyboard height on iOS (flutter/engine#4420)

Browse Source 
This allows for us to start migrating framework classes (notably
Scaffold) to use window.viewInsets.bottom to get the keyboard height.
Once framework updates have landed, we will land an engine patch to
expose the iOS bottom safe area inset as padding.

This change is already landed for Android.

Related issue: flutter/flutter#12098
This commit is contained in:
Chris Bracken
2017-12-06 15:06:12 -08:00
committed by GitHub
parent 4d46c62401
commit cfc2cf4c3a
1 changed files with 8 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterViewController.mm
View File

@@ -656,17 +656,19 @@ static inline blink::PointerData::DeviceKind DeviceKindFromTouchType(UITouch* to
NSDictionary* info = [notification userInfo];
CGFloat bottom = CGRectGetHeight([[info objectForKey:UIKeyboardFrameEndUserInfoKey] CGRectValue]);
CGFloat scale = [UIScreen mainScreen].scale;
// TODO(cbracken): Once framework has been updated to use view insets, keyboard should change
// insets rather than padding.
// _viewportMetrics.physical_view_inset_bottom = bottom * scale;
_viewportMetrics.physical_view_inset_bottom = bottom * scale;
// TODO(cbracken): Once framework has been updated to use view insets for keyboard padding,
// eliminate this line.
_viewportMetrics.physical_padding_bottom = bottom * scale;
[self updateViewportMetrics];
}
- (void)keyboardWillBeHidden:(NSNotification*)notification {
// TODO(cbracken): Once framework has been updated to use view insets, keyboard should change
// insets rather than padding.
// _viewportMetrics.physical_view_inset_bottom = 0;
_viewportMetrics.physical_view_inset_bottom = 0;
// TODO(cbracken): Once framework has been updated to use view insets for keyboard padding,
// eliminate this line.
_viewportMetrics.physical_padding_bottom = 0;
[self updateViewportMetrics];
}