firka/flutter
3
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
33,155 Commits 1 Branch 0 Tags
261ebc4fdb4bf37ac7c548db311882c574e4b0d6
Commit Graph

33155 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
skia-flutter-autoroll
261ebc4fdb Roll Dart SDK from 422e0bcdcf96 to feb35ba49cd7 (2 revisions) (flutter/engine#48839) 
https://dart.googlesource.com/sdk.git/+log/422e0bcdcf96..feb35ba49cd7

2023-12-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-209.0.dev
2023-12-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-208.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-08 19:29:12 +00:00
Zachary Anderson
ff0ecf88c5 Run full clang_tidy in presubmit (flutter/engine#48831) 
I'm seeing post-submit runs of full clang_tidy taking about ~20-ish
minutes excluding queue time, so the premise of
https://github.com/flutter/flutter/issues/139769 may be incorrect. In
that case, we should re-enable full clang_tidy in presubmit and observe
any impacts to queue time.

Context is that the clang autoroll became unblocked and landed a roll
that passed clang_tidy checks in presubmit, but then failed in post
submit: https://github.com/flutter/engine/pull/48817
 2023-12-08 10:00:14 -08:00
skia-flutter-autoroll
6ad3d04825 Roll Skia from 13c286972ea3 to e55567fceb5f (4 revisions) (flutter/engine#48834) 
https://skia.googlesource.com/skia.git/+log/13c286972ea3..e55567fceb5f

2023-12-08 kjlubick@google.com Rename legacy Bazel targets in //modules
2023-12-08 johnstiles@google.com Ensure dm reports its progress at least every 4 seconds.
2023-12-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 9da917953470 to d4258544ceac (6 revisions)
2023-12-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from dc4b1acd4859 to b8ca8de43841 (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-08 16:27:23 +00:00
skia-flutter-autoroll
00b054b86a Roll Dart SDK from 2c928cc12f94 to 422e0bcdcf96 (1 revision) (flutter/engine#48822) 
https://dart.googlesource.com/sdk.git/+log/2c928cc12f94..422e0bcdcf96

2023-12-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-207.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-08 15:32:51 +00:00
skia-flutter-autoroll
2c23d94297 Roll Skia from 9e89d96899f4 to 13c286972ea3 (1 revision) (flutter/engine#48821) 
https://skia.googlesource.com/skia.git/+log/9e89d96899f4..13c286972ea3

2023-12-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from f24d68c0b358 to 2291a55e72cd (20 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-08 15:29:42 +00:00
Jackson Gardner
3133e1fbca Add the flutter_js target as a dep to web_sdk. (flutter/engine#48814) 
Currently, the `flutter_js` target is built as part of the flutter_web_sdk_archive target. However, it should also be built when doing the normal web_sdk, as that is what the monorepo builds (and does its own archiving).
 2023-12-08 15:28:12 +00:00
auto-submit[bot]
f7a88fc8f1 Reverts "Roll Clang from 00396e6a1a0b to 725656bdd885" (flutter/engine#48832) 
Reverts flutter/engine#48817
Initiated by: zanderso
This change reverts the following previous change:
Original Description:

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/clang-flutter-engine
Please CC chinmaygarde@google.com,rmistry@google.com,zanderso@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Clang: https://bugs.fuchsia.dev/p/fuchsia/issues/list?q=component%3AToolchain
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-08 15:04:18 +00:00
skia-flutter-autoroll
404b3cdb1b Roll Dart SDK from be8a95b6717d to 2c928cc12f94 (6 revisions) (flutter/engine#48818) 
https://dart.googlesource.com/sdk.git/+log/be8a95b6717d..2c928cc12f94

2023-12-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-206.0.dev
2023-12-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-205.0.dev
2023-12-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-204.0.dev
2023-12-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-203.0.dev
2023-12-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-202.0.dev
2023-12-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-201.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-08 02:24:22 +00:00
skia-flutter-autoroll
5a23e2862c Roll Clang from 00396e6a1a0b to 725656bdd885 (flutter/engine#48817) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/clang-flutter-engine
Please CC chinmaygarde@google.com,rmistry@google.com,zanderso@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Clang: https://bugs.fuchsia.dev/p/fuchsia/issues/list?q=component%3AToolchain
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-08 02:04:19 +00:00
gaaclarke
4124911784 [Impeller] implements new blur tile mode (flutter/engine#48805) 
fixes https://github.com/flutter/flutter/issues/139165

## before

<img width="1027" alt="Screenshot 2023-12-07 at 2 18 42 PM"
src="https://github.com/flutter/engine/assets/30870216/606d7203-20d6-4efd-a788-2f539508a280">


## after

<img width="1026" alt="Screenshot 2023-12-07 at 2 14 39 PM"
src="https://github.com/flutter/engine/assets/30870216/8209b372-e477-4552-b4d1-2296b1e6d2d8">


## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-12-07 16:06:04 -08:00
skia-flutter-autoroll
c97bdcde90 Roll Skia from dd7e37c0e2bd to 9e89d96899f4 (2 revisions) (flutter/engine#48809) 
https://skia.googlesource.com/skia.git/+log/dd7e37c0e2bd..9e89d96899f4

2023-12-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from d5f6f7c34c83 to 9da917953470 (7 revisions)
2023-12-07 johnstiles@google.com Improve diagnostic text from NoDestructor.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-07 23:12:15 +00:00
Matan Lurey
cb8b4e07f6 Add a note that rolling clang_version manually is dangerous. (flutter/engine#48808) 
See
https://github.com/flutter/flutter/wiki/Engine-pre‐submits-and-post‐submits#post-submit.
 2023-12-07 14:57:24 -08:00
skia-flutter-autoroll
91da8ecf7d Roll Skia from b541f668f531 to dd7e37c0e2bd (3 revisions) (flutter/engine#48804) 
https://skia.googlesource.com/skia.git/+log/b541f668f531..dd7e37c0e2bd

2023-12-07 bungeman@google.com Fix spelling of MININUM
2023-12-07 nscobie@google.com Allow any exception to pass SkQP's SkSL error tests
2023-12-07 briansalomon@gmail.com Remove empty source list from shared_sources.gni

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-07 22:21:41 +00:00
Jason Simmons
e1ddb5e7f6 Revert Dart SDK back to be8a95b6717d (flutter/engine#48799) 
See https://github.com/flutter/flutter/issues/139755
 2023-12-07 21:59:06 +00:00
Victoria Ashworth
31210e4a38 Retry when safaridriver fails (flutter/engine#48791) 
Starting `safaridriver` is flakey sometimes on macOS 13. It will occasionally error with "Operation not permitted". As a workaround, if it fails with that message, retry starting `safaridriver`.

Fixes https://github.com/flutter/flutter/issues/136972.

Example of fix on macOS 13 bot: https://ci.chromium.org/ui/p/flutter/builders/try/Mac%20Engine%20Drone/564967/overview
Note: The test is still failing due to https://github.com/flutter/flutter/issues/136279, but you can see it first has error "Operation not permitted" and retries and connects on second attempt.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-12-07 21:55:06 +00:00
skia-flutter-autoroll
301283a2dd Roll Skia from f49ec3e6c1b1 to b541f668f531 (2 revisions) (flutter/engine#48796) 
https://skia.googlesource.com/skia.git/+log/f49ec3e6c1b1..b541f668f531

2023-12-07 jvanverth@google.com [Vulkan] Allow push constants on Qualcomm devices.
2023-12-07 robertphillips@google.com [graphite] Allow 'tall_stretched_bitmaps' to run on the Dawn bots

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-07 21:34:26 +00:00
auto-submit[bot]
dc9d6cb793 Reverts "Update clang revision from 00396e6a1a0b7 to b3a9e8f7c0afb00." (flutter/engine#48802) 
Reverts flutter/engine#48705
Initiated by: zanderso
This change reverts the following previous change:
Original Description:
Previously attempted by https://github.com/flutter/engine/pull/48563 but failed because of fixes needed in https://github.com/flutter/engine/pull/48693
 2023-12-07 21:02:30 +00:00
Chinmay Garde
d7e9f69ce3 Update clang revision from 00396e6a1a0b7 to b3a9e8f7c0afb00. (flutter/engine#48705) 
Previously attempted by https://github.com/flutter/engine/pull/48563 but failed because of fixes needed in https://github.com/flutter/engine/pull/48693
 2023-12-07 19:44:16 +00:00
skia-flutter-autoroll
4cc7876a3e Roll Skia from c68e050e9198 to f49ec3e6c1b1 (1 revision) (flutter/engine#48790) 
https://skia.googlesource.com/skia.git/+log/c68e050e9198..f49ec3e6c1b1

2023-12-07 robertphillips@google.com [graphite] Add Android Graphite-Vulkan WindowContext creation helper

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-07 18:08:17 +00:00
skia-flutter-autoroll
594b872ad3 Roll Skia from af998f66ae73 to c68e050e9198 (1 revision) (flutter/engine#48788) 
https://skia.googlesource.com/skia.git/+log/af998f66ae73..c68e050e9198

2023-12-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 6a9824d7b61e to fd238f3fc588

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-07 17:27:53 +00:00
Jason Simmons
09e12e0f51 Reland "Replace use of Fontmgr::RefDefault with explicit creation calls" (flutter/engine#48764) 
Relands https://github.com/flutter/engine/pull/48571 with a patch that uses the directory-based SkFontMgr as a default font manager on Linux
 2023-12-07 15:45:08 +00:00
skia-flutter-autoroll
76b315be4d Roll Skia from 308f3d9bef2c to af998f66ae73 (1 revision) (flutter/engine#48784) 
https://skia.googlesource.com/skia.git/+log/308f3d9bef2c..af998f66ae73

2023-12-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms from 945923e21457 to ffaff60d9659 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-07 15:12:49 +00:00
skia-flutter-autoroll
38483f2fc0 Roll Skia from 2b33ff5642c3 to 308f3d9bef2c (1 revision) (flutter/engine#48777) 
https://skia.googlesource.com/skia.git/+log/2b33ff5642c3..308f3d9bef2c

2023-12-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 7c94b6d771a5 to d5f6f7c34c83 (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-07 10:11:23 +00:00
skia-flutter-autoroll
dfe925db3d Roll Dart SDK from 4b22e6430c20 to b6d5e010d2c5 (1 revision) (flutter/engine#48776) 
https://dart.googlesource.com/sdk.git/+log/4b22e6430c20..b6d5e010d2c5

2023-12-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-202.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-07 09:30:17 +00:00
skia-flutter-autoroll
31c6a156af Roll Skia from 0753f680c573 to 2b33ff5642c3 (1 revision) (flutter/engine#48772) 
https://skia.googlesource.com/skia.git/+log/0753f680c573..2b33ff5642c3

2023-12-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from f58ba0886370 to dc4b1acd4859 (7 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-07 07:42:09 +00:00
skia-flutter-autoroll
1313fa862c Roll Skia from 0f1822e9137a to 0753f680c573 (1 revision) (flutter/engine#48771) 
https://skia.googlesource.com/skia.git/+log/0f1822e9137a..0753f680c573

2023-12-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 4befa3ada54c to 77be35e337bb (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-07 06:33:36 +00:00
skia-flutter-autoroll
9533a6792d Roll Skia from dbcf508d1dce to 0f1822e9137a (1 revision) (flutter/engine#48769) 
https://skia.googlesource.com/skia.git/+log/dbcf508d1dce..0f1822e9137a

2023-12-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 8160db278a63 to f24d68c0b358 (23 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-07 05:48:21 +00:00
skia-flutter-autoroll
29c963f361 Roll Dart SDK from be8a95b6717d to 4b22e6430c20 (1 revision) (flutter/engine#48768) 
https://dart.googlesource.com/sdk.git/+log/be8a95b6717d..4b22e6430c20

2023-12-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-201.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-07 05:48:20 +00:00
skia-flutter-autoroll
7227929e66 Roll Skia from 8ebf43ba1c09 to dbcf508d1dce (1 revision) (flutter/engine#48766) 
https://skia.googlesource.com/skia.git/+log/8ebf43ba1c09..dbcf508d1dce

2023-12-07 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll skcms from 529510fe003a to 945923e21457 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-07 05:00:22 +00:00
Jason Simmons
6f48ab3443 Revert "Replace use of Fontmgr::RefDefault with explicit creation calls" (flutter/engine#48755) 
This reverts commit d5d8b5de90.

The flutter/tests/skp_generator test (running in flutter_tester on
Linux) was failing, along with some customer tests.
 2023-12-06 17:50:14 -08:00
skia-flutter-autoroll
e0f9af8da2 Roll Skia from 2abb01e18ab3 to 8ebf43ba1c09 (1 revision) (flutter/engine#48761) 
https://skia.googlesource.com/skia.git/+log/2abb01e18ab3..8ebf43ba1c09

2023-12-07 contact@omeid.me Implement onMatchFamilyStyle for SkParagraph.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-07 01:50:04 +00:00
skia-flutter-autoroll
3fff2ca308 Roll Dart SDK from dbfe4e3f867e to be8a95b6717d (1 revision) (flutter/engine#48757) 
https://dart.googlesource.com/sdk.git/+log/dbfe4e3f867e..be8a95b6717d

2023-12-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-200.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-07 00:32:59 +00:00
godofredoc
3551cb7ac6 Remove obsolete properties. (flutter/engine#48753) 
These properties were used within recipes to generate the gn and ninja commands for the different platforms. With V2 gn commands and its properties are set explicitly and the properties are not required anymore.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-12-06 22:55:04 +00:00
skia-flutter-autoroll
9610e75839 Roll Skia from 7ff0103760d0 to 2abb01e18ab3 (1 revision) (flutter/engine#48751) 
https://skia.googlesource.com/skia.git/+log/7ff0103760d0..2abb01e18ab3

2023-12-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from b8034f11414b to 7c94b6d771a5 (13 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-06 21:53:06 +00:00
skia-flutter-autoroll
8e321f89a0 Roll Skia from 570103e08087 to 7ff0103760d0 (1 revision) (flutter/engine#48748) 
https://skia.googlesource.com/skia.git/+log/570103e08087..7ff0103760d0

2023-12-06 jvanverth@google.com [GL] Enable TransferPixelsFromTextureTest for M1 tasks.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-06 21:04:51 +00:00
skia-flutter-autoroll
d9e59a5f9f Roll Skia from 326bdc97ac40 to 570103e08087 (1 revision) (flutter/engine#48746) 
https://skia.googlesource.com/skia.git/+log/326bdc97ac40..570103e08087

2023-12-06 ccameron@chromium.org SkCGUtils: Fix color space usage

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-06 20:17:53 +00:00
skia-flutter-autoroll
b69313946f Roll Dart SDK from 6eb13603c212 to dbfe4e3f867e (1 revision) (flutter/engine#48745) 
https://dart.googlesource.com/sdk.git/+log/6eb13603c212..dbfe4e3f867e

2023-12-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-199.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-06 20:17:50 +00:00
Jonah Williams
8b54eb6bf5 [Impeller] Store Buffer/Texture bindings in vector instead of map. (flutter/engine#48719) 
Places the binding data in a vector, since they key was only meaningful on metal but not used anywhere. I don't think that we need to specificially handle the case where our own contents bind the same contents multiple times, but interested to discuss if folks disagree.
 2023-12-06 19:32:41 +00:00
skia-flutter-autoroll
a75c76e6ec Roll Skia from 33cba437bf70 to 326bdc97ac40 (2 revisions) (flutter/engine#48743) 
https://skia.googlesource.com/skia.git/+log/33cba437bf70..326bdc97ac40

2023-12-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from bebb07797be7 to c890c27e81bc
2023-12-06 jvanverth@google.com [GL] Add Apple Silicon support and fix transfer alignment issue.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-06 19:28:22 +00:00
Jason Simmons
2de054c92a [Impeller] Provide the clear color to an advanced blend if it was optimized out (flutter/engine#48646) 
If all previous elements were skipped due to clear color optimization,
then the clear color must be rendered as an input to the advanced blend
if framebuffer fetch is not available.
 2023-12-06 10:46:22 -08:00
Loïc Sharma
ea34df3c56 [Windows] Set swap interval on raster thread after startup (flutter/engine#47787) 
The EGL context can only be used by a single thread at a time. Currently:

1. The platform thread uses the EGL context to configure the render surface when a `FlutterViewController` is created
2. The raster thread uses the EGL context to render

In a multi-view world, a `FlutterViewController` can be created in parallel to a rendering operation. This results in multiple threads attempting to use the EGL context in parallel, which can crash (see https://github.com/flutter/flutter/issues/137973).

This change configures the render surface on the raster thread if the raster thread exists (aka the engine is running).

Addresses https://github.com/flutter/flutter/issues/137973

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-12-06 18:44:17 +00:00
skia-flutter-autoroll
e5f88de515 Roll Skia from 384d14063dc1 to 33cba437bf70 (3 revisions) (flutter/engine#48740) 
https://skia.googlesource.com/skia.git/+log/384d14063dc1..33cba437bf70

2023-12-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from a85db99b109f to 6d35505d6747
2023-12-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll debugger-app-base from 7c0dd491306e to bcc08563e656
2023-12-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll shaders-base from debc2d5dd36c to efb13717ecae

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-06 18:35:49 +00:00
Loïc Sharma
6c6f23360c [Windows] Refactor the GLES proc table (flutter/engine#48688) 
GLES functions are resolved at runtime. This refactors how these functions are stored by introducing the `GlProcTable` abstraction.

This is a step towards switching the Windows embedder to `FlutterCompositor` rendering as the present callback will use the `GlProcTable` to render OpenGL backing stores.
 
Part of https://github.com/flutter/flutter/issues/128904

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-12-06 18:19:36 +00:00
Kevin Lubick
d5d8b5de90 Replace use of Fontmgr::RefDefault with explicit creation calls (flutter/engine#48571) 
In https://g-issues.skia.org/issues/305780908 Skia is removing the
default SkFontMgr. Previous work consolidated all references to
txt/platform.h and this replaces those last references. I attempted to
mirror the existing functionality, which still responds to GN flags and
the target platform.

After this PR, Flutter should not be depending on the default fontmgr
(and the defines in flutter_defines.gni) will maintain that behavior
until the legacy functions/methods are deleted from Skia. There were a
few tests that I missed on an earlier PR which relied on the default
font (helper added in #47493). These tests were failing because they
were making some assertions related to TextBlobs, which didn't work if
the (now-empty) Typeface they loaded had no glyphs. Thus, I added a few
extra asserts to make sure these textblobs *had* glyphs which make the
failing tests less mysterious, should this issue crop up again.

I cleaned up Flutter's BUILD.gn file for Skia a bit, deleting unused
targets related to the font managers. This involved fixing an implicit
dependency from //third_party/glfw/ to `Gdi32.lib` on Windows.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-12-06 13:02:34 -05:00
Jonah Williams
9eb8dc90f3 [Impeller] disable entity culling by default. (flutter/engine#48717) 
From local testing across both flutter galleries, wonderous, some other test apps, the only time this code successfully culls is during the stretch overscroll (and we cull 1 or so entries). The cost of this culling is approximately 20% of entity rendering time, and about 5% of overall raster time.

![image](https://github.com/flutter/engine/assets/8975114/ef85629c-48a8-457f-8385-0c8136404571)
 2023-12-06 18:00:07 +00:00
skia-flutter-autoroll
c31f4b027f Roll Skia from 23e1cb20a6b5 to 384d14063dc1 (1 revision) (flutter/engine#48738) 
https://skia.googlesource.com/skia.git/+log/23e1cb20a6b5..384d14063dc1

2023-12-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll jsfiddle-base from b23272a3cb61 to 6ceb3b75033e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-06 17:47:10 +00:00
skia-flutter-autoroll
a84b6362ed Roll Skia from 12dffa893c2a to 23e1cb20a6b5 (1 revision) (flutter/engine#48737) 
https://skia.googlesource.com/skia.git/+log/12dffa893c2a..23e1cb20a6b5

2023-12-06 briansalomon@gmail.com [graphite] Externalize the use of Asyncify to yield in WASM builds.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-06 17:02:59 +00:00
skia-flutter-autoroll
909857fc6f Roll Dart SDK from 691e4650ce91 to 6eb13603c212 (1 revision) (flutter/engine#48736) 
https://dart.googlesource.com/sdk.git/+log/691e4650ce91..6eb13603c212

2023-12-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-198.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-06 16:28:49 +00:00
skia-flutter-autoroll
e727de502f Roll Skia from afa75c6cf697 to 12dffa893c2a (1 revision) (flutter/engine#48732) 
https://skia.googlesource.com/skia.git/+log/afa75c6cf697..12dffa893c2a

2023-12-06 jvanverth@google.com [graphite] Flush all tracked devices when invalidating PathAtlas.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-06 15:22:12 +00:00
skia-flutter-autoroll
3aaeda6006 Roll Dart SDK from 9e54241e915a to 691e4650ce91 (1 revision) (flutter/engine#48725) 
https://dart.googlesource.com/sdk.git/+log/9e54241e915a..691e4650ce91

2023-12-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-197.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-06 09:28:06 +00:00