firka/flutter
3
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Run full clang_tidy in presubmit (flutter/engine#48831)

Browse Source 
I'm seeing post-submit runs of full clang_tidy taking about ~20-ish
minutes excluding queue time, so the premise of
https://github.com/flutter/flutter/issues/139769 may be incorrect. In
that case, we should re-enable full clang_tidy in presubmit and observe
any impacts to queue time.

Context is that the clang autoroll became unblocked and landed a roll
that passed clang_tidy checks in presubmit, but then failed in post
submit: https://github.com/flutter/engine/pull/48817
This commit is contained in:
Zachary Anderson
2023-12-08 10:00:14 -08:00
committed by GitHub
parent 6ad3d04825
commit ff0ecf88c5
3 changed files with 0 additions and 248 deletions
Download Patch File Download Diff File Expand all files Collapse all files

40
engine/src/flutter/.ci.yaml
View File

@@ -199,7 +199,6 @@ targets:
- name: Linux linux_clang_tidy
recipe: engine_v2/engine_v2
presubmit: false
timeout: 120
properties:
config_name: linux_clang_tidy
@@ -216,24 +215,6 @@ targets:
- "**.frag"
- "**.vert"
- name: Linux linux_clang_tidy_presubmit
recipe: engine_v2/engine_v2
timeout: 120
properties:
config_name: linux_clang_tidy_presubmit
runIf:
- DEPS
- .ci.yaml
- tools/clang_tidy/**
- ci/builders/**
- ci/clang_tidy.sh
- "**.h"
- "**.c"
- "**.cc"
- "**.fbs"
- "**.frag"
- "**.vert"
- name: Linux linux_arm_host_engine
recipe: engine_v2/engine_v2
timeout: 120
@@ -354,7 +335,6 @@ targets:
- name: Mac mac_clang_tidy
recipe: engine_v2/engine_v2
presubmit: false
timeout: 120
properties:
config_name: mac_clang_tidy
@@ -373,26 +353,6 @@ targets:
- "**.m"
- "**.mm"
- name: Mac mac_clang_tidy_presubmit
recipe: engine_v2/engine_v2
timeout: 120
properties:
config_name: mac_clang_tidy_presubmit
runIf:
- DEPS
- .ci.yaml
- tools/clang_tidy/**
- ci/builders/**
- ci/clang_tidy.sh
- "**.h"
- "**.c"
- "**.cc"
- "**.fbs"
- "**.frag"
- "**.vert"
- "**.m"
- "**.mm"
- name: Mac mac_host_engine
recipe: engine_v2/engine_v2
timeout: 120

95
engine/src/flutter/ci/builders/linux_clang_tidy_presubmit.json
View File

@@ -1,95 +0,0 @@
{
"builds": [
{
"name": "android_debug_arm64",
"archives": [],
"drone_dimensions": [
"device_type=none",
"os=Linux"
],
"gn": [
"--android",
"--android-cpu",
"arm64",
"--no-lto"
],
"ninja": {
"config": "android_debug_arm64"
}
},
{
"name": "host_debug",
"archives": [],
"drone_dimensions": [
"device_type=none",
"os=Linux"
],
"gn": [
"--runtime-mode",
"debug",
"--prebuilt-dart-sdk",
"--no-lto"
],
"ninja": {
"config": "host_debug"
}
}
],
"tests": [
{
"name": "test: lint host_debug",
"recipe": "engine_v2/tester_engine",
"drone_dimensions": [
"device_type=none",
"os=Linux",
"cores=32"
],
"gclient_variables": {
"download_android_deps": false
},
"dependencies": [
"host_debug",
"android_debug_arm64"
],
"tasks": [
{
"name": "test: lint host_debug",
"parameters": [
"--variant",
"host_debug",
"--shard-id=0",
"--shard-variants=android_debug_arm64"
],
"max_attempts": 1,
"script": "flutter/ci/clang_tidy.sh"
}
]
},
{
"name": "test: lint android_debug_arm64",
"recipe": "engine_v2/tester_engine",
"drone_dimensions": [
"device_type=none",
"os=Linux",
"cores=32"
],
"dependencies": [
"host_debug",
"android_debug_arm64"
],
"tasks": [
{
"name": "test: lint android_debug_arm64",
"parameters": [
"--variant",
"android_debug_arm64",
"--shard-id=1",
"--shard-variants=host_debug"
],
"max_attempts": 1,
"script": "flutter/ci/clang_tidy.sh"
}
]
}
]
}

113
engine/src/flutter/ci/builders/mac_clang_tidy_presubmit.json
View File

@@ -1,113 +0,0 @@
{
"builds": [
{
"drone_dimensions": [
"device_type=none",
"os=Mac-12|Mac-13",
"cpu=arm64"
],
"gclient_variables": {
"download_android_deps": false
},
"gn": [
"--runtime-mode",
"debug",
"--prebuilt-dart-sdk",
"--no-lto",
"--force-mac-arm64"
],
"name": "host_debug",
"ninja": {
"config": "host_debug"
}
},
{
"drone_dimensions": [
"device_type=none",
"os=Mac-12|Mac-13",
"cpu=arm64"
],
"gclient_variables": {
"download_android_deps": false
},
"gn": [
"--ios",
"--runtime-mode",
"debug",
"--simulator",
"--no-lto",
"--force-mac-arm64"
],
"name": "ios_debug_sim",
"ninja": {
"config": "ios_debug_sim"
}
}
],
"tests": [
{
"name": "test: lint host_debug",
"recipe": "engine_v2/tester_engine",
"drone_dimensions": [
"device_type=none",
"os=Mac-12|Mac-13",
"cpu=arm64"
],
"gclient_variables": {
"download_android_deps": false
},
"dependencies": [
"host_debug",
"ios_debug_sim"
],
"contexts": [
"osx_sdk"
],
"tasks": [
{
"name": "test: lint host_debug",
"parameters": [
"--variant",
"host_debug",
"--shard-id=0",
"--shard-variants=ios_debug_sim"
],
"max_attempts": 1,
"script": "flutter/ci/clang_tidy.sh"
}
]
},
{
"name": "test: lint ios_debug_sim",
"recipe": "engine_v2/tester_engine",
"drone_dimensions": [
"device_type=none",
"os=Mac-12|Mac-13",
"cpu=arm64"
],
"gclient_variables": {
"download_android_deps": false
},
"dependencies": [
"host_debug",
"ios_debug_sim"
],
"contexts": [
"osx_sdk"
],
"tasks": [
{
"name": "test: lint ios_debug_sim",
"parameters": [
"--variant",
"ios_debug_sim",
"--shard-id=1",
"--shard-variants=host_debug"
],
"max_attempts": 1,
"script": "flutter/ci/clang_tidy.sh"
}
]
}
]
}