Commit Graph

13194 Commits

Author SHA1 Message Date
jslavitz
1196dbe94a Fixes a cursor offset mistake for Material on iOS (#27851)
* Fixes offset and unblocks roll
2019-02-13 12:25:25 -08:00
Jonah Williams
a5af29e83c Revert "Lazily download artifacts (Part II) (#27735)" (#27895)
This reverts commit 76061c4fa9.
2019-02-13 11:59:51 -08:00
Jonah Williams
76061c4fa9 Lazily download artifacts (Part II) (#27735) 2019-02-13 11:04:28 -08:00
Hans Muller
16fd0eb512 Add Armenian translations (#27865) 2019-02-13 08:35:26 -08:00
KyleWong
4b4a9400b7 Refactor build-number/build-name logic. (#27743)
This PR aims at several things:

1. Use pub_semver to check a version in pubspec.yaml meets the requirements specified in https://semver.org/.
2. Don't limit build-number/build-name as a fixed format. Instead, validate it according to the target(ios/android).
3. Make sure that build-number/build-name are always validated no matter it's specified by the `flutter command` or version in pubspec.yaml.

Fixes #27589
2019-02-13 07:48:03 -08:00
KyleWong
f2004b8f43 Add android studio process logic for JetBrainsToolbox (#27687)
* Make plugin path search logic use version check as a fallback.

* In JetBrainsToolbox, Info.plist would be just some kind of wrapper, we need a double check before get the real one.

* Use Regex to get content instead of `default command` to avoid error output as there could be no JetBrainsToolboxApp key/value for a normal Info.plist(Android Studio.)
2019-02-13 15:05:20 +08:00
KyleWong
199ebaa677 Refactor ios bundleid/android application process logic. (#27471)
When creating a flutter project,
Make sure: applicationid for android conforms to: https://developer.android.com/studio/build/application-id

Make sure: bundleid for ios conforms to:
https://developer.apple.com/library/archive/documentation/FileManagement/Conceptual/understanding_utis/understand_utis_conc/understand_utis_conc.html
(Not only the name,but also the organization, as it's a check for whole bundleid.)
2019-02-12 19:40:53 -08:00
Greg Spencer
ef9c059ef2 Hook up character events and unmodified code points to Android raw key event handling. (#27853)
This makes Android raw key event handling use the "character" data coming from the engine properly, and gets rid of the "toLowerCase" hack that I was using to normalize logical key events, in favor of using the new "plainCodePoint" that has the unmodified code point (the code point as if no modifier keys were pressed).
2019-02-12 19:40:19 -08:00
xster
8d0346a0ec Handle back swipe completed->completed or completed->dismissed transitions (#27866) 2019-02-12 18:50:06 -08:00
Jonah Williams
7cc694e5d5 Track InheritedElement dependencies in diagnostic properties (#27387) 2019-02-12 18:37:51 -08:00
Michael Goderbauer
aa8f86135d Fix crash when disposing nested Scrollables while holding in overscroll position (#27864) 2019-02-12 18:00:35 -08:00
Raouf Rahiche
964fab0205 fix small typo (#27659)
just a small typo 
the word "the constraints" is duplicated
2019-02-12 15:54:50 -08:00
xster
892c8919c7 Add long-press-drag cursor move support on iOS (#26001) 2019-02-12 15:10:48 -08:00
Gary Qian
e44fc1356f Temporarily disable inconsistent golden tests due to test fonts (#27861) 2019-02-12 15:02:45 -08:00
Jake Gough
dfce0a7f0b Added 'physics' prop to Stepper. (#26297)
* Update stepper.dart

Added 'physics' prop which allows the developer to assign the Stepper's scroll view's 'ScrollPhysics' which can solve with unwanted scrolling behaviour if the parent is also a scroll view. Defaults to 'AlwaysScrollableScrollPhysics' if null.

* Update stepper.dart

Removed unnecessary import and defaulting to 'AlwaysScrollableScrollPhysics' if physics prop is null.

* Update stepper.dart

Ran through format to remove unwanted whitespace which Analysis isn't happy about.

* Update stepper.dart

Tried reformatting again.

* Update stepper.dart

Tried reformatting again.

* Update stepper.dart

Formatting again why do you hate me github editor.

* Update stepper.dart

* Update stepper.dart

if this format doesn't work i'll cry

* Update stepper_test.dart

Added Stepper scroll tests. One that fails to find Text after Stepper if physics left as null and one that succeeds if physics set to `ClampingScrollPhysics()`

* Update stepper_test.dart

Added const constructors

* Update stepper_test.dart

trying to get rid of whitespace again

* Update stepper_test.dart

* Update stepper_test.dart

why whitespace why

* Update stepper_test.dart

* Update stepper_test.dart

* Update stepper_test.dart

* Update stepper_test.dart

Swapped to `findsNothing` because I'm an idiot.

* Update stepper_test.dart

* Update stepper.dart
2019-02-12 14:02:36 -08:00
rami-a
c348be9739 [Material] Update the card demo in the Gallery to demonstrate different uses of the Card widget (#27699)
Additionally, this adds a tappable Card example to the Card documentation.
2019-02-12 16:56:47 -05:00
vanya elizarov
f021ee27be CupertinoSliverRefreshControl inactive overscroll behavior (#27588) 2019-02-12 13:41:17 -08:00
Ian Hickson
58939b70ef Prevent tests from importing other tests. (#27800)
This pattern is problematic when Flutter is ported to build systems
that require each executable end-point to be self-contained (e.g.
Bazel).
2019-02-12 12:29:36 -08:00
Dan Field
ead5e8e4d7 Fix Xcode_backend.sh for flavors (#27691) 2019-02-12 12:28:56 -08:00
Dan Field
fdcb861b05 Deflake AnsiSpinner tests (#27825) 2019-02-12 12:28:45 -08:00
Dan Field
e711fd9744 Revert "Revert "d48de7a3e Support for binary decompression of dynamic patches. (flutter/engine#7777) (#27822)" (#27849)" (#27855)
This reverts commit 4bb21a5c53.
2019-02-12 12:28:20 -08:00
engine-flutter-autoroll
d64d30828b d48de7a3e Support for binary decompression of dynamic patches. (flutter/engine#7777) (#27850)
713fe130eb...d48de7a3ec

git log 713fe130eb0200412b04cc0c3356fce5f6f98153..d48de7a3ec97ebf7ffe543aa74993efa51064789 --no-merges --oneline
d48de7a3e Support for binary decompression of dynamic patches. (flutter/engine#7777)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (liyuqian@google.com), and stop
the roller if necessary.
2019-02-12 14:51:28 -05:00
Dan Field
4bb21a5c53 Revert "d48de7a3e Support for binary decompression of dynamic patches. (flutter/engine#7777) (#27822)" (#27849)
This reverts commit 738559188c.
2019-02-12 10:44:36 -08:00
TruongSinh Tran-Nguyen
d15a361244 flutter create --template=plugin now include flutter unit test (#26456) 2019-02-12 10:37:00 -08:00
KyleWong
cb2ac0a125 Null check logic for datatable. (#27632) 2019-02-12 01:05:09 -08:00
engine-flutter-autoroll
738559188c d48de7a3e Support for binary decompression of dynamic patches. (flutter/engine#7777) (#27822)
713fe130eb...d48de7a3ec

git log 713fe130eb0200412b04cc0c3356fce5f6f98153..d48de7a3ec97ebf7ffe543aa74993efa51064789 --no-merges --oneline
d48de7a3e Support for binary decompression of dynamic patches. (flutter/engine#7777)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com), and stop
the roller if necessary.
2019-02-12 01:04:29 -05:00
engine-flutter-autoroll
60ec197d0c Roll engine 4663d357a360..713fe130eb02 (2 commits) (#27820)
4663d357a3...713fe130eb

git log 4663d357a36043b7dcafa01fc88511f457cc1319..713fe130eb0200412b04cc0c3356fce5f6f98153 --no-merges --oneline
713fe130e Roll src/third_party/skia 103288b50fa7..454e5fb7457d (11 commits) (flutter/engine#7792)
87b40ba97 Allow embedders to specify pointer device IDs. (flutter/engine#7790)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com), and stop
the roller if necessary.
2019-02-12 00:09:28 -05:00
KyleWong
52687c7910 Optimize flutter run logic for iOS by "ONLY_ACTIVE_ARCH=YES" if possible (#27817) 2019-02-12 12:24:57 +08:00
engine-flutter-autoroll
963d69d8b1 Roll engine 3a1a604d71a4..4663d357a360 (3 commits) (#27816)
3a1a604d71...4663d357a3

git log 3a1a604d71a464b5b6013eed52a4c3657f0cce3c..4663d357a36043b7dcafa01fc88511f457cc1319 --no-merges --oneline
4663d357a Recommended implementation of combining characters implementation. (flutter/engine#7758)
d52121271 Revert "Roll src/third_party/dart fdfe40ea95..de2e7e7721 (7 commits)" (flutter/engine#7789)
a003c4678 Roll src/third_party/dart fdfe40ea95..de2e7e7721 (7 commits)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com), and stop
the roller if necessary.
2019-02-11 22:51:28 -05:00
KyleWong
bf20fa7c9d Refactor "no ios devices attached" logic. (#27717) 2019-02-12 10:14:01 +08:00
Jonah Williams
23d38901ef Pass method used to start flutter application (#27812) 2019-02-11 18:05:23 -08:00
Stanislav Baranov
b47da6c2b7 Add support for binary compression of dynamic patches by the flutter tool. (#27754)
This reduces the typical dynamic patch size by more than 10x.

Also see https://github.com/flutter/engine/pull/7777 for decompression support in the runtime.
2019-02-11 16:57:26 -08:00
engine-flutter-autoroll
8101862bdb 3a1a604d7 Roll src/third_party/skia 77a1a7e6182e..103288b50fa7 (16 commits) (flutter/engine#7787) (#27804)
f804279964...3a1a604d71

git log f8042799641e67ab5907e59078e08538c9eb5023..3a1a604d71a464b5b6013eed52a4c3657f0cce3c --no-merges --oneline
3a1a604d7 Roll src/third_party/skia 77a1a7e6182e..103288b50fa7 (16 commits) (flutter/engine#7787)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com), and stop
the roller if necessary.
2019-02-11 19:48:28 -05:00
KyleWong
1c0a06f397 Make version documentation clearer. (#27278)
Currently, in pubspec.yaml, semver.org is referred to for more about versioning.
However, the versionCode/versionName could differ on different platforms (iOS, Android, Dart).

This adds more clear and complete information that could help users to understand it better.

See: #27251
2019-02-11 16:29:38 -08:00
Hans Muller
5ee5766c89 Add builder parameter to showDatePicker, showTimePicker (#27703) 2019-02-11 15:53:31 -08:00
engine-flutter-autoroll
1e5d2e55fc Roll engine 694300d32539..f8042799641e (3 commits) (#27794)
694300d325...f804279964

git log 694300d32539f22969d8a0e0ec9c1efbfa599125..f8042799641e67ab5907e59078e08538c9eb5023 --no-merges --oneline
f80427996 Update licenses for the switch away from the Wuffs GIF decoder (flutter/engine#7786)
28bafe690 Don't use Wuffs (flutter/engine#7785)
a3be1ff58 libtxt: support justification of RTL text (flutter/engine#7719)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com), and stop
the roller if necessary.
2019-02-11 18:07:28 -05:00
Jonah Williams
4c3d15832d add desktop devices to daemon behind flag (#27665) 2019-02-11 14:49:07 -08:00
Kate Lovett
c58e31a74f Cupertino TextField Cursor Fix (#27697)
* Fix for #26261. Changes CupertinoTextField's cursorColor to read from CupertinoTheme instead of prior default of activeBlue. CursorColor will still default to activeBlue for light theme and activeOrange for dark theme if a primary color has not been specified for the CupertinoTheme.

* Reverted unnecessary changes in XCode file.

* Updated text_field.dart per suggestions from @gspencergoog

* Updated comments for cursorColor to reflect appropriate hyperlinks per @Hixie

* Simplified cursorColor assignment per @xster

* Added test in cupertino/text_field_test.dart to check for correct cursorColor based on CupertinoTheme per @Hixie & @xster.
2019-02-11 12:54:21 -08:00
engine-flutter-autoroll
c633e02853 Roll engine 5dee035ee2d9..694300d32539 (14 commits) (#27783)
5dee035ee2...694300d325

git log 5dee035ee2d9a47123b72c0ac8d14b60e5c9fee1..694300d32539f22969d8a0e0ec9c1efbfa599125 --no-merges --oneline
694300d32 Provide a default pressure range if a MotionEvent does not have a device (flutter/engine#7737)
5dfa02949 Roll src/third_party/skia d336ebdea812..77a1a7e6182e (5 commits) (flutter/engine#7784)
dbb90a534 Roll src/third_party/skia 136cd7018a99..d336ebdea812 (4 commits) (flutter/engine#7781)
6933fcb2b Roll src/third_party/dart 174d6fec3d..fdfe40ea95 (27 commits)
f4a22d896 Roll src/third_party/skia ef26fcb13fc6..136cd7018a99 (1 commits) (flutter/engine#7778)
9c2f8726d Roll src/third_party/skia 5fc138c04690..ef26fcb13fc6 (1 commits) (flutter/engine#7775)
94e0e2c20 Roll src/third_party/skia fbe2e937c798..5fc138c04690 (1 commits) (flutter/engine#7774)
c3523d910 Roll src/third_party/skia 475134f2de57..fbe2e937c798 (1 commits) (flutter/engine#7773)
967460f83 Roll src/third_party/skia 1e1bc8de5671..475134f2de57 (1 commits) (flutter/engine#7772)
81cdd5491 Roll src/third_party/skia dafd65217b4e..1e1bc8de5671 (1 commits) (flutter/engine#7771)
06cc2e459 Roll src/third_party/skia cd9ef731fe75..dafd65217b4e (1 commits) (flutter/engine#7770)
ba0f38b1d Allow specifying the out directory prefix (flutter/engine#7762)
b2a93978b Roll src/third_party/skia 0b36acdad970..cd9ef731fe75 (1 commits) (flutter/engine#7769)
ddd224072 Roll src/third_party/skia 1f43a4359d7d..0b36acdad970 (1 commits) (flutter/engine#7768)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com), and stop
the roller if necessary.
2019-02-11 15:47:28 -05:00
Anthony
39bb6712f6 [Material] Simple API for skipping over certain Slider shapes (#27613)
* Provide a simmplified API for skipping over slider thumb, overlay, and tick mark painting

* doc fixes

* comments

* comments

* comments

* comments

* comments

* analyzer

* comments
2019-02-11 14:57:41 -05:00
engine-flutter-autoroll
20d4770136 5dee035ee Roll src/third_party/skia 5c211130646b..1f43a4359d7d (5 commits) (flutter/engine#7767) (#27727)
067045757f...5dee035ee2

git log 067045757ff529aeeba3d7ebaf0ebee0b2e09d8d..5dee035ee2d9a47123b72c0ac8d14b60e5c9fee1 --no-merges --oneline
5dee035ee Roll src/third_party/skia 5c211130646b..1f43a4359d7d (5 commits) (flutter/engine#7767)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com), and stop
the roller if necessary.
2019-02-11 14:39:28 -05:00
Danny Tuppeny
ad3da3b4a3 Update temp folder name to me more consistent with others (#26702)
This change was dropped out of #26227 because it seems to inexplicably result in timeouts talking to the VM service on Windows Cirrus. After 1 month of periodically debugging it, it just started passing 🤷‍♂️.
2019-02-11 16:20:45 +00:00
engine-flutter-autoroll
fec01201b1 067045757 Roll src/third_party/skia 87461aad7285..5c211130646b (1 commits) (flutter/engine#7766) (#27723)
90569e8416...067045757f

git log 90569e8416c71b2f763dc5e47924b56e5f911660..067045757ff529aeeba3d7ebaf0ebee0b2e09d8d --no-merges --oneline
067045757 Roll src/third_party/skia 87461aad7285..5c211130646b (1 commits) (flutter/engine#7766)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com), and stop
the roller if necessary.
2019-02-09 11:23:28 -05:00
engine-flutter-autoroll
9b810b54d3 Roll engine 7c702404b820..90569e8416c7 (13 commits) (#27722)
7c702404b8...90569e8416

git log 7c702404b820c670cda34b564ac3f8c0b914f40e..90569e8416c71b2f763dc5e47924b56e5f911660 --no-merges --oneline
90569e841 Provide public api to allow FlutterEngine related context to be destoryed (flutter/engine#7610)
693645e46 Revert "Add mock capability to PerformanceOverlayLayer (#7537)" (flutter/engine#7765)
d130f15af Add x bit to some python scripts (flutter/engine#7764)
2146cdeca Roll src/third_party/skia 706a7cd1e826..87461aad7285 (1 commits) (flutter/engine#7763)
2a648b903 Roll src/third_party/skia be39f713e530..706a7cd1e826 (4 commits) (flutter/engine#7761)
68396ae3a Throttle picture raster cache (flutter/engine#7759)
a6753b08a Roll src/third_party/dart 52f5e34dbf..174d6fec3d (12 commits)
f9252e72f allow specifying out directory root (flutter/engine#7753)
12d0b95c2 Don't call OnAnimatorNotifyIdle if a frame is scheduled (flutter/engine#7746)
5f3f3bd98 Add mock capability to PerformanceOverlayLayer (flutter/engine#7537)
7d97afd8a Roll src/third_party/skia 37064c1739f3..be39f713e530 (7 commits) (flutter/engine#7757)
3bfd26505 Add flutter config to macOS targets (flutter/engine#7756)
4d3a11227 Document GPUSurfaceGLDelegate methods and move it to its own file. (flutter/engine#7755)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com), and stop
the roller if necessary.
2019-02-09 06:41:28 -05:00
Jonah Williams
216a65b669 remove build_runner_core import from flutter_tools (#27708) 2019-02-08 18:12:28 -08:00
Stanislav Baranov
63e6a7ad30 Support for building dynamic patches in AOT mode. (#27672) 2019-02-08 17:52:57 -08:00
Jonah Williams
7cdb30fba2 Revert "Lazily download artifacts (#27374)" (#27705)
This reverts commit 98971f3c64.
2019-02-08 15:50:18 -08:00
Jonah Williams
98971f3c64 Lazily download artifacts (#27374) 2019-02-08 15:24:09 -08:00
engine-flutter-autoroll
523c5deebc Roll engine 25c513c72a5a..7c702404b820 (5 commits) (#27701)
25c513c72a...7c702404b8

git log 25c513c72a5a4b2ef3cf5c174a9541e7f327d2b8..7c702404b820c670cda34b564ac3f8c0b914f40e --no-merges --oneline
7c702404b Create mipmaps for images when uploading them on the IO thread (flutter/engine#7751)
3183d151d Rename macOS framework to FlutterMacOS.framework (flutter/engine#7740)
aa275820b Support for loading dynamic patches in AOT mode. (flutter/engine#7744)
5bfb1ecb5 Roll src/third_party/skia f2a3f5943e4c..37064c1739f3 (11 commits) (flutter/engine#7752)
cf1d70a27 Add onPlatformBrightnessChanged/platformBrightness to stub ui window. (flutter/engine#7739)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com), and stop
the roller if necessary.
2019-02-08 17:49:28 -05:00
Hans Muller
944ede85ff TextField should only set EditableText.cursorOffset for iOS (#27663) 2019-02-08 14:31:35 -08:00