firka/flutter
3
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Temporarily disable inconsistent golden tests due to test fonts (#27861)

Browse Source
This commit is contained in:
Gary Qian
2019-02-12 15:02:45 -08:00
committed by GitHub
parent dfce0a7f0b
commit e44fc1356f
1 changed files with 12 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
packages/flutter/test/widgets/text_golden_test.dart
View File

@@ -244,7 +244,8 @@ void main() {
find.byType(Container),
matchesGoldenFile('text_golden.StrutDefault.png'),
);
}, skip: !Platform.isLinux);
}, skip: true); // Should only be on linux (skip: !Platform.isLinux).
// Disabled for now until font inconsistency is resolved.
testWidgets('Strut text 1', (WidgetTester tester) async {
await tester.pumpWidget(
@@ -271,7 +272,8 @@ void main() {
find.byType(Container),
matchesGoldenFile('text_golden.Strut.1.png'),
);
}, skip: !Platform.isLinux);
}, skip: true); // Should only be on linux (skip: !Platform.isLinux).
// Disabled for now until font inconsistency is resolved.
testWidgets('Strut text 2', (WidgetTester tester) async {
await tester.pumpWidget(
@@ -299,7 +301,8 @@ void main() {
find.byType(Container),
matchesGoldenFile('text_golden.Strut.2.png'),
);
}, skip: !Platform.isLinux);
}, skip: true); // Should only be on linux (skip: !Platform.isLinux).
// Disabled for now until font inconsistency is resolved.
testWidgets('Strut text rich', (WidgetTester tester) async {
await tester.pumpWidget(
@@ -350,7 +353,8 @@ void main() {
find.byType(Container),
matchesGoldenFile('text_golden.Strut.3.png'),
);
}, skip: !Platform.isLinux);
}, skip: true); // Should only be on linux (skip: !Platform.isLinux).
// Disabled for now until font inconsistency is resolved.
testWidgets('Strut text font fallback', (WidgetTester tester) async {
// Font Fallback
@@ -385,7 +389,8 @@ void main() {
find.byType(Container),
matchesGoldenFile('text_golden.Strut.4.png'),
);
}, skip: !Platform.isLinux);
}, skip: true); // Should only be on linux (skip: !Platform.isLinux).
// Disabled for now until font inconsistency is resolved.
testWidgets('Strut text rich forceStrutHeight', (WidgetTester tester) async {
await tester.pumpWidget(
@@ -436,5 +441,6 @@ void main() {
find.byType(Container),
matchesGoldenFile('text_golden.StrutForce.1.png'),
);
}, skip: !Platform.isLinux);
}, skip: true); // Should only be on linux (skip: !Platform.isLinux).
// Disabled for now until font inconsistency is resolved.
}