firka/flutter
3
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Update a test expectation that depended on an SkParagraph fix (#119756)

Browse Source 
This assertion had been disabled because a bug fix was pending in
SkParagraph.  This PR updates it to match the new behavior.

See https://github.com/flutter/flutter/pull/119653
This commit is contained in:
Jason Simmons
2023-02-01 14:55:02 -08:00
committed by GitHub
parent 7a926dcb03
commit cd118dada9
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
packages/flutter/test/widgets/selectable_region_test.dart
View File

@@ -842,8 +842,7 @@ void main() {
// Add a little offset to cross the boundary between paragraph 2 and 3.
await gesture.moveTo(textOffsetToPosition(paragraph3, 6) + const Offset(0, 1));
expect(paragraph1.selections[0], const TextSelection(baseOffset: 2, extentOffset: 12));
// TODO(jsimmons): reenable this with updated expectations after https://skia-review.googlesource.com/c/skia/+/619838 lands
//expect(paragraph2.selections[0], const TextSelection(baseOffset: 0, extentOffset: 8));
expect(paragraph2.selections[0], const TextSelection(baseOffset: 0, extentOffset: 9));
expect(paragraph3.selections[0], const TextSelection(baseOffset: 0, extentOffset: 6));
await gesture.up();