From cd118dada912d1ef7f7022c2dc0b8fea789883c4 Mon Sep 17 00:00:00 2001 From: Jason Simmons Date: Wed, 1 Feb 2023 14:55:02 -0800 Subject: [PATCH] Update a test expectation that depended on an SkParagraph fix (#119756) This assertion had been disabled because a bug fix was pending in SkParagraph. This PR updates it to match the new behavior. See https://github.com/flutter/flutter/pull/119653 --- packages/flutter/test/widgets/selectable_region_test.dart | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/packages/flutter/test/widgets/selectable_region_test.dart b/packages/flutter/test/widgets/selectable_region_test.dart index 4e834f8cd3..4af40c4af5 100644 --- a/packages/flutter/test/widgets/selectable_region_test.dart +++ b/packages/flutter/test/widgets/selectable_region_test.dart @@ -842,8 +842,7 @@ void main() { // Add a little offset to cross the boundary between paragraph 2 and 3. await gesture.moveTo(textOffsetToPosition(paragraph3, 6) + const Offset(0, 1)); expect(paragraph1.selections[0], const TextSelection(baseOffset: 2, extentOffset: 12)); - // TODO(jsimmons): reenable this with updated expectations after https://skia-review.googlesource.com/c/skia/+/619838 lands - //expect(paragraph2.selections[0], const TextSelection(baseOffset: 0, extentOffset: 8)); + expect(paragraph2.selections[0], const TextSelection(baseOffset: 0, extentOffset: 9)); expect(paragraph3.selections[0], const TextSelection(baseOffset: 0, extentOffset: 6)); await gesture.up();