firka/flutter
3
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Skip SimpleRasterizerStatistics test on Fuchsia (flutter/engine#26053)

Browse Source 
* Skip SimpleRasterizerStatistics test on Fuchsia

This test depends on a valid default SkFontMgr to be installed. Otherwise, it uses an empty typeface, which leads to an SkTextBlob with empty bounds and unexpected test failures when Skia updates its quickReject() behavior.

Fuchsia is the only platform that does not install an SkFontMgr.

* Fix code style and line length
This commit is contained in:
Michael Ludwig
2021-05-11 09:37:15 -04:00
committed by GitHub
parent 5aa0f81814
commit be14e77dc7
1 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
engine/src/flutter/flow/layers/performance_overlay_layer_unittests.cc
View File

@@ -170,6 +170,13 @@ TEST_F(PerformanceOverlayLayerTest, SimpleRasterizerStatistics) {
SkPaint text_paint;
text_paint.setColor(SK_ColorGRAY);
SkPoint text_position = SkPoint::Make(16.0f, 22.0f);
// TODO(https://github.com/flutter/flutter/issues/82202): Remove once the
// performance overlay can use Fuchsia's font manager instead of the empty
// default.
#if defined(OS_FUCHSIA)
GTEST_SKIP() << "Expectation requires a valid default font manager";
#endif // OS_FUCHSIA
EXPECT_EQ(mock_canvas().draw_calls(),
std::vector({MockCanvas::DrawCall{
0, MockCanvas::DrawTextData{overlay_text_data, text_paint,