From be14e77dc7be869df5fa81652c751dba89150a6b Mon Sep 17 00:00:00 2001 From: Michael Ludwig Date: Tue, 11 May 2021 09:37:15 -0400 Subject: [PATCH] Skip SimpleRasterizerStatistics test on Fuchsia (flutter/engine#26053) * Skip SimpleRasterizerStatistics test on Fuchsia This test depends on a valid default SkFontMgr to be installed. Otherwise, it uses an empty typeface, which leads to an SkTextBlob with empty bounds and unexpected test failures when Skia updates its quickReject() behavior. Fuchsia is the only platform that does not install an SkFontMgr. * Fix code style and line length --- .../flow/layers/performance_overlay_layer_unittests.cc | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/engine/src/flutter/flow/layers/performance_overlay_layer_unittests.cc b/engine/src/flutter/flow/layers/performance_overlay_layer_unittests.cc index 37432714e2..0fe52300cb 100644 --- a/engine/src/flutter/flow/layers/performance_overlay_layer_unittests.cc +++ b/engine/src/flutter/flow/layers/performance_overlay_layer_unittests.cc @@ -170,6 +170,13 @@ TEST_F(PerformanceOverlayLayerTest, SimpleRasterizerStatistics) { SkPaint text_paint; text_paint.setColor(SK_ColorGRAY); SkPoint text_position = SkPoint::Make(16.0f, 22.0f); + + // TODO(https://github.com/flutter/flutter/issues/82202): Remove once the + // performance overlay can use Fuchsia's font manager instead of the empty + // default. +#if defined(OS_FUCHSIA) + GTEST_SKIP() << "Expectation requires a valid default font manager"; +#endif // OS_FUCHSIA EXPECT_EQ(mock_canvas().draw_calls(), std::vector({MockCanvas::DrawCall{ 0, MockCanvas::DrawTextData{overlay_text_data, text_paint,