firka/flutter
3
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Skip font-tests for host_profile variants. (flutter/engine#31515)

Browse Source 
font-tests are not built by default in the host_profile variant. The
test was working properly because all the variants were being built
sequentially in the same host. With the separation of builds and tests
every variant is built in a separate host and host_profile does not have
access to font-tests built by host_debug.

Bug: https://github.com/flutter/flutter/issues/98642
This commit is contained in:
godofredoc
2022-02-17 09:13:52 -08:00
committed by GitHub
parent 26545e6e49
commit 65ca495690
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
engine/src/flutter/testing/run_tests.py
View File

@@ -632,7 +632,8 @@ def main():
RunBenchmarkTests(build_dir)
RunEngineBenchmarks(build_dir, engine_filter)
if ('engine' in types or 'font-subset' in types) and args.variant != 'host_release':
variants_to_skip = ['host_release', 'host_profile']
if ('engine' in types or 'font-subset' in types) and args.variant not in variants_to_skip:
RunCmd(['python', 'test.py'], cwd=font_subset_dir)