From 65ca4956908a75ea06cd13260743467d96470f42 Mon Sep 17 00:00:00 2001 From: godofredoc Date: Thu, 17 Feb 2022 09:13:52 -0800 Subject: [PATCH] Skip font-tests for host_profile variants. (flutter/engine#31515) font-tests are not built by default in the host_profile variant. The test was working properly because all the variants were being built sequentially in the same host. With the separation of builds and tests every variant is built in a separate host and host_profile does not have access to font-tests built by host_debug. Bug: https://github.com/flutter/flutter/issues/98642 --- engine/src/flutter/testing/run_tests.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/engine/src/flutter/testing/run_tests.py b/engine/src/flutter/testing/run_tests.py index 332820611b..5393c519c7 100755 --- a/engine/src/flutter/testing/run_tests.py +++ b/engine/src/flutter/testing/run_tests.py @@ -632,7 +632,8 @@ def main(): RunBenchmarkTests(build_dir) RunEngineBenchmarks(build_dir, engine_filter) - if ('engine' in types or 'font-subset' in types) and args.variant != 'host_release': + variants_to_skip = ['host_release', 'host_profile'] + if ('engine' in types or 'font-subset' in types) and args.variant not in variants_to_skip: RunCmd(['python', 'test.py'], cwd=font_subset_dir)