firka/flutter
3
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[fuchsia] remove Fuchsia-specific kVsyncTraceName from VsyncWaiter. (flutter/engine#33519)

Browse Source 
This CL changes the vsync trace name to "VsyncProcessCallback". The
benchmarks in fuchsia currently support "VsyncProcessCallback" and "vsync callback". After this change, support for "vsync callback" can be safely removed from fuchsia benchmarks.

Test: fx test host_x64/knowledge_card_test

Bug: 73367
This commit is contained in:
Shivesh Ganju
2022-05-27 15:04:12 -04:00
committed by GitHub
parent 41a5bd513e
commit 61a5c8873c
1 changed files with 0 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
engine/src/flutter/shell/common/vsync_waiter.cc
View File

@@ -16,23 +16,7 @@ namespace flutter {
static constexpr const char* kVsyncFlowName = "VsyncFlow";
#if defined(OS_FUCHSIA)
// ________ _________ ________ ________
// |\ ____\|\___ ___\\ __ \|\ __ \
// \ \ \___|\|___ \ \_\ \ \|\ \ \ \|\ \
// \ \_____ \ \ \ \ \ \ \\\ \ \ ____\
// \|____|\ \ \ \ \ \ \ \\\ \ \ \___|
// ____\_\ \ \ \__\ \ \_______\ \__\
// |\_________\ \|__| \|_______|\|__|
// \|_________|
//
// Fuchsia benchmarks depend on this trace event's name. Please do not change
// it without checking that the changes are compatible with Fuchsia benchmarks
// first!
static constexpr const char* kVsyncTraceName = "vsync callback";
#else
static constexpr const char* kVsyncTraceName = "VsyncProcessCallback";
#endif
VsyncWaiter::VsyncWaiter(TaskRunners task_runners)
: task_runners_(std::move(task_runners)) {}