From 61a5c8873caea8a3b33741abe3d32e84c8f26411 Mon Sep 17 00:00:00 2001 From: Shivesh Ganju Date: Fri, 27 May 2022 15:04:12 -0400 Subject: [PATCH] [fuchsia] remove Fuchsia-specific kVsyncTraceName from VsyncWaiter. (flutter/engine#33519) This CL changes the vsync trace name to "VsyncProcessCallback". The benchmarks in fuchsia currently support "VsyncProcessCallback" and "vsync callback". After this change, support for "vsync callback" can be safely removed from fuchsia benchmarks. Test: fx test host_x64/knowledge_card_test Bug: 73367 --- engine/src/flutter/shell/common/vsync_waiter.cc | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/engine/src/flutter/shell/common/vsync_waiter.cc b/engine/src/flutter/shell/common/vsync_waiter.cc index 1a545368f1..e787b0384d 100644 --- a/engine/src/flutter/shell/common/vsync_waiter.cc +++ b/engine/src/flutter/shell/common/vsync_waiter.cc @@ -16,23 +16,7 @@ namespace flutter { static constexpr const char* kVsyncFlowName = "VsyncFlow"; -#if defined(OS_FUCHSIA) -// ________ _________ ________ ________ -// |\ ____\|\___ ___\\ __ \|\ __ \ -// \ \ \___|\|___ \ \_\ \ \|\ \ \ \|\ \ -// \ \_____ \ \ \ \ \ \ \\\ \ \ ____\ -// \|____|\ \ \ \ \ \ \ \\\ \ \ \___| -// ____\_\ \ \ \__\ \ \_______\ \__\ -// |\_________\ \|__| \|_______|\|__| -// \|_________| -// -// Fuchsia benchmarks depend on this trace event's name. Please do not change -// it without checking that the changes are compatible with Fuchsia benchmarks -// first! -static constexpr const char* kVsyncTraceName = "vsync callback"; -#else static constexpr const char* kVsyncTraceName = "VsyncProcessCallback"; -#endif VsyncWaiter::VsyncWaiter(TaskRunners task_runners) : task_runners_(std::move(task_runners)) {}