AJI 86b582a6bc Fix damage calculation when not providing populate_existing_damage for gl embedder (flutter/engine#45611) ...

# Description

This PR fixes the `gl_populate_existing_damage` in embedder.cc, which currently returns an empty rectangle when a full repaint is needed. This leads to the `frame_damage` being considered empty in rasterizer.cc, causing incorrect partial repaint within Flutter when `gl_populate_existing_damage` is not provided by the embedder.

# Related Issue

https://github.com/flutter/flutter/issues/119601

# Tests

Add a new test. Also fixes damage calculation related tests in EmbedderTest by

* Use a new Dart embedder fixture entry point `render_gradient_retained` which retains the old layer to make sure layer tree diff happens.
* Add `latch.Wait()` after `SetGLPresentCallback` to make sure assertions have been executed.
* Make `existing_damage_rects` static since it should be valid after `populate_existing_damage` returns.

2023-09-28 20:06:51 +00:00

engine/src/flutter

Fix damage calculation when not providing populate_existing_damage for gl embedder (flutter/engine#45611)

2023-09-28 20:06:51 +00:00

DEPS

Roll Skia from d8a71d549262 to 33502f9b0c7d (2 revisions) (flutter/engine#46375)

2023-09-28 18:44:14 +00:00

Description

No description provided

328 MiB

Languages

Dart 75.4%

C++ 16.4%

Objective-C++ 2.7%

Java 2.7%

Objective-C 0.6%

Other 1.8%