auto-submit[bot] 6ef80156ff Reverts "[Impeller] cache onscreen render targets. (#50751)" (flutter/engine#50871) ...

Reverts flutter/engine#50751

Initiated by: jonahwilliams

Reason for reverting: breaking flutter tester --enable-impeller workflow

Original PR Author: jonahwilliams

Reviewed By: {matanlurey}

This change reverts the following previous change:
Original Description:
Currently we cache render pass objects to offscreen render targets only. Caching onscreen doesn't work as 1) the render targets are stored on the texture_vk object and 2) the texture_vk object is recreated for each frame (see https://github.com/flutter/engine/blob/main/impeller/renderer/backend/vulkan/surface_vk.cc#L14 ).

To make sure the render pass is cached, move the storage to the texture source.

part of https://github.com/flutter/flutter/issues/141750

2024-02-22 17:11:25 +00:00

engine/src/flutter

Reverts "[Impeller] cache onscreen render targets. (#50751)" (flutter/engine#50871)

2024-02-22 17:11:25 +00:00

DEPS

Roll Skia from 0b55d78d32f9 to b9c16065b76d (1 revision) (flutter/engine#50861)

2024-02-22 12:56:29 +00:00

Description

No description provided

328 MiB

Languages

Dart 75.4%

C++ 16.4%

Objective-C++ 2.7%

Java 2.7%

Objective-C 0.6%

Other 1.8%