Commit Graph

28542 Commits

Author SHA1 Message Date
Jim Graham
d05d99805f hide DisplayList::DisposeOps and other lint suggestions (flutter/engine#41464)
Fixes https://github.com/flutter/flutter/issues/125428

Note that these are lint-type fixes and so there are no tests for them.
2023-04-25 19:46:26 +00:00
skia-flutter-autoroll
fb07edfa72 Roll Dart SDK from 170137fc759b to f9d4d255c6e7 (1 revision) (flutter/engine#41486)
https://dart.googlesource.com/sdk.git/+log/170137fc759b..f9d4d255c6e7

2023-04-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-42.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aam@google.com,dart-vm-team@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-25 19:30:11 +00:00
Srujan Gaddam
e253aeff60 Remove package:js references and move to dart:js_interop (flutter/engine#41212)
dart:js_interop and package:js will start conflicting. Eventually, we
want people to only use dart:js_interop, so this CL refactors code to do
that.

Unblocks https://dart-review.googlesource.com/c/sdk/+/294130/8 and
prevents confusing shadowing of dart:js_interop annotations like we do
today.

## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [Mentioned CL that is unblocked] I listed at least one issue that this
PR fixes in the description above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [Need test-exemption] I added new tests to check the change I am
making, or this PR is [test-exempt].
- [X] All existing and new tests are passing.
2023-04-25 12:20:12 -07:00
林洵锋
2c3afe9b15 [ios] Fix hold and drag spacebar does not move cursor when obscureText is true. (flutter/engine#40216)
Fixes [flutter/flutter#122139](https://github.com/flutter/flutter/issues/122139) with flutter pr [flutter/flutter#122383](https://github.com/flutter/flutter/pull/122383)
2023-04-25 17:56:56 +00:00
skia-flutter-autoroll
63e04a3814 Roll Dart SDK from 337365e42613 to 170137fc759b (2 revisions) (flutter/engine#41483)
https://dart.googlesource.com/sdk.git/+log/337365e42613..170137fc759b

2023-04-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-41.0.dev
2023-04-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-40.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aam@google.com,dart-vm-team@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-25 15:26:29 +00:00
skia-flutter-autoroll
7e0bed752f Roll Skia from c44f06399619 to 1bed4228ea3b (1 revision) (flutter/engine#41482)
https://skia.googlesource.com/skia.git/+log/c44f06399619..1bed4228ea3b

2023-04-25 kjlubick@google.com replace SkASSERT(! with SkDEBUGFAIL

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,rmistry@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-25 14:08:21 +00:00
skia-flutter-autoroll
23df286d11 Roll Skia from 7a0879961df5 to c44f06399619 (1 revision) (flutter/engine#41479)
https://skia.googlesource.com/skia.git/+log/7a0879961df5..c44f06399619

2023-04-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 79949f0f1146 to a52479099cf2 (3 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,rmistry@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-25 11:10:23 +00:00
skia-flutter-autoroll
3704fb44e3 Roll Skia from 571074c14049 to 7a0879961df5 (1 revision) (flutter/engine#41478)
https://skia.googlesource.com/skia.git/+log/571074c14049..7a0879961df5

2023-04-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 83a6fdf2e118 to 8f39f2978ef8 (7 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,rmistry@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-25 10:25:40 +00:00
skia-flutter-autoroll
844941e663 Roll Skia from 9b1b2a5dd899 to 571074c14049 (1 revision) (flutter/engine#41476)
https://skia.googlesource.com/skia.git/+log/9b1b2a5dd899..571074c14049

2023-04-25 blundell@chromium.org [Dawn] Set stencil state only if using stencil

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,rmistry@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-25 08:37:23 +00:00
skia-flutter-autoroll
eee823714c Roll Dart SDK from c3afc3507b4f to 337365e42613 (1 revision) (flutter/engine#41475)
https://dart.googlesource.com/sdk.git/+log/c3afc3507b4f..337365e42613

2023-04-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-39.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aam@google.com,chinmaygarde@google.com,dart-vm-team@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-25 07:37:49 +00:00
skia-flutter-autoroll
1a9bc7dfbb Roll Fuchsia Linux SDK from 8TJtGsJTpIHk5-Ss5... to xfKYQ2vkoLvxhBHIf... (flutter/engine#41474)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-25 07:28:05 +00:00
skia-flutter-autoroll
624fd3eb52 Roll Skia from 2c0f33c7ec04 to 9b1b2a5dd899 (2 revisions) (flutter/engine#41473)
https://skia.googlesource.com/skia.git/+log/2c0f33c7ec04..9b1b2a5dd899

2023-04-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from d2b5bd140525 to c1b3c7431680 (16 revisions)
2023-04-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from dd55e592406d to c0e5813a9b77 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,rmistry@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-25 06:29:54 +00:00
skia-flutter-autoroll
dc54b29051 Roll Fuchsia Mac SDK from gxpKJcSBfY7AuR_Ur... to 5bc9_eyVcLoMrWvdO... (flutter/engine#41471)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-25 06:24:24 +00:00
skia-flutter-autoroll
d00dbc773b Roll Skia from 8822608fcb4d to 2c0f33c7ec04 (1 revision) (flutter/engine#41470)
https://skia.googlesource.com/skia.git/+log/8822608fcb4d..2c0f33c7ec04

2023-04-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 19d83f15ade0 to 8f39f2978ef8

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,rmistry@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-25 05:38:14 +00:00
skia-flutter-autoroll
803a272db0 Roll Skia from 5f4dd36a69f9 to 8822608fcb4d (2 revisions) (flutter/engine#41469)
https://skia.googlesource.com/skia.git/+log/5f4dd36a69f9..8822608fcb4d

2023-04-24 johnstiles@google.com Reorder struct for better Neon codegen.
2023-04-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 4b61bdad813f to 79949f0f1146 (6 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,rmistry@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-25 04:14:09 +00:00
godofredoc
465c5dc0a7 [Cleanup] remove type=local from local test/generators. (flutter/engine#41465)
The `"type": "local"` property from local test and generators was never used. Removing from configurations.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-04-25 02:53:06 +00:00
Jonah Williams
78d8124320 Revert "[impeller] convert src over to src for solid color" (flutter/engine#41466)
Reverts flutter/engine#41351
2023-04-25 00:49:11 +00:00
godofredoc
fe21fedc1e Remove empty tests properties. (flutter/engine#41461)
Tests property is optional, empty tests property can be safely removed from the build configurations.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-04-24 23:03:16 +00:00
skia-flutter-autoroll
fd65498026 Roll Skia from 0ec4c84abd0b to 5f4dd36a69f9 (21 revisions) (flutter/engine#41462)
https://skia.googlesource.com/skia.git/+log/0ec4c84abd0b..5f4dd36a69f9

2023-04-24 johnstiles@google.com Add release note for SkRP.
2023-04-24 jamesgk@google.com Early-out instead of asserting in make_vk_backend_texture
2023-04-24 istepancar@gmail.com fix(*): fix links in canvaskit readme
2023-04-24 sunnyps@chromium.org graphite: Split backend include sources in build
2023-04-24 johnstiles@google.com Create dedicated SkRP op for matrix-multiply.
2023-04-24 brianosman@google.com (Reland) Always run color space math in full-float
2023-04-24 johnstiles@google.com Use packed contexts for small swizzles in SkRP.
2023-04-24 cmumford@google.com Switch to putting new release notes in //relnotes/
2023-04-24 johnstiles@google.com Eliminate SkVM-specific features from Viewer.
2023-04-24 johnstiles@google.com Rewrite ES2 loop-test conditions that use !=.
2023-04-24 egdaniel@google.com [Graphite] Add support for purgeNotUsedSinced to ResourceCache.
2023-04-24 brianosman@google.com Remove SkXfermode and SkXfermode_opts
2023-04-24 kjlubick@google.com Add minimal viewer build with Bazel.
2023-04-24 michaelludwig@google.com [skif] Cleanup FilterResultTest to prep for color filters
2023-04-24 michaelludwig@google.com [skif] Inline FilterResult::concatTransform() into applyTransform()
2023-04-24 johnstiles@google.com Eliminate SkVM-specific bots.
2023-04-24 brianosman@google.com Remove xfermode support from legacy shader blitter
2023-04-24 johnstiles@google.com Eliminate 'skia_compare_vm_vs_rp' benchmarking code.
2023-04-24 johnstiles@google.com Increase the arena stack size in onFilterColor4f.
2023-04-24 johnstiles@google.com Add a pad_stack op to the RP builder.
2023-04-24 johnstiles@google.com Eliminate SkVM unit tests for debug tracing.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,rmistry@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-24 22:41:17 +00:00
godofredoc
2e49be471e Reland "Upload windows arm artifacts to production bucket." (flutter/engine#41409)
Reverts flutter/engine#41372

The duplicated artifacts were removed from Windows Host Engine in https://flutter-review.googlesource.com/c/recipes/+/42340. After the recipes change lands and is propagated it will be safe to update the `Windows windows_arm_host_engine` build to upload the artifacts to prod.

Bug: https://github.com/flutter/flutter/issues/125262
2023-04-24 21:17:24 +00:00
skia-flutter-autoroll
d55e58bd92 Roll Dart SDK from c7042dc03f43 to c3afc3507b4f (1 revision) (flutter/engine#41458)
https://dart.googlesource.com/sdk.git/+log/c7042dc03f43..c3afc3507b4f

2023-04-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-38.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aam@google.com,chinmaygarde@google.com,dart-vm-team@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-24 20:47:24 +00:00
keyonghan
b896507aea Add 16.2 runtime to Mac unopt (flutter/engine#41456)
Fixes: https://github.com/flutter/flutter/issues/124408
2023-04-24 19:55:21 +00:00
skia-flutter-autoroll
97e9678d45 Roll Fuchsia Mac SDK from EEdHfWcEn3fHwQj46... to gxpKJcSBfY7AuR_Ur... (flutter/engine#41453)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-24 17:30:07 +00:00
skia-flutter-autoroll
52bc10ceef Roll Fuchsia Linux SDK from fJ7ysM-O4VYAGeBDc... to 8TJtGsJTpIHk5-Ss5... (flutter/engine#41451)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-24 16:04:00 +00:00
skia-flutter-autoroll
d0d9fbfaf0 Roll Dart SDK from a1c1e0d3bb18 to c7042dc03f43 (2 revisions) (flutter/engine#41452)
https://dart.googlesource.com/sdk.git/+log/a1c1e0d3bb18..c7042dc03f43

2023-04-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-37.0.dev
2023-04-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-36.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aam@google.com,chinmaygarde@google.com,dart-vm-team@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-24 15:41:25 +00:00
skia-flutter-autoroll
526f2abfa6 Roll Skia from 1f84e5060646 to 0ec4c84abd0b (6 revisions) (flutter/engine#41449)
https://skia.googlesource.com/skia.git/+log/1f84e5060646..0ec4c84abd0b

2023-04-24 kjlubick@google.com Remove SkImageEncoder and SkImage::encodeToData
2023-04-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 60517cf84231 to 4b61bdad813f (1 revision)
2023-04-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 77d86c4a7ecc to b58ef53abced (11 revisions)
2023-04-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 83a6fdf2e118 to fab3b205b6c7
2023-04-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 003e879fd974 to d2b5bd140525 (14 revisions)
2023-04-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from f5a15d80499c to 83a6fdf2e118 (9 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,rmistry@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-24 13:57:52 +00:00
dependabot[bot]
06b8eef0d8 Bump actions/setup-python from 4.5.0 to 4.6.0 (flutter/engine#41444)
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 4.5.0 to 4.6.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/setup-python/releases">actions/setup-python's releases</a>.</em></p>
<blockquote>
<h2>Add allow-prereleases input</h2>
<p>In scope of this release we added a new input (<code>allow-prereleases</code>) to allow <a href="https://redirect.github.com/actions/setup-python/pull/414">falling back to pre-release versions of Python when a matching GA version of Python is not available</a></p>
<pre lang="yaml"><code>steps:
  - uses: actions/checkout@v3
  - uses: actions/setup-python@v4
    with:
      python-version: 3.12
      allow-prereleases: true
</code></pre>
<p>Besides, we added such changes as:</p>
<ul>
<li>Fix bug to trim new line for PyPy version: <a href="https://redirect.github.com/actions/setup-python/pull/610">actions/setup-python#610</a></li>
<li>Added pip dependency file to generate hash from it: <a href="https://redirect.github.com/actions/setup-python/pull/604">actions/setup-python#604</a></li>
<li>Improved error handling for saving and restoring cache: <a href="https://redirect.github.com/actions/setup-python/pull/618">actions/setup-python#618</a></li>
<li>Add warning if cache paths are empty: <a href="https://redirect.github.com/actions/setup-python/pull/642">actions/setup-python#642</a></li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="57ded4d7d5"><code>57ded4d</code></a> update <code>@​azure/storage-blob</code> (<a href="https://redirect.github.com/actions/setup-python/issues/655">#655</a>)</li>
<li><a href="df6abcc733"><code>df6abcc</code></a> update xml2js (<a href="https://redirect.github.com/actions/setup-python/issues/652">#652</a>)</li>
<li><a href="7a4f344e33"><code>7a4f344</code></a> Add warning for empty cache paths (<a href="https://redirect.github.com/actions/setup-python/issues/642">#642</a>)</li>
<li><a href="d1244c8404"><code>d1244c8</code></a> Remove ubuntu-18.04 from e2e (<a href="https://redirect.github.com/actions/setup-python/issues/641">#641</a>)</li>
<li><a href="3091b37310"><code>3091b37</code></a> Fix glob bug in package.json scripts section (<a href="https://redirect.github.com/actions/setup-python/issues/637">#637</a>)</li>
<li><a href="dfa76f8d0d"><code>dfa76f8</code></a> Update configuration files (<a href="https://redirect.github.com/actions/setup-python/issues/622">#622</a>)</li>
<li><a href="03eb867e3d"><code>03eb867</code></a> Add error handling for saving and restoring cache (<a href="https://redirect.github.com/actions/setup-python/issues/618">#618</a>)</li>
<li><a href="b41aaf9f0c"><code>b41aaf9</code></a> Merge pull request <a href="https://redirect.github.com/actions/setup-python/issues/621">#621</a> from akv-platform/reusable-workflow</li>
<li><a href="0ffa49cfca"><code>0ffa49c</code></a> Add update-config-files.yml</li>
<li><a href="ec365b4eba"><code>ec365b4</code></a> Add and configure ESLint and update configuration for Prettier (<a href="https://redirect.github.com/actions/setup-python/issues/617">#617</a>)</li>
<li>Additional commits viewable in <a href="d27e3f3d7c...57ded4d7d5">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/setup-python&package-manager=github_actions&previous-version=4.5.0&new-version=4.6.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>
2023-04-24 10:13:05 +00:00
skia-flutter-autoroll
9eeaf57bdd Roll Fuchsia Mac SDK from kZQW1hC63MessR4gl... to EEdHfWcEn3fHwQj46... (flutter/engine#41441)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-24 02:29:22 +00:00
skia-flutter-autoroll
821e87b833 Roll Fuchsia Linux SDK from 1RnHwa4NRXqe4iS6H... to fJ7ysM-O4VYAGeBDc... (flutter/engine#41440)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-24 00:51:24 +00:00
skia-flutter-autoroll
0da94426d9 Roll Skia from b9c90858cdd8 to 1f84e5060646 (1 revision) (flutter/engine#41432)
https://skia.googlesource.com/skia.git/+log/b9c90858cdd8..1f84e5060646

2023-04-23 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,rmistry@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-23 15:23:29 +00:00
skia-flutter-autoroll
b975c3ffaa Roll Fuchsia Mac SDK from KWUhrqWF9DaVpikxZ... to kZQW1hC63MessR4gl... (flutter/engine#41430)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-23 09:03:23 +00:00
skia-flutter-autoroll
f253f78e2a Roll Fuchsia Linux SDK from I9z-K7N5PdhXN-5SG... to 1RnHwa4NRXqe4iS6H... (flutter/engine#41428)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-23 06:39:10 +00:00
skia-flutter-autoroll
57beeaabbd Roll Dart SDK from fd4797c1464b to a1c1e0d3bb18 (1 revision) (flutter/engine#41427)
https://dart.googlesource.com/sdk.git/+log/fd4797c1464b..a1c1e0d3bb18

2023-04-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-35.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aam@google.com,chinmaygarde@google.com,dart-vm-team@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-23 02:47:36 +00:00
skia-flutter-autoroll
9b4b5cb3db Roll Fuchsia Mac SDK from qLDaxNMysjqL-IcPn... to KWUhrqWF9DaVpikxZ... (flutter/engine#41426)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-22 18:11:27 +00:00
skia-flutter-autoroll
623c2fd396 Roll Fuchsia Linux SDK from RdOaZ2-aDsn_64hk5... to I9z-K7N5PdhXN-5SG... (flutter/engine#41424)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-22 16:43:38 +00:00
skia-flutter-autoroll
48672abb9c Roll Dart SDK from be6db2b60a41 to fd4797c1464b (2 revisions) (flutter/engine#41422)
https://dart.googlesource.com/sdk.git/+log/be6db2b60a41..fd4797c1464b

2023-04-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-34.0.dev
2023-04-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-33.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aam@google.com,chinmaygarde@google.com,dart-vm-team@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-22 15:33:04 +00:00
skia-flutter-autoroll
b8244e7e08 Roll Skia from 9912500bcca3 to b9c90858cdd8 (2 revisions) (flutter/engine#41421)
https://skia.googlesource.com/skia.git/+log/9912500bcca3..b9c90858cdd8

2023-04-22 johnstiles@google.com Preserve SkRP execution masks when calling to/fromLinearSrgb.
2023-04-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 172c51ea9b08 to 60517cf84231 (5 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-22 15:31:21 +00:00
skia-flutter-autoroll
05d3998590 Roll Dart SDK from b6de2d42e58d to be6db2b60a41 (2 revisions) (flutter/engine#41416)
https://dart.googlesource.com/sdk.git/+log/b6de2d42e58d..be6db2b60a41

2023-04-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-32.0.dev
2023-04-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-31.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aam@google.com,chinmaygarde@google.com,dart-vm-team@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-22 05:28:36 +00:00
skia-flutter-autoroll
c77da4832d Roll Skia from 36a6690cd1f1 to 9912500bcca3 (2 revisions) (flutter/engine#41415)
https://skia.googlesource.com/skia.git/+log/36a6690cd1f1..9912500bcca3

2023-04-21 johnstiles@google.com Reland "Disable SkVM by default."
2023-04-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from bfd1e43ef9d6 to 172c51ea9b08 (6 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-22 02:24:23 +00:00
skia-flutter-autoroll
a49c2876c9 Roll Skia from aa592c60846d to 36a6690cd1f1 (11 revisions) (flutter/engine#41413)
https://skia.googlesource.com/skia.git/+log/aa592c60846d..36a6690cd1f1

2023-04-21 johnstiles@google.com Ignore SkVM-related flags when SK_ENABLE_SKVM is not defined.
2023-04-21 johnstiles@google.com Fix lifetime issue with deferred uniforms in SkRP.
2023-04-21 brianosman@google.com Fully remove legacy sprite blitters for everything but SrcOver
2023-04-21 johnstiles@google.com Revert "Disable SkVM by default."
2023-04-21 johnstiles@google.com Disable SkVM by default.
2023-04-21 jvanverth@google.com [graphite] Still more steps to get dm running with Vulkan
2023-04-21 johnstiles@google.com Simplify shuffle instruction-encoding in RP builder.
2023-04-21 rmistry@google.com Update "directly ping rmistry@" documentation
2023-04-21 johnstiles@google.com Move #ifdef guards to fix Chrome roll.
2023-04-21 fmalita@chromium.org [skottie] Plumb new text direction property
2023-04-21 blundell@chromium.org [Graphite] Return null when color type not found in DawnCaps.cpp

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-22 01:26:25 +00:00
skia-flutter-autoroll
96c50b5dca Roll Fuchsia Mac SDK from fMOcI5zn1z0nOrV7s... to qLDaxNMysjqL-IcPn... (flutter/engine#41412)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-22 00:46:22 +00:00
skia-flutter-autoroll
46b36722ee Roll Fuchsia Linux SDK from Edv0I0o8GQ7c0z8XK... to RdOaZ2-aDsn_64hk5... (flutter/engine#41407)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-21 23:29:05 +00:00
skia-flutter-autoroll
618b27cbca Roll Dart SDK from fabaeef00dfb to b6de2d42e58d (2 revisions) (flutter/engine#41401)
https://dart.googlesource.com/sdk.git/+log/fabaeef00dfb..b6de2d42e58d

2023-04-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-30.0.dev
2023-04-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-29.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aam@google.com,chinmaygarde@google.com,dart-vm-team@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-21 19:08:06 +00:00
Jason Simmons
6f5ee7f984 [Impeller] Add a CommandBuffer::WaitUntilScheduled API (flutter/engine#41303)
This can be used by IO thread operations such as image decoding to ensure that the results of GPU commands become visible to the raster thread.
2023-04-21 19:08:04 +00:00
gaaclarke
b6818a0773 [Impeller] Turned off the TextRotated golden test again (flutter/engine#41399)
We previously turned this test to `ignore` to see if we could get it to stabilize by accepting the variants and it doesn't seem to have worked.  I'm going to turn it off again.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-04-21 18:26:10 +00:00
skia-flutter-autoroll
041e2f267d Roll Skia from 5754b81988b8 to aa592c60846d (11 revisions) (flutter/engine#41398)
https://skia.googlesource.com/skia.git/+log/5754b81988b8..aa592c60846d

2023-04-21 skia-autoroll@skia-public.iam.gserviceaccount.com (Manual) Roll Dawn from 9e9c4560752a to 003e879fd974 (22 revisions)
2023-04-21 johnstiles@google.com Eliminate redundant register/stack exchanges.
2023-04-21 ccameron@chromium.org SkJpeg: Update gainmap encode and decode to reflect spec changes
2023-04-21 johnstiles@google.com Wrap SkVM with #ifdef SK_ENABLE_SKVM.
2023-04-21 johnstiles@google.com Wrap remaining usage of SkVM with #ifdef SK_ENABLE_SKVM.
2023-04-21 johnstiles@google.com Wrap SkSLVMCodeGenerator with #ifdef SK_ENABLE_SKVM.
2023-04-21 johnstiles@google.com Wrap SkColorFilter/Blender::onProgram calls with #ifdef SK_ENABLE_SKVM.
2023-04-21 johnstiles@google.com Reland "Wrap SkShader::program calls with #ifdef SK_ENABLE_SKVM."
2023-04-21 kjlubick@google.com Expose SkPixmapUtils
2023-04-21 kjlubick@google.com Move most of the Ganesh code out of SkImage_Base and SkImage_Lazy
2023-04-21 michaelludwig@google.com Fix anisotropic subset check in GrTextureEffect

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-21 17:48:45 +00:00
gaaclarke
3d7eeccb55 [impeller] fixed flake where blit wasn't tracking its texture (flutter/engine#41347)
fixes https://github.com/flutter/flutter/issues/125147

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-04-21 10:45:26 -07:00
Prashant Andoriya
238f79d114 removing the check_gn_format.py file from ci/ (flutter/engine#41397)
Delete obsolete empty script.

fixes:  flutter/flutter#100741

*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*

*List which issues are fixed by this PR. You must list at least one issue.*

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

- [+] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
- [+] I signed the [CLA].

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-04-21 17:26:34 +00:00
David Iglesias
dfd9ef5e60 [web] Fix HashUrlStrategy.addPopStateListener (flutter/engine#41384)
During a JS-interop refactor, we introduced a small bug in the `addPopStateListener` method of the `HashUrlStrategy` object (web).

This wasn't caught before because the existing tests were mocking the refactored code.

## Issues

Fixes: https://github.com/flutter/flutter/issues/125228

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-04-21 17:26:31 +00:00
Brandon DeRosier
549dd82f2f [Impeller] Fix division by zero for transparent shadows (flutter/engine#41391)
A division by zero happens if the shadow color is fully transparent, and
the NaNs are getting assigned to the RGB values of the paint color being
handed to the rrect shadow draw. This doesn't cause a problem when wide
gamut is off because NaN output ends up being interpreted as zero (thus
making the shadow output fully transparent black, which happens to be
the expected and correct result). However, when a wide gamut attachment
is present, the NaN output ends up being interpreted as a negative
value.

Reproduction app:
```dart
import 'package:flutter/material.dart';

void main() => runApp(const GeneralDialogApp());

class EvilPainter extends CustomPainter {
  @override
  void paint(Canvas canvas, Size size) {
    final Rect rect = Offset.zero & size;
    canvas.drawPaint(Paint()..color = Colors.white);
    canvas.saveLayer(null, Paint()..blendMode = BlendMode.srcOver);
    canvas.drawShadow(Path()..addRect(Rect.fromLTRB(100, 100, 300, 300)),
        Colors.black54, 15, false);
    canvas.drawShadow(Path()..addRect(Rect.fromLTRB(100, 100, 300, 300)),
        Colors.black54, 15, false);
    canvas.drawShadow(Path()..addRect(Rect.fromLTRB(100, 100, 300, 300)),
        Colors.transparent, 15, false);
    canvas.restore();
  }

  @override
  bool shouldRepaint(EvilPainter oldDelegate) => false;
  @override
  bool shouldRebuildSemantics(EvilPainter oldDelegate) => false;
}

class GeneralDialogApp extends StatelessWidget {
  const GeneralDialogApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      restorationScopeId: 'app',
      home: CustomPaint(painter: EvilPainter()),
    );
  }
}
```

Before:

![image](https://user-images.githubusercontent.com/919017/233558512-0bfdcdc0-017d-4df3-870f-bd8808ef73b7.png)


After:

![image](https://user-images.githubusercontent.com/919017/233558076-b56c7f43-c81e-4ca6-897d-246251dae930.png)
2023-04-21 08:58:05 -07:00