zan1456/flutter
1
0
Fork 0
forked from firka/flutter
Code Pull Requests Activity
34,106 Commits 2 Branches 0 Tags
b91d52b1df9d26ee1b9448cdff04c19ec51fa047
Commit Graph

34106 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
skia-flutter-autoroll
b91d52b1df Roll Fuchsia Linux SDK from l6mWjvlO1xJg5ZFKK... to mZP8LxbhYHstUxmxd... (flutter/engine#50638) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-14 05:21:13 +00:00
skia-flutter-autoroll
b35bf08fc8 Roll Skia from 79ec267090bd to b8acfa559db0 (1 revision) (flutter/engine#50636) 
https://skia.googlesource.com/skia.git/+log/79ec267090bd..b8acfa559db0

2024-02-14 michaelludwig@google.com [ganesh] Actually let SkSpecialImage::asShader() skip subset clamping

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-14 04:34:24 +00:00
skia-flutter-autoroll
c6f1cc2b23 Roll Skia from d650dcaf4b49 to 79ec267090bd (1 revision) (flutter/engine#50634) 
https://skia.googlesource.com/skia.git/+log/d650dcaf4b49..79ec267090bd

2024-02-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 42673e90d5d2 to b9bd9ba3560a

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-14 03:37:17 +00:00
skia-flutter-autoroll
6f13d73b7d Roll Skia from f7e3a5395fe1 to d650dcaf4b49 (8 revisions) (flutter/engine#50632) 
https://skia.googlesource.com/skia.git/+log/f7e3a5395fe1..d650dcaf4b49

2024-02-14 michaelludwig@google.com Revert "[skif] Add BoundsScope to analyzeBounds()"
2024-02-13 scroggo@google.com Fix fBytesWrittenBeforeTail on malloc failure
2024-02-13 michaelludwig@google.com [skif] Add makePixelOutset() to expand a SpecialImage's subset
2024-02-13 kjlubick@google.com Move Graphite-specific and GR_TEST_UTILS code out of SkTiledImageUtils
2024-02-13 michaelludwig@google.com [skif] Add BoundsScope to analyzeBounds()
2024-02-13 herb@google.com Use / for UBSAN analysis
2024-02-13 weiyuhuang@google.com Fix Half Leading for Strut.
2024-02-13 kjlubick@google.com Define GR_TEST_UTILS when building skqp for Android Framework

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-14 02:47:00 +00:00
Jason Simmons
e5061e239c In run_tests, use the regular path to the Vulkan library if lib.unstripped does not exist (flutter/engine#50629) 
lib.unstripped will not be created in a "gn --no-stripped" build

See https://github.com/flutter/engine/pull/50443
 2024-02-14 02:19:21 +00:00
skia-flutter-autoroll
64b9fa3d42 Roll Dart SDK from a8303c0bf1b4 to 032323fa534b (1 revision) (flutter/engine#50631) 
https://dart.googlesource.com/sdk.git/+log/a8303c0bf1b4..032323fa534b

2024-02-14 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-140.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-14 02:08:44 +00:00
gaaclarke
35f67519ca [Impeller] replaces golden file count with a golden diff file (flutter/engine#50621) 
fixes https://github.com/flutter/flutter/issues/143353

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-02-14 01:24:52 +00:00
Brandon DeRosier
f8d9ab0419 [Impeller] Migrate all ColorSourceContents to use a shared rendering routine. (flutter/engine#50261) 
This is going to be our "in" for performing StC in all the ColorSourceContents when necessary.

No semantic change.
 2024-02-14 01:24:51 +00:00
Matan Lurey
5703ca8384 Run Skia and Impeller OpenGLES on APIv28. (flutter/engine#50583) 
Partial work towards https://github.com/flutter/flutter/issues/143351.

I filed https://github.com/flutter/flutter/issues/143374 about the state
of the docs, it was hard to figure this out.
 2024-02-13 17:12:18 -08:00
Gray Mackall
42bdee9589 Make Android Studio depend on the android_embedding_dependencies (flutter/engine#50612) 
Aligns our (Android Studio) IDE support with the actual dependencies that get resolved by our build process, by depending on the androidx jars directly.

Follow up to [discord discussion](https://discord.com/channels/608014603317936148/1204566292346961950/1204594136343248946).

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-02-14 01:12:07 +00:00
LongCatIsLooong
cd637f73f2 Temporarily change canvaskit kitchensink test to unblock the skia roll (flutter/engine#50617) 
The previous skia roll (https://github.com/flutter/engine/pull/50609) failed on [Linux linux_web_engine](https://ci.chromium.org/b/8756177705618610401).
I've tested that the failing `canvaskit_api_tt_on_test.dart` would pass with the new skia revision `'a1c58c4eb6d5ae553097c5d27c134e09c8825e06` on this patch.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-02-14 00:27:50 +00:00
Jim Graham
7688fafdff [Impeller] add benchmarks for the stroke geometry entity code (flutter/engine#50616) 
Adds benchmarks (and backend support methods) for tracking the performance of the stroking code in the entity geometry package.
 2024-02-13 23:47:08 +00:00
Loïc Sharma
729dd91430 [Windows] Refactor window destroyed app lifecycle event (flutter/engine#50565) 
Improves Windows's lifecycle event for window destruction:

1. Made `FlutterWindowsView` generate the "window hidden" event when the HWND is destroyed instead of the `FlutterWindow`.
    1. Before the window would submit this event using a destroyed view:
        1. The `FlutterWindowsView` destructor runs to completion.
        2. The view owns the window, so the `FlutterWindow` is destroyed
        3. The window's destructor generates a "window hidden" event
        4. The window uses the destroyed view to notify the engine of the event
2. Adds an app lifecycle integration test to verify the `resumed` and `hidden` events are sent when an app is launched and closed.
3. Removed the `FlutterWindowTest` type as it was unused

Prepares for https://github.com/flutter/flutter/issues/137267

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-02-13 22:35:42 +00:00
Jonah Williams
a656286e39 [Impeller] fix cmd buffer recycling bug in test. (flutter/engine#50615) 
Speculative fix for a flake seen by @matanlurey . In the past we've seen race conditions when a single DeathRattle is used, because it actually gets destructed before the cmd pool state. By adding two and waiting we guaranteee that everything has completed in the resource manager.
 2024-02-13 22:33:16 +00:00
skia-flutter-autoroll
9b11e555f4 Roll Dart SDK from 04caefbfa60f to a8303c0bf1b4 (1 revision) (flutter/engine#50614) 
https://dart.googlesource.com/sdk.git/+log/04caefbfa60f..a8303c0bf1b4

2024-02-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-139.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-13 22:10:55 +00:00
gaaclarke
a9e542b824 [Impeller] Turn on golden tests that use the ImGui widgets functions (flutter/engine#50606) 
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-02-13 20:35:25 +00:00
Jonah Williams
4047466a83 [Impeller] remove denylist entry. (flutter/engine#50605) 
This was fixed in https://github.com/flutter/engine/pull/50539
 2024-02-13 20:22:04 +00:00
Zachary Anderson
9f2ff32022 [engine_build_configs] Use dart:ffi Abi to determine the host cpu (flutter/engine#50604) 
Follow-up on https://github.com/flutter/engine/pull/50543#discussion_r1486546946
 2024-02-13 19:19:27 +00:00
Jason Simmons
5b220df694 Update embedder support for Impeller/OpenGL to load some missing shaders and configure a depth attachment (flutter/engine#50416) 2024-02-13 18:55:10 +00:00
skia-flutter-autoroll
4cdf45c587 Roll Skia from 30bba7419898 to f7e3a5395fe1 (1 revision) (flutter/engine#50603) 
https://skia.googlesource.com/skia.git/+log/30bba7419898..f7e3a5395fe1

2024-02-13 jlavrova@google.com Fixing word spacing in RTL languages

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-13 18:53:10 +00:00
gaaclarke
7fca8fb5ba [Impeller] replaced playground macros with functions (flutter/engine#50602) 
testing: Refactor only

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2024-02-13 10:45:43 -08:00
Matan Lurey
8446a7fe3c Allow deprecated members from the Dart SDK to roll in. (flutter/engine#50575) 
Namely, without breaking the tree. This is a deliberate policy decision
change.

See https://github.com/flutter/flutter/issues/143312.
 2024-02-13 10:41:39 -08:00
zijiehe@
458841cf62 [Fuchsia] Run tests with test arguments (flutter/engine#50478) 
This change starts executing the suites with extra arguments, namely txt_tests, though the implementation does not limit to the suite.

Bug: flutter/flutter#140179

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-02-13 18:23:22 +00:00
skia-flutter-autoroll
87ac440ff3 Roll Dart SDK from 105312b80125 to 04caefbfa60f (1 revision) (flutter/engine#50600) 
https://dart.googlesource.com/sdk.git/+log/105312b80125..04caefbfa60f

2024-02-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-138.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-13 17:52:49 +00:00
skia-flutter-autoroll
0ab1f1d51d Roll Skia from aaed347b2dbb to 30bba7419898 (7 revisions) (flutter/engine#50599) 
https://skia.googlesource.com/skia.git/+log/aaed347b2dbb..30bba7419898

2024-02-13 bungeman@google.com Roll FreeType from 45903920 to 47574f7e (94 commits)
2024-02-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from f8dd9bcbe55d to 2cedf06e4cdf (3 revisions)
2024-02-13 herb@google.com Allow divide by zero in reciprocal of alpha
2024-02-13 borenet@google.com [infra] Remove P30 jobs
2024-02-13 herb@google.com Specialize ReciprocalAlpha(Times255)
2024-02-13 michaelludwig@google.com [skif] Rename preserveTransparency to better preserveDstBounds
2024-02-13 michaelludwig@google.com [skif] Move FilterResult subsetting to member function

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-13 17:46:02 +00:00
Dan Field
e83d4c3a30 Do not use AChoreographer on 32 bit devices (flutter/engine#50586) 
This is a fix forward alternative to the revert here: https://github.com/flutter/engine/pull/50581

If the revert lands first I'll rebase into this. I'm working on verifying this locally against the devicelab tests.
 2024-02-13 17:32:16 +00:00
Zachary Anderson
f202a1fdce Move libpng to //flutter/third_party/libpng (flutter/engine#50571) 
This is an example of moving a dependency to `//flutter/third_party`
that requires forward/aliasing through the secondary build directory.
Without forwarding, and only making changes to the `DEPS` file and
rewriting paths in the engine repo, a `gn` invocation gets the following
error:
```
ERROR at //third_party/freetype2/BUILD.gn:85:5: Can't load input file.
    "//third_party/libpng",
    ^---------------------
Unable to load:
  /Users/zra/flutter/engine/src/third_party/libpng/BUILD.gn
I also checked in the secondary tree for:
  /Users/zra/flutter/engine/src/flutter/build/secondary/third_party/libpng/BUILD.gn
```

Another dependency, with a `BUILD.gn` file outside of the engine repo,
is still referring to `libpng` by the old path. However, `gn` tells us
that it is also checking under the secondary tree. We can put whatever
we want in that `BUILD.gn` file to make `freetype2` happy. In this case
it's easy, we just add a build rule there that forwards to `libpng`'s
new location. There's only one wrinkle, which is that the dependency in
the `group` target has to be `public_deps` rather than a simple `deps`.
This is so that `public_deps` and `public_configs` of
`//flutter/third_party/libpng` are correctly inherited by dependents of
`//third_party/libpng`.
 2024-02-13 07:08:45 -08:00
skia-flutter-autoroll
c8fd12690f Roll Skia from b150107d536d to aaed347b2dbb (2 revisions) (flutter/engine#50595) 
https://skia.googlesource.com/skia.git/+log/b150107d536d..aaed347b2dbb

2024-02-13 jvanverth@google.com [graphite] Add owning Recorder to PathAtlas classes.
2024-02-13 fmalita@chromium.org [mesh2d demo] Updated to latest API

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-13 15:04:06 +00:00
skia-flutter-autoroll
2758ec7635 Roll Dart SDK from 8d3a8d85c883 to 105312b80125 (2 revisions) (flutter/engine#50593) 
https://dart.googlesource.com/sdk.git/+log/8d3a8d85c883..105312b80125

2024-02-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-137.0.dev
2024-02-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-136.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-13 13:45:16 +00:00
skia-flutter-autoroll
7864be661d Roll Skia from d503bc9c6e46 to b150107d536d (1 revision) (flutter/engine#50591) 
https://skia.googlesource.com/skia.git/+log/d503bc9c6e46..b150107d536d

2024-02-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from eaddd3baa5ed to cb7d3cc206d6 (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-13 11:10:21 +00:00
skia-flutter-autoroll
347091d257 Roll Skia from a1d9b83034ac to d503bc9c6e46 (3 revisions) (flutter/engine#50587) 
https://skia.googlesource.com/skia.git/+log/a1d9b83034ac..d503bc9c6e46

2024-02-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 996f56b64f8b to 42673e90d5d2 (9 revisions)
2024-02-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from b10254f79f46 to 10bc0e035997 (16 revisions)
2024-02-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 2b29178c7ccf to 42673e90d5d2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,johnstiles@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-13 06:50:35 +00:00
gaaclarke
c4575d9ac7 [Impeller] cleaned up and removed golden test exceptions (flutter/engine#50572) 
This starts generating golden image tests for most interactive tests instead of having to explicitly exempt them.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-02-13 04:40:12 +00:00
skia-flutter-autoroll
67db5ec63e Roll Skia from 17d00f9241b3 to a1d9b83034ac (2 revisions) (flutter/engine#50582) 
https://skia.googlesource.com/skia.git/+log/17d00f9241b3..a1d9b83034ac

2024-02-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 8bd678a29dfa to f8dd9bcbe55d (8 revisions)
2024-02-13 armansito@google.com [viewer] Context option and UI toggle for compute MSAAx16

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,johnstiles@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-13 04:38:05 +00:00
skia-flutter-autoroll
b73e1ed01e Roll Fuchsia Linux SDK from RVHAIKU50ogkiV-Lj... to l6mWjvlO1xJg5ZFKK... (flutter/engine#50579) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-13 02:07:14 +00:00
skia-flutter-autoroll
fbab5d3360 Roll Dart SDK from 94f7dec34cef to 8d3a8d85c883 (1 revision) (flutter/engine#50577) 
https://dart.googlesource.com/sdk.git/+log/94f7dec34cef..8d3a8d85c883

2024-02-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-135.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-13 02:03:16 +00:00
Matan Lurey
c4b914c009 Add Impeller runtime options to Android scenario_app (flutter/engine#50487) 
Closes https://github.com/flutter/flutter/issues/143171.

Adds builds for both Impeller Vulkan and Impeller OpenGLES.

_Some of the goldens for Impeller/Vulkan won't look right yet. I'll link
to the blocking issues after CI runs._
 2024-02-12 17:59:19 -08:00
skia-flutter-autoroll
d1efcd938a Roll Skia from c464143dfaab to 17d00f9241b3 (1 revision) (flutter/engine#50576) 
https://skia.googlesource.com/skia.git/+log/c464143dfaab..17d00f9241b3

2024-02-13 armansito@google.com [graphite] Support the MSAA16 mode in VelloRenderer

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,johnstiles@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-13 01:13:38 +00:00
skia-flutter-autoroll
d4bbb25f86 Roll Skia from ecf2f622d0b3 to c464143dfaab (2 revisions) (flutter/engine#50574) 
https://skia.googlesource.com/skia.git/+log/ecf2f622d0b3..c464143dfaab

2024-02-12 armansito@google.com [graphite][vello] Incorporate stroke rework changes
2024-02-12 bungeman@google.com Update sbix slide

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,johnstiles@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-13 00:18:32 +00:00
Jonah Williams
b85e2d9b8d [Impeller] CommandPoolVK recycles command buffers too. (flutter/engine#50468) 
Its a bit ambiguous whether or not resetting a cmd pool returns the cmd buffers resources back to the pool in a way that can be reused on subsequent frames. Since reseting the pool resets the cmd buffers to their initial state, they are safe to reuse once reset. Additionally, through profiling I can observe that there is less allocation in cmd buffer creation when the buffers themselves are recycled, at least on the Mali drivers.

### Before (Animated Advanced Blend Macrobenchmark)

![image](https://github.com/flutter/engine/assets/8975114/c0022d7a-d16e-4db5-862a-01d5a6157e18)

### After

![image](https://github.com/flutter/engine/assets/8975114/3b45f9a9-8811-4fbc-8b90-24338317df6e)
 2024-02-12 23:40:19 +00:00
Matan Lurey
154fa183ad Make dart:ui#Paint final to allow changes/disallow implementing. (flutter/engine#50557) 
Closes https://github.com/flutter/flutter/issues/142937.
 2024-02-12 15:30:32 -08:00
Robert Ancell
51c9fc1c08 Replace usage of an integer for GdkModifierType (flutter/engine#50481) 
The integer is replaced with the enumerated type in GTK4. The
documentation in GTK3 indicates the value is the enumerated type.
 2024-02-13 12:26:46 +13:00
Robert Ancell
08995aae83 Remove FlKeyEvent.dispose_origin and use GdkEvent type for origin (flutter/engine#50483) 
This removes casting. origin was a pointer for testing purposes to be
mocked but the tests make no use of this.
 2024-02-13 12:19:29 +13:00
Zachary Anderson
b2b54c426d Move Linux impeller_unittests to linux_unopt (flutter/engine#50558) 
This PR moves linux impeller_unittests to the correct builder, but does
not yet merge it with the rest of the tests running in a
host_debug_unopt build due to:
https://github.com/flutter/flutter/issues/143330
 2024-02-12 15:00:32 -08:00
Chinmay Garde
6f01f71b03 [Impeller] Don't suppress outdated validation error. (flutter/engine#50568) 
We build our own validation layers. So this should no longer be an issue.
 2024-02-12 22:42:21 +00:00
Chinmay Garde
2416280285 [Impeller] Remove references to moved impeller/image from README. (flutter/engine#50513) 
Moved by @dnfield in https://github.com/flutter/engine/pull/50480
 2024-02-12 22:32:47 +00:00
skia-flutter-autoroll
a3232d6251 Roll Dart SDK from dca13675e65e to 94f7dec34cef (1 revision) (flutter/engine#50567) 
https://dart.googlesource.com/sdk.git/+log/dca13675e65e..94f7dec34cef

2024-02-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-134.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-12 22:14:04 +00:00
skia-flutter-autoroll
d510b5c517 Roll Skia from f88eeb658358 to ecf2f622d0b3 (1 revision) (flutter/engine#50566) 
https://skia.googlesource.com/skia.git/+log/f88eeb658358..ecf2f622d0b3

2024-02-12 scroggo@google.com SkDynamicMemoryWStream::write: allow malloc to fail

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,johnstiles@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-12 22:06:19 +00:00
skia-flutter-autoroll
7a708268c0 Roll Skia from 867c1e8390e2 to f88eeb658358 (5 revisions) (flutter/engine#50564) 
https://skia.googlesource.com/skia.git/+log/867c1e8390e2..f88eeb658358

2024-02-12 michaelludwig@google.com [skif] Make AutoSurface a member type of FilterResult
2024-02-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll debugger-app-base from 3acd3682009f to be5714074b1a
2024-02-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from 67e2da56aec4 to 30062bca1496
2024-02-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll shaders-base from 45ec924a5da0 to b04a5aef564b
2024-02-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll jsfiddle-base from db3abc597412 to 0ccdb32ff1ca

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,johnstiles@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-12 21:11:24 +00:00
Jason Simmons
fb48b918b9 Roll vulkan-deps to 014f44e134a1de387791bffacc32ff9d8db71176 (flutter/engine#50515) 
Fixes https://github.com/flutter/flutter/issues/141277
See https://github.com/flutter/flutter/issues/138117
 2024-02-12 20:22:40 +00:00
skia-flutter-autoroll
84ba9bfb5e Roll Skia from 4081496b7693 to 867c1e8390e2 (20 revisions) (flutter/engine#50562) 
https://skia.googlesource.com/skia.git/+log/4081496b7693..867c1e8390e2

2024-02-12 scroggo@google.com WebpEncoder: respect the return value of write()
2024-02-12 kjlubick@google.com Remove Docker tasks from the CQ
2024-02-12 johnstiles@google.com Manual roll Dawn from 37780d217965 to b10254f79f46 (38 revisions)
2024-02-12 jvanverth@google.com [graphite] Make atlas-related recordUploads() calls have same signature.
2024-02-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from f53f1b6ab28e to 8bd678a29dfa (2 revisions)
2024-02-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 996f56b64f8b to dd80ac99b627
2024-02-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 3ad163d09102 to eaddd3baa5ed (9 revisions)
2024-02-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 536d1c386426 to 996f56b64f8b (5 revisions)
2024-02-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 2e6294aece33 to f53f1b6ab28e (1 revision)
2024-02-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 91655d665673 to 2e6294aece33 (1 revision)
2024-02-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from fe1cbbda7543 to 996f56b64f8b
2024-02-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 6c7bb72d35e0 to 91655d665673 (3 revisions)
2024-02-09 kjlubick@google.com Use old define for gif (for now)
2024-02-09 lovisolo@google.com [bazel] GaneshVulkanSurfaceManager.cpp: Implement.
2024-02-09 jvanverth@google.com [graphite] Stub in SmallPathAtlas.
2024-02-09 lovisolo@google.com [bazel] Move skiatest::TestType from //tests/Test.h to a new //test/TestType.h file.
2024-02-09 kjlubick@google.com Rename Benchmark::Backend::kGPU to Benchmark::Backend::kGanesh
2024-02-09 lovisolo@google.com [bazel] Fix Android build.
2024-02-09 kjlubick@google.com Make sure all uses of SkResources that need codecs register them
2024-02-09 jlavrova@google.com Assure last cluster of Run ends at the end of Run

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,johnstiles@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-12 20:18:27 +00:00