skia-flutter-autoroll
a961f419fc
Roll Skia from d58324bf653d to 23052eb28808 (3 revisions) ( flutter/engine#43418 )
...
https://skia.googlesource.com/skia.git/+log/d58324bf653d..23052eb28808
2023-07-05 sunnyps@chromium.org graphite: Implement asyncRescaleAndReadPixels for RGBA
2023-07-05 nicolettep@google.com [graphite] Create VkGraphicsPipeline, implement Vulkan pipeline key creation
2023-07-05 johnstiles@google.com Avoid crash in Viewer when viewing shaders in Graphite.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com ,jamesgk@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-05 15:46:18 +00:00
skia-flutter-autoroll
24c1b51da9
Roll Skia from faf906db84ab to a453fed07c91 (4 revisions) ( flutter/engine#43412 )
...
https://skia.googlesource.com/skia.git/+log/faf906db84ab..a453fed07c91
2023-07-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 095b710a2ea5 to 9bf70d50d3ad
2023-07-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 347306080b87 to df22aa218f6a (1 revision)
2023-07-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 222e07b368b1 to 3e73cce1c470 (1 revision)
2023-07-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 73aa9bd33f2c to 095b710a2ea5 (2 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com ,jamesgk@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-05 06:59:19 +00:00
skia-flutter-autoroll
35d39a3429
Roll Skia from 85a3fda32850 to bb18c9b1f730 (3 revisions) ( flutter/engine#43399 )
...
https://skia.googlesource.com/skia.git/+log/85a3fda32850..bb18c9b1f730
2023-07-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 73aa9bd33f2c to 9f7b74110b61
2023-07-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 414f9688245c to 73aa9bd33f2c (1 revision)
2023-07-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 9c78ac0f4327 to c5c482733140 (7 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jamesgk@google.com ,jimgraham@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-04 06:30:04 +00:00
dependabot[bot]
5082d28b1e
Bump actions/labeler from 4.1.0 to 4.2.0 ( flutter/engine#43398 )
...
Bumps [actions/labeler](https://github.com/actions/labeler ) from 4.1.0 to 4.2.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/labeler/releases ">actions/labeler's releases</a>.</em></p>
<blockquote>
<h2>v4.2.0</h2>
<h2>What's Changed</h2>
<p>In the scope of this release, the following outputs were added by <a href="https://github.com/danielsht86 "><code>@âdanielsht86</code></a> in <a href="https://redirect.github.com/actions/labeler/issues/60 ">#60</a>:</p>
<ul>
<li><code>new-labels</code> - a comma-separated string that contains all newly added labels.</li>
<li><code>all-labels</code> - a comma-separated string that contains all labels currently assigned to the PR.</li>
</ul>
<p>For detailed information, please refer to our <a href="0967ca812e (outputs)https://github.com/markmssd "><code>@âmarkmssd</code></a> in <a href="https://redirect.github.com/actions/labeler/issues/497 ">#497</a>. However, it's important to note that the GitHub API imposes a limit of 100 labels. To ensure smooth operation, a warning message that will alert you if the number of labels exceeds this limit was implemented. From this point forward, if more than 100 labels are specified, only the first 100 will be assigned.</p>
<p>The error handling for the <code>Resource not accessible by integration</code> error was added by <a href="https://github.com/jsoref "><code>@âjsoref</code></a> in <a href="https://redirect.github.com/actions/labeler/issues/405 ">#405</a>. Now, if the workflow is misconfigured, the labeler provides a clear warning and guidance for correction.</p>
<p>This release also includes the following changes:</p>
<ul>
<li>Warn about the limitations of GitHub tokens by <a href="https://github.com/dfandrich "><code>@âdfandrich</code></a> in <a href="https://redirect.github.com/actions/labeler/pull/491 ">actions/labeler#491</a></li>
<li>Improve readme by <a href="https://github.com/jsoref "><code>@âjsoref</code></a> in <a href="https://redirect.github.com/actions/labeler/pull/589 ">actions/labeler#589</a></li>
<li>Bump eslint-plugin-jest from 27.2.1 to 27.2.2 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/actions/labeler/pull/591 ">actions/labeler#591</a></li>
<li>Bump eslint from 8.42.0 to 8.43.0 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/actions/labeler/pull/592 ">actions/labeler#592</a></li>
<li>Bump <code>@âtypescript-eslint/eslint-plugin</code> from 5.60.0 to 5.60.1 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/actions/labeler/pull/598 ">actions/labeler#598</a></li>
<li>Bump <code>@âtypescript-eslint/parser</code> from 5.60.0 to 5.60.1 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/actions/labeler/pull/597 ">actions/labeler#597</a></li>
<li>Bump <code>@âoctokit/plugin-retry</code> from 5.0.2 to 5.0.4 by <a href="https://github.com/MaksimZhukov "><code>@âMaksimZhukov</code></a> in <a href="https://redirect.github.com/actions/labeler/pull/599 ">actions/labeler#599</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/dfandrich "><code>@âdfandrich</code></a> made their first contribution in <a href="https://redirect.github.com/actions/labeler/pull/491 ">actions/labeler#491</a></li>
<li><a href="https://github.com/markmssd "><code>@âmarkmssd</code></a> made their first contribution in <a href="https://redirect.github.com/actions/labeler/pull/497 ">actions/labeler#497</a></li>
<li><a href="https://github.com/danielsht86 "><code>@âdanielsht86</code></a> made their first contribution in <a href="https://redirect.github.com/actions/labeler/pull/60 ">actions/labeler#60</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/labeler/compare/v4...v4.2.0 ">https://github.com/actions/labeler/compare/v4...v4.2.0 </a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="0967ca812ehttps://redirect.github.com/actions/labeler/issues/60 ">#60</a>)</li>
<li><a href="375538a703https://redirect.github.com/actions/labeler/issues/599 ">#599</a>)</li>
<li><a href="8d17e8ac4chttps://redirect.github.com/actions/labeler/issues/597 ">#597</a>)</li>
<li><a href="9d45a7438fhttps://redirect.github.com/actions/labeler/issues/598 ">#598</a>)</li>
<li><a href="130636aba5https://redirect.github.com/actions/labeler/issues/592 ">#592</a>)</li>
<li><a href="54aeabf7b5https://redirect.github.com/actions/labeler/issues/593 ">#593</a>)</li>
<li><a href="899595ff01https://redirect.github.com/actions/labeler/issues/591 ">#591</a>)</li>
<li><a href="8056174ee0https://redirect.github.com/actions/labeler/issues/594 ">#594</a>)</li>
<li><a href="7a202e6428https://redirect.github.com/actions/labeler/issues/497 ">#497</a>)</li>
<li><a href="b5ff161cf0https://redirect.github.com/actions/labeler/issues/405 ">#405</a>)</li>
<li>Additional commits viewable in <a href="9fcb2c2f55...0967ca812ehttps://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/labeler&package-manager=github_actions&previous-version=4.1.0&new-version=4.2.0 )](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2023-07-04 06:12:39 +00:00
Chinmay Garde
e7964a816f
[Impeller] Document impeller::Context. ( flutter/engine#43389 )
2023-07-04 00:30:23 +00:00
skia-flutter-autoroll
285d749ac5
Roll Skia from e16d5b988a36 to 94ad507b8959 (2 revisions) ( flutter/engine#43383 )
...
https://skia.googlesource.com/skia.git/+log/e16d5b988a36..94ad507b8959
2023-07-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 414f9688245c to 73aa9bd33f2c
2023-07-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 4ea8b01e8983 to 414f9688245c (4 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jamesgk@google.com ,jimgraham@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-03 06:57:23 +00:00
Brandon DeRosier
a3745e962c
[Impeller] Remove blend mode restrictions on clear color optimization ( flutter/engine#43348 )
...
Now that all of the CPU blend modes work, we can allow back-to-back
fullscreen solid color draws to get blended together regardless of their
blend mode/color opacity.
2023-06-30 21:48:45 -07:00
skia-flutter-autoroll
8803d0b50d
Roll Skia from ceaeef84b8a3 to dbf0829114ee (15 revisions) ( flutter/engine#43370 )
...
https://skia.googlesource.com/skia.git/+log/ceaeef84b8a3..dbf0829114ee
2023-06-30 bungeman@google.com Allow use of DWriteCore
2023-06-30 kjlubick@google.com Reland "Move GPU specific ImageFilter context factories to src/gpu/"
2023-06-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 18e68e17ca5c to d2fc29b352fe (8 revisions)
2023-06-30 armansito@google.com [graphite][vello] Better quality hairline strokes
2023-06-30 johnstiles@google.com Remove shared compiler from ResourceProvider.
2023-06-30 jlavrova@google.com Updating SkParagraph test to newer font version
2023-06-30 bungeman@google.com Fix DirectWrite port COLRv1 palette overrides
2023-06-30 robertphillips@google.com Add a tiled-image cache test
2023-06-30 kjlubick@google.com Run buildifier on tools/window/BUILD.bazel
2023-06-30 nicolettep@google.com Revert "[graphite] Reenable tiled image cache size heuristic"
2023-06-30 het@google.com [canvaskit] Add `Picture.cullRect` and `Picture.approximateBytesUsed`.
2023-06-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 77c4b6779152 to 20cc4a9bc250 (6 revisions)
2023-06-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 4ea8b01e8983 to c97b5b1d4d66
2023-06-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 96ae8b91855e to 4ea8b01e8983 (3 revisions)
2023-06-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 49af09d96379 to 15d2e87074d6 (18 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jimgraham@google.com ,nicolettep@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-01 01:49:05 +00:00
Brandon DeRosier
c90389c9cd
[Impeller] Add explicit color filter types to Aiks. ( flutter/engine#43342 )
...
Part of https://github.com/flutter/flutter/issues/127232 .
Adds an explicit ColorFilter concept to Aiks which wraps the GPU and CPU
implementations. We're not using the CPU implementations yet, but I'll
be getting it wired up in a follow-up patch.
2023-06-30 18:42:21 -07:00
Jonah Williams
cb7fd03312
[Impeller] cache MSAA texture in swapchain for devices that do not support memoryless. ( flutter/engine#43349 )
...
For devices that don't support memoryless textures, the fullscreen MSAA texture adds a substantial amount of memory thrashing when it is allocated and deallocated. For these devices, lets cache the MSAA texture in the swapchain image.
https://github.com/flutter/flutter/issues/129737
2023-06-30 18:34:29 +00:00
Jonah Williams
70cb44975f
[Impeller] Fix validation error in position color shader. ( flutter/engine#43356 )
...
The input was a float16 vec4, so the corresponding output must match or else we get a validation error. Not related to platform view issue.
2023-06-30 18:34:27 +00:00
yaakovschectman
570578974c
Fix inverted boolean in Windows document selection changed a11y event ( flutter/engine#43281 )
...
Fix a typo that inverted an intended condition, and amend a unit test to
check for this. This a11y event should target the focused node, but a
fallback for when the focus returns null was inverted.
https://github.com/flutter/flutter/issues/127789
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
---------
Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com >
2023-06-30 12:10:37 -04:00
Brandon DeRosier
cd52c0ce82
Revert "Reland "add non-rendering operation culling to DisplayListBuilder" ( #41463 )" ( flutter/engine#43358 )
...
Reverts flutter/engine#42584 . (Thanks to @jonahwilliams for bisecting)
With this change, layers are getting clipped incorrectly when rendering
platform views in Wondrous.
2023-06-30 04:22:21 -07:00
skia-flutter-autoroll
2112b6ae43
Roll Fuchsia Linux SDK from nboAFpQUzwtrESDVo... to iwgWLB4KaXslnaGwK... ( flutter/engine#43357 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jimgraham@google.com ,rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-30 06:44:17 +00:00
David Iglesias
f1b51a702c
[web] Add nonce configuration. ( flutter/engine#42829 )
...
This PR adds a `nonce` JS configuration attribute so users can pass a nonce value to their flutter engine initialization code.
This `nonce` is used to mark all scripts/styles needed by Flutter web that are considered `unsafe-inline` by CSP. In this change, there are only two tags that benefit from this:
* canvaskit.js
* inline styles for text editing
Before this change, the most strict CSP that allows a Flutter Web app to run would look like:
```
script-src 'self' 'nonce-flutter-init-scripts' 'wasm-unsafe-eval' https://www.gstatic.com/flutter-canvaskit/ ;
font-src https://fonts.gstatic.com ;
style-src 'unsafe-inline';
```
After this change, CSP could be tightened to:
```
script-src 'self' 'nonce-YOUR_NONCE_VALUE' 'wasm-unsafe-eval';
font-src https://fonts.gstatic.com ;
style-src 'nonce-YOUR_NONCE_VALUE';
```
By initializing the Flutter web app with something like this:
```html
<meta http-equiv="Content-Security-Policy" content="script-src 'self' 'nonce-YOUR_NONCE_VALUE' 'wasm-unsafe-eval'; font-src https://fonts.gstatic.com ; style-src 'nonce-YOUR_NONCE_VALUE';">
...
<script nonce="YOUR_NONCE_VALUE">
_flutter.loader.loadEntrypoint({
onEntrypointLoaded: async function(engineInitializer) {
let appRunner = await engineInitializer.initializeEngine({
nonce: 'YOUR_NONCE_VALUE',
});
appRunner.runApp();
}
});
</script>
```
## Issues
Fixes https://github.com/flutter/flutter/issues/126977 (does not address `flutter.js`, that's a [different story](https://github.com/flutter/flutter/issues/128061 ))
Helps with https://github.com/flutter/flutter/issues/80221
---
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-06-30 01:48:04 +00:00
Brandon DeRosier
46bf003f4a
[Impeller] Unwrap optional procs in EntityPass ( flutter/engine#43352 )
...
Whoopsies, I missed a spot... Fix a possible crash where an optional nullptr can be provided as the backdrop filter proc. Related: https://github.com/flutter/engine/pull/43345
2023-06-30 00:51:28 +00:00
Brandon DeRosier
9e12cf7aca
[Impeller] Assign missing user to TODO. ( flutter/engine#43351 )
...
The linter is failing on this in my unrelated PR for some reason: https://github.com/flutter/engine/pull/43348
```
â Failures for clang-tidy on /Volumes/Work/s/w/ir/cache/builder/src/flutter/impeller/renderer/backend/metal/vertex_descriptor_mtl.mm:
/Volumes/Work/s/w/ir/cache/builder/src/flutter/impeller/renderer/backend/metal/vertex_descriptor_mtl.mm:177:3: error: missing username/bug in TODO [google-readability-todo,-warnings-as-errors]
// TODO: its odd that we offset buffers from the max index on metal
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
// TODO(chrome-bot): its odd that we offset buffers from the max index on metal
Suppressed 1476 warnings (1475 in non-user code, 1 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
1 warning treated as error
```
2023-06-30 00:22:10 +00:00
skia-flutter-autoroll
f8ba5d6e6d
Roll Skia from a1ae27969207 to 2d05e3ec6b67 (1 revision) ( flutter/engine#43350 )
...
https://skia.googlesource.com/skia.git/+log/a1ae27969207..2d05e3ec6b67
2023-06-29 jvanverth@google.com [graphite] Add rescale support.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jimgraham@google.com ,nicolettep@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-29 23:12:52 +00:00
Jonah Williams
eee7308d1f
[Impeller] Check for lazy memory support. ( flutter/engine#43339 )
...
Some Android devices do not support the memory type eLazilyAllocated, which we use for MSAA and stencil textures. These textures were falling back to device local in dedicated allocations, which are expensive to both allocate and free. The dedicated allocation is implied by asking for eLazilyAllocated
Instead, perform a check for support for this memory type. Never request dedicated allocations (at least not until we have a compelling use case)
This should fix https://github.com/flutter/flutter/issues/129737
https://github.com/flutter/flutter/issues/129784
2023-06-29 22:16:57 +00:00
Brandon DeRosier
2523231c29
[Impeller] Remove all double empties ( flutter/engine#43345 )
...
Unwrap optionals that already have an empty state that must be checked, like `std::optional<std::shared_ptr<T>>` and `std::optional<std::function<T>>`.
2023-06-29 22:04:51 +00:00
skia-flutter-autoroll
d446d15416
Roll Skia from c83f8ba23a80 to a1ae27969207 (8 revisions) ( flutter/engine#43343 )
...
https://skia.googlesource.com/skia.git/+log/c83f8ba23a80..a1ae27969207
2023-06-29 johnstiles@google.com Revert "Move GPU specific ImageFilter context factories to src/gpu/"
2023-06-29 sallyqi@google.com Revert "Fix the way of Alpha8 gainmap support in Skia."
2023-06-29 lovisolo@google.com [bazel] Add android_gm_test macro.
2023-06-29 kjlubick@google.com Move GPU specific ImageFilter context factories to src/gpu/
2023-06-29 johnstiles@google.com Add MD5::Digest methods to create a hex string.
2023-06-29 johnstiles@google.com Fix SkRP implementation of step() intrinsic.
2023-06-29 kjlubick@google.com Remove #ifdefs from SkAndroidCodec.cpp
2023-06-29 robertphillips@google.com [graphite] Reenable tiled image cache size heuristic
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jimgraham@google.com ,nicolettep@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-29 21:50:07 +00:00
Tamir Duberstein
e4d08d4e8c
Remove unused constants ( flutter/engine#43344 )
2023-06-29 21:42:05 +00:00
skia-flutter-autoroll
5603c1beab
Roll Skia from a4d0373cd414 to c83f8ba23a80 (3 revisions) ( flutter/engine#43340 )
...
https://skia.googlesource.com/skia.git/+log/a4d0373cd414..c83f8ba23a80
2023-06-29 michaelludwig@google.com [skif] Update Compose to use FilterResult
2023-06-29 wcandillon@gmail.com Add FontMgr.matchFamilyStyle()
2023-06-29 johnstiles@google.com Disable perlinnoise_layered test on Iris Xe.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jimgraham@google.com ,nicolettep@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-29 20:32:05 +00:00
Mouad Debbar
647d4fca2b
[web] Move web-only initialization APIs to dart:ui_web ( flutter/engine#43111 )
...
| Old API in `dart:ui` | New API in `dart:ui_web` |
|-|-|
| ~`webOnlyInitializePlatform`~ | ~`ui_web.initializePlatform`~ |
| `webOnlyWarmupEngine` | `ui_web.bootstrapEngine` |
| `debugEmulateFlutterTesterEnvironment` | `ui_web.debugEmulateFlutterTesterEnvironment` |
| `webOnlySetPluginHandler` | `ui_web.setPluginHandler` |
Part of https://github.com/flutter/flutter/issues/126831
2023-06-29 19:52:48 +00:00
skia-flutter-autoroll
b2ace50e6e
Roll Skia from 8ada2c4b2947 to a4d0373cd414 (14 revisions) ( flutter/engine#43338 )
...
https://skia.googlesource.com/skia.git/+log/8ada2c4b2947..a4d0373cd414
2023-06-29 lovisolo@google.com [bazel] Rename skia_android_unit_test -> android_unit_test and reorganize code.
2023-06-29 michaelludwig@google.com Add SK_API to SkColorTable declaration
2023-06-29 bungeman@google.com Fix DirectWrite port COLRv1 clang warnings
2023-06-29 armansito@google.com Roll vello from 12e764d5 to 44353989
2023-06-29 jzern@google.com update libwebp to v1.3.1
2023-06-29 johnstiles@google.com Simplify appendInstruction.
2023-06-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from b5fa16ad27df to 7ded50742b4c (3 revisions)
2023-06-29 johnstiles@google.com Provide a semicolon when invoking the declareFunction callback.
2023-06-29 kjlubick@google.com Remove conditional compilation of SkJpegSourceMgr.cpp
2023-06-29 nicolettep@google.com [graphite] Populate most of Vulkan pipeline layout & creation structs.
2023-06-29 kjlubick@google.com Reland "Remove SkCanvas::flush() from Skia-proper and remove other gpu-specific code"
2023-06-29 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from 4765e38cdc27 to 49af09d96379 (32 revisions)
2023-06-29 johnstiles@google.com Rename Graphite's MtlTestContext.mm to fix libtool warning.
2023-06-29 bungeman@google.com Move SkPathEnums.h to src/core
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jimgraham@google.com ,nicolettep@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-29 19:19:07 +00:00
skia-flutter-autoroll
88997b281e
Roll Fuchsia Linux SDK from fxCNy4QivAngZXkvM... to nboAFpQUzwtrESDVo... ( flutter/engine#43334 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jimgraham@google.com ,rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-29 17:31:04 +00:00
Martin Kustermann
d6f96120e9
Prepare for utf8.encode() to return more precise Uint8List type ( flutter/engine#43335 )
...
To avoid analyzer warnings when utf8.encode() will return the more
precise Uint8List type, we use const Utf8Encoder().convert() which
already returns Uint8List
See https://github.com/dart-lang/sdk/issues/52801
2023-06-29 19:27:49 +02:00
Jason Simmons
0f55317632
[Impeller] Ensure that the auto-release pool is available when the GoldenPlaygroundTestImpl is destructed ( flutter/engine#43322 )
2023-06-29 09:33:26 -07:00
Emircan Uysaler
d69d614045
[fuchsia] Remove strict equality check for SkMatrix comparison for Fl… ( flutter/engine#43309 )
...
Flatland version of
010e710512
2023-06-29 12:01:12 -04:00
Jason Simmons
eb4725c362
[Impeller] Add an autorelease pool to the GoldenTests fixture ( flutter/engine#43323 )
2023-06-29 15:11:47 +00:00
skia-flutter-autoroll
4dfe901363
Roll Skia from 2b30565d0173 to 0c320b3d5b64 (2 revisions) ( flutter/engine#43331 )
...
https://skia.googlesource.com/skia.git/+log/2b30565d0173..0c320b3d5b64
2023-06-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 96ae8b91855e to 1761cfde4cbe
2023-06-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from ca7f5660896c to 96ae8b91855e (6 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jimgraham@google.com ,nicolettep@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-29 07:01:19 +00:00
skia-flutter-autoroll
8045b8824d
Roll Skia from 26fa4b343fd3 to 21feae4f3d8b (17 revisions) ( flutter/engine#43329 )
...
https://skia.googlesource.com/skia.git/+log/26fa4b343fd3..21feae4f3d8b
2023-06-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 5e35b0b24e12 to b5fa16ad27df (6 revisions)
2023-06-28 armansito@google.com Roll vello from ef2630ad to 12e764d5
2023-06-28 johnstiles@google.com Remove Win10 + ANGLE + IrisXe test and perf jobs.
2023-06-28 robertphillips@google.com Fail wrapping a protected AHardwareBuffer within an unprotected context
2023-06-28 michaelludwig@google.com Implement normalize as sqrt + divide instead of invsqrt + multiply
2023-06-28 kjlubick@google.com Mark some methods on Runtime Builders as const
2023-06-28 kjlubick@google.com Remove gSkBlobAsSlugTesting
2023-06-28 robertphillips@google.com [graphite] Enable manual image tiling GMs (take 2)
2023-06-28 johnstiles@google.com Add extra parentheses as required by WGSL spec.
2023-06-28 johnstiles@google.com Fix logical-xor operator in WGSL.
2023-06-28 jlavrova@google.com Improve justification algorithm
2023-06-28 johnstiles@google.com Add GM test slide to reproduce Perlin noise issue.
2023-06-28 johnstiles@google.com Add peephole optimization for merge_condition_mask.
2023-06-28 johnstiles@google.com Remove set_current_stack SkRP op.
2023-06-28 johnstiles@google.com Add SkRP builder methods for instruction handling.
2023-06-28 herb@google.com Add builtin_expect to SkASSERT_RELEASE
2023-06-28 nicolettep@google.com [graphite] Improve Vulkan descriptor set lifetime mgmnt.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jimgraham@google.com ,nicolettep@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-29 04:37:57 +00:00
Jason Simmons
a636ee22cf
[Impeller] Add a missing method to the Context mock ( flutter/engine#43326 )
2023-06-28 19:11:58 -07:00
gaaclarke
4f5dfc63c5
[Impeller] Collapse DrawRects into clear colors optimization ( flutter/engine#43168 )
...
design doc: https://docs.google.com/document/d/1Lqf1BRn4uCcUfv9dZlDyAgdSMeQ3FTnPgPjKF9yQ3MI/edit
fixes: https://github.com/flutter/flutter/issues/129292
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-06-29 00:37:02 +00:00
Chinmay Garde
0098a0b154
[Impeller] Add trace events to Vulkan texture and buffer lifecycle events. ( flutter/engine#43321 )
2023-06-29 00:32:05 +00:00
Brandon DeRosier
5533ea8e5c
[Impeller] Fix advanced CPU blend modes ( flutter/engine#43294 )
...
Resolves https://github.com/flutter/flutter/issues/128606 .
All CPU blends now match the behavior of Impeller's GPU blends, which (after https://github.com/flutter/engine/pull/43283 ) closely matches Skia's blends! Now we can finally use these.
https://github.com/flutter/engine/assets/919017/f9dc7323-fd14-4cdc-ba8b-930622be4206
2023-06-28 22:34:26 +00:00
skia-flutter-autoroll
2bab49e2f6
Roll Fuchsia Linux SDK from 10hNrVMjnCypybnz2... to fxCNy4QivAngZXkvM... ( flutter/engine#43314 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jimgraham@google.com ,rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-28 21:43:05 +00:00
skia-flutter-autoroll
7c7a9c5211
Roll Skia from 0b4f472a8c44 to 26fa4b343fd3 (2 revisions) ( flutter/engine#43306 )
...
https://skia.googlesource.com/skia.git/+log/0b4f472a8c44..26fa4b343fd3
2023-06-28 fmalita@chromium.org [skwindow] Relocate WindowContext out of sk_app
2023-06-28 drott@chromium.org [Fontations] Remove static initializer for typeface registration
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jimgraham@google.com ,nicolettep@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-28 21:39:20 +00:00
Jonah Williams
0d33dc9e2e
[Impeller] remove redundant highp modifiers in vertex shaders. ( flutter/engine#43305 )
...
Since we've let all vertex shaders opt into highp by default I believe these are redundant (though lets wait for malioc diff to confirm).
2023-06-28 17:10:55 +00:00
skia-flutter-autoroll
a2bd9b2c43
Roll Skia from 5209dc7702d0 to 0b4f472a8c44 (58 revisions) ( flutter/engine#43304 )
...
Roll Skia from 5209dc7702d0 to 0b4f472a8c44 (58 revisions)
https://skia.googlesource.com/skia.git/+log/5209dc7702d0..0b4f472a8c44
2023-06-28 jsimmons@google.com Remove unnecessary SkUnicodeHardCodedCharProperties destructor declaration
2023-06-28 jamesgk@google.com [graphite] Do partial dst copies
2023-06-28 robertphillips@google.com Remove SkCanvasPriv::DeviceClipBounds
2023-06-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from d5b636f780eb to 5e35b0b24e12 (2 revisions)
2023-06-28 robertphillips@google.com [graphite] Enable manual image tiling GMs
2023-06-28 robertphillips@google.com Clean up TiledTextureUtils
2023-06-28 michaelludwig@google.com Use a patterned source image in FilterResultTest
2023-06-28 armansito@google.com [graphite] AtlasShapeRenderStep support for inverse fills
2023-06-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 122b292d96c9 to ed391dae33e6 (7 revisions)
2023-06-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 9e529172240d to 44d18bcca074
2023-06-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from d5f800d73318 to ca7f5660896c (3 revisions)
2023-06-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from afd97bf1e914 to 47b5898a4fa7 (1 revision)
2023-06-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from ed70ac0399fc to 4765e38cdc27 (17 revisions)
2023-06-28 lehoangquyen@chromium.org graphite-dawn: use memoryless for MSAA & depth stencil textures.
2023-06-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 5897d0f765da to d5b636f780eb (4 revisions)
2023-06-28 jvanverth@google.com [graphite] Remove unused Device asyncRescaleAndRead methods.
2023-06-28 michaelludwig@google.com [skif] Take dst bounds into account for layer fills in FilterResult
2023-06-28 michaelludwig@google.com Add SkRectPriv::ClosestDisjointEdge utility function
2023-06-28 herb@google.com Add skia_use_safe_libcxx
2023-06-27 brianosman@google.com Revert "Fix link errors when XML (expat) is not included"
2023-06-27 armansito@google.com [graphite] Support atlas draws
2023-06-27 brianosman@google.com Fix link errors when XML (expat) is not included
2023-06-27 jmbetancourt@google.com [skottie] implement text slot tracking for SlotManager
2023-06-27 jvanverth@google.com [graphite] One more revision of the asyncReadPixelsYUV420 API.
2023-06-27 sunnyps@chromium.org graphite: Reset UniformDataCache on recording snap
2023-06-27 michaelludwig@google.com Add SkTileMode support to FilterResultTest harness
2023-06-27 michaelludwig@google.com Reorganize crop_imagefilter GM to be easier to interpret
2023-06-27 lovisolo@google.com [bazel] Add BazelGMRunner.cpp.
2023-06-27 jvanverth@google.com [graphite] Add more Recorder support to async yuv GMs.
2023-06-27 armansito@google.com [graphite] Rename text/AtlasManager to text/TextAtlasManager
2023-06-27 johnstiles@google.com Remove DUMP_SRC_IR macro from WGSL code generator.
2023-06-27 jlavrova@google.com Fixing CanvasKit build
2023-06-27 kjlubick@google.com Add CanvasKit Bazel Build job to the CQ
2023-06-27 kjlubick@google.com Remove SkEncodedImageFormat::kUnknown
2023-06-27 kjlubick@google.com Reland "Remove SkRuntimeEffect::makeImage"
2023-06-27 robertphillips@google.com [graphite] Implement new tiled API for Graphite
2023-06-27 michaelludwig@google.com Reland "[skif] Remove dedicated SkDropShadowImageFilter implementation"
2023-06-27 jvanverth@google.com [graphite] Get asyncReadPixelsYUV420 working.
2023-06-27 herb@google.com Remove unused private variables from DashOp
2023-06-27 jlavrova@google.com Extending SkUnicode API to avoid code duplication
2023-06-27 johnstiles@google.com Enable all shared tests in WGSL.
2023-06-27 johnstiles@google.com Implement array-cast constructors in WGSL.
2023-06-27 kjlubick@google.com Make context methods on SkCanvas const
2023-06-27 johnstiles@google.com Add WGSL support for ES2 geometric intrinsics.
2023-06-27 michaelludwig@google.com [skif] Remove legacy Lighting filter implementations
2023-06-27 kjlubick@google.com Remove slug-related #ifdefs from src/core
...
2023-06-28 16:07:54 +00:00
skia-flutter-autoroll
3b8e71d838
Roll Fuchsia Linux SDK from Bvv7TyHm_VHUkndFx... to 10hNrVMjnCypybnz2... ( flutter/engine#43297 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jimgraham@google.com ,rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-28 07:33:28 +00:00
Jason Simmons
ff3ce46a4d
Include the SkRTreeFactory headers in the skwasm picture recorder ( flutter/engine#43292 )
2023-06-28 00:45:38 +00:00
Brandon DeRosier
09246795b0
[Impeller] Correct advanced blending behavior. ( flutter/engine#43283 )
...
Investigated as part of
https://github.com/flutter/flutter/issues/127232 .
This took some time to work out, but:
* The amount of blending applied to the source color needs to be
weighted by the destination alpha, which is pretty sensible behavior.
This is in addition to applying source-over behavior with the resulting
blended color.
* All of the blend functions assume that the color is already
premultiplied, so remove the unpremultiply/premultiply surrounding the
blend call.
All of the blend modes now visually match up with the [Flutter
docs](https://api.flutter.dev/flutter/dart-ui/BlendMode.html ), except
for ColorBurn and Saturation, which appear to have a slight
miscalculation going on with the red channel.
2023-06-27 16:04:41 -07:00
Srujan Gaddam
fe300ba3c6
Revert "Refactor JSNumber.toDart and Object.toJS" ( flutter/engine#43286 )
...
Reverts flutter/engine#43149
Reason for reverting: Broke the roll into the framework.
2023-06-27 22:31:17 +00:00
Jim Graham
7d44b42d7a
Update skia includes to be more specific ( flutter/engine#43284 )
...
Update flutter engine includes to be more specific about use of Skia includes.
These changes are required to unblock the Skia roller that has new streamlined include files.
2023-06-27 21:33:59 +00:00
Yegor
007bc8126e
[web:a11y] introduce primary role responsible for ARIA roles ( flutter/engine#43159 )
...
This PR fixes https://github.com/flutter/flutter/issues/128468 by changing the relationship between semantics nodes and their roles from this:
```
SemanticsNode one-to-many RoleManager
```
To this:
```
SemanticsNode one-to-one PrimaryRoleManager one-to-many RoleManager
```
Previously a node would simply have multiple role managers, some of which would be responsible for setting the `role` attribute. It wasn't clear which role manager should be doing this. It also wasn't clear which role managers were safe to reuse across multiple types of nodes. This led to the unfortunate situation in https://github.com/flutter/flutter/issues/128468 where `LabelAndValue` ended up overriding the role assigned by `Checkable`.
With this PR, a `SemanticsNode` has exactly one `PrimaryRoleManager`. A primary role manager is responsible for setting the `role` attribute, and importantly, it's the _only_ thing responsible for it. It's _not safe_ to share primary role managers across different kinds of nodes. They are meant to provide very specific functionality for the widget's main role. OTOH, a non-primary `RoleManager` provides a piece of functionality that's safe to share.
A `Checkable` is a `PrimaryRoleManager` and is the only thing that decides on the `role` attribute. `LabelAndValue` is now a `RoleManager` that's not responsible for setting the role. It's only responsible for `aria-label`. No more confusion.
This also drastically simplifies the logic for role assignment. There's no more [logical soup](d4889c682d/lib/web_ui/lib/src/engine/semantics/semantics.dart (L1340)93df91df95/lib/web_ui/lib/src/engine/semantics/semantics.dart (L1477)93df91df95/lib/web_ui/lib/src/engine/semantics/semantics.dart (L1498)93df91df95/lib/web_ui/lib/src/engine/semantics/image.dart (L16)
2023-06-27 20:49:03 +00:00
skia-flutter-autoroll
8eeb3843c0
Roll ANGLE from 9faf7059f9ef to 113f847be69f (2 revisions) ( flutter/engine#43278 )
...
9faf7059f9..113f847be6steven@uplinklabs.net centralize basic OS/platform detection functions
2023-06-27 abdolrashidi@google.com Vulkan: Move device OOM tests to new test suite
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC flutter-engine@google.com ,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-27 20:23:30 +00:00
Jackson Gardner
3a44bbda74
Initialize skwasm codecs before handing them back to the user. ( flutter/engine#43274 )
...
Benchmarks were failing because the code was reading the `frameCount` and `repetitionCount` before reading any frames out of the codec. The codec gets implicitly initialized when you read a frame, but we should return it to the user initialized so that `frameCount` and `repetitionCount` work even if you haven't read a frame yet. This is consistent with how CanvasKit's codec works.
Also, modified our unit tests so that they exercise the codecs in this way.
2023-06-27 20:17:30 +00:00
Victoria Ashworth
06457c8cae
Update Xcode to 14.3.1 ( flutter/engine#42930 )
...
Engine part of https://github.com/flutter/flutter/issues/129019 .
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-06-27 18:21:30 +00:00
Jonah Williams
7a937cfb61
[Impeller] Add Vulkan allocator traces. ( flutter/engine#43215 )
...
I suspect this is where we're blocking on the texture uploads right now.
2023-06-27 18:18:06 +00:00
