Commit Graph

29821 Commits

Author SHA1 Message Date
skia-flutter-autoroll
a961f419fc Roll Skia from d58324bf653d to 23052eb28808 (3 revisions) (flutter/engine#43418)
https://skia.googlesource.com/skia.git/+log/d58324bf653d..23052eb28808

2023-07-05 sunnyps@chromium.org graphite: Implement asyncRescaleAndReadPixels for RGBA
2023-07-05 nicolettep@google.com [graphite] Create VkGraphicsPipeline, implement Vulkan pipeline key creation
2023-07-05 johnstiles@google.com Avoid crash in Viewer when viewing shaders in Graphite.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,jamesgk@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-05 15:46:18 +00:00
Zachary Anderson
c7ea4c3630 Reverts Dart SDK to version 3.1.0-262.0.dev (flutter/engine#43417)
To unblock rolls for https://github.com/flutter/flutter/issues/130009
2023-07-05 08:38:15 -07:00
skia-flutter-autoroll
66bde928a9 Roll Fuchsia Mac SDK from 8YulTHvG-Jg3Sof-S... to C3Q7MJBYkiin8zw-f... (flutter/engine#43415)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-05 11:43:23 +00:00
skia-flutter-autoroll
a8ddb5e089 Roll Dart SDK from f7c242ded366 to e193587883d6 (1 revision) (flutter/engine#43414)
https://dart.googlesource.com/sdk.git/+log/f7c242ded366..e193587883d6

2023-07-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-276.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-05 10:17:34 +00:00
skia-flutter-autoroll
47dfd0d57d Roll Skia from a453fed07c91 to d58324bf653d (1 revision) (flutter/engine#43413)
https://skia.googlesource.com/skia.git/+log/a453fed07c91..d58324bf653d

2023-07-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from db3537aa004e to b41c42f44e82 (7 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,jamesgk@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-05 08:05:24 +00:00
skia-flutter-autoroll
24c1b51da9 Roll Skia from faf906db84ab to a453fed07c91 (4 revisions) (flutter/engine#43412)
https://skia.googlesource.com/skia.git/+log/faf906db84ab..a453fed07c91

2023-07-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 095b710a2ea5 to 9bf70d50d3ad
2023-07-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 347306080b87 to df22aa218f6a (1 revision)
2023-07-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 222e07b368b1 to 3e73cce1c470 (1 revision)
2023-07-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 73aa9bd33f2c to 095b710a2ea5 (2 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,jamesgk@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-05 06:59:19 +00:00
skia-flutter-autoroll
35240ce2fe Roll Dart SDK from c89f5ac4fd46 to f7c242ded366 (1 revision) (flutter/engine#43410)
https://dart.googlesource.com/sdk.git/+log/c89f5ac4fd46..f7c242ded366

2023-07-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-275.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-05 02:17:08 +00:00
skia-flutter-autoroll
c07d4f1517 Roll Fuchsia Mac SDK from 8-taK-r4HkgVAIGtU... to 8YulTHvG-Jg3Sof-S... (flutter/engine#43409)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-04 22:36:23 +00:00
skia-flutter-autoroll
afa2b5b3cc Roll Dart SDK from 7cd6ed860b63 to c89f5ac4fd46 (1 revision) (flutter/engine#43408)
https://dart.googlesource.com/sdk.git/+log/7cd6ed860b63..c89f5ac4fd46

2023-07-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-274.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-04 22:00:32 +00:00
skia-flutter-autoroll
e6c072593f Roll Dart SDK from d128bd4977a7 to 7cd6ed860b63 (1 revision) (flutter/engine#43406)
https://dart.googlesource.com/sdk.git/+log/d128bd4977a7..7cd6ed860b63

2023-07-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-273.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-04 17:44:23 +00:00
skia-flutter-autoroll
412c1ef6d3 Roll Skia from eaca275ef1c0 to faf906db84ab (1 revision) (flutter/engine#43405)
https://skia.googlesource.com/skia.git/+log/eaca275ef1c0..faf906db84ab

2023-07-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from bfb786a7daec to 347306080b87 (2 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,jamesgk@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-04 17:38:34 +00:00
skia-flutter-autoroll
ac21b289ed Roll Dart SDK from e58e3bd3b507 to d128bd4977a7 (1 revision) (flutter/engine#43403)
https://dart.googlesource.com/sdk.git/+log/e58e3bd3b507..d128bd4977a7

2023-07-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-272.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-04 10:43:22 +00:00
skia-flutter-autoroll
5246e68cf0 Roll Fuchsia Mac SDK from GNWxBcnfjZlyaOw34... to 8-taK-r4HkgVAIGtU... (flutter/engine#43402)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-04 08:02:26 +00:00
skia-flutter-autoroll
c63803e398 Roll Skia from bb18c9b1f730 to eaca275ef1c0 (1 revision) (flutter/engine#43401)
https://skia.googlesource.com/skia.git/+log/bb18c9b1f730..eaca275ef1c0

2023-07-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 25ce3dfec69b to db3537aa004e (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jamesgk@google.com,jimgraham@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-04 07:38:23 +00:00
skia-flutter-autoroll
2c2401cc83 Roll Dart SDK from 604ccea2f5b9 to e58e3bd3b507 (1 revision) (flutter/engine#43400)
https://dart.googlesource.com/sdk.git/+log/604ccea2f5b9..e58e3bd3b507

2023-07-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-271.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-04 06:42:21 +00:00
skia-flutter-autoroll
35d39a3429 Roll Skia from 85a3fda32850 to bb18c9b1f730 (3 revisions) (flutter/engine#43399)
https://skia.googlesource.com/skia.git/+log/85a3fda32850..bb18c9b1f730

2023-07-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 73aa9bd33f2c to 9f7b74110b61
2023-07-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 414f9688245c to 73aa9bd33f2c (1 revision)
2023-07-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 9c78ac0f4327 to c5c482733140 (7 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jamesgk@google.com,jimgraham@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-04 06:30:04 +00:00
dependabot[bot]
5082d28b1e Bump actions/labeler from 4.1.0 to 4.2.0 (flutter/engine#43398)
Bumps [actions/labeler](https://github.com/actions/labeler) from 4.1.0 to 4.2.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/labeler/releases">actions/labeler's releases</a>.</em></p>
<blockquote>
<h2>v4.2.0</h2>
<h2>What's Changed</h2>
<p>In the scope of this release, the following outputs were added by <a href="https://github.com/danielsht86"><code>@​danielsht86</code></a> in <a href="https://redirect.github.com/actions/labeler/issues/60">#60</a>:</p>
<ul>
<li><code>new-labels</code> - a comma-separated string that contains all newly added labels.</li>
<li><code>all-labels</code> - a comma-separated string that contains all labels currently assigned to the PR.</li>
</ul>
<p>For detailed information, please refer to our <a href="0967ca812e (outputs)">updated documentation</a>.</p>
<p>The issue of encountering an <code>HttpError: Server Error</code> when adding more than 50 labels has been successfully resolved by <a href="https://github.com/markmssd"><code>@​markmssd</code></a> in <a href="https://redirect.github.com/actions/labeler/issues/497">#497</a>. However, it's important to note that the GitHub API imposes a limit of 100 labels. To ensure smooth operation, a warning message that will alert you if the number of labels exceeds this limit was implemented. From this point forward, if more than 100 labels are specified, only the first 100 will be assigned.</p>
<p>The error handling for the <code>Resource not accessible by integration</code> error was added by <a href="https://github.com/jsoref"><code>@​jsoref</code></a> in <a href="https://redirect.github.com/actions/labeler/issues/405">#405</a>. Now, if the workflow is misconfigured, the labeler provides a clear warning and guidance for correction.</p>
<p>This release also includes the following changes:</p>
<ul>
<li>Warn about the limitations of GitHub tokens by <a href="https://github.com/dfandrich"><code>@​dfandrich</code></a> in <a href="https://redirect.github.com/actions/labeler/pull/491">actions/labeler#491</a></li>
<li>Improve readme by <a href="https://github.com/jsoref"><code>@​jsoref</code></a> in <a href="https://redirect.github.com/actions/labeler/pull/589">actions/labeler#589</a></li>
<li>Bump eslint-plugin-jest from 27.2.1 to 27.2.2 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/actions/labeler/pull/591">actions/labeler#591</a></li>
<li>Bump eslint from 8.42.0 to 8.43.0 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/actions/labeler/pull/592">actions/labeler#592</a></li>
<li>Bump <code>@​typescript-eslint/eslint-plugin</code> from 5.60.0 to 5.60.1 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/actions/labeler/pull/598">actions/labeler#598</a></li>
<li>Bump <code>@​typescript-eslint/parser</code> from 5.60.0 to 5.60.1 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/actions/labeler/pull/597">actions/labeler#597</a></li>
<li>Bump <code>@​octokit/plugin-retry</code> from 5.0.2 to 5.0.4 by <a href="https://github.com/MaksimZhukov"><code>@​MaksimZhukov</code></a> in <a href="https://redirect.github.com/actions/labeler/pull/599">actions/labeler#599</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/dfandrich"><code>@​dfandrich</code></a> made their first contribution in <a href="https://redirect.github.com/actions/labeler/pull/491">actions/labeler#491</a></li>
<li><a href="https://github.com/markmssd"><code>@​markmssd</code></a> made their first contribution in <a href="https://redirect.github.com/actions/labeler/pull/497">actions/labeler#497</a></li>
<li><a href="https://github.com/danielsht86"><code>@​danielsht86</code></a> made their first contribution in <a href="https://redirect.github.com/actions/labeler/pull/60">actions/labeler#60</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/labeler/compare/v4...v4.2.0">https://github.com/actions/labeler/compare/v4...v4.2.0</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="0967ca812e"><code>0967ca8</code></a> Added output (<a href="https://redirect.github.com/actions/labeler/issues/60">#60</a>)</li>
<li><a href="375538a703"><code>375538a</code></a> Bump <code>@​octokit/plugin-retry</code> from 5.0.2 to 5.0.4 (<a href="https://redirect.github.com/actions/labeler/issues/599">#599</a>)</li>
<li><a href="8d17e8ac4c"><code>8d17e8a</code></a> Bump <code>@​typescript-eslint/parser</code> from 5.60.0 to 5.60.1 (<a href="https://redirect.github.com/actions/labeler/issues/597">#597</a>)</li>
<li><a href="9d45a7438f"><code>9d45a74</code></a> Bump <code>@​typescript-eslint/eslint-plugin</code> from 5.60.0 to 5.60.1 (<a href="https://redirect.github.com/actions/labeler/issues/598">#598</a>)</li>
<li><a href="130636aba5"><code>130636a</code></a> Bump eslint from 8.42.0 to 8.43.0 (<a href="https://redirect.github.com/actions/labeler/issues/592">#592</a>)</li>
<li><a href="54aeabf7b5"><code>54aeabf</code></a> Bump <code>@​typescript-eslint/parser</code> from 5.59.11 to 5.60.0 (<a href="https://redirect.github.com/actions/labeler/issues/593">#593</a>)</li>
<li><a href="899595ff01"><code>899595f</code></a> Bump eslint-plugin-jest from 27.2.1 to 27.2.2 (<a href="https://redirect.github.com/actions/labeler/issues/591">#591</a>)</li>
<li><a href="8056174ee0"><code>8056174</code></a> Bump <code>@​typescript-eslint/eslint-plugin</code> from 5.59.11 to 5.60.0 (<a href="https://redirect.github.com/actions/labeler/issues/594">#594</a>)</li>
<li><a href="7a202e6428"><code>7a202e6</code></a> fix: Limit number of labels added to 100 (<a href="https://redirect.github.com/actions/labeler/issues/497">#497</a>)</li>
<li><a href="b5ff161cf0"><code>b5ff161</code></a> Explain misconfigured workflow (<a href="https://redirect.github.com/actions/labeler/issues/405">#405</a>)</li>
<li>Additional commits viewable in <a href="9fcb2c2f55...0967ca812e">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/labeler&package-manager=github_actions&previous-version=4.1.0&new-version=4.2.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>
2023-07-04 06:12:39 +00:00
skia-flutter-autoroll
d7142dbbb2 Roll Skia from 4abc43e2ffcc to 85a3fda32850 (1 revision) (flutter/engine#43393)
https://skia.googlesource.com/skia.git/+log/4abc43e2ffcc..85a3fda32850

2023-07-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from e21365bc9170 to bfb786a7daec (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jamesgk@google.com,jimgraham@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-04 04:38:36 +00:00
Chinmay Garde
e7964a816f [Impeller] Document impeller::Context. (flutter/engine#43389) 2023-07-04 00:30:23 +00:00
skia-flutter-autoroll
02453b5a59 Roll Dart SDK from a4c5ed075a2b to 604ccea2f5b9 (1 revision) (flutter/engine#43390)
https://dart.googlesource.com/sdk.git/+log/a4c5ed075a2b..604ccea2f5b9

2023-07-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-270.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-03 23:50:21 +00:00
skia-flutter-autoroll
75718cf3e2 Roll Dart SDK from c092e09b7e64 to a4c5ed075a2b (1 revision) (flutter/engine#43387)
https://dart.googlesource.com/sdk.git/+log/c092e09b7e64..a4c5ed075a2b

2023-07-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-269.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-03 19:30:11 +00:00
skia-flutter-autoroll
2f6643c20c Roll Skia from 6a5ea15c942b to 4abc43e2ffcc (1 revision) (flutter/engine#43386)
https://skia.googlesource.com/skia.git/+log/6a5ea15c942b..4abc43e2ffcc

2023-07-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 8eda3fc5098a to e21365bc9170 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jamesgk@google.com,jimgraham@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-03 15:51:21 +00:00
skia-flutter-autoroll
8d67e79b2f Roll Fuchsia Mac SDK from cytps4RRhs8-wbcVJ... to GNWxBcnfjZlyaOw34... (flutter/engine#43373)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-03 15:20:02 +00:00
skia-flutter-autoroll
b3bc31735e Roll Dart SDK from dedff8f0ebd2 to c092e09b7e64 (1 revision) (flutter/engine#43374)
https://dart.googlesource.com/sdk.git/+log/dedff8f0ebd2..c092e09b7e64

2023-07-01 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-268.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-03 15:18:02 +00:00
skia-flutter-autoroll
7bb164b6e1 Roll Skia from 94ad507b8959 to 6a5ea15c942b (1 revision) (flutter/engine#43385)
https://skia.googlesource.com/skia.git/+log/94ad507b8959..6a5ea15c942b

2023-07-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 20cc4a9bc250 to 25ce3dfec69b (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jamesgk@google.com,jimgraham@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-03 11:01:05 +00:00
skia-flutter-autoroll
285d749ac5 Roll Skia from e16d5b988a36 to 94ad507b8959 (2 revisions) (flutter/engine#43383)
https://skia.googlesource.com/skia.git/+log/e16d5b988a36..94ad507b8959

2023-07-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 414f9688245c to 73aa9bd33f2c
2023-07-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 4ea8b01e8983 to 414f9688245c (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jamesgk@google.com,jimgraham@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-03 06:57:23 +00:00
skia-flutter-autoroll
4f3f2de929 Roll Skia from 384b84445a9f to e16d5b988a36 (1 revision) (flutter/engine#43382)
https://skia.googlesource.com/skia.git/+log/384b84445a9f..e16d5b988a36

2023-07-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 15d2e87074d6 to 9c78ac0f4327 (37 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jamesgk@google.com,jimgraham@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-03 05:45:13 +00:00
skia-flutter-autoroll
a42e60e7ce Roll Skia from dbf0829114ee to 384b84445a9f (2 revisions) (flutter/engine#43381)
https://skia.googlesource.com/skia.git/+log/dbf0829114ee..384b84445a9f

2023-07-02 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version
2023-07-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from d2fc29b352fe to 8eda3fc5098a (3 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jamesgk@google.com,jimgraham@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-02 14:19:29 +00:00
Brandon DeRosier
a3745e962c [Impeller] Remove blend mode restrictions on clear color optimization (flutter/engine#43348)
Now that all of the CPU blend modes work, we can allow back-to-back
fullscreen solid color draws to get blended together regardless of their
blend mode/color opacity.
2023-06-30 21:48:45 -07:00
skia-flutter-autoroll
a0dc7abbe9 Roll Dart SDK from f00f7363f4bf to dedff8f0ebd2 (4 revisions) (flutter/engine#43371)
https://dart.googlesource.com/sdk.git/+log/f00f7363f4bf..dedff8f0ebd2

2023-06-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-267.0.dev
2023-06-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-266.0.dev
2023-06-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-265.0.dev
2023-06-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-264.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-01 01:59:23 +00:00
skia-flutter-autoroll
8803d0b50d Roll Skia from ceaeef84b8a3 to dbf0829114ee (15 revisions) (flutter/engine#43370)
https://skia.googlesource.com/skia.git/+log/ceaeef84b8a3..dbf0829114ee

2023-06-30 bungeman@google.com Allow use of DWriteCore
2023-06-30 kjlubick@google.com Reland "Move GPU specific ImageFilter context factories to src/gpu/"
2023-06-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 18e68e17ca5c to d2fc29b352fe (8 revisions)
2023-06-30 armansito@google.com [graphite][vello] Better quality hairline strokes
2023-06-30 johnstiles@google.com Remove shared compiler from ResourceProvider.
2023-06-30 jlavrova@google.com Updating SkParagraph test to newer font version
2023-06-30 bungeman@google.com Fix DirectWrite port COLRv1 palette overrides
2023-06-30 robertphillips@google.com Add a tiled-image cache test
2023-06-30 kjlubick@google.com Run buildifier on tools/window/BUILD.bazel
2023-06-30 nicolettep@google.com Revert "[graphite] Reenable tiled image cache size heuristic"
2023-06-30 het@google.com [canvaskit] Add `Picture.cullRect` and `Picture.approximateBytesUsed`.
2023-06-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 77c4b6779152 to 20cc4a9bc250 (6 revisions)
2023-06-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 4ea8b01e8983 to c97b5b1d4d66
2023-06-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 96ae8b91855e to 4ea8b01e8983 (3 revisions)
2023-06-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 49af09d96379 to 15d2e87074d6 (18 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-01 01:49:05 +00:00
Brandon DeRosier
c90389c9cd [Impeller] Add explicit color filter types to Aiks. (flutter/engine#43342)
Part of https://github.com/flutter/flutter/issues/127232.

Adds an explicit ColorFilter concept to Aiks which wraps the GPU and CPU
implementations. We're not using the CPU implementations yet, but I'll
be getting it wired up in a follow-up patch.
2023-06-30 18:42:21 -07:00
skia-flutter-autoroll
847fcdd753 Roll Dart SDK from 2d98d9e27dae to f00f7363f4bf (1 revision) (flutter/engine#43354)
https://dart.googlesource.com/sdk.git/+log/2d98d9e27dae..f00f7363f4bf

2023-06-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-263.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-01 00:42:02 +00:00
skia-flutter-autoroll
89694d62dd Roll Skia from 2d05e3ec6b67 to ceaeef84b8a3 (1 revision) (flutter/engine#43355)
https://skia.googlesource.com/skia.git/+log/2d05e3ec6b67..ceaeef84b8a3

2023-06-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 7ded50742b4c to 18e68e17ca5c (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-01 00:40:14 +00:00
Jonah Williams
cb7fd03312 [Impeller] cache MSAA texture in swapchain for devices that do not support memoryless. (flutter/engine#43349)
For devices that don't support memoryless textures, the fullscreen MSAA texture adds a substantial amount of memory thrashing when it is allocated and deallocated. For these devices, lets cache the MSAA texture in the swapchain image.

https://github.com/flutter/flutter/issues/129737
2023-06-30 18:34:29 +00:00
Jonah Williams
70cb44975f [Impeller] Fix validation error in position color shader. (flutter/engine#43356)
The input was a float16 vec4, so the corresponding output must match or else we get a validation error. Not related to platform view issue.
2023-06-30 18:34:27 +00:00
yaakovschectman
570578974c Fix inverted boolean in Windows document selection changed a11y event (flutter/engine#43281)
Fix a typo that inverted an intended condition, and amend a unit test to
check for this. This a11y event should target the focused node, but a
fallback for when the focus returns null was inverted.

https://github.com/flutter/flutter/issues/127789

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

---------

Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>
2023-06-30 12:10:37 -04:00
Brandon DeRosier
cd52c0ce82 Revert "Reland "add non-rendering operation culling to DisplayListBuilder" (#41463)" (flutter/engine#43358)
Reverts flutter/engine#42584. (Thanks to @jonahwilliams for bisecting)

With this change, layers are getting clipped incorrectly when rendering
platform views in Wondrous.
2023-06-30 04:22:21 -07:00
skia-flutter-autoroll
2112b6ae43 Roll Fuchsia Linux SDK from nboAFpQUzwtrESDVo... to iwgWLB4KaXslnaGwK... (flutter/engine#43357)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-30 06:44:17 +00:00
David Iglesias
f1b51a702c [web] Add nonce configuration. (flutter/engine#42829)
This PR adds a `nonce` JS configuration attribute so users can pass a nonce value to their flutter engine initialization code.

This `nonce` is used to mark all scripts/styles needed by Flutter web that are considered `unsafe-inline` by CSP. In this change, there are only two tags that benefit from this:

* canvaskit.js
* inline styles for text editing

Before this change, the most strict CSP that allows a Flutter Web app to run would look like:

```
script-src 'self' 'nonce-flutter-init-scripts' 'wasm-unsafe-eval' https://www.gstatic.com/flutter-canvaskit/;
font-src https://fonts.gstatic.com;
style-src 'unsafe-inline';
```

After this change, CSP could be tightened to:

```
script-src 'self' 'nonce-YOUR_NONCE_VALUE' 'wasm-unsafe-eval';
font-src https://fonts.gstatic.com;
style-src 'nonce-YOUR_NONCE_VALUE';
```

By initializing the Flutter web app with something like this:

```html
<meta http-equiv="Content-Security-Policy" content="script-src 'self' 'nonce-YOUR_NONCE_VALUE' 'wasm-unsafe-eval'; font-src https://fonts.gstatic.com; style-src 'nonce-YOUR_NONCE_VALUE';">

...

<script nonce="YOUR_NONCE_VALUE">
  _flutter.loader.loadEntrypoint({
    onEntrypointLoaded: async function(engineInitializer) {
      let appRunner = await engineInitializer.initializeEngine({
        nonce: 'YOUR_NONCE_VALUE',
      });
      appRunner.runApp();
    }
  });
</script>
```

## Issues

Fixes https://github.com/flutter/flutter/issues/126977 (does not address `flutter.js`, that's a [different story](https://github.com/flutter/flutter/issues/128061))
Helps with https://github.com/flutter/flutter/issues/80221

---

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-06-30 01:48:04 +00:00
Brandon DeRosier
46bf003f4a [Impeller] Unwrap optional procs in EntityPass (flutter/engine#43352)
Whoopsies, I missed a spot... Fix a possible crash where an optional nullptr can be provided as the backdrop filter proc. Related: https://github.com/flutter/engine/pull/43345
2023-06-30 00:51:28 +00:00
Brandon DeRosier
9e12cf7aca [Impeller] Assign missing user to TODO. (flutter/engine#43351)
The linter is failing on this in my unrelated PR for some reason: https://github.com/flutter/engine/pull/43348

```
❌ Failures for clang-tidy on /Volumes/Work/s/w/ir/cache/builder/src/flutter/impeller/renderer/backend/metal/vertex_descriptor_mtl.mm:
/Volumes/Work/s/w/ir/cache/builder/src/flutter/impeller/renderer/backend/metal/vertex_descriptor_mtl.mm:177:3: error: missing username/bug in TODO [google-readability-todo,-warnings-as-errors]
  // TODO: its odd that we offset buffers from the max index on metal
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  // TODO(chrome-bot): its odd that we offset buffers from the max index on metal
Suppressed 1476 warnings (1475 in non-user code, 1 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
1 warning treated as error
```
2023-06-30 00:22:10 +00:00
skia-flutter-autoroll
f8ba5d6e6d Roll Skia from a1ae27969207 to 2d05e3ec6b67 (1 revision) (flutter/engine#43350)
https://skia.googlesource.com/skia.git/+log/a1ae27969207..2d05e3ec6b67

2023-06-29 jvanverth@google.com [graphite] Add rescale support.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-29 23:12:52 +00:00
skia-flutter-autoroll
6f7042adc8 Roll Dart SDK from ecc2440be198 to 2d98d9e27dae (1 revision) (flutter/engine#43347)
https://dart.googlesource.com/sdk.git/+log/ecc2440be198..2d98d9e27dae

2023-06-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-262.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-29 22:28:19 +00:00
Jonah Williams
eee7308d1f [Impeller] Check for lazy memory support. (flutter/engine#43339)
Some Android devices do not support the memory type eLazilyAllocated, which we use for MSAA and stencil textures. These textures were falling back to device local in dedicated allocations, which are expensive to both allocate and free. The dedicated allocation is implied by asking for eLazilyAllocated

Instead, perform a check for support for this memory type. Never request dedicated allocations (at least not until we have a compelling use case)

This should fix https://github.com/flutter/flutter/issues/129737

https://github.com/flutter/flutter/issues/129784
2023-06-29 22:16:57 +00:00
Brandon DeRosier
2523231c29 [Impeller] Remove all double empties (flutter/engine#43345)
Unwrap optionals that already have an empty state that must be checked, like `std::optional<std::shared_ptr<T>>` and `std::optional<std::function<T>>`.
2023-06-29 22:04:51 +00:00
skia-flutter-autoroll
d446d15416 Roll Skia from c83f8ba23a80 to a1ae27969207 (8 revisions) (flutter/engine#43343)
https://skia.googlesource.com/skia.git/+log/c83f8ba23a80..a1ae27969207

2023-06-29 johnstiles@google.com Revert "Move GPU specific ImageFilter context factories to src/gpu/"
2023-06-29 sallyqi@google.com Revert "Fix the way of Alpha8 gainmap support in Skia."
2023-06-29 lovisolo@google.com [bazel] Add android_gm_test macro.
2023-06-29 kjlubick@google.com Move GPU specific ImageFilter context factories to src/gpu/
2023-06-29 johnstiles@google.com Add MD5::Digest methods to create a hex string.
2023-06-29 johnstiles@google.com Fix SkRP implementation of step() intrinsic.
2023-06-29 kjlubick@google.com Remove #ifdefs from SkAndroidCodec.cpp
2023-06-29 robertphillips@google.com [graphite] Reenable tiled image cache size heuristic

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-29 21:50:07 +00:00
Tamir Duberstein
e4d08d4e8c Remove unused constants (flutter/engine#43344) 2023-06-29 21:42:05 +00:00
skia-flutter-autoroll
5603c1beab Roll Skia from a4d0373cd414 to c83f8ba23a80 (3 revisions) (flutter/engine#43340)
https://skia.googlesource.com/skia.git/+log/a4d0373cd414..c83f8ba23a80

2023-06-29 michaelludwig@google.com [skif] Update Compose to use FilterResult
2023-06-29 wcandillon@gmail.com Add FontMgr.matchFamilyStyle()
2023-06-29 johnstiles@google.com Disable perlinnoise_layered test on Iris Xe.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-29 20:32:05 +00:00
Mouad Debbar
647d4fca2b [web] Move web-only initialization APIs to dart:ui_web (flutter/engine#43111)
| Old API in `dart:ui` | New API in `dart:ui_web` |
|-|-|
| ~`webOnlyInitializePlatform`~ | ~`ui_web.initializePlatform`~ |
| `webOnlyWarmupEngine` | `ui_web.bootstrapEngine` |
| `debugEmulateFlutterTesterEnvironment` | `ui_web.debugEmulateFlutterTesterEnvironment` |
| `webOnlySetPluginHandler` | `ui_web.setPluginHandler` |

Part of https://github.com/flutter/flutter/issues/126831
2023-06-29 19:52:48 +00:00