RenderTable._computeColumnWidths() had a logic error that caused flex columns to be collapsed to their minimum widths in certain situations dependent on the layout width constraint and the number of flex columns.
* Disallow cursor from appearing beyond the width of the input.
* Test that verifies the cursor can't exceed the width of the input
* Use constant from editable.dart to explain 1 pixel difference in test
* Fix failing test that tested the case of overflowing spaces
## Description
Print actionable warnings if `flutter drive` (where most of our performance benchmarks come from) is run in debug mode and it tries to gather benchmarks using `traceAction`.
## Related Issues
https://github.com/flutter/flutter/issues/30625
## Tests
I added the following tests:
* drive_perf_debug_warning devicelab test
ff1bcdc009...8a46559653
git log ff1bcdc00941188ba27123a4857b443e3c9392bb..8a465596533d75eb128faab5cd70b60c5e989935 --no-merges --oneline
8a4655965 Route FlutterEventTracer events to Fuchsia tracing for Fuchsia (flutter/engine#8499)
7ce64be6c [scenic] Remove unused mozart.internal (flutter/engine#8496)
edb050f7a Roll src/third_party/skia 2f08a4043b26..0ea414a08208 (2 commits) (flutter/engine#8506)
623dca053 Roll src/third_party/dart b23817105c..cc63d6e647 (8 commits)
c7b138d82 [scenic][SCN-1054] remove dangling uses of SetTranslationRH (flutter/engine#8503)
53620352a Roll src/third_party/dart aacc0b0709..b23817105c (8 commits)
046b3cd28 Get rid of the macro for accessing the current test name. (flutter/engine#8500)
533ca016e Roll src/third_party/skia 6b797fec83f0..2f08a4043b26 (8 commits) (flutter/engine#8501)
612abee90 Wire up support for Dart fixtures in shell_unittests. (flutter/engine#8497)
dbcfc504c Android Embedding PR26: Offer an async version of FlutterMain's ensure initialization complete. (flutter/engine#8465)
a930ca893 Roll src/third_party/dart 8e4dcf48c4..aacc0b0709 (4 commits)
acfc83179 Roll src/third_party/skia 602df41025ea..6b797fec83f0 (19 commits) (flutter/engine#8494)
3558fa65a [Docs] Correcting link to contributing guide. (flutter/engine#8472)
0bf708ee1 Refactor ios play input sound logic. (flutter/engine#7783)
78bd318c9 Add Locale.toLanguageTag() (flutter/engine#8421)
efb3b003f Roll src/third_party/dart 8e0a669e74..8e4dcf48c4 (8 commits)
075b4899d Support ContextWrapper when FlutterView is instantiated within a Fragment. (flutter/engine#7776)
85ca8c485 Roll src/third_party/skia 053b2939938c..602df41025ea (21 commits) (flutter/engine#8492)
a6b8e70ad Remove unused variable (flutter/engine#8490)
377dc6400 Roll src/third_party/dart 86b5304ccd..8e0a669e74 (6 commits)
7ee3a31c5 Roll src/third_party/dart 907c514c89..86b5304ccd (27 commits)
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (jsimmons@google.com), and stop
the roller if necessary.
`Border.all()` is a factory constructor and thus not const
constructible. This change adds a `const Border.uniform()`
constructor and makes `Border.all()` delegate to it. This allows
callers to more likely be able to make their widget tree const
constructible.
When submitting data to a server, callers need a callback that will
get invoked after all the individual form fields are saved. If they
have a button that submits the form, they could just do this logic
in the click handler for the button (save the form, then submit to
the server), but if they have more ways than one to submit the form
(i.e. hitting enter while in a text form field), then it becomes
more convoluted and calls for a unified callback that will get
notified when the form is submitted.
6bc33b5e14...0c393d64e4
git log 6bc33b5e144254ceab274298dd61d9d9ed0dcc8f..0c393d64e4d1c4cd408a591eac72ba05cdc2c0da --no-merges --oneline
0c393d64e Roll dart back to 907c514c8937cf76e (flutter/engine#8473)
fea42a259 Roll src/third_party/dart 9e1adc54a7..389ccc9000 (10 commits)
d6cf2bda1 Roll src/third_party/dart da4ccd0855..9e1adc54a7 (3 commits)
0c2a2c1c4 Initialize OpacityLayer's matrix to identity (flutter/engine#8467)
7fd4caf03 Roll src/third_party/dart 1ad11facec..da4ccd0855 (6 commits)
d3fbaea9a Android Embedding PR25: Prevent black rectangle when launching FlutterActivity (flutter/engine#8460)
99da038da Document the leak_vm flag. (flutter/engine#8462)
ce7c21ce9 Log the correct function on error in the embedder. (flutter/engine#8461)
e10d46421 Improve path metrics tests and docs (flutter/engine#7851)
424045c3f Enable shutting down all root isolates in a VM. (flutter/engine#8457)
816e3dc0f Roll src/third_party/dart 907c514c89..1ad11facec (7 commits)
45dc353ee Roll src/third_party/skia 0e35ce27e0e9..053b2939938c (10 commits) (flutter/engine#8458)
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com), and stop
the roller if necessary.
-* Inserted an `IconTheme` widget under `CupertinoTheme` to provide a default icon color when using `CupertinoTheme`.
* Changed `CupertinoTheme` to a `StatelessWidget`, to match the implementation of `Theme`
* Changed the nesting order of `Theme`'s sub widgets, to let `Theme.iconTheme` take precedence, so that `Theme`'s behavior is kept as is.
