gaaclarke
52bb0c4cee
Switched CupertinoDynamicColor to implements Color ( #153938 )
...
issue: https://github.com/flutter/flutter/issues/127855
This was an impediment to [changing the Color class](https://github.com/flutter/engine/pull/54415 ).
2024-09-03 20:00:04 +00:00
Mohsin Raza
76955826ae
set onChangedField function to only update options with new results ( #150776 )
...
Added function and result identifiers into the RawAutocomplete onChangedField method, now the options value will not be updated if the data is from an optionsBuilder call older than the last call which updated the options
*List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.*
Issue #150774 is fixed by this PR
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2024-09-03 19:55:12 +00:00
Kate Lovett
72ebfc7dc0
Update customer test logging ( #154577 )
...
Reverts flutter/flutter#154356 , and updates logging so that the test suite's name and runtime is always logged, not just on failure.
The issue is resolved in https://github.com/flutter/tests/pull/406
Related to https://github.com/flutter/flutter/issues/154251
2024-09-03 19:51:08 +00:00
Kate Lovett
132dc8f82d
Revert #154339 , remove bringup on linux customer testing ( #154372 )
...
Reverts increased timeouts on customer testing from #154339 , also removes bringup state from https://github.com/flutter/flutter/issues/154293 .
This was related to https://github.com/flutter/flutter/issues/154251 , which will be fixed by https://github.com/flutter/tests/pull/406 (so we should land that first).
2024-09-03 19:36:56 +00:00
engine-flutter-autoroll
f508d0a10c
Roll Flutter Engine from a3504c2f347d to 537343143275 (17 revisions) ( #154569 )
...
a3504c2f34...5373431432skia-flutter-autoroll@skia.org Roll Skia from ab2317b94853 to 2d5a75027691 (3 revisions) (flutter/engine#54940 )
2024-09-03 skia-flutter-autoroll@skia.org Roll Skia from 041fd378d332 to ab2317b94853 (3 revisions) (flutter/engine#54937 )
2024-09-03 49699333+dependabot[bot]@users.noreply.github.com Bump actions/setup-python from 5.1.1 to 5.2.0 (flutter/engine#54933 )
2024-09-03 skia-flutter-autoroll@skia.org Roll Skia from 49ea0f383706 to 041fd378d332 (1 revision) (flutter/engine#54932 )
2024-09-03 robert.ancell@canonical.com Make FlApplication class (flutter/engine#54637 )
2024-09-03 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from ksNJVM5ZoBB74rba_... to BaO2fyTu4jhvdTtdE... (flutter/engine#54931 )
2024-09-02 skia-flutter-autoroll@skia.org Roll Skia from 3d0c9bf48176 to 49ea0f383706 (1 revision) (flutter/engine#54928 )
2024-09-02 skia-flutter-autoroll@skia.org Roll Skia from 03bdb5c60304 to 3d0c9bf48176 (1 revision) (flutter/engine#54925 )
2024-09-02 skia-flutter-autoroll@skia.org Roll Skia from c873eb5f38d5 to 03bdb5c60304 (1 revision) (flutter/engine#54924 )
2024-09-02 skia-flutter-autoroll@skia.org Roll Skia from 514feab300b4 to c873eb5f38d5 (1 revision) (flutter/engine#54923 )
2024-09-02 skia-flutter-autoroll@skia.org Roll Skia from 15641c0df7e8 to 514feab300b4 (1 revision) (flutter/engine#54922 )
2024-09-01 skia-flutter-autoroll@skia.org Roll Skia from 80f2cd706443 to 15641c0df7e8 (1 revision) (flutter/engine#54919 )
2024-09-01 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from uDdFN_cZC6F9BVTzz... to ksNJVM5ZoBB74rba_... (flutter/engine#54918 )
2024-09-01 skia-flutter-autoroll@skia.org Roll Skia from 5477dbb533bb to 80f2cd706443 (1 revision) (flutter/engine#54916 )
2024-09-01 skia-flutter-autoroll@skia.org Roll Skia from 95ef9caae482 to 5477dbb533bb (1 revision) (flutter/engine#54915 )
2024-08-31 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from JKPo9G1NaAdstrimW... to uDdFN_cZC6F9BVTzz... (flutter/engine#54914 )
2024-08-31 jonahwilliams@google.com [Impeller] separate algorithm for computing render target size. (flutter/engine#54604 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from JKPo9G1NaAds to BaO2fyTu4jhv
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com ,rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-03 19:14:06 +00:00
John McDole
6035698acb
Really make the seed stable to YYYY-MM-DD ( #154568 )
...
`hashCode` is stable for the same inputs of `DateTime`; those inputs should be to the day only (oops).
2024-09-03 19:10:18 +00:00
Christopher Fujino
28a9124304
Add Android SDK to Linux packages_autoroller ( #154462 )
...
Fixes https://github.com/flutter/flutter/issues/154151
This target now requires the Android toolchain because it may
re-generate gradle lockfiles.
2024-09-03 11:23:49 -07:00
Darniel Rumple
7b71d9f493
Fix typing error in AutofillGroup docs ( #154405 )
...
Fixes a small typing error in the AutofillGroup docs
2024-09-03 18:22:00 +00:00
Nate Wilson
c2a2b13e0c
Refactor CircularNotchedRectangle.getOuterPath() ( #154036 )
...
This PR makes a notched rectangle method a bit more readable.
- The circular notched rectangle's `getOuterPath()` method no longer
uses any null-asserts.
- It also used to have 2 variables (`r` and `notchRadius`) that held the
same value, but that's no longer the case.
2024-09-03 12:17:00 -06:00
Shreyans Pathak
6f19403eb6
Replace ListTile usage with CupertinoListTile ( #154473 )
...
This PR replaces the `ListTile` usage in the cupertino switch example with `CupertinoListTile`.
Fixes #154450
2024-09-03 18:14:53 +00:00
engine-flutter-autoroll
7abeeb196b
Roll Flutter Engine from 2d56e448887f to a3504c2f347d (1 revision) ( #154464 )
...
2d56e44888...a3504c2f34skia-flutter-autoroll@skia.org Roll Skia from 9d0039785ebd to
95ef9caae482 (1 revision) (flutter/engine#54911 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com ,zra@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-03 10:24:27 -07:00
gaaclarke
d1385a4827
Adds wide gamut framework test ( #153319 )
...
issue: https://github.com/flutter/flutter/issues/127855
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2024-09-03 09:41:30 -07:00
Phil Quitslund
29af4a174c
sort part directives ( #154456 )
...
A pending change to the `directives_ordering` lint will enforce part
sorting.
See: https://github.com/dart-lang/linter/issues/4945
And `flutter-analyze` failure:
https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8738142237425031297/+/u/analyze_flutter_flutter/stdout
Related to change: https://dart-review.googlesource.com/c/sdk/+/383023
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2024-09-03 09:21:37 -07:00
Konstantin Scheglov
74a31399e1
Remove unnecessary imports. ( #154527 )
...
With https://dart-review.googlesource.com/c/sdk/+/382901 we will start checking it differently, and find more unnecessary imports.
2024-09-03 16:14:44 +00:00
engine-flutter-autoroll
700ce065ea
Roll Packages from c9c000430163 to 848d7e915e21 (3 revisions) ( #154510 )
...
c9c0004301...848d7e915emhvdijk@gmail.com [flutter_adaptive_scaffold] Compare breakpoints (flutter/packages#7531 )
2024-08-30 tarrinneal@gmail.com [pigeon] adds support for collections of enums and classes (flutter/packages#7476 )
2024-08-30 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads] Fixes bug where ad can replay during content playback (flutter/packages#7537 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-03 16:11:02 +00:00
John McDole
95c3292623
Improve microbenchmarks a smidge ( #154461 )
...
1. Allow for selective benchmarks to run locally (see README.md)
2. Shuffle the tests; the seed being rotated daily or specified (see
README.md)
2024-09-03 09:10:13 -07:00
Daco Harkes
6a47cdb6b5
[native assets] Roll dependencies ( #154507 )
...
Roll the dependencies from dart-lang/native.
2024-09-03 16:07:08 +00:00
Zachary Anderson
164ff46f7c
Revert "improve trace logging in packages autoroller" ( #154555 )
...
Reverts flutter/flutter#154441
https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20packages_autoroller/11826/overview
I can't see how this change would be causing the specific failure on the
tree, but the failure is consistent after this commit, so speculatively
reverting.
The revert label isn't working since we're out of the window, so this is
a manual revert.
2024-09-03 08:59:11 -07:00
engine-flutter-autoroll
6fe09872b1
Roll Flutter Engine from 4f1de98aa0c8 to 2d56e448887f (1 revision) ( #154459 )
...
4f1de98aa0...2d56e44888yjbanov@google.com [web:canvaskit] switch to temporary SkPaint objects (flutter/engine#54818 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-30 23:53:11 +00:00
Christopher Fujino
54c886b716
improve trace logging in packages autoroller ( #154441 )
...
Add debugging to diagnose:
https://github.com/flutter/flutter/issues/154151
2024-08-30 16:26:14 -07:00
engine-flutter-autoroll
881f86943c
Roll Flutter Engine from eff1b76cf297 to 4f1de98aa0c8 (4 revisions) ( #154451 )
...
eff1b76cf2...4f1de98aa0skia-flutter-autoroll@skia.org Roll Skia from 0182585d38dd to 9d0039785ebd (4 revisions) (flutter/engine#54910 )
2024-08-30 skia-flutter-autoroll@skia.org Roll Skia from 2727e4e5d7ec to 0182585d38dd (1 revision) (flutter/engine#54908 )
2024-08-30 30870216+gaaclarke@users.noreply.github.com Reland: Hooks up framework wide gamut to engine wide gamut (flutter/engine#54906 )
2024-08-30 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from ohUS2y1HixZYziUtX... to JKPo9G1NaAdstrimW... (flutter/engine#54907 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from ohUS2y1HixZY to JKPo9G1NaAds
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-30 22:21:33 +00:00
Yegor
9502cb1576
increase Linux build_test shard count from 3 to 5 ( #154444 )
...
Fixes https://github.com/flutter/flutter/issues/154443
2024-08-30 15:05:55 -07:00
John McDole
7aace1c5f9
Run all microbenchmarks (part trois) ( #154446 )
...
**Three things**
Re-lands #154374
New: fix `platform_channels_benchmarks` to print the "done" key. Updated notes for the microbenchmark parser. There are no other users of `microbenchmarks.readJsonResults`.
Re-Re-land: Uninstall microbenchmarks before running them.
Flakes in https://github.com/flutter/flutter/issues/153828 stem from adb saying the app isn't installed, but then failing to install wtih -r. Several other tests uninstall the app before trying to run it. Previous fix called uninstall between tests, but iOS takes 12 to 13 seconds to perform uninstall / install, which timed out the test. Just uninstall the one time since we only care about any lingering apps with different keys.
Potential solution https://github.com/flutter/flutter/issues/153828
Re-land Make things go fast
Instead of installing 21 different compilations of the same app to get results; compile and run them together. Locally on Mac+iOS, this should takes ~3 minutes instead of ~15 minutes.
2024-08-30 20:55:16 +00:00
engine-flutter-autoroll
8c1a93508b
Roll Flutter Engine from 94487cc5765b to eff1b76cf297 (2 revisions) ( #154435 )
...
94487cc576...eff1b76cf230870216+gaaclarke@users.noreply.github.com Reland: Framework wide color (#54415 ) (#54737 ) (flutter/engine#54905 )
2024-08-30 skia-flutter-autoroll@skia.org Roll Skia from f3811180e7df to 2727e4e5d7ec (3 revisions) (flutter/engine#54904 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-30 20:17:12 +00:00
auto-submit[bot]
8c264775bf
Reverts "Run all microbenchmarks ( #154374 )" ( #154440 )
...
Reverts: flutter/flutter#154374
Initiated by: jtmcdole
Reason for reverting: A different benchmark was using the microbenchmark parser and timing out.
Original PR Author: jtmcdole
Reviewed By: {zanderso}
This change reverts the following previous change:
Two things:
**Re-land**: Uninstall microbenchmarks before running them.
Flakes in #153828 stem from adb saying the app isn't installed, but then failing to install wtih `-r`. Several other tests uninstall the app before trying to run it. Previous fix called uninstall between tests, but iOS takes 12 to 13 seconds to perform uninstall / install, which timed out the test. Just uninstall the one time since we only care about any lingering apps with different keys.
Potential solution #153828
**Make things go fast**
Instead of installing 21 different compilations of the same app to get results; compile and run them together. Locally on Mac+iOS, this should takes ~3 minutes instead of ~15 minutes.
2024-08-30 19:44:19 +00:00
Dimil Kalathiya
620d1ea729
Expose long press in ``CupertinoButton`` ( #154052 )
...
Adds long press as per https://github.com/flutter/flutter/issues/153956 request
Fixes #153956
2024-08-30 18:56:00 +00:00
John McDole
9fc160b11c
Run all microbenchmarks ( #154374 )
...
Two things:
**Re-land**: Uninstall microbenchmarks before running them.
Flakes in #153828 stem from adb saying the app isn't installed, but then failing to install wtih `-r`. Several other tests uninstall the app before trying to run it. Previous fix called uninstall between tests, but iOS takes 12 to 13 seconds to perform uninstall / install, which timed out the test. Just uninstall the one time since we only care about any lingering apps with different keys.
Potential solution #153828
**Make things go fast**
Instead of installing 21 different compilations of the same app to get results; compile and run them together. Locally on Mac+iOS, this should takes ~3 minutes instead of ~15 minutes.
2024-08-30 18:22:06 +00:00
hangyu
0d8247eb7d
Add a RegExp for iOS domain when reading domains from xcodeProject ( #154201 )
...
Append the string `?mode=<alternate mode>` to the associated domain to
enable alternate mode in some use cases is recommended in apple
developer guide
(https://developer.apple.com/documentation/xcode/configuring-an-associated-domain#Enable-alternate-mode-for-unreachable-servers )
So when reading these domains from xcode settings, we should consider
this case and trim it.
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2024-08-30 11:17:29 -07:00
Dishank Jindal
01e8ecaea6
Added support for elevation on refresh indicator ( #154182 )
...
Refresh Indicator Elevation:
- Added elevation to the refresh indicator using elevation attribute.
- This change improves the indicator's visibility against various background colors and enhances overall UI consistency.
- If we want to get rid of shadow effect from the indicator itself.
The refresh indicator did not provide the control over depth of the progress indicator. This change addresses that issue by adding elevation to the indicator, creating a subtle depth effect that makes it more visually prominent and provides better feedback to the user.
No breaking changes.
| Before | After |
| --- | --- |
|  |  |
Pre-launch Checklist
2024-08-30 17:50:08 +00:00
engine-flutter-autoroll
e48a45ff5e
Roll Flutter Engine from c851c58019e9 to 94487cc5765b (2 revisions) ( #154427 )
...
c851c58019...94487cc576skia-flutter-autoroll@skia.org Roll Skia from 2b633f7626ea to f3811180e7df (2 revisions) (flutter/engine#54900 )
2024-08-30 skia-flutter-autoroll@skia.org Roll Fuchsia Test Scripts from DtxLvjJOVzo_oZGui... to p5MYp7o9Tt0sossYJ... (flutter/engine#54899 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-30 17:15:21 +00:00
Justin McCandless
995a1da104
Android predictive back should work after returning to the app from a notification ( #154313 )
...
Fixes a bug where the app would exit on a back gesture when there were still routes in the navigation stack after returning to the app from a notification.
2024-08-30 09:36:10 -07:00
engine-flutter-autoroll
357704aeb2
Roll Flutter Engine from 9c3f66d822e4 to c851c58019e9 (7 revisions) ( #154416 )
...
9c3f66d822...c851c58019#54886 )" (flutter/engine#54902 )
2024-08-30 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Dart SDK from 88d311c9a531 to 995324d1b218 (1 revision) (#54896 )" (flutter/engine#54901 )
2024-08-30 skia-flutter-autoroll@skia.org Roll Dart SDK from 88d311c9a531 to 995324d1b218 (1 revision) (flutter/engine#54896 )
2024-08-30 skia-flutter-autoroll@skia.org Roll Fuchsia Test Scripts from NWpblL_DFACOx_Spi... to DtxLvjJOVzo_oZGui... (flutter/engine#54891 )
2024-08-30 skia-flutter-autoroll@skia.org Roll Skia from c23d19fdf117 to 2b633f7626ea (1 revision) (flutter/engine#54890 )
2024-08-30 skia-flutter-autoroll@skia.org Roll Skia from 9ce15f8b2c7e to c23d19fdf117 (2 revisions) (flutter/engine#54889 )
2024-08-30 skia-flutter-autoroll@skia.org Roll Dart SDK from 139867e57ba9 to 88d311c9a531 (1 revision) (flutter/engine#54886 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-30 16:23:19 +00:00
engine-flutter-autoroll
08c3970f2b
Roll Packages from 2a0f25419c52 to c9c000430163 (6 revisions) ( #154411 )
...
2a0f25419c...c9c000430110687576+bparrishMines@users.noreply.github.com [pigeon] Kotlin implementation for ProxyApis (flutter/packages#6371 )
2024-08-29 louisehsu@google.com [in_app_purchase_storekit] Add storekit 2 support for canMakePayments and products (flutter/packages#7473 )
2024-08-29 mhvdijk@gmail.com [flutter_adaptive_scaffold] Add correct material spacing and panes (flutter/packages#7428 )
2024-08-29 34871572+gmackall@users.noreply.github.com [many] Upgrade example apps to AGP 8.5.2 (if they were below 8.1.0) (flutter/packages#7521 )
2024-08-29 tarrinneal@gmail.com [pigeon] allow gen of unused classes (flutter/packages#7529 )
2024-08-29 magder@google.com Increase deprecation check minimum to iOS 14 and macOS 13 (flutter/packages#7431 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-30 15:52:21 +00:00
engine-flutter-autoroll
967286b386
Roll Flutter Engine from da87db6d55e3 to 9c3f66d822e4 (2 revisions) ( #154385 )
...
da87db6d55...9c3f66d822#54415 ) (#54737 )" (flutter/engine#54885 )
2024-08-30 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Hooks up framework wide gamut to engine wide gamut (#54567 )" (flutter/engine#54884 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-30 06:13:13 +00:00
engine-flutter-autoroll
3541a83a8e
Roll Flutter Engine from dc7eefb0f18a to da87db6d55e3 (2 revisions) ( #154381 )
...
dc7eefb0f1...da87db6d55jonahwilliams@google.com [android] Disable AHB swapchain and import on huawei API 29 devices. (flutter/engine#54879 )
2024-08-29 30870216+gaaclarke@users.noreply.github.com Hooks up framework wide gamut to engine wide gamut (flutter/engine#54567 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-30 02:38:29 +00:00
engine-flutter-autoroll
2bcd6055d7
Roll Flutter Engine from 2ed08d7ea315 to dc7eefb0f18a (2 revisions) ( #154379 )
...
2ed08d7ea3...dc7eefb0f1skia-flutter-autoroll@skia.org Roll Skia from 82e12bf2991a to 9ce15f8b2c7e (4 revisions) (flutter/engine#54881 )
2024-08-29 skia-flutter-autoroll@skia.org Roll Dart SDK from e6ccd7185482 to 139867e57ba9 (1 revision) (flutter/engine#54880 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-30 01:02:37 +00:00
Andrew Kolos
a8528c70b6
catch StateError thrown from Chromium.close ( #154366 )
...
Fixes crasher https://github.com/flutter/flutter/issues/154203 .
Also does a little refactoring to move exception handling into the `getChromeTabGuarded` utility function.
I plan on cherry-picking a subset of this change. This would be included in the custom CP patch for https://github.com/flutter/flutter/issues/153064 .
2024-08-30 00:01:12 +00:00
Mairramer
680f33d238
fix:: elevation and scrollUnderElevation depends on scrolling drawers on issue #120083 ( #150793 )
...
fixes https://github.com/flutter/flutter/issues/120083
Description
This PR addresses the following issues:
- Resolves the unexpected scrolledUnderElevation trigger that occurs when scrolling within the Drawer and NavigationDrawer.
2024-08-29 23:06:20 +00:00
Matan Lurey
712cf654d1
Remove --disable-dart-dev across flutter/flutter. ( #154280 )
...
As per the Dart CLI team and @bkonyi, this is no longer providing value and we shouldn't cargo-cult it.
Work towards https://github.com/flutter/flutter/issues/154268 .
2024-08-29 22:50:04 +00:00
Christopher Fujino
eed0b71c20
unpin path_provider_android ( #154369 )
...
Fixes https://github.com/flutter/flutter/issues/140796
2024-08-29 22:46:19 +00:00
engine-flutter-autoroll
facae75629
Roll Flutter Engine from 30750940b60a to 2ed08d7ea315 (3 revisions) ( #154367 )
...
30750940b6...2ed08d7ea3skia-flutter-autoroll@skia.org Roll Skia from 1d16eab57a8e to 82e12bf2991a (6 revisions) (flutter/engine#54876 )
2024-08-29 jbauman@google.com Use fuchsia.scheduler.RoleManager protocol (flutter/engine#54587 )
2024-08-29 68449066+zijiehe-google-com@users.noreply.github.com [fuchsia] Remove duplicate gn_configs (flutter/engine#54855 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-29 22:30:25 +00:00
Qun Cheng
1501e9eee0
CupertinoSlidingSegmentedControl is able to have proportional layout based on segment content (#153125 )
2024-08-29 15:06:44 -07:00
Michael Goderbauer
de3d174050
Make ViewAnchor a LookupBoundary ( #154300 )
...
So, uhm, 2 years ago in https://github.com/flutter/flutter/pull/116429 we introduced this concept of a lookup boundary to hide certain InheritedWidgets in widget subtrees who belong to a different render tree than the InheritedWidget itself. This is for example needed for the Material widget: Buttons reach out to their Material ancestor to draw ink splashes on its associated render object. This only produces the desired effect if the button render object is a descendant of the Material render object (the two need to be in the same render tree). Overlay widgets have a similar problem.
Lookup boundaries were specifically designed for multi view support, where a sub view would be powered by a separate and independent render tree. Ergo, widgets in the sub view shouldn't see these InheritedWidgets if they are part of the parent view. After all, it would be strange if clicking on a button in a subview draws the ink splash effect into the parent view. Unfortunately, we (and by that I really mean I) forgot to put a LayoutBoundary into the relevant multi view widgets when those were introduced in https://github.com/flutter/flutter/pull/125003 . This PR addresses that by wrapping the `ViewAnchor.view` child in a LookupBoundary so that its subtree (which bootstraps a separate render tree) cannot see these InheritedWidgets in the parent view.
2024-08-29 21:49:25 +00:00
Valentin Vignal
15904ef9be
Add tests for sliver grid delegate with fixed cross axis count examples ( #153500 )
...
Contributes to https://github.com/flutter/flutter/issues/130459
It adds a test for
- `examples/api/lib/rendering/sliver_grid/sliver_grid_delegate_with_fixed_cross_axis_count.0.dart`
- `examples/api/lib/rendering/sliver_grid/sliver_grid_delegate_with_fixed_cross_axis_count.1.dart`
I also fixed a mistake in the documentation
2024-08-29 21:41:21 +00:00
engine-flutter-autoroll
8f80d14e35
Roll Flutter Engine from 6d4cb16395ca to 30750940b60a (2 revisions) ( #154364 )
...
6d4cb16395...30750940b6skia-flutter-autoroll@skia.org Roll Skia from 10e44e318a72 to 1d16eab57a8e (3 revisions) (flutter/engine#54874 )
2024-08-29 30870216+gaaclarke@users.noreply.github.com Reland: Framework wide color (#54415 ) (flutter/engine#54737 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-29 21:24:57 +00:00
engine-flutter-autoroll
77a17873be
Roll Flutter Engine from 8c2789185956 to 6d4cb16395ca (1 revision) ( #154362 )
...
8c27891859...6d4cb16395skia-flutter-autoroll@skia.org Roll Dart SDK from 3c1bb8338b79 to e6ccd7185482 (2 revisions) (flutter/engine#54872 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-29 20:28:25 +00:00
Christopher Fujino
7be9e5558b
validate and commit after regenerating gradle lockfiles from pub autoroller ( #154152 )
...
Fixes https://github.com/flutter/flutter/issues/154151
Validate the git diff generated by the regenerate gradle lockfile script and then commit the changes.
2024-08-29 20:22:24 +00:00
Ben Konyi
04595bc088
Launch DDS using DartDevelopmentServiceLauncher ( #154015 )
...
`DartDevelopmentServiceLauncher` was created to share the DDS launch
logic from flutter_tools with other Dart tooling.
---------
Co-authored-by: Andrew Kolos <andrewrkolos@gmail.com >
2024-08-29 16:16:27 -04:00
flutter-pub-roller-bot
055350f84a
Roll pub packages ( #154360 )
...
This PR was generated by `flutter update-packages --force-upgrade`.
2024-08-29 14:56:39 -04:00
engine-flutter-autoroll
f42a5f11ac
Roll Flutter Engine from 27a04c95859d to 8c2789185956 (3 revisions) ( #154358 )
...
27a04c9585...8c27891859matanlurey@users.noreply.github.com Fix `build/dart/rules.gni` which contains erroneous code after my refactor. (flutter/engine#54867 )
2024-08-29 skia-flutter-autoroll@skia.org Roll Skia from 20b3af58d4a5 to 10e44e318a72 (1 revision) (flutter/engine#54869 )
2024-08-29 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from ZL8AvfXX5LFIH1LYN... to ohUS2y1HixZYziUtX... (flutter/engine#54868 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from ZL8AvfXX5LFI to ohUS2y1HixZY
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-29 18:29:42 +00:00
