engine-flutter-autoroll
212064a3e5
Roll Skia from 8f1638231e34 to da7929d79c28 (1 revision) ( #166657 )
...
https://skia.googlesource.com/skia.git/+log/8f1638231e34..da7929d79c28
2025-04-06 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com
Update SKP version
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,jlavrova@google.com ,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-04-06 14:58:26 +00:00
engine-flutter-autoroll
05a8102bf3
Roll Skia from 943df306bc3a to 8f1638231e34 (2 revisions) ( #166647 )
...
https://skia.googlesource.com/skia.git/+log/943df306bc3a..8f1638231e34
2025-04-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 1e4361042837 to 007b93a5bc8b (1 revision)
2025-04-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 5d081c7499b4 to 1e4361042837 (11 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,egdaniel@google.com ,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-04-06 02:03:24 +00:00
auto-submit[bot]
778ed9e8b6
Reverts "[web] fix text selection offset in multi-line fields ( #166565 )" ( #166644 )
...
<!-- start_original_pr_link -->
Reverts: flutter/flutter#166565
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: jtmcdole
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: Tree is broken
https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20linux_web_engine_tests/1240/overview
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: yjbanov
<!-- end_original_pr_author -->
<!-- start_reviewers -->
Reviewed By: {justinmc}
<!-- end_reviewers -->
<!-- start_revert_body -->
This change reverts the following previous change:
Fixes https://github.com/flutter/flutter/issues/162698
<!-- end_revert_body -->
Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com >
2025-04-05 17:14:19 +00:00
engine-flutter-autoroll
31dfefc79e
Roll Skia from a7da13848085 to 943df306bc3a (8 revisions) ( #166609 )
...
https://skia.googlesource.com/skia.git/+log/a7da13848085..943df306bc3a
2025-04-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms
from 374c10637d4a to 8faeb7707de8 (1 revision)
2025-04-04 kjlubick@google.com Minor cleanups
2025-04-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from e615014fb3e1 to 5d081c7499b4 (2 revisions)
2025-04-04 kjlubick@google.com Remove unused function in SkScan.h
2025-04-04 bungeman@google.com Simplify "font with random glyph mask
formats" gm.
2025-04-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from 0f9feb495ff9 to 127aec7e6c2c (13 revisions)
2025-04-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from 22e0e37fcf6e to db66eb3d2ec7 (22 revisions)
2025-04-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 897477bba573 to e615014fb3e1 (7 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,egdaniel@google.com ,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-04-04 22:00:41 +00:00
chunhtai
7afe7a5f8b
Adds semantics input type ( #165925 )
...
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->
fixes https://github.com/flutter/flutter/issues/162130
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-04-04 21:15:12 +00:00
Jim Graham
790d1b1d9a
Relands "[Impeller] Render conics without conversion from Flutter apps ( #166305 )" ( #166598 )
...
Reverts flutter/flutter#166591
Golden diffs were not discovered the first time this was submitted.
Re-submitting to double check the goldens.
2025-04-04 20:47:09 +00:00
Yegor
a56ff4890d
[web] fix text selection offset in multi-line fields ( #166565 )
...
Fixes https://github.com/flutter/flutter/issues/162698
2025-04-04 20:30:18 +00:00
Jonah Williams
f00d387cb8
[Impeller] if drawTextFrame scale is massive, convert to Path. ( #166234 )
...
Fixes https://github.com/flutter/flutter/issues/165583
Fixes https://github.com/flutter/flutter/issues/136112
If the text scale gets too big, its faster (and higher res) to switch to
path rendering than to keep using the glyph atlas cache.
2025-04-04 20:28:25 +00:00
Ben Konyi
d6c0d6fee7
[ Widget Previews ] Add widget_preview_scaffold.shard to test the widget_preview_scaffold template contents ( #166358 )
...
Adds a new `widget_preview_scaffold.shard` directory which contains a
hydrated `widget_preview_scaffold` template. This will allow for us to
write widget tests against the widgets defined in the templates.
This PR doesn't add any widget tests and is only adding the ability to
run these tests in follow up changes.
Fixes https://github.com/flutter/flutter/issues/166416
2025-04-04 18:43:52 +00:00
Matej Knopp
a400e79ce6
[Embedder] Only call removeview callback when raster thread is done with the view ( #164571 )
...
Fixes
https://github.com/flutter/flutter/issues/164564#issuecomment-2698714466
This would ensure that raster thread is completely done with the view,
i.e. it won't try to use the opengl context, which might be associated
with view window. So the client can know for sure, that when the
callback returns, it is safe to destroy the view and container window.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com >
2025-04-04 18:38:19 +00:00
engine-flutter-autoroll
f9dd5c01fc
Roll Packages from 4a36dc63f719 to 267ac7b66308 (2 revisions) ( #166583 )
...
4a36dc63f7...267ac7b663engine-flutter-autoroll@skia.org Roll Flutter from
a0b1b3253402f13c3784flutter/packages#8996 )
2025-04-03 engine-flutter-autoroll@skia.org Manual roll Flutter (stable)
from 09de023485e9 to c23637390482 (14 revisions) (flutter/packages#8990 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-04-04 18:17:29 +00:00
engine-flutter-autoroll
c45cead566
Roll Dart SDK from 4293d50dd30d to 87965ab4864e (3 revisions) ( #166571 )
...
https://dart.googlesource.com/sdk.git/+log/4293d50dd30d..87965ab4864e
2025-04-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-265.0.dev
2025-04-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-264.0.dev
2025-04-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-263.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC aaclarke@google.com ,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-04-04 18:12:55 +00:00
Jackson Gardner
4a8d42a9b1
Disable firefox image_to_byte_data_test as a group. ( #166559 )
...
Grouping allows us to avoid running the setup function when the tests
are skipped, and the setup function is where it was actually stalling.
Skipping as a group seems to avoid this problem.
We can turn `bringup: true` off of the web unit tests now.
2025-04-04 18:12:55 +00:00
Jia Hao
97f53167b3
Add x64 ddm variants ( #166511 )
...
As a follow up to https://github.com/flutter/flutter/pull/162855 . Adding
x64 allows us to add tests internally.
Towards b/393719931
Tested:
```
$ bin/et build --config ci/android_release_arm64_ddm
$ bin/et build --config ci/android_release_x64_ddm
```
cc @sigmundch
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-04-04 18:11:21 +00:00
engine-flutter-autoroll
485d6b8ae3
Roll Skia from af7ff0e98c4e to a7da13848085 (3 revisions) ( #166560 )
...
https://skia.googlesource.com/skia.git/+log/af7ff0e98c4e..a7da13848085
2025-04-03 danieldilan@google.com Add correct type to SkStringPrintf in
EncodeTest
2025-04-03 nicolettep@google.com [graphite] Formatting fixes
2025-04-03 bungeman@google.com Mark SkScalerContext::fRec const
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,egdaniel@google.com ,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-04-04 18:11:21 +00:00
auto-submit[bot]
b1c08092d0
Reverts "[Impeller] Render conics without conversion from Flutter apps ( #166305 )" ( #166591 )
...
<!-- start_original_pr_link -->
Reverts: flutter/flutter#166305
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: gaaclarke
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: Integration golden test failures. Please reland it
this and address golden diffs.
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: flar
<!-- end_original_pr_author -->
<!-- start_reviewers -->
Reviewed By: {jonahwilliams}
<!-- end_reviewers -->
<!-- start_revert_body -->
This change reverts the following previous change:
Now that Impeller performs high fidelity tessellation of Conic curves we
will no longer convert Flutter app's conic curves into approximated
quadratic curves.
<!-- end_revert_body -->
Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com >
2025-04-04 17:10:47 +00:00
engine-flutter-autoroll
2615ab6c19
Roll Dart SDK from d174ec16c3ea to 4293d50dd30d (1 revision) ( #166557 )
...
https://dart.googlesource.com/sdk.git/+log/d174ec16c3ea..4293d50dd30d
2025-04-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-262.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC aaclarke@google.com ,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-04-03 21:25:07 +00:00
engine-flutter-autoroll
dafbc0e1c0
Roll Skia from 5f65df75febd to af7ff0e98c4e (7 revisions) ( #166551 )
...
https://skia.googlesource.com/skia.git/+log/5f65df75febd..af7ff0e98c4e
2025-04-03 danieldilan@google.com Implement ConvertPixels in
SkPngEncoder with guard for Chrome
2025-04-03 kjlubick@google.com Decouple SkEdge and SkAnalyticEdge
2025-04-03 kjlubick@google.com Clean up SkPathEdgeIter::Edge enum
2025-04-03 borenet@google.com [infra] Fix OS dimension for migrated
GalaxyS7_G930FD, Mokey, and Nexus7
2025-04-03 egdaniel@google.com Check angle driverVersion for Ganesh
powerVR workaround.
2025-04-03 michaelludwig@google.com [graphite] Add
RecorderOptions.fRequireOrderedRecordings
2025-04-03 bungeman@google.com Remove forceOffGenerateImageFromPath
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,egdaniel@google.com ,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-04-03 20:12:37 +00:00
Jim Graham
cb0e649e78
[Impeller] Render conics without conversion from Flutter apps ( #166305 )
...
Now that Impeller performs high fidelity tessellation of Conic curves we
will no longer convert Flutter app's conic curves into approximated
quadratic curves.
2025-04-03 20:06:23 +00:00
Kate Lovett
a5cf980068
Update localizations from console ( #166496 )
...
Regular import of latest translations.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-04-03 18:58:22 +00:00
engine-flutter-autoroll
b6959ff8ac
Roll Fuchsia GN SDK from K_1kHDN1WfObPYHya... to jsZSHIOmQAs3URvWU... ( #166544 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-gn-sdk-flutter
Please CC aaclarke@google.com ,chrome-fuchsia-engprod@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-04-03 18:23:02 +00:00
engine-flutter-autoroll
02f13c3784
Roll Packages from 07496eb03035 to 4a36dc63f719 (3 revisions) ( #166542 )
...
07496eb030...4a36dc63f71063596+reidbaker@users.noreply.github.com [all_packages]
Enforce property assignment for compile sdk over method assignment
(flutter/packages#8897 )
2025-04-03 stuartmorgan@google.com [google_maps_flutter] Fix iOS info
window regression (flutter/packages#8939 )
2025-04-02 engine-flutter-autoroll@skia.org Roll Flutter from
05b5e79105a0b1b32534flutter/packages#8985 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-04-03 17:58:01 +00:00
engine-flutter-autoroll
ceec33f16b
Roll Skia from b67e53719e78 to 5f65df75febd (2 revisions) ( #166538 )
...
https://skia.googlesource.com/skia.git/+log/b67e53719e78..5f65df75febd
2025-04-03 robertphillips@google.com [graphite] Fix PipelineUsesInEpoch
UMA stat
2025-04-03 nicolettep@google.com [graphite] Fix ordering of image layout
transition call
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,egdaniel@google.com ,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-04-03 17:28:13 +00:00
Jenn Magder
73590fb0d2
Update docs to debug the Android embedder ( #166170 )
...
Update Android embedder debugging instructions.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-04-03 17:23:05 +00:00
engine-flutter-autoroll
269d544a9b
Roll Dart SDK from 72562ca93bb5 to d174ec16c3ea (1 revision) ( #166525 )
...
https://dart.googlesource.com/sdk.git/+log/72562ca93bb5..d174ec16c3ea
2025-04-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-261.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC aaclarke@google.com ,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-04-03 15:47:27 +00:00
Matej Knopp
3237222b62
[macOS] Implement merged UI and platform thread ( #162883 )
...
Original issue: https://github.com/flutter/flutter/issues/150525
This PR lets the macOS embedder run both with and without UI and
platform thread merged.
Thread merging is controlled through `FLTEnableMergedPlatformUIThread`
`info.plist` option similar to iOS embedder, though the default value is
currently `false`.
Changes in the resize / vsync synchronization:
- Added `FlutterRunLoop` class to schedule Flutter tasks on main thread
in a way where it is possible to only process these (Flutter posted)
tasks while waiting for correct frame size during resizing. This
significantly simplifies the resize synchronization and makes the same
code work both with separate UI thread and with UI and platform thread
merged.
- `FlutterThreadSynchronizer` has been renamed to
`FlutterResizeSynchronizer` vastly simplified, mutex and conditions are
removed and the blocking is now done by only processing Flutter messages
while waiting for resizing. It is now per view (instead of storing a
viewId->Size map internally) and owned by the view itself, instead of
engine.
- This approach to resize synchronization will work for Windows and
Linux as well. This will allow us to conceptually consolidate the way we
do threading and resize synchronization on all three desktop embedders.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-04-03 15:25:17 +00:00
engine-flutter-autoroll
f01d068d25
Roll Skia from f91412f5d89d to b67e53719e78 (1 revision) ( #166527 )
...
https://skia.googlesource.com/skia.git/+log/f91412f5d89d..b67e53719e78
2025-04-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 7de3e153f521 to 897477bba573 (4 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,egdaniel@google.com ,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-04-03 14:55:26 +00:00
engine-flutter-autoroll
6df932243c
Roll Packages from 125c117a432f to 07496eb03035 (31 revisions) ( #166457 )
...
125c117a43...07496eb030alexander.irion@siemens.com [multicast_dns]
MDnsClient::listen supports onError callback (flutter/packages#8888 )
2025-04-02 15619084+vashworth@users.noreply.github.com Upgrade tests to
use Xcode 16 and iOS 18 (flutter/packages#8968 )
2025-04-01 engine-flutter-autoroll@skia.org Manual roll Flutter from
1d954f4e9605b5e79105flutter/packages#8960 )
2025-04-01 kevmoo@users.noreply.github.com Drop deprecated HTML head
meta tags (flutter/packages#8970 )
2025-04-01 stuartmorgan@google.com Adjust PR checklist formatter
discussion (flutter/packages#8924 )
2025-04-01 stuartmorgan@google.com Update CODEOWNERS username
(flutter/packages#8933 )
2025-04-01 69054810+M97Chahboun@users.noreply.github.com
[flutter_markdown] Added sizedImageBuilder to Markdown widget
(flutter/packages#6739 )
2025-04-01 stuartmorgan@google.com [google_maps_flutter] Skip impl copy
of iOS tests (flutter/packages#8975 )
2025-04-01 stuartmorgan@google.com [google_maps_flutter] Skip more
hanging iOS tests (flutter/packages#8967 )
2025-04-01 stanleycocoa@gmail.com [url_launcher] When not fully loaded,
clicking close causes the callback to not be triggered correctly.
(flutter/packages#8582 )
2025-04-01 robert.odrowaz@leancode.pl [camera_avfoundation] Test utils
and mocks swift migration - part 2 (flutter/packages#8892 )
2025-03-31 15619084+vashworth@users.noreply.github.com [webview_flutter]
Skip flaky legacy tests on iOS (flutter/packages#8911 )
2025-03-31 davidmartos96@gmail.com [camera_android] Don't override
default fps range when not recording (flutter/packages#8891 )
2025-03-31 filiph@users.noreply.github.com [google_maps_flutter] Fix
typo and remove duplicitous CHANGELOG entry (flutter/packages#8754 )
2025-03-31 kevmoo@users.noreply.github.com [extension_gsi] Support the
latest version of googleapis_auth (flutter/packages#8931 )
2025-03-31 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump com.android.tools.build:gradle from 8.0.0 to 8.9.1 in
/packages/pigeon/platform_tests/test_plugin/android
(flutter/packages#8955 )
2025-03-31 linxunfeng@yeah.net [webview_flutter_wkwebview] Fixes crash
when sending undefined message via javascript channel
(flutter/packages#8776 )
2025-03-31 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump com.android.tools.build:gradle from 8.0.0 to 8.9.1 in
/packages/pigeon/platform_tests/alternate_language_test_plugin/android
(flutter/packages#8946 )
2025-03-31 10687576+bparrishMines@users.noreply.github.com
[interactive_media_ads] Fixes `AdEventType`s not triggering on iOS in
release mode (flutter/packages#8918 )
2025-03-31 stuartmorgan@google.com [google_maps_flutter] Skip test that
hangs iOS CI (flutter/packages#8958 )
2025-03-28 engine-flutter-autoroll@skia.org Manual roll Flutter from
b16430b2fd1d954f4e96flutter/packages#8922 )
2025-03-28 robert.odrowaz@leancode.pl [camera_avfoundation] Test utils
and mocks swift migration - part 3 (flutter/packages#8912 )
2025-03-27 jacksongardner@google.com Use a more deterministic way of
waiting for ad widgets to be ready. (flutter/packages#8920 )
2025-03-27 robert.odrowaz@leancode.pl [camera_avfoundation] Test utils
and mocks swift migration - part 1 (flutter/packages#8890 )
2025-03-27 tarrinneal@gmail.com [pigeon] correct usage of extended
generics in generator methods (flutter/packages#8910 )
2025-03-27 34892635+fa0311@users.noreply.github.com [video_player] Fix
layout issue caused by `Transform.rotate` not affecting space
calculation. (flutter/packages#8685 )
2025-03-27 43759233+kenzieschmoll@users.noreply.github.com
[shared_preferences] Fix a late initialized error with the example app
(flutter/packages#8540 )
2025-03-26 stuartmorgan@google.com [various] Disable sandbox in Chrome
dart tests (flutter/packages#8909 )
2025-03-25 stuartmorgan@google.com [tool] Move changed file detection to
base command class (flutter/packages#8730 )
2025-03-25 34327253+lenzpaul@users.noreply.github.com [Camera] Add lens
type information (iOS) (flutter/packages#8723 )
2025-03-25 tarrinneal@gmail.com [pigeon] kotlin equality methods
(flutter/packages#8887 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
---------
Co-authored-by: Maurice Parrish <10687576+bparrishMines@users.noreply.github.com >
2025-04-03 14:55:25 +00:00
engine-flutter-autoroll
275ad8da5b
Roll Skia from 2be12bc2668b to f91412f5d89d (2 revisions) ( #166517 )
...
https://skia.googlesource.com/skia.git/+log/2be12bc2668b..f91412f5d89d
2025-04-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from c9956ce0c4be to 0f9feb495ff9 (9 revisions)
2025-04-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from bd7a6d4fe2b1 to 22e0e37fcf6e (27 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,egdaniel@google.com ,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-04-03 09:14:14 +00:00
engine-flutter-autoroll
9a363420db
Roll Dart SDK from 2a1a13cc3a91 to 72562ca93bb5 (2 revisions) ( #166514 )
...
https://dart.googlesource.com/sdk.git/+log/2a1a13cc3a91..72562ca93bb5
2025-04-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-260.0.dev
2025-04-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-259.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC aaclarke@google.com ,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-04-03 07:44:26 +00:00
Daco Harkes
dec31cbab6
[native_assets] Roll dependencies ( #166282 )
...
Updating the dart-lang/native dependencies to the ones published today.
No functional changes, but `CodeAsset` does not expose an `architecture`
and `os ` anymore (https://github.com/dart-lang/native/issues/2127 ).
Instead these should be taken from what is passed in for the
`CodeConfig`. This PR refactors the `DartBuildResult` to carry around
the `Target` with `CodeAsset`s as `FlutterCodeAsset`s.
(This PR avoid refactoring relevant code due to
https://github.com/flutter/flutter/pull/164094 already refactoring this
code.)
2025-04-03 05:42:31 +00:00
Bruno Leroux
b85c0fc2fe
Fix read only TextField focus traversal on macOS ( #166056 )
...
## Description
This PR fixes a focus traversal issue for read-only TextField on macOS.
# Implementation details
On macOS, some editing capabilities are handled differently compared to
other platforms.
Since https://github.com/flutter/flutter/pull/105407 , the macOS engine
send editing selectors to the framework.
To do so a text input connection should be opened.
Before this PR there was no text input connection for a read-only
EditableText which means several shortcut were not handled, especially
tab traversal (but also selection shortcuts using arrows).
After this PR an input connection is always created on macOS even if an
EditableText is read-only.
## Related Issue
Fixes [Read-only TextField prevents focus from
changing](https://github.com/flutter/flutter/issues/161482 )
## Tests
Adds 1 test.
2025-04-03 04:54:21 +00:00
engine-flutter-autoroll
722096ef8b
Roll Skia from c106d7831592 to 2be12bc2668b (1 revision) ( #166509 )
...
https://skia.googlesource.com/skia.git/+log/c106d7831592..2be12bc2668b
2025-04-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from b0afd1a16c52 to 7de3e153f521 (9 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,egdaniel@google.com ,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-04-03 04:04:26 +00:00
engine-flutter-autoroll
5f33d1800b
Roll Fuchsia Linux SDK from v7PGvypiiWLO8PbsZ... to vYisSsIgqw0mqFRVJ... ( #166508 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC aaclarke@google.com ,zra@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-04-03 03:22:28 +00:00
engine-flutter-autoroll
ef084c83ee
Roll Dart SDK from b8b4076b1237 to 2a1a13cc3a91 (1 revision) ( #166504 )
...
https://dart.googlesource.com/sdk.git/+log/b8b4076b1237..2a1a13cc3a91
2025-04-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-258.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC aaclarke@google.com ,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-04-03 02:08:07 +00:00
engine-flutter-autoroll
51aabac708
Roll Skia from 75a0ec473181 to c106d7831592 (1 revision) ( #166499 )
...
https://skia.googlesource.com/skia.git/+log/75a0ec473181..c106d7831592
2025-04-02 jvanverth@google.com [graphite] Limit plot invalidation in
DrawAtlas::compact().
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,egdaniel@google.com ,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-04-03 01:04:26 +00:00
Kishan Rathore
3bf6754d48
Migrate to Theme.brightnessOf method ( #163950 )
...
Refactor: Migrate to Theme.brightnessOf method
fixes : #163837
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
2025-04-03 00:34:53 +00:00
Kishan Rathore
503672ff1d
Fix: Range slider show overlay for both thumbs on hovering one ( #165393 )
...
Fix: Range slider show overlay for both thumbs on hovering one
fixes : #165281
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
2025-04-03 00:33:58 +00:00
Victor Sanni
e1213e4869
Deprecate ExpansionTileController ( #166368 )
...
Fixes https://github.com/flutter/flutter/issues/165511
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-04-03 00:33:58 +00:00
Dimil Kalathiya
1e63b20d48
Add styling parameters in PopupMenuDivider ( #164790 )
...
Fixes https://github.com/flutter/flutter/issues/68176
- Add thickness, indent, endIndent and radius option on PopupMenuDivider
- Test coverage
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-04-03 00:33:58 +00:00
Matan Lurey
997f742ac5
Fix ISSUE_TEMPLATE Ordering: 10 < 9, but 10 > 09 ( #166455 )
...
Unfortunately `10_google3_bug.yml` comes before `2_bug.yml`.
This changes the name (slightly) of the issue templates based on the
instructions from GitHub on what to do when you have 10+ issue templates
(as a side-note: I wonder if we need/still use umbrella bugs for the
feature tracker, or two types of performance bugs)
2025-04-03 00:24:34 +00:00
Kate Lovett
e359812a51
Skip flaking scheduler test ( #166471 )
...
Noticed this is a recurring flake in
-
https://github.com/flutter/flutter/issues/165470#issuecomment-2771927113
-
https://github.com/flutter/flutter/issues/165479#issuecomment-2771927163
Filed https://github.com/flutter/flutter/issues/166470 for follow up
investigation.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-04-03 00:09:17 +00:00
flutter-pub-roller-bot
2976ed00ce
Roll pub packages ( #166043 )
...
This PR was generated by `flutter update-packages --force-upgrade`.
2025-04-02 22:38:54 +00:00
Yegor
fbbe0f9e7a
[a11y] add SemanticsValidationResult ( #165935 )
...
Add `SemanticsValidationResult` to semantics that maps onto
`aria-invalid`.
Fixes https://github.com/flutter/flutter/issues/162142
2025-04-02 22:00:19 +00:00
Srujan Gaddam
10d2631548
Remove unnecessary cache busting mechanism in hot restart ( #166295 )
...
In the case of a multi-app scenario, different applications may store
files in different locations. In order to avoid reloading files that
were unchanged, a suffix can be added to indicate which "version" of
this file we're loading. Even if it has a different path, because the id
and "version" (which is URL(...).search) are the same, the file would
not be reloaded.
With Flutter tools, this scenario doesn't occur. The running application
ultimately does not need to worry about the same file in different
locations.
The benefit to avoid this caching is that the user only ever sees one
copy of every file, which is the latest version, instead of the current
behavior where a "gen=N" suffix is added to a newer version.
Note that this is unrelated to the XHR or its headers or any of its
caching mechanisms. The XHR is only used to fetch the *list* of changed
files, not the files themselves. The files get loaded as part of the
`appendChild` call.
https://github.com/flutter/flutter/issues/166294
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
2025-04-02 21:38:23 +00:00
engine-flutter-autoroll
a22e3fec6e
Roll Skia from 52cbb917fffd to 75a0ec473181 (21 revisions) ( #166484 )
...
https://skia.googlesource.com/skia.git/+log/52cbb917fffd..75a0ec473181
2025-04-02 thomsmit@google.com [graphite] Align the new pendingBase to
the stride of incoming elements.
2025-04-02 nicolettep@google.com [graphite] Add Vulkan render pass and
texture changes to support reading from the dst texture
2025-04-02 nicolettep@google.com [graphite] Align DrawPass and
RenderPassDesc dst read strategy
2025-04-02 drott@chromium.org [Fontations] Path not modified for
advanced metrics, PostScript name
2025-04-02 bungeman@google.com [fontations] Set font format in
onGetAdvancedMetrics
2025-04-02 jvanverth@google.com Make VertexFiller backend independent.
2025-04-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 5b6a0bdc7c48 to b0afd1a16c52 (2 revisions)
2025-04-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from bbf92d12266d to c9956ce0c4be (9 revisions)
2025-04-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from 1411699ba4cd to bd7a6d4fe2b1 (27 revisions)
2025-04-01 danieldilan@google.com Implement asImageFilter for
SkShaderMaskFilter
2025-04-01 robertphillips@google.com [graphite] Expand
PrecompileContext::reportPipelineStats
2025-04-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 12ef946decd5 to 5b6a0bdc7c48 (3 revisions)
2025-04-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms
from 1e365691d01a to 374c10637d4a (1 revision)
2025-04-01 bungeman@google.com Fix gn side fontations sources
2025-04-01 robertphillips@google.com Add
SK_HISTOGRAM_CUSTOM_EXACT_LINEAR
2025-04-01 sharaks@google.com Merge 2 release notes into
RELEASE_NOTES.md
2025-04-01 sharaks@google.com Update Skia milestone to 137
2025-04-01 egdaniel@google.com Plumb SurfaceDrawContext through
asFragmentProcessor calls.
2025-04-01 borenet@google.com [infra] Older versions of setarch require
a parameter
2025-04-01 robertphillips@google.com Address TSAN issue in
GrSurfaceProxy::backingStoreDimensions
2025-04-01 jamesgk@google.com [ganesh] Fix blank screen when creating
offscreen surface
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,egdaniel@google.com ,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-04-02 21:29:46 +00:00
gaaclarke
25f7c15dd7
Started pixel aligning hairlines ( #166351 )
...
fixes https://github.com/flutter/flutter/issues/162378
builds from: https://github.com/flutter/flutter/pull/165079
gets rid of the line artifacts in
https://github.com/flutter/flutter/issues/165689
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-04-02 21:28:58 +00:00
chunhtai
aeab137280
Adds semantics role and adjust semantics for navigation bar ( #162467 )
...
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->
framework side of https://github.com/flutter/flutter/issues/107861
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-04-02 21:28:56 +00:00
Jackson Gardner
34ea67bdbf
Reland "[skwasm] Dynamic Threading" ( #166454 )
...
This is a reland of https://github.com/flutter/flutter/pull/164748 ,
which was reverted here: https://github.com/flutter/flutter/pull/165350
It was reverted due to some issues in the flutter packages roller:
https://github.com/flutter/flutter/issues/165347
The unit test in flutter/packages was modified to be more deterministic
and less affected by minor timing differences:
https://github.com/flutter/packages/pull/8920
So this is basically being relanded without any significant changes,
since the downstream tests have been fixed.
2025-04-02 21:27:09 +00:00
Tong Mu
f2e0a2afb3
[dart:ui] Add Path.addRSuperellipse ( #166045 )
...
This PR adds `Path.addRSuperellipse` to `dart:ui`. This is needed to
implement a parity class to `RoundedRectangleBorder` as discussed
[here](https://github.com/flutter/flutter/pull/164857#issuecomment-2715637356 ).
<details>
<summary>
Obsolete description, no longer applicable
</summary>
I want to reuse the existing algorithm created for impeller stroking.
The existing algorithm is moved from `path_builder.cc` to
`round_superellipse_param.cc`, and a delegated is added so that the same
algorithm can output for different path classes.
I'm not 100% sure this is _the_ best way to implement this, but I've
tried some methods in vain.
* `DlPathReceiver` added in
https://github.com/flutter/flutter/pull/164753 sounds like a similar
concept as the delegate created in this PR. I tried to use that but not
only are the methods private, they're neither in an accessible
directory.
* I also thought of converting an impeller `Path` to a skia path, but it
seems that the impeller path isn't designed to be traversed.
* Another possibility is that we refactor impeller stroking to be based
on the triangles instead of path, a direction we agreed to eventually
move toward, which allows avoiding code share at all. I've briefly read
the code in `StrokePathGeometry` and have some ideas but also something
uncertain, so I didn't choose this path for now.
</details>
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-04-02 21:27:08 +00:00
