zan1456/flutter
1
0
Fork 0
forked from firka/flutter
Code Pull Requests Activity

[web] - Clean up skipped tests (#124981)

Browse Source 
Fixes https://github.com/flutter/flutter/issues/124174
Fixes https://github.com/flutter/flutter/issues/124980
This commit is contained in:
htoor3
2023-04-18 14:31:18 -05:00
committed by GitHub
parent ad784bf843
commit cb90ae4d97
2 changed files with 6 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
dev/integration_tests/web_e2e_tests/lib/common.dart
View File

@@ -16,24 +16,15 @@ bool get isFirefox => window.navigator.userAgent.toLowerCase().contains('firefox
/// without penetrating the shadow DOM. In the latter case, if the application
/// creates platform views, this will also find platform view elements.
List<Node> findElements(String selector) {
final Element? glassPane = document.querySelector('flt-glass-pane');
if (glassPane == null) {
final Element? flutterView = document.querySelector('flutter-view');
if (flutterView == null) {
fail(
'Failed to locate <flt-glass-pane>. Possible reasons:\n'
'Failed to locate <flutter-view>. Possible reasons:\n'
' - The application failed to start'
' - `findElements` was called before the application started'
);
}
// TODO(htoor3): Remove shadowRoot selectors once DOM structure PR is merged.
final Element? flutterView = document.querySelector('flutter-view');
if(flutterView != null){
return flutterView.querySelectorAll(selector);
}
final ShadowRoot? shadowRoot = glassPane.shadowRoot;
return shadowRoot != null
? shadowRoot.querySelectorAll(selector)
: glassPane.querySelectorAll(selector);
return flutterView.querySelectorAll(selector);
}

2
examples/hello_world/test_driver/smoke_web_engine_test.dart
View File

@@ -43,6 +43,6 @@ void main() {
<dynamic>[],
) as WebElement?;
expect(fltSemantics, isNotNull);
}, skip: true); // https://github.com/flutter/flutter/issues/124174
});
});
}