zan1456/flutter
1
0
Fork 0
forked from firka/flutter
Code Pull Requests Activity

DCHECK that clip layer's behavior isn't none (flutter/engine#7659)

Browse Source 
This will further guard that the framework won't forget to set the
clip behavior.

This has been tested with the flutter/flutter framework
`flutter test --local-engine=host_debug_unopt`
to ensure a successful engine roll.
This commit is contained in:
liyuqian
2019-02-04 13:31:21 -08:00
committed by GitHub
parent 13d75a0e8d
commit b6888b482e
3 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
engine/src/flutter/flow/layers/clip_path_layer.cc
View File

@@ -13,7 +13,9 @@
namespace flow {
ClipPathLayer::ClipPathLayer(Clip clip_behavior)
: clip_behavior_(clip_behavior) {}
: clip_behavior_(clip_behavior) {
FML_DCHECK(clip_behavior != Clip::none);
}
ClipPathLayer::~ClipPathLayer() = default;

4
engine/src/flutter/flow/layers/clip_rect_layer.cc
View File

@@ -7,7 +7,9 @@
namespace flow {
ClipRectLayer::ClipRectLayer(Clip clip_behavior)
: clip_behavior_(clip_behavior) {}
: clip_behavior_(clip_behavior) {
FML_DCHECK(clip_behavior != Clip::none);
}
ClipRectLayer::~ClipRectLayer() = default;

4
engine/src/flutter/flow/layers/clip_rrect_layer.cc
View File

@@ -7,7 +7,9 @@
namespace flow {
ClipRRectLayer::ClipRRectLayer(Clip clip_behavior)
: clip_behavior_(clip_behavior) {}
: clip_behavior_(clip_behavior) {
FML_DCHECK(clip_behavior != Clip::none);
}
ClipRRectLayer::~ClipRRectLayer() = default;