zan1456/flutter
1
0
Fork 0
forked from firka/flutter
Code Pull Requests Activity

[License] Enable prefer_final_fields lint

Browse Source
This commit is contained in:
Chris Bracken
2018-12-20 12:06:26 -08:00
parent daa400f0ef
commit 9fcc2f0a94
3 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
engine/src/flutter/tools/licenses/analysis_options.yaml
View File

@@ -47,6 +47,7 @@ linter:
- package_prefixed_library_names
- prefer_asserts_in_initializer_lists
- prefer_equal_for_default_values
- prefer_final_fields
- prefer_final_locals
- prefer_is_not_empty
- prefer_single_quotes

4
engine/src/flutter/tools/licenses/lib/filesystem.dart
View File

@@ -530,8 +530,8 @@ class ArchiveDirectory extends IoNode implements Directory {
@override
final String name;
Map<String, ArchiveDirectory> _subdirectories = SplayTreeMap<String, ArchiveDirectory>();
List<ArchiveFile> _files = <ArchiveFile>[];
final Map<String, ArchiveDirectory> _subdirectories = SplayTreeMap<String, ArchiveDirectory>();
final List<ArchiveFile> _files = <ArchiveFile>[];
void _add(a.ArchiveFile entry, List<String> remainingPath) {
if (remainingPath.length > 1) {

4
engine/src/flutter/tools/licenses/lib/licenses.dart
View File

@@ -368,8 +368,8 @@ abstract class License implements Comparable<License> {
final LicenseType type;
Iterable<String> get licensees => _licensees;
List<String> _licensees = <String>[];
Set<String> _libraries = Set<String>();
final List<String> _licensees = <String>[];
final Set<String> _libraries = Set<String>();
bool get isUsed => _licensees.isNotEmpty;