zan1456/flutter
1
0
Fork 0
forked from firka/flutter
Code Pull Requests Activity

Prevent disabled cupertino textfield from being edited with voiceover/talkback (#48902)

Browse Source
This commit is contained in:
rami-a
2020-01-16 18:21:16 +00:00
committed by GitHub
parent 4c1d79f42f
commit 91f8d3da32
2 changed files with 59 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
packages/flutter/lib/src/cupertino/text_field.dart
View File

@@ -929,7 +929,8 @@ class _CupertinoTextFieldState extends State<CupertinoTextField> with AutomaticK
);
return Semantics(
onTap: () {
enabled: enabled,
onTap: !enabled ? null : () {
if (!controller.selection.isValid) {
controller.selection = TextSelection.collapsed(offset: controller.text.length);
}

57
packages/flutter/test/cupertino/text_field_test.dart
View File

@@ -3944,4 +3944,61 @@ void main() {
await tester.pump();
expect(focusNode3.hasPrimaryFocus, isTrue);
});
testWidgets('Cupertino text field semantics', (WidgetTester tester) async {
await tester.pumpWidget(
CupertinoApp(
home: Center(
child: ConstrainedBox(
constraints: BoxConstraints.loose(const Size(200, 200)),
child: const CupertinoTextField(),
),
),
),
);
expect(
tester.getSemantics(
find.descendant(
of: find.byType(CupertinoTextField),
matching: find.byType(Semantics),
).first,
),
matchesSemantics(
isTextField: true,
isEnabled: true,
hasEnabledState: true,
hasTapAction: true,
),
);
});
testWidgets('Disabled Cupertino text field semantics', (WidgetTester tester) async {
await tester.pumpWidget(
CupertinoApp(
home: Center(
child: ConstrainedBox(
constraints: BoxConstraints.loose(const Size(200, 200)),
child: const CupertinoTextField(
enabled: false,
),
),
),
),
);
expect(
tester.getSemantics(
find.descendant(
of: find.byType(CupertinoTextField),
matching: find.byType(Semantics),
).first,
),
matchesSemantics(
isEnabled: false,
hasEnabledState: true,
hasTapAction: false,
),
);
});
}