zan1456/flutter
1
0
Fork 0
forked from firka/flutter
Code Pull Requests Activity

[Impeller] fix min filter for GL external textures. (#166224)

Browse Source 
Fixes https://github.com/flutter/flutter/issues/165976

Pass through sampler options for oes external textures.
This commit is contained in:
Jonah Williams
2025-03-30 17:18:20 -07:00
committed by GitHub
parent b2730aa81b
commit 8d7e8608b3
2 changed files with 9 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
engine/src/flutter/impeller/entity/contents/texture_contents.cc
View File

@@ -208,6 +208,10 @@ bool TextureContents::Render(const ContentContext& renderer,
// coordinates.
sampler_desc.width_address_mode = SamplerAddressMode::kClampToEdge;
sampler_desc.height_address_mode = SamplerAddressMode::kClampToEdge;
sampler_desc.min_filter = sampler_descriptor_.min_filter;
sampler_desc.mag_filter = sampler_descriptor_.mag_filter;
sampler_desc.mip_filter = MipFilter::kBase;
FSExternal::BindSAMPLEREXTERNALOESTextureSampler(
pass, texture_,
renderer.GetContext()->GetSamplerLibrary()->GetSampler(sampler_desc));

5
engine/src/flutter/impeller/entity/contents/tiled_texture_contents.cc
View File

@@ -5,6 +5,7 @@
#include "impeller/entity/contents/tiled_texture_contents.h"
#include "fml/logging.h"
#include "impeller/core/formats.h"
#include "impeller/entity/contents/content_context.h"
#include "impeller/entity/tiled_texture_fill.frag.h"
#include "impeller/entity/tiled_texture_fill_external.frag.h"
@@ -159,6 +160,10 @@ bool TiledTextureContents::Render(const ContentContext& renderer,
// coordinates.
sampler_desc.width_address_mode = SamplerAddressMode::kClampToEdge;
sampler_desc.height_address_mode = SamplerAddressMode::kClampToEdge;
sampler_desc.min_filter = sampler_descriptor_.min_filter;
sampler_desc.mag_filter = sampler_descriptor_.mag_filter;
sampler_desc.mip_filter = MipFilter::kBase;
FSExternal::BindSAMPLEREXTERNALOESTextureSampler(
pass, texture_,
renderer.GetContext()->GetSamplerLibrary()->GetSampler(