zan1456/flutter
1
0
Fork 0
forked from firka/flutter
Code Pull Requests Activity

Rename layoutGoals to kLayoutGoals to enforce lints on headers. (flutter/engine#46054)

Browse Source 
This is required to eventually land https://github.com/flutter/flutter/issues/134969 (lint header files).
This commit is contained in:
Matan Lurey
2023-09-19 10:58:33 -07:00
committed by GitHub
parent 0363248df8
commit 7ebcf75a46
3 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
engine/src/flutter/shell/platform/darwin/macos/framework/Source/FlutterKeyboardManager.mm
View File

@@ -275,7 +275,7 @@ typedef _Nullable _NSResponderPtr (^NextResponderProvider)();
std::map<uint32_t, LayoutGoal> mandatoryGoalsByChar;
std::map<uint32_t, LayoutGoal> usLayoutGoalsByKeyCode;
for (const LayoutGoal& goal : flutter::layoutGoals) {
for (const LayoutGoal& goal : flutter::kLayoutGoals) {
if (goal.mandatory) {
mandatoryGoalsByChar[goal.keyChar] = goal;
} else {

2
engine/src/flutter/shell/platform/darwin/macos/framework/Source/KeyCodeMap.g.mm
View File

@@ -245,7 +245,7 @@ const NSDictionary* modifierFlagToKeyCode = @{
const uint64_t kCapsLockPhysicalKey = 0x00070039;
const uint64_t kCapsLockLogicalKey = 0x100000104;
const std::vector<LayoutGoal> layoutGoals = {
const std::vector<LayoutGoal> kLayoutGoals = {
LayoutGoal{0x31, 0x20, false}, // Space
LayoutGoal{0x27, 0x22, false}, // Quote
LayoutGoal{0x2b, 0x2c, false}, // Comma

2
engine/src/flutter/shell/platform/darwin/macos/framework/Source/KeyCodeMap_Internal.h
View File

@@ -104,6 +104,6 @@ typedef struct {
* All keys that Flutter wants to derive layout for, and guides on how to derive
* them.
*/
extern const std::vector<LayoutGoal> layoutGoals;
extern const std::vector<LayoutGoal> kLayoutGoals;
} // namespace flutter