zan1456/flutter
1
0
Fork 0
forked from firka/flutter
Code Pull Requests Activity

[Impeller] Fix size of squares in DrawPoints(PointMode). (flutter/engine#48547)

Browse Source 
Fixes: https://github.com/flutter/flutter/issues/138877

The existing golden tests were already showing this bug, but we didn't see it. With this fix the size of the squares should be the same as the circle for the round caps in the DrawPoints playground goldens.

Test exemption request: This fix is covered by existing golden tests.
This commit is contained in:
Jim Graham
2023-12-01 09:39:29 -08:00
committed by GitHub
parent e809f7dfac
commit 72ea712ff9
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
engine/src/flutter/impeller/entity/geometry/point_field_geometry.cc
View File

@@ -181,7 +181,7 @@ GeometryResult PointFieldGeometry::GetPositionBufferGPU(
PS::FrameInfo frame_info;
frame_info.count = points_.size();
frame_info.radius = radius;
frame_info.radius = round_ ? radius : radius * kSqrt2;
frame_info.radian_start = round_ ? 0.0f : kPiOver4;
frame_info.radian_step = k2Pi / vertices_per_geom;
frame_info.points_per_circle = points_per_circle;