forked from firka/flutter
fix failing lints in aar_init_script.gradle (#158025)
android studio is marking those three imports as unused imports. ```gradle import org.gradle.api.Project import org.gradle.api.artifacts.Configuration import org.gradle.api.publish.maven.MavenPublication ``` the lint :  and this method could be converted to static : ```gradle String getFlutterRoot(Project project) { if (!project.hasProperty("flutter-root")) { throw new GradleException("The `-Pflutter-root` flag must be specified.") } return project.property("flutter-root") } ``` ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
This commit is contained in:
committed by
GitHub
parent
22ffc0b935
commit
59a8d9dc76
@@ -4,16 +4,14 @@
|
||||
// The local repository will contain the AAR and POM files.
|
||||
|
||||
import java.nio.file.Paths
|
||||
import org.gradle.api.Project
|
||||
import org.gradle.api.artifacts.Configuration
|
||||
import org.gradle.api.publish.maven.MavenPublication
|
||||
|
||||
|
||||
void configureProject(Project project, String outputDir) {
|
||||
if (!project.hasProperty("android")) {
|
||||
throw new GradleException("Android property not found.")
|
||||
}
|
||||
if (!project.android.hasProperty("libraryVariants")) {
|
||||
throw new GradleException("Can't generate AAR on a non Android library project.");
|
||||
throw new GradleException("Can't generate AAR on a non Android library project.")
|
||||
}
|
||||
|
||||
// Snapshot versions include the timestamp in the artifact name.
|
||||
@@ -79,7 +77,7 @@ void configurePlugin(Project project, String outputDir) {
|
||||
configureProject(project, outputDir)
|
||||
}
|
||||
|
||||
String getFlutterRoot(Project project) {
|
||||
static String getFlutterRoot(Project project) {
|
||||
if (!project.hasProperty("flutter-root")) {
|
||||
throw new GradleException("The `-Pflutter-root` flag must be specified.")
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user