zan1456/flutter
1
0
Fork 0
forked from firka/flutter
Code Pull Requests Activity

Fix the fix (#90217)

Browse Source
This commit is contained in:
Kate Lovett
2021-09-17 11:07:03 -05:00
committed by GitHub
parent a8a27635a1
commit 4889064ff5
3 changed files with 8 additions and 64 deletions
Download Patch File Download Diff File Expand all files Collapse all files

64
packages/flutter/lib/fix_data.yaml
View File

@@ -2162,22 +2162,6 @@ transforms:
name: 'FloatingLabelBehavior'
- kind: 'removeParameter'
name: 'hasFloatingPlaceholder'
- if: "hasFloatingPlaceholder != 'true' && hasFloatingPlaceholder != 'false'"
changes:
- kind: 'addParameter'
index: 14
name: 'floatingLabelBehavior'
style: optional_named
argumentValue:
expression: '{% hasFloatingPlaceholder %} ? {% FloatingLabelBehavior %}.auto : {% FloatingLabelBehavior %}.never'
requiredIf: "hasFloatingPlaceholder != 'true' && hasFloatingPlaceholder != 'false'"
variables:
FloatingLabelBehavior:
kind: 'import'
uris: [ 'material.dart' ]
name: 'FloatingLabelBehavior'
- kind: 'removeParameter'
name: 'hasFloatingPlaceholder'
variables:
hasFloatingPlaceholder:
kind: 'fragment'
@@ -2223,22 +2207,6 @@ transforms:
name: 'FloatingLabelBehavior'
- kind: 'removeParameter'
name: 'hasFloatingPlaceholder'
- if: "hasFloatingPlaceholder != 'true' && hasFloatingPlaceholder != 'false'"
changes:
- kind: 'addParameter'
index: 14
name: 'floatingLabelBehavior'
style: optional_named
argumentValue:
expression: '{% hasFloatingPlaceholder %} ? {% FloatingLabelBehavior %}.auto : {% FloatingLabelBehavior %}.never'
requiredIf: "hasFloatingPlaceholder != 'true' && hasFloatingPlaceholder != 'false'"
variables:
FloatingLabelBehavior:
kind: 'import'
uris: [ 'material.dart' ]
name: 'FloatingLabelBehavior'
- kind: 'removeParameter'
name: 'hasFloatingPlaceholder'
variables:
hasFloatingPlaceholder:
kind: 'fragment'
@@ -2295,22 +2263,6 @@ transforms:
name: 'FloatingLabelBehavior'
- kind: 'removeParameter'
name: 'hasFloatingPlaceholder'
- if: "hasFloatingPlaceholder != 'true' && hasFloatingPlaceholder != 'false'"
changes:
- kind: 'addParameter'
index: 14
name: 'floatingLabelBehavior'
style: optional_named
argumentValue:
expression: '{% hasFloatingPlaceholder %} ? {% FloatingLabelBehavior %}.auto : {% FloatingLabelBehavior %}.never'
requiredIf: "hasFloatingPlaceholder != 'true' && hasFloatingPlaceholder != 'false'"
variables:
FloatingLabelBehavior:
kind: 'import'
uris: [ 'material.dart' ]
name: 'FloatingLabelBehavior'
- kind: 'removeParameter'
name: 'hasFloatingPlaceholder'
variables:
hasFloatingPlaceholder:
kind: 'fragment'
@@ -2356,22 +2308,6 @@ transforms:
name: 'FloatingLabelBehavior'
- kind: 'removeParameter'
name: 'hasFloatingPlaceholder'
- if: "hasFloatingPlaceholder != 'true' && hasFloatingPlaceholder != 'false'"
changes:
- kind: 'addParameter'
index: 14
name: 'floatingLabelBehavior'
style: optional_named
argumentValue:
expression: '{% hasFloatingPlaceholder %} ? {% FloatingLabelBehavior %}.auto : {% FloatingLabelBehavior %}.never'
requiredIf: "hasFloatingPlaceholder != 'true' && hasFloatingPlaceholder != 'false'"
variables:
FloatingLabelBehavior:
kind: 'import'
uris: [ 'material.dart' ]
name: 'FloatingLabelBehavior'
- kind: 'removeParameter'
name: 'hasFloatingPlaceholder'
variables:
hasFloatingPlaceholder:
kind: 'fragment'

4
packages/flutter/test_fixes/material.dart
View File

@@ -189,17 +189,21 @@ void main() {
const InputDecoration inputDecoration = InputDecoration(hasFloatingPlaceholder: true);
InputDecoration(hasFloatingPlaceholder: false);
InputDecoration();
InputDecoration(error: '');
InputDecoration.collapsed(hasFloatingPlaceholder: true);
InputDecoration.collapsed(hasFloatingPlaceholder: false);
InputDecoration.collapsed();
InputDecoration.collapsed(error: '');
inputDecoration.hasFloatingPlaceholder;
const InputDecorationTheme inputDecorationTheme = InputDecorationTheme(hasFloatingPlaceholder: true);
InputDecorationTheme(hasFloatingPlaceholder: false);
InputDecorationTheme();
InputDecorationTheme(error: '');
inputDecorationTheme.hasFloatingPlaceholder;
inputDecorationTheme.copyWith(hasFloatingPlaceholder: false);
inputDecorationTheme.copyWith(hasFloatingPlaceholder: true);
inputDecorationTheme.copyWith();
inputDecorationTheme.copyWith(error: '');
// Changes made in https://github.com/flutter/flutter/pull/66482
ThemeData(textSelectionColor: Colors.red);

4
packages/flutter/test_fixes/material.dart.expect
View File

@@ -190,17 +190,21 @@ void main() {
const InputDecoration inputDecoration = InputDecoration(floatingLabelBehavior: FloatingLabelBehavior.auto);
InputDecoration(floatingLabelBehavior: FloatingLabelBehavior.never);
InputDecoration();
InputDecoration(error: '');
InputDecoration.collapsed(floatingLabelBehavior: FloatingLabelBehavior.auto);
InputDecoration.collapsed(floatingLabelBehavior: FloatingLabelBehavior.never);
InputDecoration.collapsed();
InputDecoration.collapsed(error: '');
inputDecoration.floatingLabelBehavior;
const InputDecorationTheme inputDecorationTheme = InputDecorationTheme(floatingLabelBehavior: FloatingLabelBehavior.auto);
InputDecorationTheme(floatingLabelBehavior: FloatingLabelBehavior.never);
InputDecorationTheme();
InputDecorationTheme(error: '');
inputDecorationTheme.floatingLabelBehavior;
inputDecorationTheme.copyWith(floatingLabelBehavior: FloatingLabelBehavior.never);
inputDecorationTheme.copyWith(floatingLabelBehavior: FloatingLabelBehavior.auto);
inputDecorationTheme.copyWith();
inputDecorationTheme.copyWith(error: '');
// Changes made in https://github.com/flutter/flutter/pull/66482
ThemeData(textSelectionTheme: TextSelectionThemeData(selectionColor: Colors.red));