zan1456/flutter
1
0
Fork 0
forked from firka/flutter
Code Pull Requests Activity

Fix failing test on Cirrus (flutter/engine#6469)

Browse Source 
Updates the tests to use the `--use-test-fonts` argument.

Fixes flutter/flutter#22682
This commit is contained in:
Michael Klimushyn
2018-10-08 15:47:53 -07:00
committed by GitHub
parent d93d762c33
commit 27cd6283b7
2 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
engine/src/flutter/testing/dart/paragraph_builder_test.dart
View File

@@ -7,7 +7,6 @@ import 'dart:ui';
import 'package:test/test.dart';
void main() {
// TODO(flutter/flutter#22682): Re-enable this test.
test('Should be able to build and layout a paragraph', () {
final ParagraphBuilder builder = ParagraphBuilder(ParagraphStyle());
builder.addText('Hello');
@@ -17,5 +16,5 @@ void main() {
paragraph.layout(ParagraphConstraints(width: 800.0));
expect(paragraph.width, isNonZero);
expect(paragraph.height, isNonZero);
}, skip: 'Fails on cirrus.');
});
}

2
engine/src/flutter/testing/run_tests.sh
View File

@@ -11,7 +11,7 @@ popd
run_test () {
out/host_debug_unopt/dart out/host_debug_unopt/gen/frontend_server.dart.snapshot --sdk-root out/host_debug_unopt/flutter_patched_sdk --incremental --strong --target=flutter --packages flutter/testing/dart/.packages --output-dill out/host_debug_unopt/engine_test.dill $1
out/host_debug_unopt/flutter_tester --disable-observatory out/host_debug_unopt/engine_test.dill
out/host_debug_unopt/flutter_tester --disable-observatory --use-test-fonts out/host_debug_unopt/engine_test.dill
}
# Verify that a failing test returns a failure code.