zan1456/flutter
1
0
Fork 0
forked from firka/flutter
Code Pull Requests Activity

[Impeller] remove validation warning ignores. (#166205)

Browse Source 
We have validation enabled on CI and these don't seem to fail now that
I've removed the VVL ignore.

Fixes https://github.com/flutter/flutter/issues/149111
This commit is contained in:
Jonah Williams
2025-03-31 10:22:52 -07:00
committed by GitHub
parent 290a85e7f2
commit 1d39997fcb
1 changed files with 0 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
engine/src/flutter/impeller/renderer/backend/vulkan/debug_report_vk.cc
View File

@@ -117,21 +117,6 @@ DebugReportVK::Result DebugReportVK::OnDebugCallback(
if (data->messageIdNumber == 0x609A13B) {
return Result::kContinue;
}
// TODO(149111): Fix VUID-VkShaderModuleCreateInfo-pCode-08737.
if (data->pMessageIdName != nullptr &&
strcmp(data->pMessageIdName,
"VUID-VkShaderModuleCreateInfo-pCode-08737") == 0) {
return Result::kContinue;
}
// TODO(149111): Fix
// VUID-VkPipelineShaderStageCreateInfo-pSpecializationInfo-06849.
if (data->pMessageIdName != nullptr &&
strcmp(
data->pMessageIdName,
"VUID-VkPipelineShaderStageCreateInfo-pSpecializationInfo-06849") ==
0) {
return Result::kContinue;
}
// This warning happens when running tests that use SwiftShader.
// Some SPIR-V shaders request the UniformAndStorageBuffer16BitAccess
@@ -145,7 +130,6 @@ DebugReportVK::Result DebugReportVK::OnDebugCallback(
std::vector<std::pair<std::string, std::string>> items;
items.emplace_back("Severity", vk::to_string(severity));
items.emplace_back("Type", vk::to_string(type));
if (data->pMessageIdName) {