zan1456/flutter
1
0
Fork 0
forked from firka/flutter
Code Pull Requests Activity

[fuchsia][scenic] Fix invalid viewRef error in pointer injection. (flutter/engine#36850)

Browse Source 
This CL fixes the bug in pointer injector delegate where the viewRef is
incorrectly cloned in the flatland platform view, causing an invalid
viewRef to be passed in the Fidl request.

Test: flutter-embedder-test
This commit is contained in:
Shivesh Ganju
2022-10-19 02:33:25 -04:00
committed by GitHub
parent a978991262
commit 19b7b0eb02
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
engine/src/flutter/shell/platform/fuchsia/flutter/flatland_platform_view.cc
View File

@@ -154,10 +154,11 @@ void FlatlandPlatformView::OnChildViewViewRef(
fuchsia::ui::views::ViewRef view_ref) {
FML_CHECK(child_view_info_.count(content_id) == 1);
focus_delegate_->OnChildViewViewRef(view_id, std::move(view_ref));
fuchsia::ui::views::ViewRef view_ref_clone;
fidl::Clone(view_ref, &view_ref_clone);
focus_delegate_->OnChildViewViewRef(view_id, std::move(view_ref));
pointer_injector_delegate_->OnCreateView(view_id, std::move(view_ref_clone));
OnChildViewConnected(content_id);
}