zan1456/flutter
1
0
Fork 0
forked from firka/flutter
Code Pull Requests Activity

[Windows] Address feedback for show window comment (#127998)

Browse Source 
Address Tong's feedback here: https://github.com/flutter/flutter/issues/127695#issuecomment-1564884872

Follow-up to: https://github.com/flutter/flutter/pull/127046
This commit is contained in:
Loïc Sharma
2023-05-31 16:42:54 -07:00
committed by GitHub
parent bf17c9eab6
commit 071ea49248
11 changed files with 28 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
dev/integration_tests/flutter_gallery/windows/runner/flutter_window.cpp
View File

@@ -36,8 +36,8 @@ bool FlutterWindow::OnCreate() {
});
// Flutter can complete the first frame before the "show window" callback is
// registered. Ensure a frame is pending to ensure the window is shown.
// This no-ops if the first frame hasn't completed yet.
// registered. The following call ensures a frame is pending to ensure the
// window is shown. It is a no-op if the first frame hasn't completed yet.
flutter_controller_->ForceRedraw();
return true;

4
dev/integration_tests/ui/windows/runner/flutter_window.cpp
View File

@@ -36,8 +36,8 @@ bool FlutterWindow::OnCreate() {
});
// Flutter can complete the first frame before the "show window" callback is
// registered. Ensure a frame is pending to ensure the window is shown.
// This no-ops if the first frame hasn't completed yet.
// registered. The following call ensures a frame is pending to ensure the
// window is shown. It is a no-op if the first frame hasn't completed yet.
flutter_controller_->ForceRedraw();
return true;

4
dev/integration_tests/windows_startup_test/windows/runner/flutter_window.cpp
View File

@@ -64,8 +64,8 @@ bool FlutterWindow::OnCreate() {
});
// Flutter can complete the first frame before the "show window" callback is
// registered. Ensure a frame is pending to ensure the window is shown.
// This no-ops if the first frame hasn't completed yet.
// registered. The following call ensures a frame is pending to ensure the
// window is shown. It is a no-op if the first frame hasn't completed yet.
flutter_controller_->ForceRedraw();
// Create a method channel to check the window's visibility.

4
dev/manual_tests/windows/runner/flutter_window.cpp
View File

@@ -36,8 +36,8 @@ bool FlutterWindow::OnCreate() {
});
// Flutter can complete the first frame before the "show window" callback is
// registered. Ensure a frame is pending to ensure the window is shown.
// This no-ops if the first frame hasn't completed yet.
// registered. The following call ensures a frame is pending to ensure the
// window is shown. It is a no-op if the first frame hasn't completed yet.
flutter_controller_->ForceRedraw();
return true;

4
examples/flutter_view/windows/runner/flutter_window.cpp
View File

@@ -36,8 +36,8 @@ bool FlutterWindow::OnCreate() {
});
// Flutter can complete the first frame before the "show window" callback is
// registered. Ensure a frame is pending to ensure the window is shown.
// This no-ops if the first frame hasn't completed yet.
// registered. The following call ensures a frame is pending to ensure the
// window is shown. It is a no-op if the first frame hasn't completed yet.
flutter_controller_->ForceRedraw();
return true;

4
examples/hello_world/windows/runner/flutter_window.cpp
View File

@@ -36,8 +36,8 @@ bool FlutterWindow::OnCreate() {
});
// Flutter can complete the first frame before the "show window" callback is
// registered. Ensure a frame is pending to ensure the window is shown.
// This no-ops if the first frame hasn't completed yet.
// registered. The following call ensures a frame is pending to ensure the
// window is shown. It is a no-op if the first frame hasn't completed yet.
flutter_controller_->ForceRedraw();
return true;

4
examples/layers/windows/runner/flutter_window.cpp
View File

@@ -36,8 +36,8 @@ bool FlutterWindow::OnCreate() {
});
// Flutter can complete the first frame before the "show window" callback is
// registered. Ensure a frame is pending to ensure the window is shown.
// This no-ops if the first frame hasn't completed yet.
// registered. The following call ensures a frame is pending to ensure the
// window is shown. It is a no-op if the first frame hasn't completed yet.
flutter_controller_->ForceRedraw();
return true;

4
examples/platform_channel/windows/runner/flutter_window.cpp
View File

@@ -99,8 +99,8 @@ bool FlutterWindow::OnCreate() {
});
// Flutter can complete the first frame before the "show window" callback is
// registered. Ensure a frame is pending to ensure the window is shown.
// This no-ops if the first frame hasn't completed yet.
// registered. The following call ensures a frame is pending to ensure the
// window is shown. It is a no-op if the first frame hasn't completed yet.
flutter_controller_->ForceRedraw();
return true;

4
packages/flutter_tools/lib/src/windows/migrations/show_window_migration.dart
View File

@@ -20,8 +20,8 @@ const String _after = r'''
});
// Flutter can complete the first frame before the "show window" callback is
// registered. Ensure a frame is pending to ensure the window is shown.
// This no-ops if the first frame hasn't completed yet.
// registered. The following call ensures a frame is pending to ensure the
// window is shown. It is a no-op if the first frame hasn't completed yet.
flutter_controller_->ForceRedraw();
return true;

4
packages/flutter_tools/templates/app_shared/windows.tmpl/runner/flutter_window.cpp
View File

@@ -32,8 +32,8 @@ bool FlutterWindow::OnCreate() {
});
// Flutter can complete the first frame before the "show window" callback is
// registered. Ensure a frame is pending to ensure the window is shown.
// This no-ops if the first frame hasn't completed yet.
// registered. The following call ensures a frame is pending to ensure the
// window is shown. It is a no-op if the first frame hasn't completed yet.
flutter_controller_->ForceRedraw();
return true;

16
packages/flutter_tools/test/general.shard/windows/migrations/show_window_migration_test.dart
View File

@@ -75,8 +75,8 @@ void main () {
' });\n'
'\n'
' // Flutter can complete the first frame before the "show window" callback is\n'
' // registered. Ensure a frame is pending to ensure the window is shown.\n'
" // This no-ops if the first frame hasn't completed yet.\n"
' // registered. The following call ensures a frame is pending to ensure the\n'
" // window is shown. It is a no-op if the first frame hasn't completed yet.\n"
' flutter_controller_->ForceRedraw();\n'
'\n'
' return true;\n';
@@ -103,8 +103,8 @@ void main () {
' });\r\n'
'\r\n'
' // Flutter can complete the first frame before the "show window" callback is\r\n'
' // registered. Ensure a frame is pending to ensure the window is shown.\r\n'
" // This no-ops if the first frame hasn't completed yet.\r\n"
' // registered. The following call ensures a frame is pending to ensure the\r\n'
" // window is shown. It is a no-op if the first frame hasn't completed yet.\r\n"
' flutter_controller_->ForceRedraw();\r\n'
'\r\n'
' return true;\r\n';
@@ -145,8 +145,8 @@ void main () {
' });\n'
'\n'
' // Flutter can complete the first frame before the "show window" callback is\n'
' // registered. Ensure a frame is pending to ensure the window is shown.\n'
" // This no-ops if the first frame hasn't completed yet.\n"
' // registered. The following call ensures a frame is pending to ensure the\n'
" // window is shown. It is a no-op if the first frame hasn't completed yet.\n"
' flutter_controller_->ForceRedraw();\n'
'\n'
' return true;\n'
@@ -176,8 +176,8 @@ void main () {
' });\r\n'
'\r\n'
' // Flutter can complete the first frame before the "show window" callback is\r\n'
' // registered. Ensure a frame is pending to ensure the window is shown.\r\n'
" // This no-ops if the first frame hasn't completed yet.\r\n"
' // registered. The following call ensures a frame is pending to ensure the\r\n'
" // window is shown. It is a no-op if the first frame hasn't completed yet.\r\n"
' flutter_controller_->ForceRedraw();\r\n'
'\r\n'
' return true;\r\n'