firka/flutter
3
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
35,441 Commits 1 Branch 0 Tags
fcbc53bcb3f8b338012a55ab86fe5f8ee9fa36dc
Commit Graph

35441 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
engine-flutter-autoroll
fcbc53bcb3 Roll Flutter Engine from 86820cbd40c5 to aca26b2afc27 (2 revisions) (#129393) 
86820cbd40...aca26b2afc

2023-06-22 skia-flutter-autoroll@skia.org Roll Skia from cb44fca83da0 to 5265b5ee1afc (4 revisions) (flutter/engine#43114)
2023-06-22 godofredoc@google.com Add missing android lint to linux_unopt. (flutter/engine#43099)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-23 01:05:08 +00:00
Renzo Olivares
3c366b7011 _TapStatusTrackerMixin should wait until the next PointerDownEvent before resetting its state when the tap timer has elapsed (#129312) 
`_TapStatusTrackerMixin` used by `BaseTapAndDragGestureRecognizer` should wait until the next tap down before resetting its state when the `_consecutiveTapTimer` times out. This is because `BaseTapAndDragGestureRecognizer` may not have fired its tap down/tap up event before the state has been reset preventing it from firing the tap down/tap up callbacks at all because `currentDown` and `currentUp` are reset to `null`.

Fixes #129161
 2023-06-23 00:10:32 +00:00
engine-flutter-autoroll
3df1de4c80 Roll Flutter Engine from 7ff6a65b7183 to 86820cbd40c5 (1 revision) (#129388) 
7ff6a65b71...86820cbd40

2023-06-22 skia-flutter-autoroll@skia.org Roll Skia from 273f4cf92b7e to cb44fca83da0 (2 revisions) (flutter/engine#43107)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-23 00:07:36 +00:00
engine-flutter-autoroll
14eb1f4ce6 Roll Flutter Engine from ed477deba7c5 to 7ff6a65b7183 (2 revisions) (#129382) 
ed477deba7...7ff6a65b71

2023-06-22 43091780+utzcoz@users.noreply.github.com [android]: Make Robolectric tests work with SDK 33 (flutter/engine#42965)
2023-06-22 skia-flutter-autoroll@skia.org Roll Skia from 09b36b8ce0db to 273f4cf92b7e (1 revision) (flutter/engine#43106)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-22 23:11:50 +00:00
Kate Lovett
087377ea2f Revert "Fix Material 3 Scrollable TabBar" (#129383) 
Reverts flutter/flutter#125974
 2023-06-22 22:34:06 +00:00
engine-flutter-autoroll
7e2f3fab24 Roll Flutter Engine from 703c9a14ac7f to ed477deba7c5 (24 revisions) (#129378) 
703c9a14ac...ed477deba7

2023-06-22 skia-flutter-autoroll@skia.org Roll ANGLE from bbcf54bcb738 to 4ed2d403a329 (7 revisions) (flutter/engine#43105)
2023-06-22 chingjun@google.com Workaround a release blocker after libc++ change (flutter/engine#43091)
2023-06-22 skia-flutter-autoroll@skia.org Roll Skia from 8168c802c391 to 09b36b8ce0db (1 revision) (flutter/engine#43102)
2023-06-22 bdero@google.com [Impeller] Reland: Correctly compute UVs in texture fill (flutter/engine#43093)
2023-06-22 bdero@google.com [Impeller] Add validation forbidding SamplerAddressMode::kDecal on the OpenGLES backend (flutter/engine#43094)
2023-06-22 103135467+sealesj@users.noreply.github.com Use minor version, ignore patches for CodeQL (flutter/engine#43088)
2023-06-22 dnfield@google.com Print a warning when a message channel is used on the wrong thread. (flutter/engine#42928)
2023-06-22 skia-flutter-autoroll@skia.org Roll Skia from 3f3e1da4b7eb to 8168c802c391 (4 revisions) (flutter/engine#43096)
2023-06-22 jonahwilliams@google.com [Impeller] default sample count back to 1 (but configure to 4 in defaults). (flutter/engine#43089)
2023-06-22 mdebbar@google.com [web] Don't get break type from v8BreakIterator (flutter/engine#43053)
2023-06-22 aam@google.com Roll dart to 3.1.0-239.0.dev (flutter/engine#43083)
2023-06-22 jonahwilliams@google.com Revert "[Impeller] dont use concurrent runner to decode images on Android." (flutter/engine#43061)
2023-06-22 jonahwilliams@google.com [Impeller] Add fence waiter trace event. (flutter/engine#43092)
2023-06-22 jonahwilliams@google.com [Impeller] remove Vulkan pipeline cache mutex. (flutter/engine#43085)
2023-06-22 zanderso@users.noreply.github.com Revert "[Impeller] Correctly compute UVs in texture fill" (flutter/engine#43087)
2023-06-22 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 7EZeNE4aGd29VfDly... to tcVndpnH_jzGm5LsJ... (flutter/engine#43081)
2023-06-22 skia-flutter-autoroll@skia.org Roll Skia from 117f57a53215 to 3f3e1da4b7eb (4 revisions) (flutter/engine#43080)
2023-06-22 skia-flutter-autoroll@skia.org Roll ANGLE from 7658525166a4 to bbcf54bcb738 (1 revision) (flutter/engine#43079)
2023-06-22 skia-flutter-autoroll@skia.org Roll Skia from 5013b651f8ec to 117f57a53215 (1 revision) (flutter/engine#43078)
2023-06-22 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from QtQznuUmHMTyORqxJ... to Ylc35wOk0_j0NLzDv... (flutter/engine#43076)
2023-06-22 skia-flutter-autoroll@skia.org Roll ANGLE from a2b3f9b64670 to 7658525166a4 (1 revision) (flutter/engine#43075)
2023-06-22 skia-flutter-autoroll@skia.org Roll ANGLE from ac263582dda4 to a2b3f9b64670 (1 revision) (flutter/engine#43074)
2023-06-22 skia-flutter-autoroll@skia.org Roll Skia from 71047dca9f77 to 5013b651f8ec (4 revisions) (flutter/engine#43073)
2023-06-22 bdero@google.com [Impeller] Correctly compute UVs in texture fill (flutter/engine#43028)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from 7EZeNE4aGd29 to tcVndpnH_jzG
  fuchsia/sdk/core/mac-amd64 from QtQznuUmHMTy to Ylc35wOk0_j0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-22 22:06:30 +00:00
Christopher Fujino
6f3b07811b [flutter_tools] delete flutter format command (#129360) 
On the current stable branch (3.10.x), `flutter format` no longer works, and gives an error. This change just deletes the code.

Fixes https://github.com/flutter/flutter/issues/115809
 2023-06-22 21:28:55 +00:00
gmackall
51f659825e Unpin path_provider_android (#129205) 
Unpins path_provider_android where it is pinned. Follows the same steps as https://github.com/flutter/flutter/pull/128898.

Fixes https://github.com/flutter/flutter/issues/116376
 2023-06-22 21:22:49 +00:00
Victor Ohashi
39bf968168 fix: SearchAnchor View not resizing when in nested navigator (#128357) 
Similar to what was done on https://github.com/flutter/flutter/pull/127198, look for the closest navigator instead of screen size.

Fixes: https://github.com/flutter/flutter/issues/128344
 2023-06-22 21:20:41 +00:00
Taha Tesser
d99e5fdd2c Fix Slider overlay remains when unfocused (#129115) 
fixes https://github.com/flutter/flutter/issues/129016
 2023-06-22 21:20:40 +00:00
Mouad Debbar
bec24367b0 [web] Migrate framework to fully use package:web (#128901) 
Remove `dom.dart`'s JS interop definitions in favor of `package:web`.

Part of https://github.com/flutter/flutter/issues/113402
Part of https://github.com/flutter/flutter/issues/127030
 2023-06-22 21:20:38 +00:00
Qun Cheng
5140b0f0c6 Add onSubmitted property to SearchBar (#129365) 
Fixes #126551

This PR is to add `onSubmitted` property to `SearchBar`.
 2023-06-22 21:19:01 +00:00
Ahmed Elsayed
042c0366c9 Remove unnecessary variable _hasPrimaryFocus (#129066) 
`_hasPrimaryFocus` variable and its related code is no longer needed after using `InkWell` for `DropdownButton` at https://github.com/flutter/flutter/pull/95906
 2023-06-22 17:58:49 +00:00
Taha Tesser
32fde139bc Fix Material 3 Scrollable TabBar (#125974) 
fix https://github.com/flutter/flutter/issues/117722

### Description
1. Fix the divider doesn't stretch to take all the available width in the scrollable tab bar in M3
2. Add `dividerHeight` property.
3. Update the default tab alignment for the scrollable tab bar to match the specs (this is backward compatible for M2 with the new `tabAlignment` property).

### Bug (default tab alignment)

![Screenshot 2023-05-05 at 19 04 40](https://user-images.githubusercontent.com/48603081/236509483-1d03af21-a764-4776-acef-2126560f0d51.png)

### Fix (default tab alignment)

![Screenshot 2023-05-05 at 19 04 15](https://user-images.githubusercontent.com/48603081/236509513-2426d456-c54f-42bd-9545-a14dc6ee7e69.png)

### Code sample

<details> 
<summary>code sample</summary> 

```dart
import 'package:flutter/material.dart';

/// Flutter code sample for [TabBar].

void main() => runApp(const TabBarApp());

class TabBarApp extends StatelessWidget {
  const TabBarApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      theme: ThemeData(
        //  tabBarTheme: const TabBarTheme(tabAlignment: TabAlignment.start),
          useMaterial3: true,
      ),
      home: const TabBarExample(),
    );
  }
}

class TabBarExample extends StatefulWidget {
  const TabBarExample({super.key});

  @override
  State<TabBarExample> createState() => _TabBarExampleState();
}

class _TabBarExampleState extends State<TabBarExample> {
  bool rtl = false;

  @override
  Widget build(BuildContext context) {
    return DefaultTabController(
      initialIndex: 1,
      length: 3,
      child: Directionality(
        textDirection:  rtl ? TextDirection.rtl : TextDirection.ltr,
        child: Scaffold(
          appBar: AppBar(
            title: const Text('TabBar Sample'),
          ),
          body: const Column(
            children: <Widget>[
              Text('Scrollable-TabAlignment.start'),
              TabBar(
                isScrollable: true,
                tabAlignment: TabAlignment.start,
                tabs: <Widget>[
                  Tab(
                    icon: Icon(Icons.cloud_outlined),
                  ),
                  Tab(
                    icon: Icon(Icons.beach_access_sharp),
                  ),
                  Tab(
                    icon: Icon(Icons.brightness_5_sharp),
                  ),
                ],
              ),
              Text('Scrollable-TabAlignment.startOffset'),
              TabBar(
                isScrollable: true,
                tabAlignment: TabAlignment.startOffset,
                tabs: <Widget>[
                  Tab(
                    icon: Icon(Icons.cloud_outlined),
                  ),
                  Tab(
                    icon: Icon(Icons.beach_access_sharp),
                  ),
                  Tab(
                    icon: Icon(Icons.brightness_5_sharp),
                  ),
                ],
              ),
              Text('Scrollable-TabAlignment.center'),
              TabBar(
                isScrollable: true,
                tabAlignment: TabAlignment.center,
                tabs: <Widget>[
                  Tab(
                    icon: Icon(Icons.cloud_outlined),
                  ),
                  Tab(
                    icon: Icon(Icons.beach_access_sharp),
                  ),
                  Tab(
                    icon: Icon(Icons.brightness_5_sharp),
                  ),
                ],
              ),
              Spacer(),
              Text('Non-scrollable-TabAlignment.fill'),
              TabBar(
                tabAlignment: TabAlignment.fill,
                tabs: <Widget>[
                  Tab(
                    icon: Icon(Icons.cloud_outlined),
                  ),
                  Tab(
                    icon: Icon(Icons.beach_access_sharp),
                  ),
                  Tab(
                    icon: Icon(Icons.brightness_5_sharp),
                  ),
                ],
              ),
              Text('Non-scrollable-TabAlignment.center'),
              TabBar(
                tabAlignment: TabAlignment.center,
                tabs: <Widget>[
                  Tab(
                    icon: Icon(Icons.cloud_outlined),
                  ),
                  Tab(
                    icon: Icon(Icons.beach_access_sharp),
                  ),
                  Tab(
                    icon: Icon(Icons.brightness_5_sharp),
                  ),
                ],
              ),
              Spacer(),
            ],
          ),
          floatingActionButton: FloatingActionButton.extended(
            onPressed: () {
              setState(() {
                rtl = !rtl;
              });
            },
            label: const Text('Switch Direction'),
            icon: const Icon(Icons.swap_horiz),
          ),
        ),
      ),
    );
  }
}
``` 
	
</details>

![Screenshot 2023-06-06 at 18 06 12](https://github.com/flutter/flutter/assets/48603081/5ee5386d-cc64-4025-a020-ed2222cb6031)
 2023-06-22 17:30:46 +00:00
Masatoshi Tsushima
0da8012cc7 Fix: Closing bottom sheet and removing FAB cause assertion failure (#128566) 
Fixes #128562
 2023-06-22 17:00:58 +00:00
Taha Tesser
2e05371c88 Add InputDecorationTheme.merge (#129011) 
fixes [[Proposal] `InputDecorationTheme.merge()`](https://github.com/flutter/flutter/issues/125471)
 2023-06-22 16:02:08 +00:00
engine-flutter-autoroll
419bf816e0 Roll Packages from 9af50d46e5d1 to 95bc1c6db547 (6 revisions) (#129351) 
9af50d46e5...95bc1c6db5

2023-06-22 stuartmorgan@google.com [ci] Switch analyze tests to LUCI (flutter/packages#4264)
2023-06-22 ditman@gmail.com Roll Flutter from fc8856eb80 to c40baf47c5 (57 revisions) (flutter/packages#4270)
2023-06-22 stuartmorgan@google.com [ci] Add LUCI version of build-all for Android (flutter/packages#4236)
2023-06-21 47866232+chunhtai@users.noreply.github.com [go_router] Adds parent navigator key to ShellRoute and StatefulShell… (flutter/packages#4201)
2023-06-21 stuartmorgan@google.com [pigeon] Add macOS Obj-C support (flutter/packages#4267)
2023-06-21 stuartmorgan@google.com [tools] Fix format instructions (flutter/packages#4259)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-22 15:55:56 +00:00
Elias Yishak
18b94b7f57 Prevent crashes on range errors when selecting device (#129290) 
Prevent the cli from crashing when a user selects a number that is not valid for `flutter run` device selection

Fixes issue:
- https://github.com/flutter/flutter/issues/129191

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
 2023-06-22 15:52:25 +00:00
Zachary Anderson
7c259deaf9 Revert "Roll Flutter Engine from 703c9a14ac7f to 8cc6d6d5efdb (1 revision)" (#129353) 
Reverts flutter/flutter#129339

Reverting for a crasher: https://ci.chromium.org/ui/p/flutter/builders/prod/Linux_android%20animated_blur_backdrop_filter_perf__timeline_summary/1120/overview
 2023-06-22 15:40:08 +00:00
engine-flutter-autoroll
a2739c09a7 Roll Flutter Engine from 703c9a14ac7f to 8cc6d6d5efdb (1 revision) (#129339) 
703c9a14ac...8cc6d6d5ef

2023-06-22 bdero@google.com [Impeller] Correctly compute UVs in texture fill (flutter/engine#43028)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-22 10:01:18 +00:00
engine-flutter-autoroll
70c25d4e66 Roll Flutter Engine from d9530e2b87de to 703c9a14ac7f (1 revision) (#129337) 
d9530e2b87...703c9a14ac

2023-06-22 skia-flutter-autoroll@skia.org Roll Skia from 076e7c004d20 to 71047dca9f77 (1 revision) (flutter/engine#43071)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-22 07:35:26 +00:00
engine-flutter-autoroll
15d594c256 Roll Flutter Engine from c6251a69a09a to d9530e2b87de (1 revision) (#129334) 
c6251a69a0...d9530e2b87

2023-06-22 dnfield@google.com [Impeller] Fix up coverage hints for blending/vertices, fix TiledTextureContents::RenderToSnapshot (flutter/engine#43017)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-22 05:13:14 +00:00
engine-flutter-autoroll
c83dce9826 Roll Flutter Engine from 08aaa88bf67f to c6251a69a09a (10 revisions) (#129331) 
08aaa88bf6...c6251a69a0

2023-06-22 tamird@google.com Remove process-local tempfs (flutter/engine#43056)
2023-06-22 skia-flutter-autoroll@skia.org Roll Skia from 0185ce148be9 to 076e7c004d20 (2 revisions) (flutter/engine#43069)
2023-06-22 skia-flutter-autoroll@skia.org Roll Skia from 96d6135e9ee8 to 0185ce148be9 (4 revisions) (flutter/engine#43068)
2023-06-22 bdero@google.com [Impeller] Uniquely label subpasses and root blit (flutter/engine#43015)
2023-06-22 bdero@google.com [Impeller] Add Rect::Project (flutter/engine#43026)
2023-06-21 skia-flutter-autoroll@skia.org Roll Skia from 32e953e71266 to 96d6135e9ee8 (1 revision) (flutter/engine#43067)
2023-06-21 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from ct6r5YjdG2xpZPhkT... to QtQznuUmHMTyORqxJ... (flutter/engine#43065)
2023-06-21 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 4mkuVtlGBaumKSe8x... to 7EZeNE4aGd29VfDly... (flutter/engine#43066)
2023-06-21 skia-flutter-autoroll@skia.org Roll ANGLE from 3a3a3c655a96 to ac263582dda4 (60 revisions) (flutter/engine#43062)
2023-06-21 skia-flutter-autoroll@skia.org Roll Skia from 7eeb94b1e778 to 32e953e71266 (17 revisions) (flutter/engine#43064)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from 4mkuVtlGBaum to 7EZeNE4aGd29
  fuchsia/sdk/core/mac-amd64 from ct6r5YjdG2xp to QtQznuUmHMTy

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-22 04:25:34 +00:00
Jason Simmons
b19ebcd17e Manual roll of packages to 9af50d46e5d118fd8bc6a7b38bae748bf7877c58 (#129328) 
Required to fix an analyzer error that is blocking the engine roller
 2023-06-22 03:23:58 +00:00
engine-flutter-autoroll
ae1e6f70d9 Roll Flutter Engine from 090fae83548a to 08aaa88bf67f (3 revisions) (#129306) 
090fae8354...08aaa88bf6

2023-06-21 mark@lazycat.hu Enabling pre-push checks on Windows (flutter/engine#36123)
2023-06-21 godofredoc@google.com Document the use of contexts on engine_v2 tests. (flutter/engine#43013)
2023-06-21 godofredoc@google.com Generate treemap. (flutter/engine#43029)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-21 21:38:36 +00:00
Yegor
07772a3d23 [framework,web] add FlutterTimeline and semantics benchmarks that use it (#128366) 
## FlutterTimeline

Add a new class `FlutterTimeline` that's a drop-in replacement for `Timeline` from `dart:developer`. In addition to forwarding invocations of `startSync`, `finishSync`, `timeSync`, and `instantSync` to `dart:developer`, provides the following extra methods that make is easy to collect timings for code blocks on a frame-by-frame basis:

* `debugCollect()` - aggregates timings since the last reset, or since the app launched.
* `debugReset()` - forgets all data collected since the previous reset, or since the app launched. This allows clearing data from previous frames so timings can be attributed to the current frame.
* `now` - this was enhanced so that it works on the web by calling `window.performance.now` (in `Timeline` this is a noop in Dart web compilers).
* `collectionEnabled` - a field that controls whether `FlutterTimeline` stores timings in memory. By default this is disabled to avoid unexpected overhead (although the class is designed for minimal and predictable overhead). Specific benchmarks can enable collection to report to Skia Perf.

## Semantics benchmarks

Add `BenchMaterial3Semantics` that benchmarks the cost of semantics when constructing a screen full of Material 3 widgets from nothing. It is expected that semantics will have non-trivial cost in this case, but we should strive to keep it much lower than the rendering cost. This is the case already. This benchmark shows that the cost of semantics is <10%.

Add `BenchMaterial3ScrollSemantics` that benchmarks the cost of scrolling a previously constructed screen full of Material 3 widgets. The expectation should be that semantics will have trivial cost, since we're just shifting some widgets around. As of today, the numbers are not great, with semantics taking >50% of frame time, which is what prompted this PR in the first place. As we optimize this, we want to see this number improve.
 2023-06-21 21:37:02 +00:00
Flutter GitHub Bot
220057794b Roll pub packages (#128966) 
This PR was generated by `flutter update-packages --force-upgrade`.
 2023-06-21 21:37:00 +00:00
Pierre-Louis
28ca523ac2 Remove incorrect non-nullable assumption from ShapeDecoration.lerp (#129298) 
Fixes https://github.com/flutter/flutter/issues/129299
 2023-06-21 21:34:58 +00:00
Justin McCandless
16eb4f2c08 Gracefully handle negative position in getWordAtOffset (#128464) 
Should fix an unreproducible crash in text editing and track it with an assertion.
 2023-06-21 14:22:04 -07:00
Christopher Fujino
5cef69dd49 [flutter_tools] add a gradle error handler for could not open cache directory (#129222) 
Works around part of https://github.com/flutter/flutter/issues/128866
 2023-06-21 20:13:40 +00:00
engine-flutter-autoroll
d2c4b5a109 Roll Flutter Engine from f973fb4636d3 to 090fae83548a (5 revisions) (#129293) 
f973fb4636...090fae8354

2023-06-21 skia-flutter-autoroll@skia.org Roll Skia from c983b97d03a8 to 7eeb94b1e778 (4 revisions) (flutter/engine#43045)
2023-06-21 godofredoc@google.com Move android emulator tests to v2. (flutter/engine#43008)
2023-06-21 skia-flutter-autoroll@skia.org Roll Skia from 65f30e5804c7 to c983b97d03a8 (2 revisions) (flutter/engine#43044)
2023-06-21 skia-flutter-autoroll@skia.org Roll Skia from 7121db7c6dc2 to 65f30e5804c7 (3 revisions) (flutter/engine#43043)
2023-06-21 skia-flutter-autoroll@skia.org Roll Dart SDK from 178d3d1184cb to 88fa9330633e (1 revision) (flutter/engine#43041)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-21 20:06:04 +00:00
Renzo Olivares
b36ef583fb Selection area right click behavior should match native (#128224) 
This change updates `SelectableRegion`s right-click gesture to match native platform behavior.

Before: Right-click gesture selects word at position and opens context menu (All Platforms)
After: 
- Linux, toggles context menu on/off, and collapses selection when click was not on an active selection (uncollapsed).
- Windows, Android, Fuchsia, shows context menu at right-clicked position (unless the click is at an active selection).
- macOS, toggles the context menu if right click was at the same position as the previous / or selects word at position and opens context menu.
- iOS, selects word at position and opens context menu.

This change also prevents the `copy` menu button from being shown when there is a collapsed selection (nothing to copy).

Fixes #117561
 2023-06-21 19:32:04 +00:00
engine-flutter-autoroll
c40baf47c5 Roll Packages from 6e1918fa166c to 0fdf05f51029 (8 revisions) (#129286) 
6e1918fa16...0fdf05f510

2023-06-21 34871572+gmackall@users.noreply.github.com [image_picker_android] Modify FileUtils.getBaseName to return the whole filename when it contains no period (flutter/packages#4237)
2023-06-21 stuartmorgan@google.com [tools] Add mockito support to update-dependency (flutter/packages#4260)
2023-06-21 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 3.5.2 to 3.5.3 (flutter/packages#4185)
2023-06-21 49699333+dependabot[bot]@users.noreply.github.com [image_picker]: Bump org.jetbrains.kotlin:kotlin-bom from 1.8.21 to 1.8.22 in /packages/image_picker/image_picker_android/android (flutter/packages#4190)
2023-06-20 49699333+dependabot[bot]@users.noreply.github.com Bump actions/labeler from 4.0.3 to 4.1.0 (flutter/packages#4145)
2023-06-20 stuartmorgan@google.com [ci] Add LUCI version of the analyze tasks (flutter/packages#4253)
2023-06-20 49699333+dependabot[bot]@users.noreply.github.com [in_app_pur]: Bump org.jetbrains.kotlin:kotlin-bom from 1.8.21 to 1.8.22 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/packages#4193)
2023-06-20 stuartmorgan@google.com [ci] Switch Linux and web build-all to LUCI (flutter/packages#4252)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-21 17:00:17 +00:00
Christopher Fujino
8af21e0efb move test ownership from zanderso -> tools team (#129199) 
Move more test ownership from zanderso to the tools team. This file is used by the flaky issue bot to comment weekly on test shards that flake > 2%. The owner of the shard will be @'d on the issue. It is their responsibility to investigate and triage (potentially re-prioritizing, the bot will initially assign it p1).
 2023-06-21 16:43:33 +00:00
Elias Yishak
5d8cc978b9 Refactor Analytics global getter to point to context only (#129196) 
Refactor the globals getter for `Analytics` to be in the context instead of having a default fallback. The current state of the tool creates a new instance every time `globals.analytics` was called

Addresses issue:
- https://github.com/flutter/flutter/issues/128535
 2023-06-21 15:27:32 +00:00
engine-flutter-autoroll
b83f762dd5 Roll Flutter Engine from cfbd3652532d to f973fb4636d3 (1 revision) (#129253) 
cfbd365253...f973fb4636

2023-06-21 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 41wcREjd9roHDS1jM... to 4mkuVtlGBaumKSe8x... (flutter/engine#43038)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from 41wcREjd9roH to 4mkuVtlGBaum

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-21 10:28:40 +00:00
engine-flutter-autoroll
66f47e94b1 Roll Flutter Engine from 059643dcc8e3 to cfbd3652532d (1 revision) (#129243) 
059643dcc8...cfbd365253

2023-06-21 skia-flutter-autoroll@skia.org Roll Skia from a6412350122e to 7121db7c6dc2 (3 revisions) (flutter/engine#43037)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-21 09:36:38 +00:00
engine-flutter-autoroll
e5559b9c6c Roll Flutter Engine from 5313ca367549 to 059643dcc8e3 (1 revision) (#129240) 
5313ca3675...059643dcc8

2023-06-21 skia-flutter-autoroll@skia.org Roll Skia from efc045c15fdd to a6412350122e (2 revisions) (flutter/engine#43036)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-21 08:35:08 +00:00
engine-flutter-autoroll
f5203cb68f Roll Flutter Engine from 946f523859fe to 5313ca367549 (2 revisions) (#129234) 
946f523859...5313ca3675

2023-06-21 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from fdtK_FqpscIVvbb_j... to ct6r5YjdG2xpZPhkT... (flutter/engine#43035)
2023-06-21 leroux_bruno@yahoo.fr [Android] Return the keyboard pressed state (flutter/engine#42758)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from fdtK_FqpscIV to ct6r5YjdG2xp

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-21 07:47:27 +00:00
engine-flutter-autoroll
88d6539e61 Roll Flutter Engine from e5a860c5479c to 946f523859fe (2 revisions) (#129232) 
e5a860c547...946f523859

2023-06-21 skia-flutter-autoroll@skia.org Roll Dart SDK from 493133372cac to 178d3d1184cb (1 revision) (flutter/engine#43032)
2023-06-21 skia-flutter-autoroll@skia.org Roll Skia from cc164404690f to efc045c15fdd (1 revision) (flutter/engine#43027)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-21 06:53:18 +00:00
LongCatIsLooong
04ff86f020 Relax OverlayPortal asserts (#129053) 
Fixes https://github.com/flutter/flutter/issues/129025

Also 
- simplifies OverlayPortal code a bit and adds an assert.
-  `Tooltip` shouldn't rebuild when hiding/showing the tooltip
 2023-06-21 02:40:48 +00:00
engine-flutter-autoroll
99aaff53dc Roll Flutter Engine from adfc3af300a9 to e5a860c5479c (3 revisions) (#129228) 
adfc3af300...e5a860c547

2023-06-21 jason-simmons@users.noreply.github.com Implement the APNG_DISPOSE_OP_BACKGROUND disposal method in the animated PNG decoder (flutter/engine#42933)
2023-06-21 skia-flutter-autoroll@skia.org Roll Skia from 13d83a6912ce to cc164404690f (1 revision) (flutter/engine#43024)
2023-06-20 tamird@google.com Roll buildroot to 6e71c38443c0bf9d8954c87bf69bb4e019f44f94 (flutter/engine#43019)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-21 02:22:37 +00:00
godofredoc
dffef2715e Move all the firebase lab device configs to .ci.yaml. (#129219) 
Bug: https://github.com/flutter/flutter/issues/129211
 2023-06-21 01:10:07 +00:00
engine-flutter-autoroll
325b7b3855 Roll Flutter Engine from 7d4abb81ccd1 to adfc3af300a9 (2 revisions) (#129225) 
7d4abb81cc...adfc3af300

2023-06-20 skia-flutter-autoroll@skia.org Roll Dart SDK from 219b3198373c to 493133372cac (2 revisions) (flutter/engine#43021)
2023-06-20 skia-flutter-autoroll@skia.org Roll Skia from 0b88d9031cd2 to 13d83a6912ce (4 revisions) (flutter/engine#43020)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-21 00:57:25 +00:00
Andrew Kolos
e1e45ca37a update resolution-aware asset docs links (#128769) 
Updates some doc comment links.

Fixes https://github.com/flutter/flutter/issues/128139
 2023-06-20 23:45:52 +00:00
Justin McCandless
40b4bc996c Fix: Magnifier appears and won't dismiss (#128545) 
Fixes a bug when tapping near certain TextFields.
 2023-06-20 16:36:45 -07:00
Tae Hyung Kim
541fdd60d3 DecoratedSliver (#127823) 
This is a second attempt to merge #107269. Currently I've fixed two of the issues:
1. Fixed horizontal scrollview by using a switch statement to consider vertical/horizontal case.
2. Fixed issue of `paintExtent` not being the right extent for painting. Rather using a `scrollExtent` for the main axis length of the decoration box and painting it offsetted by the `scrollOffset`.
3. If the sliver child has inifinite scrollExtent, then we only draw the decoration down to the bottom of the `cacheExtent`. The developer is expected to ensure that the border does not creep up above the cache area.

This PR includes a test that checks that the correct rectangle is drawn at a certain scrollOffset for both the horizontal and vertical case which should be sufficient for checking that `SliverDecoration` works properly now.

Fixes https://github.com/flutter/flutter/issues/107498.
 2023-06-20 23:35:42 +00:00
engine-flutter-autoroll
08561958eb Roll Flutter Engine from 666244148e89 to 7d4abb81ccd1 (1 revision) (#129217) 
666244148e...7d4abb81cc

2023-06-20 skia-flutter-autoroll@skia.org Roll Skia from d56841344bbe to 0b88d9031cd2 (3 revisions) (flutter/engine#43018)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-20 23:32:12 +00:00
engine-flutter-autoroll
83f8b2e6c0 Roll Flutter Engine from 06d0c08460e5 to 666244148e89 (2 revisions) (#129208) 
06d0c08460...666244148e

2023-06-20 skia-flutter-autoroll@skia.org Roll Skia from 9f8b501ca68c to d56841344bbe (5 revisions) (flutter/engine#43016)
2023-06-20 skia-flutter-autoroll@skia.org Roll Skia from 0b26ffb4efe0 to 9f8b501ca68c (10 revisions) (flutter/engine#43012)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-20 22:37:53 +00:00
Md. Yeasin Sheikh
b733901de1 fixed PreferredSize constuctor invocations (#128181) 
This PR changes the `PreferredSize` constructor parameter positioning to cover the constructor invocations. It helps on auto-complete and suggestion. 

*List which issues are fixed by this PR. You must list at least one issue.*
Fixes #128178
 2023-06-20 22:21:12 +00:00