firka/flutter
3
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
17,058 Commits 1 Branch 0 Tags
e768c92fbc6cf8bf4e1814ef950a6092bbb6f658
Commit Graph

17058 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Ian Hickson
e768c92fbc Add many more global analyses. (#47875) 
* Update packages.

* Add many more global analyses.

* Catch trailing spaces and trailing newlines in all text files.
  Before we were only checking newly added files, but that means we
  missed some.

* Port the trailing spaces logic to work on Windows too.

* Correct all the files with trailing spaces and newlines.

* Refactor some of the dev/bots logic into a utils.dart library.
  Notably, the "exit" and "print" shims for testing are now usable
  from test.dart, analyze.dart, and run_command.dart.

* Add an "exitWithError" function that prints the red lines and
  then exits. This is the preferred way to exit from test.dart,
  analyze.dart, and run_command.dart.

* More consistency in the output of analyze.dart.

* Refactor analyze.dart to use the _allFiles file enumerating logic
  more widely.

* Add some double-checking logic to the _allFiles logic to catch
  cases where changes to that logic end up catching fewer files
  than expected (helps prevent future false positives).

* Add a check to prevent new binary files from being added to
  the repository. Grandfather in the binaries that we've already
  added.

* Update all the dependencies (needed because we now import crypto in
  dev/bots/analyze.dart).
 2019-12-30 17:12:19 -08:00
Kate Lovett
4fbef2a4a9 Revert "Testing tryjob triage (#47893)" (#47985) 
This reverts commit 659dc8129d.
 2019-12-30 13:09:14 -08:00
Shi-Hao Hong
173322dc78 Support preferred locales for gen_l10n (#47845) 
* Add preferred-supported-locales option to gen_l10n.dart executable
 2019-12-30 11:22:01 -08:00
Kate Lovett
659dc8129d Testing tryjob triage (#47893) 2019-12-30 09:24:47 -08:00
Devon Carew
43a8c24344 fix an analysis ignore for the missing_required_param hint (#47956) 2019-12-29 12:28:57 -08:00
engine-flutter-autoroll
841924e161 Roll engine 5a730c60d3ce..bdc9708d235e (25 commits) (#47926) 
5a730c60d3...bdc9708d23

git log 5a730c60d3ce..bdc9708d235e --first-parent --oneline
2019-12-28 franciscojma86@gmail.com Revert "Use ELF for Dart AOT snapshots on Fuchsia. (#13896)" (flutter/engine#14823)
2019-12-27 skia-flutter-autoroll@skia.org Roll src/third_party/skia 89bf1547f3aa..5a2f962313a5 (16 commits) (flutter/engine#14825)
2019-12-27 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from ikxBh... to sxapd... (flutter/engine#14821)
2019-12-27 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from IEPKx... to iImpF... (flutter/engine#14817)
2019-12-27 skia-flutter-autoroll@skia.org Roll src/third_party/dart 94a4f6415e6c..c547f5d933e5 (9 commits) (flutter/engine#14812)
2019-12-27 skia-flutter-autoroll@skia.org Roll src/third_party/skia f2d522a3f434..89bf1547f3aa (4 commits) (flutter/engine#14814)
2019-12-26 skia-flutter-autoroll@skia.org Roll src/third_party/dart 232a171a0b1c..94a4f6415e6c (8 commits) (flutter/engine#14808)
2019-12-26 skia-flutter-autoroll@skia.org Roll src/third_party/skia 07d744fb8a53..f2d522a3f434 (4 commits) (flutter/engine#14807)
2019-12-26 skia-flutter-autoroll@skia.org Roll src/third_party/skia 05eb83be171c..07d744fb8a53 (3 commits) (flutter/engine#14806)
2019-12-26 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from v3R8A... to ikxBh... (flutter/engine#14802)
2019-12-26 skia-flutter-autoroll@skia.org Roll src/third_party/dart 75fc15c7e186..232a171a0b1c (4 commits) (flutter/engine#14803)
2019-12-26 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from ZA31z... to IEPKx... (flutter/engine#14702)
2019-12-26 skia-flutter-autoroll@skia.org Roll src/third_party/skia 3d3150c89c5f..05eb83be171c (3 commits) (flutter/engine#14800)
2019-12-24 skia-flutter-autoroll@skia.org Roll src/third_party/skia a2d7225c0fc1..3d3150c89c5f (1 commits) (flutter/engine#14680)
2019-12-24 skia-flutter-autoroll@skia.org Roll src/third_party/dart 8736fec094bb..75fc15c7e186 (6 commits) (flutter/engine#14679)
2019-12-24 liyuqian@google.com Run and collect benchmarks (flutter/engine#14556)
2019-12-23 skia-flutter-autoroll@skia.org Roll src/third_party/dart 4a639e8df261..8736fec094bb (11 commits) (flutter/engine#14678)
2019-12-23 skia-flutter-autoroll@skia.org Roll src/third_party/skia ac29f1342fd2..a2d7225c0fc1 (5 commits) (flutter/engine#14677)
2019-12-23 nurhan@google.com fix selection issue (flutter/engine#14604)
2019-12-23 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from TUoVa... to v3R8A... (flutter/engine#14670)
2019-12-23 skia-flutter-autoroll@skia.org Roll src/third_party/dart cfca5ea9f2e9..4a639e8df261 (7 commits) (flutter/engine#14671)
2019-12-23 skia-flutter-autoroll@skia.org Roll src/third_party/skia 6ec826085b2a..ac29f1342fd2 (1 commits) (flutter/engine#14672)
2019-12-23 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from IZ278... to ZA31z... (flutter/engine#14675)
2019-12-21 skia-flutter-autoroll@skia.org Roll src/third_party/dart 1db1a837f8c9..cfca5ea9f2e9 (2 commits) (flutter/engine#14667)
2019-12-21 skia-flutter-autoroll@skia.org Roll src/third_party/skia 2723af6a6d43..6ec826085b2a (3 commits) (flutter/engine#14665)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC cbracken@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
 2019-12-28 14:50:12 -05:00
神楽坂花火
b28dd0c296 Reland "Add brightness to CupertinoNavigationBar (fixes #46216) (#47521)" (#47855) 2019-12-27 18:33:01 -08:00
Jim Graham
cf00b969a1 Fix semantics and transition-perf tests to parse new event format. (#47899) 2019-12-27 18:15:49 -08:00
Jim Graham
4f23c4342b Roll to include Dart changes to timeline to fix devicelab. (#47896) 2019-12-27 15:01:48 -08:00
Francisco Magdaleno
bc0d35c34e Reland "fix duration event of timeline summary (#47742)" (#47889) 
This reverts commit 50d421224d.
 2019-12-27 11:15:48 -08:00
Francisco Magdaleno
50d421224d Revert "fix duration event of timeline summary (#47742)" (#47888) 
This reverts commit e43fd1c54d.
 2019-12-27 10:26:49 -08:00
Gityuan
e43fd1c54d fix duration event of timeline summary (#47742) 
* fix duration event of timeline summary

* Revert "fix duration event of timeline summary"

This reverts commit 699aa45ed3d115f8bbea95cf6d37116b442db399.

* fix duration event of timeline summary
 2019-12-27 09:36:59 -08:00
LongCatIsLooong
ae24f18414 Reland 39919 CupertinoPicker (#47837) 2019-12-26 17:26:55 -08:00
Francisco Magdaleno
09b31a4d0d Revert "Roll engine dc0187f21777..69e41497404d (6 commits) (#47847)" (#47856) 
This reverts commit 645cdbcf3e.
 2019-12-26 15:20:52 -08:00
engine-flutter-autoroll
645cdbcf3e Roll engine dc0187f21777..69e41497404d (6 commits) (#47847) 
dc0187f217...69e4149740

git log dc0187f21777..69e41497404d --first-parent --oneline
2019-12-26 skia-flutter-autoroll@skia.org Roll src/third_party/skia 05eb83be171c..07d744fb8a53 (3 commits) (flutter/engine#14806)
2019-12-26 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from v3R8A... to ikxBh... (flutter/engine#14802)
2019-12-26 skia-flutter-autoroll@skia.org Roll src/third_party/dart 75fc15c7e186..232a171a0b1c (4 commits) (flutter/engine#14803)
2019-12-26 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from ZA31z... to IEPKx... (flutter/engine#14702)
2019-12-26 skia-flutter-autoroll@skia.org Roll src/third_party/skia 3d3150c89c5f..05eb83be171c (3 commits) (flutter/engine#14800)
2019-12-24 skia-flutter-autoroll@skia.org Roll src/third_party/skia a2d7225c0fc1..3d3150c89c5f (1 commits) (flutter/engine#14680)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC cbracken@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
 2019-12-26 18:01:12 -05:00
Francisco Magdaleno
2884758f50 Revert "Roll engine 42bb7c9eea9a..dc0187f21777 (15 commits) (#47829)" (#47846) 
This reverts commit 149e31c76e.
 2019-12-26 11:59:45 -08:00
engine-flutter-autoroll
149e31c76e Roll engine 42bb7c9eea9a..dc0187f21777 (15 commits) (#47829) 
42bb7c9eea...dc0187f217

git log 42bb7c9eea9a..dc0187f21777 --first-parent --oneline
2019-12-24 skia-flutter-autoroll@skia.org Roll src/third_party/dart 8736fec094bb..75fc15c7e186 (6 commits) (flutter/engine#14679)
2019-12-24 liyuqian@google.com Run and collect benchmarks (flutter/engine#14556)
2019-12-23 skia-flutter-autoroll@skia.org Roll src/third_party/dart 4a639e8df261..8736fec094bb (11 commits) (flutter/engine#14678)
2019-12-23 skia-flutter-autoroll@skia.org Roll src/third_party/skia ac29f1342fd2..a2d7225c0fc1 (5 commits) (flutter/engine#14677)
2019-12-23 nurhan@google.com fix selection issue (flutter/engine#14604)
2019-12-23 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from TUoVa... to v3R8A... (flutter/engine#14670)
2019-12-23 skia-flutter-autoroll@skia.org Roll src/third_party/dart cfca5ea9f2e9..4a639e8df261 (7 commits) (flutter/engine#14671)
2019-12-23 skia-flutter-autoroll@skia.org Roll src/third_party/skia 6ec826085b2a..ac29f1342fd2 (1 commits) (flutter/engine#14672)
2019-12-23 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from IZ278... to ZA31z... (flutter/engine#14675)
2019-12-21 skia-flutter-autoroll@skia.org Roll src/third_party/dart 1db1a837f8c9..cfca5ea9f2e9 (2 commits) (flutter/engine#14667)
2019-12-21 skia-flutter-autoroll@skia.org Roll src/third_party/skia 2723af6a6d43..6ec826085b2a (3 commits) (flutter/engine#14665)
2019-12-21 skia-flutter-autoroll@skia.org Roll src/third_party/dart c260e4e8dac6..1db1a837f8c9 (8 commits) (flutter/engine#14606)
2019-12-21 skia-flutter-autoroll@skia.org Roll src/third_party/skia 28b0c5d4b3bb..2723af6a6d43 (4 commits) (flutter/engine#14605)
2019-12-20 dnfield@google.com View ref pair (flutter/engine#14602)
2019-12-20 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from VC7eE... to IZ278... (flutter/engine#14603)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC cbracken@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
 2019-12-26 12:46:11 -05:00
Jonathan White
1fe05983e6 Fix typos in DefaultTabController.of documentation (#46907) 
Fix error in `DefaultTabController.of` documentation

Co-authored-by: Shi-Hao Hong <shihaohong@google.com>
 2019-12-26 09:45:25 -08:00
engine-flutter-autoroll
39c5f1ea29 Roll engine 33813929e3cd..42bb7c9eea9a (3 commits) (#47565) 
33813929e3...42bb7c9eea

git log 33813929e3cd..42bb7c9eea9a --first-parent --oneline
2019-12-20 50856934+nturgut@users.noreply.github.com [web] fix leaking problem in tests for text editing. (flutter/engine#14582)
2019-12-20 skia-flutter-autoroll@skia.org Roll src/third_party/dart 886615d0f95b..c260e4e8dac6 (15 commits) (flutter/engine#14601)
2019-12-20 skia-flutter-autoroll@skia.org Roll src/third_party/skia 088913a63b7e..28b0c5d4b3bb (17 commits) (flutter/engine#14600)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
 2019-12-26 11:07:08 -05:00
LongCatIsLooong
b7af5e714d Revert "Add brightness to CupertinoNavigationBar (fixes #46216) (#47521)" (#47805) 2019-12-25 23:49:55 -08:00
神楽坂花火
2cbf126fe8 Add brightness to CupertinoNavigationBar (fixes #46216) (#47521) 2019-12-25 21:54:12 -08:00
Shi-Hao Hong
6e72facad1 Fix Icon.color docs (#47691) 2019-12-24 10:54:04 -08:00
Jenn Magder
d874596e38 Remove package:flutter/foundation.dart import (#47701) 2019-12-23 16:16:43 -08:00
Francisco Magdaleno
e46671f323 Revert "Add visual density to the gallery options (#46090)"... (#47702) 
* Revert "Add visual density to the gallery options (#46090)"

This reverts commit 924efae96c.

* Revert "fix analysis (#47594)"

This reverts commit 49c7845907.
 2019-12-23 15:42:53 -08:00
Chen Yumin
0265cb6849 Make tab's icon margin configurable (Fix #47363) (#47364) 
Adds the `iconMargin` parameter to Tab
 2019-12-23 15:37:16 -08:00
Francisco Magdaleno
f2f9d0e4fd Revert "Flutter Web Driver Support (#47470)" (#47698) 
This reverts commit cc1c9649c4.
 2019-12-23 15:20:11 -08:00
Jenn Magder
9861a1c045 flutter build ios-framework generate Flutter.podspec (#47556) 2019-12-23 13:12:36 -08:00
Alexandre Ardhuin
4adad2c652 update list of lints (#47661) 2019-12-23 18:40:56 +01:00
Jim Graham
fcaf9c4070 Support for ImageFiltered widget to apply ImageFilter to children. (#47489) 2019-12-21 14:03:01 -08:00
Alexandre Ardhuin
49c7845907 fix analysis (#47594) 2019-12-21 20:53:14 +01:00
Greg Spencer
924efae96c Add visual density to the gallery options (#46090) 
This PR adds an option to the gallery options that sets the visual density to one of "standard" (the default), "comfortable", or "compact".
 2019-12-20 20:36:29 -08:00
Lau Ching Jun
ef398d9e87 Disable most screenshot tests for web until we understand the flakes. (#47554) 2019-12-20 18:43:01 -08:00
Jenn Magder
85e9be36bf Revert "Check Xcode build setting FULL_PRODUCT_NAME for the name of the built app during flutter run (#47266)" (#47568) 
This reverts commit 648a5d8a1e.
 2019-12-20 17:45:16 -08:00
Shi-Hao Hong
88cd1135bf Handle plural gen_l10n regular placeholders and DateTime placeholders (#47483) 
* Handle simple placeholders in plurals

* Handle Date plural placeholders

* Improve variable names

* Turn assert into exceptions, add tests
 2019-12-20 16:22:44 -08:00
engine-flutter-autoroll
0db0299907 Roll engine 854d5f8e9e74..33813929e3cd (10 commits) (#47549) 
* 399a29eed Roll src/third_party/dart 141fcfa61092..4681868aaf77 (9 commits) (flutter/engine#14590)

* 97fd705a4 Roll src/third_party/skia 7e2dea568299..dcac29b02d02 (3 commits) (flutter/engine#14591)

* 6d9288740 Roll src/third_party/dart 4681868aaf77..b92fefdfe971 (1 commits) (flutter/engine#14592)

* 4d7313ffc Roll fuchsia/sdk/core/mac-amd64 from f51Q_... to VC7eE... (flutter/engine#14593)

* fac66c28d [web] Long press fix on Safari on IOS (flutter/engine#14588)

* 32eb6e922 Roll src/third_party/skia dcac29b02d02..088913a63b7e (1 commits) (flutter/engine#14597)

* ede1b6b20 Roll fuchsia/sdk/core/linux-amd64 from 25LzW... to TUoVa... (flutter/engine#14596)

* cce5afd48 Roll src/third_party/dart b92fefdfe971..886615d0f95b (2 commits) (flutter/engine#14595)

* 9b299f2c2 fix editable placement in a11y mode (flutter/engine#14581)

* 33813929e [web] implement pushImageFilter (flutter/engine#14599)
 2019-12-20 16:12:30 -08:00
Greg Spencer
19b9206add Add variant testing to testWidgets (#45646) 
This adds the ability to define variants of tests with different environmental values for a particular testWidgets test.

This allows you to run the same test multiple times with a different test environment. One test variant has been implemented that allows running a test with different settings of the TargetPlatform.
 2019-12-20 15:00:16 -08:00
engine-flutter-autoroll
cb98f7222f Roll engine 472197a8e932..854d5f8e9e74 (20 commits) (#47503) 
* bb118c655 Roll src/third_party/dart 8d11c1dce64a..642f8d052fd7 (1 commits) (flutter/engine#14574)

* 09c434d26 Use ELF for Dart AOT snapshots on Fuchsia. (flutter/engine#13896)

* e1e78512a Roll fuchsia/sdk/core/linux-amd64 from VdBKA... to uFFWW... (flutter/engine#14575)

* f317f8f7f Roll src/third_party/skia c76ac8e325c7..77742c350371 (1 commits) (flutter/engine#14576)

* 2ba563336 instructions for running firefox/safari tests (flutter/engine#14562)

* 9cf1e46b9 Roll src/third_party/dart 642f8d052fd7..7113fc79a83c (3 commits) (flutter/engine#14578)

* f5b877af9 [web] Run engine tests on Safari locally by launching safari installed on MacOS (flutter/engine#14555)

* 68d919670 Fix DOM-based ParagraphRuler.hitTest() (flutter/engine#14504)

* bb65df884 Roll src/third_party/skia 77742c350371..a8352ccaae37 (8 commits) (flutter/engine#14579)

* ad1ab564b Roll src/third_party/dart 7113fc79a83c..e50d98cd5651 (8 commits) (flutter/engine#14580)

* 22413efc4 Update formatting in web_ui scene bulder to match flutter style and dartfmt. (flutter/engine#14539)

* 6e825e7bd Roll fuchsia/sdk/core/mac-amd64 from Ykb4b... to f51Q_... (flutter/engine#14584)

* 1d3bb8c27 Fix message_loop_fuchsia and thus enable fml_tests and flow_tests for Fuchsia (flutter/engine#14583)

* 1f7bb9d0c Wire up OpacityLayer to Scenic (flutter/engine#14577)

* 11db035ca Roll src/third_party/skia a8352ccaae37..87e9ddb675b6 (11 commits) (flutter/engine#14585)

* bd58af743 Roll src/third_party/dart e50d98cd5651..141fcfa61092 (3 commits) (flutter/engine#14586)

* 929b1edff Engine support for ImageFiltered widget (flutter/engine#14491)

* 40b84fc19 Fix lint warnings across web_ui, add missing browserEngine case in text field. (flutter/engine#14535)

* ea1d330d8 Roll fuchsia/sdk/core/linux-amd64 from uFFWW... to 25LzW... (flutter/engine#14587)

* 854d5f8e9 Roll src/third_party/skia 87e9ddb675b6..7e2dea568299 (1 commits) (flutter/engine#14589)
 2019-12-20 13:33:55 -08:00
gaaclarke
72a3d914ee Added a code sample for replacing the image cache. (#47467) 2019-12-20 08:50:42 -08:00
Dan Field
93f718b386 Fix requestExistingInputState response (#47472) 2019-12-20 03:33:01 -08:00
Angjie Li
cc1c9649c4 Flutter Web Driver Support (#47470) 2019-12-19 19:53:01 -08:00
Matt Sullivan
f6922d57fc Fixed incorrect offsetting when applying ShaderMasks (#45654) 2019-12-19 19:48:01 -08:00
engine-flutter-autoroll
275a2f133d Roll engine 0f90e6546bf3..472197a8e932 (3 commits) (#47442) 
* ffb497de2 Roll src/third_party/skia 9e0afb791ac2..c76ac8e325c7 (4 commits) (flutter/engine#14571)

* da08f4ce2 Roll src/third_party/dart aa6709974dea..8d11c1dce64a (2 commits) (flutter/engine#14572)

* 472197a8e Roll fuchsia/sdk/core/mac-amd64 from NHgyx... to Ykb4b... (flutter/engine#14573)
 2019-12-19 18:43:35 -08:00
LongCatIsLooong
e3c8ecaf7f Reland "Fix sliver geometry assert (#47027)" 2019-12-19 14:27:35 -08:00
Jenn Magder
648a5d8a1e Check Xcode build setting FULL_PRODUCT_NAME for the name of the built app during flutter run (#47266) 2019-12-19 14:18:10 -08:00
Dan Field
41a911099b comments (#47473) 2019-12-19 13:48:02 -08:00
Gary Qian
b011ea5468 Pass _caretPrototype to prevent cache miss (#46720) 2019-12-20 06:46:49 +09:00
Jonah Williams
3fe6668849 [flutter_tool] ensure extraGenSnapshotArguments are forwarded to gen_snapshot from Android builds (#47059) 2019-12-19 13:44:21 -08:00
Dan Field
4ad8271bf5 Reland text state (#47464) 2019-12-19 13:43:02 -08:00
Janice Collins
bd25f70c66 Upgrade dartdoc to 0.29.3. (#47246) 2019-12-19 09:45:02 -08:00
Justin McCandless
92c21a5701 Fix a typo in the docs (#47391) 
Just a docs text change.
 2019-12-19 09:40:01 -08:00