Commit Graph

33222 Commits

Author SHA1 Message Date
Sam Rawlins
e62abfae62 Remove unreachable_from_main linter rule (#120110)
* Remove unreachable_from_main linter rule

* Comment out

* Update analysis_options.yaml

---------

Co-authored-by: Michael Goderbauer <goderbauer@google.com>
2023-02-06 17:52:30 -08:00
Jenn Magder
e627e8d841 Force web_tool_tests to run on x64 builders (#120128) 2023-02-06 23:52:52 +00:00
Justin McCandless
575ced6c5a Fix context menu web examples (#120104)
The context menu examples on the docs site now work on the web.
2023-02-06 15:51:11 -08:00
林洵锋
ec524ed068 Fix flutter_tools stuck when using custom LLDB prompt (#119443)
* Fix flutter_tools stuck when using custom LLDB prompt

* Remove trailing space character

* Fix local variable name

* Add comment

* Remove trailing space character

* Update packages/flutter_tools/lib/src/ios/ios_deploy.dart

Co-authored-by: Jenn Magder <magder@google.com>

* Update packages/flutter_tools/lib/src/ios/ios_deploy.dart

Co-authored-by: Jenn Magder <magder@google.com>

* Remove trailing space character

---------

Co-authored-by: Jenn Magder <magder@google.com>
2023-02-06 22:50:07 +00:00
Haroon Awan
40b5e4cb5e Added "insertAll" and "removeAll" methods to AnimatedList (#115545)
* Added "insertAll" and "removeAll" method to AnimatedList

* Fixed doc

* Changes in documentation asked by reviewwer

* Removed unnecessary asserts.

* Doc changes asked by reviewer.

* Doc changes.

---------

Co-authored-by: Rashid Khabeer <rkhabeer84@gmail.com>
2023-02-06 16:45:39 +00:00
engine-flutter-autoroll
7bf1e99ea8 Roll Plugins from 9302d87ee545 to d065e4e0a82a (6 revisions) (#120084)
* 97a05241e [camera_android] Default to legacy recording profile when EncoderProfiles unavailable (flutter/plugins#7073)

* a59517a03 Roll Flutter from d278808014 to c5e8757fcb (54 revisions) (flutter/plugins#7092)

* bde2ff0d7 Roll Flutter (stable) from b06b8b271095 to 7048ed95a5ad (5 revisions) (flutter/plugins#7091)

* 1e58ab0f0 [in_app_pur]: Bump billing from 5.0.0 to 5.1.0 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/plugins#6701)

* a5f40d751 Roll Flutter from c5e8757fcb to b8f5394a5c (22 revisions) (flutter/plugins#7105)

* d065e4e0a [gh_actions]: Bump actions/upload-artifact from 3.1.1 to 3.1.2 (flutter/plugins#6936)
2023-02-06 15:51:51 +00:00
stuartmorgan
1bec87b4a1 Update Android TESTOWNERS (#119960)
Updates the tests that were passed temporarily to me in #109717 to
@reidbaker
2023-02-06 15:51:47 +00:00
Eilidh Southren
3c3c9a1bd9 [M3] Add ListTile's iconColor property support for icon buttons (#120075)
* add icon button property override

* list tile changes

* add imports

* add newlines

* whitespace
2023-02-06 14:39:14 +00:00
Ben Konyi
47a0674651 Reland "Add --serve-observatory flag to run, attach, and test (#118402)" (#119737)
This reverts commit 254a796bc3.
2023-02-06 09:23:35 -05:00
Taha Tesser
bbca7ff693 Add Material 3 SwitchListTile example and update existing examples (#119714)
* Add Material 3 `SwitchListTile` example and update existing examples

* Update examples with `useMaterial3: true` and update example descriptions.

* add a `ColorScheme` colour
2023-02-06 09:02:37 +00:00
Christopher Fujino
b8f5394a5c [flutter_tools] Fix Future error handling ArgumentError in doctor --android-licenses (#119977)
* wip

* write test

* make error handling printError

* remove diff
2023-02-05 07:06:19 +00:00
engine-flutter-autoroll
2e39badf98 Roll Flutter Engine from 6bd500c38ea8 to 2a104cdfcdf8 (2 revisions) (#120022)
* 65678e026 Roll Fuchsia Linux SDK from D0jJKibnSzSOs68QJ... to Z6Bdg2fbH4n5ptsKZ... (flutter/engine#39393)

* 2a104cdfc Roll Skia from 8de8c6287254 to 45a4fdcc0cb0 (1 revision) (flutter/engine#39394)
2023-02-05 07:04:10 +00:00
engine-flutter-autoroll
5187b45e4d Roll Flutter Engine from c7a4bbab0e75 to 6bd500c38ea8 (2 revisions) (#120018)
* f2d3dbda0 Roll Fuchsia Linux SDK from y0pMcSL4ejAh7JYTq... to D0jJKibnSzSOs68QJ... (flutter/engine#39386)

* 6bd500c38 Roll Fuchsia Mac SDK from hcZFTTKMN0k4lXjfs... to j6dhXDhI_KUUyqTSF... (flutter/engine#39390)
2023-02-05 00:24:12 +00:00
Brandon DeRosier
f10e625eb2 De-flake adapter integration test (#120016) 2023-02-04 15:29:59 -08:00
engine-flutter-autoroll
61f6a0bcd4 Roll Flutter Engine from 1b132e44194d to c7a4bbab0e75 (6 revisions) (#119990)
* 49f2d98d2 Roll Skia from f083b79aa388 to 5d8a7ed8acfe (3 revisions) (flutter/engine#39381)

* 88fda68f4 Roll Skia from 5d8a7ed8acfe to 8de8c6287254 (1 revision) (flutter/engine#39382)

* 23f53e5ef [fuchsia] Add output_path property to customize output path of .so files (flutter/engine#39007)

* 87ed27470 Roll Fuchsia Mac SDK from _6bmpi47oMZC-msOI... to hcZFTTKMN0k4lXjfs... (flutter/engine#39384)

* d3edcc985 Roll Dart SDK from de912d108ebb to a507a9057730 (2 revisions) (flutter/engine#39385)

* c7a4bbab0 [Impeller] Make text appear less emboldened (flutter/engine#39383)
2023-02-04 08:08:35 +00:00
engine-flutter-autoroll
5241d38fae Roll Flutter Engine from e1b265bb52aa to 1b132e44194d (8 revisions) (#119980)
* 2ddbff9b6 [Impeller] Append to existing atlas if room exists, reuse texture (flutter/engine#38253)

* 9dd2e9c98 [fuchsia] fdio_service_connect no longer provides rights which we need (flutter/engine#39374)

* 9dde1563c [impeller] drawVertices blend mode (flutter/engine#38985)

* 18750d245 [ios] Lock refresh rate to 80fps when threads are merged (flutter/engine#39172)

* fe259c2ba Roll Skia from 83a3d8b16c94 to f083b79aa388 (5 revisions) (flutter/engine#39376)

* 4fdbb0a36 [Impeller] Retain embolden/skew font properties when rendering text glyphs (flutter/engine#39378)

* 868234df1 Roll Dart SDK from b7a0c75d4470 to de912d108ebb (1 revision) (flutter/engine#39379)

* 1b132e441 [iOS] Ensure FlutterView's background color is not nil to avoid CAMetalLayer nextDrawable being time-consuming (flutter/engine#39359)
2023-02-04 03:32:28 +00:00
godofredoc
c8e75a8dff Do not run customer testing on release candidate branches. (#119979)
These tests try to use a commit contemporary to the framework commit in
customer repositories. This won't work because a CP to the framework
release candidate branch may be recent even though the release candidate
branch can be months old.
2023-02-04 03:32:26 +00:00
godofredoc
f7c2bd05f0 Revert "Fix unable to find bundled Java version (#119244)" (#119981)
This reverts commit 57fd50f84e.
2023-02-04 02:57:53 +00:00
crasowas
57fd50f84e Fix unable to find bundled Java version (#119244) 2023-02-03 18:04:04 -08:00
Jenn Magder
909dc30090 Verify Mac artifact codesigning on x64 and arm64 (#119971)
* Verify Mac artifact codesigning on x64 and arm64

* mac_arm64
2023-02-04 01:52:05 +00:00
engine-flutter-autoroll
0fbef46932 e1b265bb5 Roll Skia from 07a95bb37760 to 83a3d8b16c94 (5 revisions) (flutter/engine#39373) (#119967) 2023-02-03 23:31:03 +00:00
Jenn Magder
c24904ddee Run macOS benchmarks in prod pool to upload metrics (#119963) 2023-02-03 22:38:53 +00:00
Jenn Magder
c52215e935 Run Mac hostonly tests on any available arch (#119884)
* Run Mac hostonly tests on any available arch

* Exception for framework tests
2023-02-03 22:37:48 +00:00
Callum Moffat
3f02d4b4c3 Tweak to floating-cursor-end behaviour (#119893)
* Tweak to floating-cursor-end behaviour

* Simplify
2023-02-03 22:29:00 +00:00
Jenn Magder
51b05ac7e1 Add mac_benchmark ci.yaml property (#119871)
* Add mac_benchmark ci.yaml property

* Remove presubmit

* Bringup

* Comma

* gems

* Test animated_complex_opacity_perf_macos__e2e_summary in presubmit

* Try top-level mac_model

* Move dependencies back into tasks

* Add signing dependency

* Revert animated_complex_opacity_perf_macos__e2e_summary test
2023-02-03 21:36:48 +00:00
engine-flutter-autoroll
16f81e6561 Roll Flutter Engine from 33d932efc68e to 110c643d6ac2 (3 revisions) (#119957)
* 7e7a8a8b0 [impellerc] sort uniforms on metal backend  (flutter/engine#39366)

* 16617b0a9 Roll Fuchsia Linux SDK from CAyoT0SrHHyXCMF31... to y0pMcSL4ejAh7JYTq... (flutter/engine#39371)

* 110c643d6 Roll Skia from 62dcca5b175a to 07a95bb37760 (10 revisions) (flutter/engine#39369)
2023-02-03 13:27:10 -08:00
Christopher Fujino
9a7e18701e [flutter_tools] fix Cannot delete file ENOENT from fuchsia_asset_builder (#119867)
* fix

* add test
2023-02-03 19:24:41 +00:00
engine-flutter-autoroll
be4c8c0eb1 33d932efc Add gen_snapshot to windows flutter artifact. (flutter/engine#39353) (#119951) 2023-02-03 19:12:54 +00:00
engine-flutter-autoroll
b65ae62cf4 Roll Flutter Engine from c39047ffb2a6 to 745d7efb5736 (3 revisions) (#119943)
* 90427769f Fire UIA event on Checkbox state change (flutter/engine#39346)

* dae0ebd00 Roll Dart SDK from be795cc64bd7 to b7a0c75d4470 (1 revision) (flutter/engine#39363)

* 745d7efb5 Roll Fuchsia Mac SDK from 2xyEsodtHgcamPwX4... to _6bmpi47oMZC-msOI... (flutter/engine#39364)
2023-02-03 18:26:08 +00:00
Justin McCandless
00b0d550c6 Fix iOS context menu position when flipped below (#119565)
* Fix anchorBelow calculation, and share toolbar padding constant

* Fix constant references in test

* Test below position when padding is not offset by content distance
2023-02-03 18:14:59 +00:00
engine-flutter-autoroll
96c8c69741 Roll Flutter Engine from 0fb48ce5b118 to c39047ffb2a6 (2 revisions) (#119939)
* 2e1c10382 Roll Skia from ee68f3edfa96 to 62dcca5b175a (1 revision) (flutter/engine#39362)

* c39047ffb Roll buildroot to 39b486f7 (flutter/engine#39361)
2023-02-03 17:37:02 +00:00
Taha Tesser
7177c413a9 Add Material 3 RadioListTile example and update existing examples (#119716)
* Add Material 3 `RadioListTile` example and update existing examples

* Update examples with `useMaterial3: true` and update example descriptions.

* add a `ColorScheme` colour
2023-02-03 16:27:43 +00:00
Eilidh Southren
c5e8757fcb Add M3 support for iconbuttons in error state in TextFields (#119925)
* add m3 iconbutton override

* changes

* spring cleaning

* whitespace fix

* sneaky whitespaces
2023-02-03 14:35:12 +00:00
Polina Cherkasova
e0b2138ba7 Dispose OverlayEntry in TooltipState. (#117291) 2023-02-03 06:31:47 -08:00
engine-flutter-autoroll
fc8ea5620c 0fb48ce5b Roll Dart SDK from 69452c5012d9 to be795cc64bd7 (1 revision) (flutter/engine#39360) (#119926) 2023-02-03 13:54:27 +00:00
engine-flutter-autoroll
a5d8a4a727 67d35267c [Impeller] Use minimal coverage for stencil restores after overdraw prevention (flutter/engine#39358) (#119910) 2023-02-03 10:07:21 +00:00
engine-flutter-autoroll
6b83eff56f Roll Flutter Engine from e3fe6dade964 to 655530e3fd15 (5 revisions) (#119905)
* 7422df491 [impellerc] sort uniforms on metal backend (flutter/engine#39345)

* d94924742 Roll Fuchsia Linux SDK from pWloCaRzjLEAUvQEz... to CAyoT0SrHHyXCMF31... (flutter/engine#39354)

* f4fbbe38c Roll Skia from a4079ec4c399 to ee68f3edfa96 (1 revision) (flutter/engine#39355)

* 6425ae2b5 Revert "[impellerc] sort uniforms on metal backend (#39345)" (flutter/engine#39356)

* 655530e3f Roll Dart SDK from 283b05994d68 to 69452c5012d9 (1 revision) (flutter/engine#39357)
2023-02-03 08:15:16 +00:00
Jonah Williams
69421c1682 [framework] use shader tiling instead of repeated calls to drawImage (#119495)
* [framework] use shader tiling instead of repeated calls to drawImage

* ++

* ++

* review and test updates

* ++

* Update decoration_image.dart

* Update decoration_image.dart

* ++

* ++

* ++

* ++

* ++

* Update painting.dart

* Update decoration_test.dart
2023-02-03 07:28:57 +00:00
engine-flutter-autoroll
f3effce630 Roll Flutter Engine from 2696fff8716d to e3fe6dade964 (3 revisions) (#119892)
* a2f53699c Roll Dart SDK from 73b03bb636d3 to 283b05994d68 (2 revisions) (flutter/engine#39349)

* 0e38e5304 Roll Skia from 4f0166baf5a4 to a4079ec4c399 (1 revision) (flutter/engine#39351)

* e3fe6dade Roll Fuchsia Mac SDK from rqjJA8z_K0gdGcsvA... to 2xyEsodtHgcamPwX4... (flutter/engine#39352)
2023-02-03 05:07:10 +00:00
engine-flutter-autoroll
bc45b18589 2696fff87 Roll Skia from c2d81db3ef41 to 4f0166baf5a4 (13 revisions) (flutter/engine#39348) (#119879) 2023-02-03 02:37:03 +00:00
Kate Lovett
3570cce58e Remove deprecated kind in GestureRecognizer et al (#119572)
* Remove deprecated kind in GestureRecognizer et al

* Fix null case
2023-02-03 01:34:17 +00:00
Kevin Moore
a27802e2db flutter_tool: remove explicit length header in HTTP response (#119869)
This is already handled by pkg:shelf
There is some subtlety with String here, since String.length might not
align with the size in bytes over the wire, depending on the contents
and the encoding

Best to just let pkg:shelf handle it
2023-02-03 01:27:23 +00:00
Greg Spencer
c6264605d9 Make _focusDebug not interpolate in debug mode (#119680)
* Make _focusDebug not interpolate in debug mode

* Add test

* Revert undesired change

* Fix test to fail before too

* Remove accidental skips

* Switch to using a generating closure for arguments.

* Remove a word
2023-02-03 01:27:20 +00:00
engine-flutter-autoroll
66b2ca6383 Roll Flutter Engine from 616ecd8be3de to 2871970337df (3 revisions) (#119870)
* a77e7bcb9 [web] Update the within() matcher to be more useful (flutter/engine#39288)

* dbf401f97 [Impeller] Don't ceil subpass texture sizes (flutter/engine#39336)

* 287197033 Bump ninja version to 1.11.1 (flutter/engine#39347)
2023-02-03 00:55:07 +00:00
Jessica Pereira
9b86a4853e Fix gets removedItem instead of its index (#119638)
* fix: gets removedItem instead of its index
add: sliver_animated_list.0_test.dart

* fix: sliver_animated_list.0_test.dart

* fix: pr comments

* fix test import

Co-authored-by: Taha Tesser <tessertaha@gmail.com>

---------

Co-authored-by: Taha Tesser <tessertaha@gmail.com>
2023-02-03 00:15:58 +00:00
Jenn Magder
d875899a65 Bump test Chrome version for Mac arm support (#119773) 2023-02-03 00:14:42 +00:00
Flutter GitHub Bot
cfdc35859e roll packages (#119865) 2023-02-02 23:59:49 +00:00
engine-flutter-autoroll
72f9cf5487 Roll Flutter Engine from ae38c9585a61 to 616ecd8be3de (3 revisions) (#119859)
* 510ecfa93 Don't rely on timings for dimension_provider unit test. (flutter/engine#39343)

* b1ccae745 Roll Skia from 60242c4ea6a7 to c2d81db3ef41 (5 revisions) (flutter/engine#39344)

* 616ecd8be [Web][HTML] Add mirrored characters support for RTL languages (flutter/engine#39162)
2023-02-02 23:08:27 +00:00
Christopher Fujino
d820aec786 Manual pub roll with dwds fix (#119575)
* roll packages

* fix dwds

* empty

---------

Co-authored-by: fluttergithubbot <fluttergithubbot@gmail.com>
2023-02-02 21:38:08 +00:00
Danny Tuppeny
8387c2388b [flutter_tools] Use base DAP detach and ensure correct output (#119076) 2023-02-02 13:28:12 -08:00