Commit Graph

42062 Commits

Author SHA1 Message Date
Michael Goderbauer
d9dbefc949 fix some unintended HTML tags in docs (#153507)
I used the `unintended_html_in_doc_comment` to find these, but sadly the lint is not ready to be enabled yet due to https://github.com/dart-lang/linter/issues/5065.
2024-08-16 23:17:14 +00:00
engine-flutter-autoroll
887afe2adf Roll Flutter Engine from b66893e1fb7e to acb71d8307fa (1 revision) (#153600)
b66893e1fb...acb71d8307

2024-08-16 lhkbob@gmail.com Remove SkOSLibrary files from build and license scripts (flutter/engine#54583)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-16 22:26:55 +00:00
engine-flutter-autoroll
8817d45220 Roll Flutter Engine from d5bf3afc601f to b66893e1fb7e (2 revisions) (#153582)
d5bf3afc60...b66893e1fb

2024-08-16 chris@bracken.jp iOS: Add dSYM binaries to without_entitlements.txt (flutter/engine#54576)
2024-08-16 kevinjchisholm@gmail.com Manual roll Dart SDK from 44635f897535 to 8c02ad43e01a (3 revisions)  (flutter/engine#54581)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-16 18:21:23 +00:00
chunhtai
9e91307947 Update README.md (#153470)
*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*

*List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.*

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2024-08-16 17:57:26 +00:00
chunhtai
5fdc911135 adds team-accessibility to triage workflow (#153575)
add team-accessibility to triage workflow
2024-08-16 17:19:06 +00:00
Andrew Kolos
080928dda3 add HttpException to the list of handled exceptions within ResidentWebRunner::run (#153527)
Resolves https://github.com/flutter/flutter/issues/153298, a major crasher of the flutter tool. I plan on cherry-picking this change.

In `ResidentWebRunner::run`, many connection-related exceptions are caught, logged, and have `ToolExit`s thrown in their place ([code](d23be7a07d/packages/flutter_tools/lib/src/isolated/resident_web_runner.dart (L370-L385)), [PR that introduced this](https://github.com/flutter/flutter/pull/50895)). However, `HttpException` is not included in this list. See https://github.com/flutter/flutter/issues/153298#issuecomment-2290900158 for details if interested.
2024-08-16 16:40:19 +00:00
Nate Wilson
a0c04534f5 Style Guide updates (#152525)
This pull request updates the style guide for improved internal consistency and to match current linter rules.

I'll make comments for each change here!
2024-08-16 16:19:06 +00:00
engine-flutter-autoroll
febf4cdc8c Roll Packages from 86d15a65d091 to 2c37fb052cd4 (5 revisions) (#153571)
86d15a65d0...2c37fb052c

2024-08-16 engine-flutter-autoroll@skia.org Manual roll Flutter from 99f00a1309 to bced008679 (13 revisions) (flutter/packages#7424)
2024-08-16 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads] Adds IMA plugin to labeler yaml (flutter/packages#7420)
2024-08-15 matanlurey@users.noreply.github.com Roll `avd_cipd_verison` to latest to use the `crashreport` tool. (flutter/packages#7422)
2024-08-15 mhvdijk@gmail.com [flutter_adaptive_scaffold] Add breakpoint extension to get the current active breakpoint (flutter/packages#7347)
2024-08-15 engine-flutter-autoroll@skia.org Roll Flutter from cc13cd1f11 to 99f00a1309 (24 revisions) (flutter/packages#7419)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-16 16:15:19 +00:00
Zachary Anderson
69ff9eae7b Move Android API level 35 emulator tests to staging (#153568)
These same tests but running against API level 34 emulators are remaining as presubmit tests. The API level 35 tests should stay in staging while the emulator stabilizes. So we can collect flake data and continue to debug. 

Related: https://github.com/flutter/flutter/issues/153445
2024-08-16 15:43:13 +00:00
engine-flutter-autoroll
19fdece6c1 Roll Flutter Engine from a8fefc81188e to d5bf3afc601f (2 revisions) (#153565)
a8fefc8118...d5bf3afc60

2024-08-16 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Manual roll Dart SDK from 44635f897535 to 790fcb755a0a (3 revisions) (#54558)" (flutter/engine#54578)
2024-08-16 skia-flutter-autoroll@skia.org Manual roll Dart SDK from 44635f897535 to 790fcb755a0a (3 revisions) (flutter/engine#54558)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-16 15:11:37 +00:00
Loïc Sharma
15876ff6ea [Swift Package Manager] Test removing the last Flutter plugin (#153519)
The Flutter tool has a bug where removing the last Flutter plugin does not correctly update the CocoaPods integration.

This adds a test to ensure  that the generated Swift package is properly updated when the last Flutter plugin is removed.

See: https://github.com/flutter/flutter/issues/11819#issuecomment-2289782626
2024-08-16 14:03:13 +00:00
engine-flutter-autoroll
bced008679 Roll Flutter Engine from 68938abd03b9 to a8fefc81188e (1 revision) (#153537)
68938abd03...a8fefc8118

2024-08-15 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from qpfC-GAVZvOwAQU5f... to Z5hq3ZkPNCpZWRQnl... (flutter/engine#54574)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from qpfC-GAVZvOw to Z5hq3ZkPNCpZ

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-16 02:29:24 +00:00
Maurice Parrish
16dae5b3bf [interactive_media_ads] Adds missing IMA plugin to issue template (#153510) 2024-08-16 02:05:33 +00:00
engine-flutter-autoroll
b96adb1e97 Roll Flutter Engine from 65fd6ca194c1 to 68938abd03b9 (1 revision) (#153533)
65fd6ca194...68938abd03

2024-08-15 jonahwilliams@google.com [Impeller] add support for superellipse. (flutter/engine#54562)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-16 01:36:25 +00:00
engine-flutter-autoroll
ba31bf8c0e Roll Flutter Engine from 8f3f80ec1225 to 65fd6ca194c1 (1 revision) (#153529)
8f3f80ec12...65fd6ca194

2024-08-15 1961493+harryterkelsen@users.noreply.github.com [canvaskit] Improve how overlays are optimized (flutter/engine#54547)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-16 00:34:39 +00:00
engine-flutter-autoroll
f825a75631 Manual roll Flutter Engine from 971ddd9fe1bf to 8f3f80ec1225 (5 revisions) (#153525)
Manual roll requested by zra@google.com

971ddd9fe1...8f3f80ec12

2024-08-15 jonahwilliams@google.com [Impeller] revert experimental canvas. (flutter/engine#54570)
2024-08-15 69794332+smart7even@users.noreply.github.com Fix typo in AppLifecycleState documentation (flutter/engine#54544)
2024-08-15 codefu@google.com Update RBE troubleshooting (flutter/engine#54568)
2024-08-15 jonahwilliams@google.com [Impeller] Switch from AIKS canvas to DL based canvas implementation. (flutter/engine#53781)
2024-08-15 jonahwilliams@google.com [Impeller] convert aiks blur tests to new canvas. (flutter/engine#54565)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-15 23:04:09 +00:00
Joe Kawai
5d59f8bb1a Add TextHeightBehavior argument for DefaultTextStyle.merge (#153178)
Addresses an issue where `DefaultTextStyle.merge` is missing the `textHeightBehavior` argument. The argument is present in the `DefaultTextStyle` constructor.

Resolves #120176
2024-08-15 23:00:15 +00:00
RamonFarizel
81ee230f49 Update TextTheme with the M3 Typography tokens (#153131)
This PR adds a new table with[ Material 3 typography tokens](https://m3.material.io/styles/typography/type-scale-tokens).

Issue:
https://github.com/flutter/flutter/issues/148429
2024-08-15 22:48:58 +00:00
Justin McCandless
73c9e4e578 Design-Documents.md incorrect link (#153509)
Fixed an incorrect link. I think it was accidentally pasted twice.
2024-08-15 22:02:00 +00:00
Matan Lurey
af815f0d9b Roll avd_cipd_verison to latest to use the crashreport tool. (#153520)
Work towards https://github.com/flutter/flutter/issues/153445.

I can do a similar set of PRs on flutter/packages and flutter/engine for consistency.

/cc @johnmccutchan @reidbaker @zanderso
2024-08-15 21:58:31 +00:00
Greg Spencer
1633c47dda Improve asserts on Element.mount (#153477)
## Description

In debugging an issue with mount, I hit one of these asserts, and I thought it would be a much better assert with some context.

## Tests
 - No test changes because the change is only to the output string of an assert.
2024-08-15 21:30:03 +00:00
Bernardo Ferrari
ce63c029c5 Fix anti-aliasing when painting borders with solid colors. (#153365)
Trying to reland https://github.com/flutter/flutter/pull/122317 in 2024. Let's see if we can.

<img width="666" alt="image" src="https://user-images.githubusercontent.com/351125/182002867-03d55bbb-163d-48b9-ba3c-ed32dbef2680.png">

Side effect: shapes with border will be rounder:
![Frame 6](https://github.com/user-attachments/assets/95324ebc-8db5-4365-817f-bc62304b9044)

Close https://github.com/flutter/flutter/issues/13675.
2024-08-15 19:02:23 +00:00
flutter-pub-roller-bot
70460854d1 Roll pub packages (#153479)
This PR was generated by `flutter update-packages --force-upgrade`.
2024-08-15 16:39:28 +00:00
engine-flutter-autoroll
ea87865364 Roll Packages from e4f2247c3f41 to 86d15a65d091 (7 revisions) (#153499)
e4f2247c3f...86d15a65d0

2024-08-15 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.26.0 to 3.26.2 (flutter/packages#7417)
2024-08-15 tarrinneal@gmail.com [shared_preferences] remove testing section from README (flutter/packages#7410)
2024-08-13 nathan.wilson1232@gmail.com Fix breakages introduced by `SplashFactory` (flutter/packages#6952)
2024-08-13 engine-flutter-autoroll@skia.org Manual roll Flutter from 2afc452d3a to cc13cd1f11 (6 revisions) (flutter/packages#7404)
2024-08-13 109111084+yaakovschectman@users.noreply.github.com [google_maps_flutter_android] Convert Circle and Marker to Pigeon (flutter/packages#7326)
2024-08-13 49699333+dependabot[bot]@users.noreply.github.com [in_app_pur]: Bump androidx.annotation:annotation from 1.8.1 to 1.8.2 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/packages#7379)
2024-08-13 49699333+dependabot[bot]@users.noreply.github.com [file_selector]: Bump androidx.annotation:annotation from 1.8.1 to 1.8.2 in /packages/file_selector/file_selector_android/android (flutter/packages#7381)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-15 15:49:24 +00:00
engine-flutter-autoroll
99f00a1309 Roll Flutter Engine from 76a1c64f4e63 to 971ddd9fe1bf (6 revisions) (#153487)
76a1c64f4e...971ddd9fe1

2024-08-15 98614782+auto-submit[bot]@users.noreply.github.com Reverts "macOS: Refactor create_macos_framework.py (#54557)" (flutter/engine#54566)
2024-08-15 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] migrate blur tests to display list. (#54519)" (flutter/engine#54564)
2024-08-15 jonahwilliams@google.com [Impeller] migrate blur tests to display list. (flutter/engine#54519)
2024-08-14 skia-flutter-autoroll@skia.org Roll Fuchsia Test Scripts from J1EXQ2ozMIQEa6F7H... to -XDS8eBA0Le-zCEfW... (flutter/engine#54561)
2024-08-14 chris@bracken.jp macOS: Refactor create_macos_framework.py (flutter/engine#54557)
2024-08-14 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from MeV5i7xXXFPHF5sBK... to qpfC-GAVZvOwAQU5f... (flutter/engine#54559)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from MeV5i7xXXFPH to qpfC-GAVZvOw

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-15 07:00:25 +00:00
Qun Cheng
108a355453 Update tokens to 5.0.0 (#153385)
This PR is to
* Update the Material Design tokens to 5.0.0
* 4 color roles in **Light mode** have different default values
   `onPrimaryContainer`: Primary10  -> Primary30 
   `onSecondaryContainer`: Secondary10 -> Secondary30
   `onTertiaryContainer`: Tertiary10 -> Tertiary30
   `onErrorContainer`: Error10 -> Error30
    
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;![Screenshot 2024-08-13 at 12 53 03 PM](https://github.com/user-attachments/assets/bfa863d9-03d3-4557-8676-d56febdb2be5)

* new tokens added in list.json
* `md.comp.menu.list-item.*` tokens are deprecated and should be replaced by tokens in list.json and we've done the migration last year:)!(#122388)
2024-08-14 22:53:36 +00:00
dependabot[bot]
b4b8f07124 Bump github/codeql-action from 3.26.1 to 3.26.2 (#153468)
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.26.1 to 3.26.2.
<details>
<summary>Commits</summary>
<ul>
<li><a href="429e197704"><code>429e197</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2425">#2425</a> from github/update-v3.26.2-a93f8c2fd</li>
<li><a href="9eec338902"><code>9eec338</code></a> Update changelog for v3.26.2</li>
<li><a href="a93f8c2fd1"><code>a93f8c2</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2423">#2423</a> from github/mergeback/v3.26.1-to-main-29d86d22</li>
<li><a href="af1f2e89e3"><code>af1f2e8</code></a> Address incorrect CHANGELOG.md</li>
<li><a href="2bc3b8381e"><code>2bc3b83</code></a> Update checked-in dependencies</li>
<li><a href="dd9700c166"><code>dd9700c</code></a> Reapply &quot;Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2417">#2417</a> from github/update-bundle/codeql-bundle-v2....</li>
<li><a href="ece28a826b"><code>ece28a8</code></a> Update changelog and version after v3.26.1</li>
<li>See full diff in <a href="29d86d22a3...429e197704">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github/codeql-action&package-manager=github_actions&previous-version=3.26.1&new-version=3.26.2)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>
2024-08-14 22:19:04 +00:00
Michael Goderbauer
4b60bb530f Enable invalid_runtime_check_with_js_interop_types, use_truncating_division (#153464)
invalid_runtime_check_with_js_interop_types has been added to recommended: 894b5006c4
2024-08-14 22:10:21 +00:00
engine-flutter-autoroll
fafe3df405 Roll Flutter Engine from 9b8421662ec9 to 76a1c64f4e63 (1 revision) (#153465)
9b8421662e...76a1c64f4e

2024-08-14 chris@bracken.jp macOS: Clean up create_macos_framework.py (#54543) (flutter/engine#54555)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-14 22:06:16 +00:00
engine-flutter-autoroll
bd083887a4 Roll Flutter Engine from 328c4df8329f to 9b8421662ec9 (1 revision) (#153463)
328c4df832...9b8421662e

2024-08-14 jonnywang@google.com [fuchsia] Use Fuchsia API 22 (flutter/engine#54554)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-14 21:12:18 +00:00
Michael Goderbauer
6289944ed6 Lint sync (#153453)
Just syncs our analysis_options.yaml with https://github.com/dart-lang/sdk/blob/main/pkg/linter/example/all.yaml. This is a no-op.
2024-08-14 21:12:15 +00:00
Michael Goderbauer
2a4e004bc0 manual pub roll w/ gradle updates (#153403)
Follow-up to https://github.com/flutter/flutter/pull/153388.
2024-08-14 21:06:11 +00:00
Camille Simon
f697d61025 Update docs to use new Android version in the engine (#151601)
Updates the steps based on what I found by working on https://github.com/flutter/engine/pull/54186 and https://github.com/flutter/engine/pull/53574 + general cleanup.
2024-08-14 19:57:07 +00:00
Christopher Fujino
5eca44a1c4 move some tool TESTOWNERS entries to andrew (#153400) 2024-08-14 19:38:02 +00:00
Denis Bowen
51c640297f Slider shows visual label of value on focus (#152960)
Fixed issue to where value indicator label is not shown to user when initially focused.

Before:  [Screen recording 2024-08-05 12.16.24 PM.webm](https://github.com/user-attachments/assets/806e94d7-7c6c-40e5-93af-dbf2fb9e0dd4)
After: https://screencast.googleplex.com/cast/NTY5NzIzMTYxNjIxMjk5MnxkY2IyMGNkYi1iZA

Fixes https://github.com/flutter/flutter/issues/113538
2024-08-14 18:27:14 +00:00
Taha Tesser
ed40925bb1 Add Row and Column widgets specific spacing tests (#153353)
Fixes [Missing `Row` and `Column` widgets specific `spacing` tests](https://github.com/flutter/flutter/issues/153352)
2024-08-14 18:19:17 +00:00
PurplePolyhedron
b5847d364a Delay DropdownMenu filtering until text input (#152368)
fixes https://github.com/flutter/flutter/issues/152055

Disabling filtering in `DropdownMenu` at start and after a selection has been made, and re-enable it (if `widget.enableFilter` is true) after text input.
This way it doesn't hide all other options when there is an existing selection.

Note: currently this may crush due to issue https://github.com/flutter/flutter/issues/151878 . Which is not directly related to this PR
2024-08-14 18:06:14 +00:00
Loïc Sharma
6ef1156f7e Update cherry pick issue template's PR field (#153381)
Make it even more obvious which PR should be linked for folks that have difficulties reading ðŸ˜
2024-08-14 17:11:33 +00:00
engine-flutter-autoroll
0e6c1d1015 Roll Flutter Engine from 5909666fdedb to 328c4df8329f (1 revision) (#153436)
5909666fde...328c4df832

2024-08-14 skia-flutter-autoroll@skia.org Roll Fuchsia Test Scripts from Kq699Ii76C_pozQ9Y... to J1EXQ2ozMIQEa6F7H... (flutter/engine#54551)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-14 14:01:40 +00:00
Martin Kustermann
354902f7ca [web] Pass --no-source-maps instead of --extra-compiler-option=--no-source-maps to dart compile wasm (#153417) 2024-08-14 12:00:24 +02:00
engine-flutter-autoroll
92c98e80ff Manual roll Flutter Engine from 019f9e3f0744 to 5909666fdedb (12 revisions) (#153413)
Manual roll requested by zra@google.com

019f9e3f07...5909666fde

2024-08-14 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Dart SDK from 44635f897535 to 733062367c2e (1 revision) (#54541)" (flutter/engine#54552)
2024-08-14 98614782+auto-submit[bot]@users.noreply.github.com Reverts "macOS: Clean up create_ios_framework.py (#54543)" (flutter/engine#54550)
2024-08-14 98614782+auto-submit[bot]@users.noreply.github.com Reverts "macOS: refactor create_macos_framework.py (#54546)" (flutter/engine#54549)
2024-08-14 chris@bracken.jp macOS: refactor create_macos_framework.py (flutter/engine#54546)
2024-08-13 flar@google.com [DisplayList] Allow random access to ops through indexing (flutter/engine#54484)
2024-08-13 mit@google.com Update dartdoc for gpu.dart (flutter/engine#54529)
2024-08-13 chris@bracken.jp macOS: Clean up create_ios_framework.py (flutter/engine#54543)
2024-08-13 skia-flutter-autoroll@skia.org Roll Dart SDK from 44635f897535 to 733062367c2e (1 revision) (flutter/engine#54541)
2024-08-13 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 2LTVy4Gv76DcMpz4V... to MeV5i7xXXFPHF5sBK... (flutter/engine#54542)
2024-08-13 1961493+harryterkelsen@users.noreply.github.com [canvaskit] Add animation detection for GIFs (flutter/engine#54483)
2024-08-13 matej.knopp@gmail.com Preserve background frame damage (flutter/engine#54540)
2024-08-13 68449066+zijiehe-google-com@users.noreply.github.com [fuchsia] Use BundledTestRunner from test-scripts (flutter/engine#54404)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from 2LTVy4Gv76Dc to MeV5i7xXXFPH

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-14 07:20:39 +00:00
PurplePolyhedron
593729165d Move @_debugOnly documentation in framework.dart to be more visible to IDE. (#153134)
Change the location of the documentation of `@_debugOnly` following the style of `@override` so it is visible to IDE where the annotation is used.
2024-08-14 01:13:34 +00:00
engine-flutter-autoroll
fb35123b38 Roll Flutter Engine from 4246f1536c5d to 019f9e3f0744 (2 revisions) (#153394)
4246f1536c...019f9e3f07

2024-08-13 jonahwilliams@google.com [Impeller] fix drawPoints scaling factors. (flutter/engine#54368)
2024-08-13 zanderso@users.noreply.github.com Move API level 34 scenario app tests back to prod (flutter/engine#54539)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-13 22:46:16 +00:00
Joy Serquiña
85b3d97673 fix(flutter/a11y assessments): h1 missing a11y from each page on the web app (#152198)
Adds Semantic Widget to wrap the contents of each page's AppBar title attribute and adds header: true and headingLevel: 1 as Semantic attributes so the content of the title is compiled as an h1 tag to meet accessibility guidelines that each page must have a h1 tag present. Also updates the test cases for the home page and each use case page to check for its respective h1.

[Before Screenshot - Accessibility Assessments Home Page](https://screenshot.googleplex.com/4i9LuiGwvLnEcZ8)
[Before Screenshot - Checkbox List Title -- note: each use case page is missing an h1](https://screenshot.googleplex.com/3qQjfqvAMTehRsm)
[After Screenshot - Accessibility Assessments Home Page](https://screenshot.googleplex.com/APSJJXBmwNBP35m)
[After Screenshot - Checkbox List Title-- note: change is similar across each Accessibility use case page](https://screenshot.googleplex.com/6EGgZnTusEgeN5L)

Fixes b/338035526
2024-08-13 22:22:28 +00:00
dependabot[bot]
87abed2b23 Bump github/codeql-action from 3.26.0 to 3.26.1 (#153395)
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.26.0 to 3.26.1.
<details>
<summary>Commits</summary>
<ul>
<li><a href="29d86d22a3"><code>29d86d2</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2422">#2422</a> from github/update-v3.26.1-0d5982aa3</li>
<li><a href="5b15b9edeb"><code>5b15b9e</code></a> Revert &quot;Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2417">#2417</a> from github/update-bundle/codeql-bundle-v2.1...</li>
<li><a href="18ac79e766"><code>18ac79e</code></a> Update changelog for v3.26.1</li>
<li><a href="0d5982aa33"><code>0d5982a</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2416">#2416</a> from github/henrymercer/ghes-3.14-compat-info</li>
<li><a href="da9ecb0f40"><code>da9ecb0</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2421">#2421</a> from github/henrymercer/log-job-run-uuid</li>
<li><a href="c4c3c4421f"><code>c4c3c44</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2417">#2417</a> from github/update-bundle/codeql-bundle-v2.18.2</li>
<li><a href="41833c77c6"><code>41833c7</code></a> Log job run UUID</li>
<li><a href="d620faa0b4"><code>d620faa</code></a> Bump the npm group with 4 updates (<a href="https://redirect.github.com/github/codeql-action/issues/2419">#2419</a>)</li>
<li><a href="25ad3c8e40"><code>25ad3c8</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2418">#2418</a> from github/henrymercer/extraction-time-telemetry</li>
<li><a href="44ecae4896"><code>44ecae4</code></a> Fix matrixing of &quot;submit SARIF after failure&quot; check</li>
<li>Additional commits viewable in <a href="eb055d739a...29d86d22a3">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github/codeql-action&package-manager=github_actions&previous-version=3.26.0&new-version=3.26.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>
2024-08-13 21:54:23 +00:00
engine-flutter-autoroll
b32eaf6f75 Roll Packages from d9a6de802e1f to e4f2247c3f41 (4 revisions) (#153383)
d9a6de802e...e4f2247c3f

2024-08-13 49699333+dependabot[bot]@users.noreply.github.com [url_launcher]: Bump androidx.annotation:annotation from 1.8.1 to 1.8.2 in /packages/url_launcher/url_launcher_android/android (flutter/packages#7386)
2024-08-13 engine-flutter-autoroll@skia.org Manual roll Flutter from 814e49be49 to 2afc452d3a (12 revisions) (flutter/packages#7399)
2024-08-12 49699333+dependabot[bot]@users.noreply.github.com [image_picker]: Bump androidx.annotation:annotation from 1.8.1 to 1.8.2 in /packages/image_picker/image_picker_android/android (flutter/packages#7390)
2024-08-12 engine-flutter-autoroll@skia.org Roll Flutter from 9b8470197f to 814e49be49 (3 revisions) (flutter/packages#7396)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-13 20:04:16 +00:00
flutter-pub-roller-bot
5f99d5782a Roll pub packages (#153380)
This PR was generated by `flutter update-packages --force-upgrade`.
2024-08-13 19:12:24 +00:00
engine-flutter-autoroll
aba00947b6 Roll Flutter Engine from 73c3135cc3be to 4246f1536c5d (2 revisions) (#153377)
73c3135cc3...4246f1536c

2024-08-13 zanderso@users.noreply.github.com Revert "Reland: Partial repaint platform views" (flutter/engine#54537)
2024-08-13 skia-flutter-autoroll@skia.org Roll Dart SDK from 9a6ec6cc9627 to 44635f897535 (2 revisions) (flutter/engine#54536)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-13 18:47:03 +00:00
Zachary Anderson
cc13cd1f11 Retry Linux_android_emu tests in presubmit like they are in postsubmit (#153369)
To help keep rolls unblocked while the flakiness of these tests is
investigated.
2024-08-13 10:23:30 -07:00
Zachary Anderson
6200318586 Shift API level 34 emulator tests to prod (#153366)
These are passing consistently
2024-08-13 09:42:30 -07:00