firka/flutter
3
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
28,178 Commits 1 Branch 0 Tags
d760d36cbcf3d31a2f240c54a6052932263b04e7
Commit Graph

28178 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
skia-flutter-autoroll
d760d36cbc Roll Dart SDK from f08901c71710 to 1f98bd4cf916 (2 revisions) (flutter/engine#40910) 
Roll Dart SDK from f08901c71710 to 1f98bd4cf916 (2 revisions)
 2023-04-04 07:43:34 +00:00
Chinmay Garde
219d65bb51 [Impeller] Enable SSBOs in the Vulkan backend. (flutter/engine#40908) 
[Impeller] Enable SSBOs in the Vulkan backend.
 2023-04-04 03:24:26 +00:00
Jonah Williams
b24bdc96b7 [Impeller] convert blend shaders to half precision (flutter/engine#40897) 
[Impeller] convert blend shaders to half precision
 2023-04-04 01:53:17 +00:00
Dan Field
567701279a Exit early on invalid gn CPU argument combos for simulators (flutter/engine#40903) 
Exit early on invalid gn CPU argument combos for simulators
 2023-04-04 01:38:04 +00:00
gaaclarke
4806e7d6e1 [Impeller] More impeller goldens from aiks_unittests (flutter/engine#40901) 
This brings over the last of the tests mentioned in
https://github.com/flutter/engine/pull/40804#issuecomment-1492516301

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-04-03 18:07:19 -07:00
Jackson Gardner
1f7f52ffac Fail the run_suite_step if any test failures are detected. (flutter/engine#40834) 
We need to throw if the `run_suite_step` encounters any test failures.
 2023-04-03 18:02:31 -07:00
Robert Ancell
2ff5380c01 Change back to using the memory address of a texture as its ID. (flutter/engine#40899) 
Change back to using the memory address of a texture as its ID.
 2023-04-04 00:43:49 +00:00
Dan Field
668566b8fa [Impeller] Respect enable-impeller command line setting over info.plist setting (flutter/engine#40902) 
[Impeller] Respect enable-impeller command line setting over info.plist setting
 2023-04-04 00:34:58 +00:00
Jonah Williams
234decefd7 [Impeller] reduce gaussian sampling by 2x (flutter/engine#40871) 
[Impeller] reduce gaussian sampling by 2x
 2023-04-04 00:28:04 +00:00
Jonah Williams
f82dc83970 Disable partial repaint on Android (flutter/engine#40898) 
Disable partial repaint on Android
 2023-04-03 23:36:58 +00:00
skia-flutter-autoroll
8135972f97 Roll Skia from 57aa7f9475de to ad459a5b8df4 (2 revisions) (flutter/engine#40900) 
Roll Skia from 57aa7f9475de to ad459a5b8df4 (2 revisions)
 2023-04-03 23:29:01 +00:00
Jonah Williams
d56b15d1a3 [Impeller] reduce advanced blend subpass count for single input with foreground color (flutter/engine#40886) 
[Impeller] reduce advanced blend subpass count for single input with foreground color
 2023-04-03 23:04:03 +00:00
gaaclarke
6cf914a15b [Impeller] Adds the ability to specify a golden threshold (flutter/engine#40824) 
[Impeller] Adds the ability to specify a golden threshold
 2023-04-03 22:50:12 +00:00
skia-flutter-autoroll
4c1e7e9090 Roll Skia from 1670c7c18c63 to 57aa7f9475de (1 revision) (flutter/engine#40896) 
Roll Skia from 1670c7c18c63 to 57aa7f9475de (1 revision)
 2023-04-03 22:29:29 +00:00
Brandon DeRosier
869f90866e [Impeller] Add subpass blend goldens (flutter/engine#40879) 2023-04-03 15:28:20 -07:00
Jonah Williams
ed0d748688 Revert "[Impeller] iOS/macOS: Only wait for command scheduling prior to present" (flutter/engine#40895) 
Reverts flutter/engine#40781

Fixes https://github.com/flutter/flutter/issues/124056

When unmerging threads we appear to get stuck for multiple seconds.
Haven't debugged further, but bisected to this commit.
 2023-04-03 14:50:27 -07:00
Jason Simmons
cf25261c4a [Impeller] Skip the color blend in drawVertices when using the destination blend mode (flutter/engine#40891) 
[Impeller] Skip the color blend in drawVertices when using the destination blend mode
 2023-04-03 20:50:04 +00:00
Chinmay Garde
51aca8ead9 [Impeller] Don't crash in image decompression if the context is unavailable. (flutter/engine#40890) 
[Impeller] Don't crash in image decompression if the context is unavailable.
 2023-04-03 19:49:04 +00:00
skia-flutter-autoroll
874d36fdf7 Roll Skia from 5013d1788fd5 to 1670c7c18c63 (1 revision) (flutter/engine#40889) 
Roll Skia from 5013d1788fd5 to 1670c7c18c63 (1 revision)
 2023-04-03 19:47:11 +00:00
Zachary Anderson
ebe7291fee Revert "Sync Mac Host Engine with its engine v2 counterpart." (flutter/engine#40892) 
Reverts flutter/engine#40856

Failure on
https://ci.chromium.org/ui/p/flutter/builders/prod/Mac%20mac_host_engine/2864/overview
 2023-04-03 12:31:17 -07:00
yaakovschectman
a3fec2cae5 Re-introduce WM_CLOSE listener, new quit protocol posts a second message to next handler (flutter/engine#40802) 
With this approach, when the last window of an app is closed, the engine
sends a message to the framework to check if it is allowed to exit. If
it may, the windows lifecycle manager synthesizes a second `WM_CLOSE`
message that it will ignore, and so the next registered top level window
proc delegate, if any, will be able to process the message. If none do
so, the message will be handled by the default window proc, so the app
will be able to close.

I was not able to get a full system tray example application running to
test this, but I could get an application that stays open when its
window is closed and can be seen as a system tray icon as long as it is
running, albeit the icon was non-functional. As this repro app still
exhibited this behavior when using this engine build, I am reasonably
confident in concluding that applications that want to be able to run
headless when their windows close will function properly.

Addresses https://github.com/flutter/flutter/issues/123654.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

---------

Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>
 2023-04-03 14:32:02 -04:00
godofredoc
89511339e2 Sync Mac Host Engine with its engine v2 counterpart. (flutter/engine#40856) 
Sync Mac Host Engine with its engine v2 counterpart.
 2023-04-03 18:21:55 +00:00
skia-flutter-autoroll
2dbacf8fce Roll Skia from 1dcbcaa213e7 to 5013d1788fd5 (1 revision) (flutter/engine#40888) 
Roll Skia from 1dcbcaa213e7 to 5013d1788fd5 (1 revision)
 2023-04-03 18:14:04 +00:00
Brandon DeRosier
fb4efeb175 [Impeller] Build fixes for impeller-cmake (flutter/engine#40880) 2023-04-03 11:11:08 -07:00
skia-flutter-autoroll
089bfc9ad5 Roll Dart SDK from 741a0ff895ad to f08901c71710 (1 revision) (flutter/engine#40887) 
Roll Dart SDK from 741a0ff895ad to f08901c71710 (1 revision)
 2023-04-03 18:10:47 +00:00
Casey Hillers
20cb8b8efc Revert "[web] remove obsolete object caches; simplify native object management" (flutter/engine#40882) 
Reverts flutter/engine#40862

Google Testing is failing on

```
The compiler crashed: root:🎯_engine::SkObjectFinalizationRegistry::@methods::|staticInteropFactoryStub is already bound to Reference to dart:_engine::SkObjectFinalizationRegistry::@methods::|staticInteropFactoryStub, trying to bind to Reference to SkObjectFinalizationRegistry.|staticInteropFactoryStub with node SkObjectFinalizationRegistry.|staticInteropFactoryStub (Procedure:1207727)
```
 2023-04-03 10:18:26 -07:00
skia-flutter-autoroll
65de4a52e5 Roll Skia from 5d72f0cd7c3b to 1dcbcaa213e7 (2 revisions) (flutter/engine#40885) 
Roll Skia from 5d72f0cd7c3b to 1dcbcaa213e7 (2 revisions)
 2023-04-03 17:15:48 +00:00
skia-flutter-autoroll
455937bcf2 Roll Skia from 58c9a8096801 to 5d72f0cd7c3b (5 revisions) (flutter/engine#40884) 
Roll Skia from 58c9a8096801 to 5d72f0cd7c3b (5 revisions)
 2023-04-03 15:23:12 +00:00
skia-flutter-autoroll
42809da881 Roll Skia from fbff5b8e6bee to 58c9a8096801 (1 revision) (flutter/engine#40875) 
Roll Skia from fbff5b8e6bee to 58c9a8096801 (1 revision)
 2023-04-03 14:30:23 +00:00
skia-flutter-autoroll
7289a214d5 Roll Dart SDK from 2e79d3e7bb24 to 741a0ff895ad (1 revision) (flutter/engine#40881) 
Roll Dart SDK from 2e79d3e7bb24 to 741a0ff895ad (1 revision)
 2023-04-03 14:12:22 +00:00
dependabot[bot]
d933f044c2 Bump ossf/scorecard-action from 2.1.2 to 2.1.3 (flutter/engine#40878) 
Bump ossf/scorecard-action from 2.1.2 to 2.1.3
 2023-04-03 09:45:12 +00:00
dependabot[bot]
c15f2e9384 Bump github/codeql-action from 2.2.8 to 2.2.9 (flutter/engine#40877) 
Bump github/codeql-action from 2.2.8 to 2.2.9
 2023-04-03 09:43:26 +00:00
skia-flutter-autoroll
8adea0dc30 Roll Dart SDK from ca96c7c53af6 to 2e79d3e7bb24 (1 revision) (flutter/engine#40876) 
Roll Dart SDK from ca96c7c53af6 to 2e79d3e7bb24 (1 revision)
 2023-04-03 08:19:20 +00:00
Yegor
e55fd93f5f [web] remove obsolete object caches; simplify native object management (flutter/engine#40862) 
[web] remove obsolete object caches; simplify native object management
 2023-04-03 04:31:16 +00:00
skia-flutter-autoroll
70109a62bc Roll Dart SDK from 8296054868c9 to ca96c7c53af6 (1 revision) (flutter/engine#40874) 
Roll Dart SDK from 8296054868c9 to ca96c7c53af6 (1 revision)
 2023-04-03 04:21:30 +00:00
Chinmay Garde
743b066d9f [Impeller] Add a Stage 2 pass to the Vulkan shader compilation pipeline. (flutter/engine#40873) 
[Impeller] Add a Stage 2 pass to the Vulkan shader compilation pipeline.
 2023-04-03 00:23:04 +00:00
Kingtous
bcaa44592e [Linux] fix: make textures thread-safe on linux (flutter/engine#40478) 
Make textures GHashTable thread-safe
 2023-04-03 11:30:04 +12:00
skia-flutter-autoroll
710e30f4e4 Roll Dart SDK from 5f7049d377cb to 8296054868c9 (1 revision) (flutter/engine#40870) 
Roll Dart SDK from 5f7049d377cb to 8296054868c9 (1 revision)
 2023-04-02 15:56:04 +00:00
skia-flutter-autoroll
8a75ab44c2 Roll Skia from 51fa1d5813d3 to fbff5b8e6bee (1 revision) (flutter/engine#40868) 
Roll Skia from 51fa1d5813d3 to fbff5b8e6bee (1 revision)
 2023-04-02 11:33:07 +00:00
skia-flutter-autoroll
38ef8e989a Roll Dart SDK from cf701d71db54 to 5f7049d377cb (1 revision) (flutter/engine#40869) 
Roll Dart SDK from cf701d71db54 to 5f7049d377cb (1 revision)
 2023-04-02 11:33:04 +00:00
skia-flutter-autoroll
2129e53dda Roll Skia from 47d56658e6bf to 51fa1d5813d3 (2 revisions) (flutter/engine#40866) 
Roll Skia from 47d56658e6bf to 51fa1d5813d3 (2 revisions)
 2023-04-02 06:26:36 +00:00
skia-flutter-autoroll
5591e1f9f6 Roll Dart SDK from d9e26506468f to cf701d71db54 (1 revision) (flutter/engine#40864) 
Roll Dart SDK from d9e26506468f to cf701d71db54 (1 revision)
 2023-04-02 04:11:57 +00:00
Casey Hillers
5a226729ad Revert "[web] remove obsolete object caches; simplify native object management" (flutter/engine#40861) 
Reverts flutter/engine#40617

See b/276167870. This is causing a build breakage to Google testing for
all web projects.
 2023-04-01 18:55:02 -07:00
skia-flutter-autoroll
12b396d99a Roll Dart SDK from 638efc51d06f to d9e26506468f (1 revision) (flutter/engine#40859) 
Roll Dart SDK from 638efc51d06f to d9e26506468f (1 revision)
 2023-04-02 00:23:39 +00:00
skia-flutter-autoroll
8aea49351b Roll Skia from e3aa2ce8a38b to 47d56658e6bf (1 revision) (flutter/engine#40858) 
Roll Skia from e3aa2ce8a38b to 47d56658e6bf (1 revision)
 2023-04-01 22:18:35 +00:00
Chinmay Garde
fc7d1fbd95 [Impeller] Remove redundant TargetPlatformNeedsSL. (flutter/engine#40857) 
TargetPlatformNeedsSL was true for all target platforms.

I believe we reworked this after we started embedding metadata in IPLR
files perhaps? In any case, this seemed unused and was making the code
harder to read. Just a cleanup that I didn't want to include in the
compiler rework for SPIRV.
 2023-04-01 14:53:49 -07:00
Chinmay Garde
1a5b150113 [Impeller] Make validation logs non-fatal by default. (flutter/engine#40855) 
[Impeller] Make validation logs non-fatal by default.
 2023-04-01 19:13:11 +00:00
Chinmay Garde
a65edb5819 [Impeller] Apply binding base correction to all shader variants. (flutter/engine#40854) 
[Impeller] Apply binding base correction to all shader variants.
 2023-04-01 18:31:22 +00:00
Chinmay Garde
0f0507b570 [Impeller] Add external synchronization to Vulkan queues access. (flutter/engine#40848) 
Fixes https://github.com/flutter/flutter/issues/123883
 2023-04-01 11:26:33 -07:00
skia-flutter-autoroll
e1c42cf8e1 Roll Dart SDK from 7e36e11608f3 to 638efc51d06f (2 revisions) (flutter/engine#40853) 
Roll Dart SDK from 7e36e11608f3 to 638efc51d06f (2 revisions)
 2023-04-01 13:56:22 +00:00