firka/flutter
3
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
30,982 Commits 1 Branch 0 Tags
d72727e744bdb07fa1cd91b7addea2b8630f6ed7
Commit Graph

30982 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Zachary Anderson
d72727e744 Remove --enable-software-rendering from iOS scenario tests (flutter/engine#45093) 2023-08-25 20:29:05 +00:00
skia-flutter-autoroll
1645ca13fc Roll Skia from 56bb647a49ac to 76672468e8d7 (3 revisions) (flutter/engine#45121) 
https://skia.googlesource.com/skia.git/+log/56bb647a49ac..76672468e8d7

2023-08-25 johnstiles@google.com Remove gn flag 'skia_enable_sksl'.
2023-08-25 michaelludwig@google.com Replace GrMatrixConvolutionEffect with GrSkSLFP runtime effect
2023-08-25 johnstiles@google.com Revert "Make empty GN lists for Ganesh Dawn."

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,lovisolo@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-25 20:03:04 +00:00
Yatendra Kumar
d2bfe45c44 Fix: Complete Documentation for RasterStatus::kSkipAndRetry (flutter/engine#44880) 
## Description

This PR completes the documentation for `RasterStatus::kSkipAndRetry` in the `compositor_context.h` file. The previous comment ended abruptly, leaving ambiguity regarding the behavior when the thread merger is disabled.

### Changes:
- Added clarification on the behavior when the thread merger is disabled.
- Explained the potential performance implications when threads are not merged.

## Related Issues

https://github.com/flutter/flutter/issues/131814

## Tests

No tests were added as this PR only involves documentation changes.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-08-25 20:01:05 +00:00
gaaclarke
25873b17bd [Impeller] Updated TextureSourceVK docs and deleted unused ivars (flutter/engine#45123) 
Just some documentation and cleanup while i'm trying to get render pass recycling working.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-08-25 19:59:21 +00:00
Zachary Anderson
41c9a99978 Revert "Fix global tests doing nothing." (flutter/engine#45125) 
Reverts flutter/engine#45097

Many failures on CI like:
```
ld: warning: ignoring file ../../../../out/ios_debug_sim_arm64_extension_safe/libocmock_shared.dylib, building for iOS Simulator-x86_64 but attempting to link with file built for iOS Simulator-arm64
ld: warning: ignoring file ../../../../out/ios_debug_sim_arm64_extension_safe/libios_test_flutter.dylib, building for iOS Simulator-x86_64 but attempting to link with file built for iOS Simulator-arm64
```


https://ci.chromium.org/ui/p/flutter/builders/prod/Mac%20Production%20Engine%20Drone/131188/overview

Not sure if there are also other tests failing in different ways.
 2023-08-25 12:38:23 -07:00
skia-flutter-autoroll
714ed0931a Roll Skia from ba7c5258d2b4 to 56bb647a49ac (3 revisions) (flutter/engine#45118) 
https://skia.googlesource.com/skia.git/+log/ba7c5258d2b4..56bb647a49ac

2023-08-25 michaelludwig@google.com [skif] Add ::Empty() convenience factory
2023-08-25 egdaniel@google.com [Graphite] Add option to set independent, custom gpu budgets on Context and Recorders.
2023-08-25 kjlubick@google.com Change defined(GR_TEST_UTILS) -> GR_TEST_UTILS

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,lovisolo@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-25 18:21:04 +00:00
Reid Baker
d8b11bc6fa Update gradle to 7.5.1 (flutter/engine#45113) 
fixes flutter/flutter#133259
Added gradle update instructions and bumped gradle version.
 2023-08-25 17:34:03 +00:00
Chris Yang
5734f9a52f Ignore unguarded-availability for unit test (flutter/engine#44852) 
Ignore ungarded-availability for unit test

fixes https://github.com/flutter/flutter/issues/128958

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-08-25 17:31:30 +00:00
Jonah Williams
843b0a5719 [Impeller] avoid hashing and std::vector growth when binding descriptor sets. (flutter/engine#45070) 
We call allocateAndBindDescriptorSets once for every cmd rendered, so this time can bubble up quite a bit. From the traces I've gathered map emplacement (emplace_unique_key_args) and std::vector growth (__push_back_slow_path) contribute the most to this trace.

I think we have physical limits on the number of descriptors we can bind, though I'm not sure if we enforce that anywhere?
 2023-08-25 17:22:43 +00:00
skia-flutter-autoroll
578dc16da4 Roll Skia from 4b30261160a2 to ba7c5258d2b4 (5 revisions) (flutter/engine#45116) 
https://skia.googlesource.com/skia.git/+log/4b30261160a2..ba7c5258d2b4

2023-08-25 johnstiles@google.com Reland "Factor out ContextType from GrContextFactory."
2023-08-25 robertphillips@google.com [graphite] Loosen assert in MakeColorSpace_Test
2023-08-25 robertphillips@google.com Add GrRecordingContext/GrDirectContext::supportsProtectedContent
2023-08-25 johnstiles@google.com Make empty GN lists for Ganesh Dawn.
2023-08-25 robertphillips@google.com Fix bug in picture image cache key creation

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,lovisolo@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-25 16:57:55 +00:00
skia-flutter-autoroll
2fe6ab4dd5 Roll Fuchsia Linux SDK from R_deCnScH70FbSeii... to u8ovJYTk3nN78xF4X... (flutter/engine#45115) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-25 16:47:04 +00:00
Greg Spencer
87e6e728ca Add quotes around Doxygen configuration values (flutter/engine#45087) 
## Description

Add quotes are the Doxygen configuration values that may have spaces, since otherwise Doxygen strips them.
 2023-08-25 16:41:04 +00:00
Jonah Williams
c94e38673c [Impeller] fix validation warning on iOS/macOS when compiling external texture shader. (flutter/engine#45080) 
```
[VERBOSE-2:validation.cc(49)] Break on 'ImpellerValidationBreak' to inspect point of failure: Could not create render pipeline for TextureFillExternal Pipeline :Fragment input(s) `user(locn1)` mismatching vertex shader output type(s) or not written by vertex shader
```

Fixes https://github.com/flutter/flutter/issues/133286
Fixes https://github.com/flutter/flutter/issues/133268
 2023-08-25 15:59:15 +00:00
godofredoc
ee26f237c7 Remove cirrus build badge (flutter/engine#45103) 
It was showing an error because the engine is not running cirrus tests anymore.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-08-25 15:14:06 +00:00
skia-flutter-autoroll
c95b1de397 Roll Skia from 8a26fe31389d to 4b30261160a2 (1 revision) (flutter/engine#45109) 
https://skia.googlesource.com/skia.git/+log/8a26fe31389d..4b30261160a2

2023-08-25 egdaniel@google.com [Graphite] Add public API for performDeferredCleanup.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,lovisolo@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-25 15:10:10 +00:00
godofredoc
7fe20d02e9 Fix global tests doing nothing. (flutter/engine#45097) 
This was related to using tests property which is expected for tests running within a build and tasks property used for global tests.

Bug: flutter/flutter#133301

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-08-25 14:23:19 +00:00
skia-flutter-autoroll
6d7519402f Roll Skia from f867f82cc758 to 8a26fe31389d (1 revision) (flutter/engine#45104) 
https://skia.googlesource.com/skia.git/+log/f867f82cc758..8a26fe31389d

2023-08-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 0b648252039f to c8ec8739ec4d (13 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,lovisolo@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-25 07:08:46 +00:00
skia-flutter-autoroll
eb90e6e281 Roll Skia from 5a1b6567544c to f867f82cc758 (2 revisions) (flutter/engine#45102) 
https://skia.googlesource.com/skia.git/+log/5a1b6567544c..f867f82cc758

2023-08-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 7a3cf15a1fc1 to e93f26585ca2
2023-08-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 97bdc453fbed to a147f6c5192a (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,lovisolo@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-25 06:23:20 +00:00
Ian Hickson
f9a5c26a42 FontVariation.lerp, custom FontVariation constructors, and more documentation (flutter/engine#45030) 
This should aid with implementing the framework side of https://github.com/flutter/flutter/issues/105120.
This should also address https://github.com/flutter/flutter/issues/28543.

Original commit in https://github.com/flutter/engine/pull/43750 was reverted in https://github.com/flutter/engine/pull/44993.
Second attempt in https://github.com/flutter/engine/pull/44996 was reverted in https://github.com/flutter/engine/pull/45023.
 2023-08-25 05:54:08 +00:00
skia-flutter-autoroll
e7b28700c8 Roll Fuchsia Mac SDK from jkVyhV_xfb8Mv43xj... to 4LHUJjNlDT21v_pdT... (flutter/engine#45100) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-25 05:47:04 +00:00
skia-flutter-autoroll
d9aa18c145 Roll Skia from 1428f16fc0de to 5a1b6567544c (1 revision) (flutter/engine#45099) 
https://skia.googlesource.com/skia.git/+log/1428f16fc0de..5a1b6567544c

2023-08-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 16dd437ab329 to 7a3cf15a1fc1 (7 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,lovisolo@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-25 05:45:20 +00:00
skia-flutter-autoroll
a217c2c749 Roll Fuchsia Linux SDK from 0kEa4JczTMD0Xus08... to R_deCnScH70FbSeii... (flutter/engine#45096) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-25 04:01:30 +00:00
Zachary Anderson
681a9ab83a Revert ios cpu changes (flutter/engine#45095) 
https://github.com/flutter/flutter/issues/133301
 2023-08-25 03:51:23 +00:00
gaaclarke
e9ea159828 [Impeller] Refactor: Create attachment descriptions without setting layouts (flutter/engine#45088) 
This refactor makes recycling render passes easier since it starts to
split out setting the layout of textures with creating the render pass
description.

I didn't fully implement the split since it would technically be slower.
Until we get caching of render passes working it would require us to
calculate the attachment descriptions twice, once to make the render
pass and once to set the texture layout.

teases out some of the work from:
https://github.com/flutter/engine/pull/44527
in the service of implementing:
https://github.com/flutter/engine/pull/44861
issue: https://github.com/flutter/flutter/issues/133182

The final split will have this function for recycled render passes:
```c++
void SetTextureLayouts(const RenderTarget& render_target,
                       const std::shared_ptr<CommandBufferVK>& command_buffer) {
  for (const auto& [bind_point, color] : render_target.GetColorAttachments()) {
    SetTextureLayout(color,
                     CreateAttachmentDescription(color, &Attachment::texture),
                     command_buffer, &Attachment::texture);
    if (color.resolve_texture) {
      SetTextureLayout(
          color,
          CreateAttachmentDescription(color, &Attachment::resolve_texture),
          command_buffer, &Attachment::resolve_texture);
    }
  }

  if (auto depth = render_target.GetDepthAttachment(); depth.has_value()) {
    SetTextureLayout(
        depth.value(),
        CreateAttachmentDescription(depth.value(), &Attachment::texture),
        command_buffer, &Attachment::texture);
  }

  if (auto stencil = render_target.GetStencilAttachment();
      stencil.has_value()) {
    SetTextureLayout(
        stencil.value(),
        CreateAttachmentDescription(stencil.value(), &Attachment::texture),
        command_buffer, &Attachment::texture);
  }
}
```

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-08-24 20:36:05 -07:00
Jim Graham
5a9d0ee712 Reland "Split DisplayListBuilder into DlCanvas optimizer and DlOp recorder classes #44718" (flutter/engine#45085) 
Fixes: https://github.com/flutter/flutter/issues/133200
 2023-08-25 00:22:14 +00:00
skia-flutter-autoroll
eb6be31280 Roll Skia from 99a76ea8e1b2 to 1428f16fc0de (1 revision) (flutter/engine#45086) 
https://skia.googlesource.com/skia.git/+log/99a76ea8e1b2..1428f16fc0de

2023-08-24 egdaniel@google.com [Graphite] Add support for Context and Recorder freeGpuResources call.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,lovisolo@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-24 23:08:48 +00:00
skia-flutter-autoroll
e834e86cdc Roll Skia from 25fafff5b32c to 99a76ea8e1b2 (2 revisions) (flutter/engine#45083) 
https://skia.googlesource.com/skia.git/+log/25fafff5b32c..99a76ea8e1b2

2023-08-24 nscobie@google.com Parameterize ImageAsyncReadPixels by renderability and origin
2023-08-24 johnstiles@google.com Revert "Factor out ContextType from GrContextFactory."

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,lovisolo@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-24 22:27:16 +00:00
Jackson Gardner
9727494b65 Revert "Turn on the skia_enable_optimize_size flag to save a bit of binary size" (flutter/engine#45082) 
Reverts flutter/engine#45029

It appears this is causing a regression in the length of time some of our integration tests are taking, causing them to take twice as long, which is causing timeouts in CI. We should revert while we investigate.
 2023-08-24 22:00:47 +00:00
skia-flutter-autoroll
df43f88eed Roll Skia from d7d56885a49b to 25fafff5b32c (1 revision) (flutter/engine#45081) 
https://skia.googlesource.com/skia.git/+log/d7d56885a49b..25fafff5b32c

2023-08-24 michaelludwig@google.com Move Gaussian blur utility functions into skgpu::BlurUtils

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,lovisolo@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-24 21:40:10 +00:00
Dan Field
62a0c52e78 [Impeller] Do not build scene unless 3d define is true (flutter/engine#45028) 
Fixes https://github.com/flutter/flutter/issues/133193
 2023-08-24 21:38:19 +00:00
skia-flutter-autoroll
0f760efe37 Roll Skia from 177e8477faf9 to d7d56885a49b (1 revision) (flutter/engine#45078) 
https://skia.googlesource.com/skia.git/+log/177e8477faf9..d7d56885a49b

2023-08-24 johnstiles@google.com Factor out ContextType from GrContextFactory.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,lovisolo@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-24 20:55:19 +00:00
Tong Mu
6351b8a111 Reland: [Rasterizer] Make resubmit information temporary (flutter/engine#45037) 
Relands https://github.com/flutter/engine/pull/42001.

The previous attempt was reverted due to post-submit flakeness, some mysterious crashes. I didn't change anything this time, but now that PR https://github.com/flutter/engine/pull/44973 is merged that fixes some racing issues, I wonder if the crashes of this change are resolved as well.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-08-24 20:44:59 +00:00
Gray Mackall
424b1c3829 Add case checking to android sdk cipd upload script (flutter/engine#45063) 
See https://github.com/flutter/flutter/pull/131901#issuecomment-1690252455 for the reason for this PR.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-08-24 20:43:05 +00:00
skia-flutter-autoroll
d8fe7aa908 Roll Skia from 007386294889 to 177e8477faf9 (1 revision) (flutter/engine#45076) 
https://skia.googlesource.com/skia.git/+log/007386294889..177e8477faf9

2023-08-24 johnstiles@google.com Disable timing-out/flaking tests on Intel Iris Pro + Metal.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,lovisolo@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-24 19:31:54 +00:00
Jackson Gardner
8cd127938f Turn on the skia_enable_optimize_size flag to save a bit of binary size (flutter/engine#45029) 
This flag removes some code from CanvasKit to reduce size by a little bit. I went ahead and did a run of the benchmarks (https://github.com/flutter/flutter/pull/133208) to see if it negatively affected anything, and there was no difference beyond noise between the current benchmark numbers and the benchmarks with this flag enabled.

The size differences are as follows:
Before the change:
```
total 30616
drwxr-xr-x  11 jacksongardner  primarygroup      352 Aug 23 14:33 .
drwxr-xr-x   7 jacksongardner  primarygroup      224 Aug 10 18:14 ..
-rw-r--r--@  1 jacksongardner  primarygroup     6148 May 12 17:41 .DS_Store
-rw-r--r--   2 jacksongardner  primarygroup    94899 Aug 23 14:23 canvaskit.js
-rwxr-xr-x   2 jacksongardner  primarygroup  6631693 Aug 23 14:23 canvaskit.wasm
-rwxr-xr-x   1 jacksongardner  primarygroup  2102151 Aug 23 14:23 canvaskit.wasm.br
drwxr-xr-x   5 jacksongardner  primarygroup      160 Aug 23 14:33 chromium
-rw-r--r--   2 jacksongardner  primarygroup   161478 Aug 23 14:28 skwasm.js
-rwxr-xr-x   2 jacksongardner  primarygroup  3296038 Aug 23 14:28 skwasm.wasm
-rwxr-xr-x   1 jacksongardner  primarygroup  1101502 Aug 23 14:28 skwasm.wasm.br
-rw-r--r--   2 jacksongardner  primarygroup     3095 Aug 23 14:28 skwasm.worker.js

./chromium:
total 15520
drwxr-xr-x   5 jacksongardner  primarygroup      160 Aug 23 14:33 .
drwxr-xr-x  11 jacksongardner  primarygroup      352 Aug 23 14:33 ..
-rw-r--r--   2 jacksongardner  primarygroup    94545 Aug 23 14:25 canvaskit.js
-rwxr-xr-x   2 jacksongardner  primarygroup  5223378 Aug 23 14:25 canvaskit.wasm
-rwxr-xr-x   1 jacksongardner  primarygroup  1492433 Aug 23 14:25 canvaskit.wasm.br
```

After the change:
```
total 28568
drwxr-xr-x  11 jacksongardner  primarygroup      352 Aug 23 14:42 .
drwxr-xr-x   7 jacksongardner  primarygroup      224 Aug 10 18:14 ..
-rw-r--r--@  1 jacksongardner  primarygroup     6148 May 12 17:41 .DS_Store
-rw-r--r--   2 jacksongardner  primarygroup    94899 Aug 23 14:37 canvaskit.js
-rwxr-xr-x   2 jacksongardner  primarygroup  6401703 Aug 23 14:37 canvaskit.wasm
-rwxr-xr-x   1 jacksongardner  primarygroup  2038390 Aug 23 14:37 canvaskit.wasm.br
drwxr-xr-x   5 jacksongardner  primarygroup      160 Aug 23 14:42 chromium
-rw-r--r--   2 jacksongardner  primarygroup   161478 Aug 23 14:41 skwasm.js
-rwxr-xr-x   2 jacksongardner  primarygroup  3143431 Aug 23 14:41 skwasm.wasm
-rwxr-xr-x   1 jacksongardner  primarygroup  1050854 Aug 23 14:41 skwasm.wasm.br
-rw-r--r--   2 jacksongardner  primarygroup     3095 Aug 23 14:41 skwasm.worker.js

./chromium:
total 15392
drwxr-xr-x   5 jacksongardner  primarygroup      160 Aug 23 14:42 .
drwxr-xr-x  11 jacksongardner  primarygroup      352 Aug 23 14:42 ..
-rw-r--r--   2 jacksongardner  primarygroup    94545 Aug 23 14:39 canvaskit.js
-rwxr-xr-x   2 jacksongardner  primarygroup  4993586 Aug 23 14:39 canvaskit.wasm
-rwxr-xr-x   1 jacksongardner  primarygroup  1427979 Aug 23 14:39 canvaskit.wasm.br
```

The brotli-compressed wasm modules save about 50-70kb each with this flag.
 2023-08-24 18:52:22 +00:00
skia-flutter-autoroll
194647c93f Roll Skia from b17ee34f3378 to 007386294889 (1 revision) (flutter/engine#45075) 
https://skia.googlesource.com/skia.git/+log/b17ee34f3378..007386294889

2023-08-24 johnstiles@google.com Remove support for Dawn in Ganesh.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,lovisolo@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-24 18:52:20 +00:00
skia-flutter-autoroll
5fa54d93d1 Roll Skia from 8b0fd320865e to b17ee34f3378 (1 revision) (flutter/engine#45073) 
https://skia.googlesource.com/skia.git/+log/8b0fd320865e..b17ee34f3378

2023-08-24 johnstiles@google.com Reject shaders which mark textures/samplers as 'uniform.'

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,lovisolo@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-24 18:00:05 +00:00
Zachary Anderson
ab3a9f6ac7 Revert Dart SDK to 3.2.0-97.0.dev (flutter/engine#45072) 
For failures in https://github.com/flutter/flutter/pull/133261
 2023-08-24 10:54:00 -07:00
skia-flutter-autoroll
4b4241c8d3 Manual roll Dart SDK from 87a5a26b25fc to bcad589d5d81 (4 revisions) (flutter/engine#45065) 
Manual roll requested by asiva@google.com

https://dart.googlesource.com/sdk.git/+log/87a5a26b25fc..bcad589d5d81

2023-08-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-105.0.dev
2023-08-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-104.0.dev
2023-08-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-103.0.dev
2023-08-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-102.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC asiva@google.com,dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-24 17:09:49 +00:00
skia-flutter-autoroll
d726320da0 Roll Fuchsia Mac SDK from P8oeVw3whCGS6pCjL... to jkVyhV_xfb8Mv43xj... (flutter/engine#45068) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-24 16:57:23 +00:00
skia-flutter-autoroll
1c9af448b6 Roll Skia from e008ee76b890 to 8b0fd320865e (3 revisions) (flutter/engine#45067) 
https://skia.googlesource.com/skia.git/+log/e008ee76b890..8b0fd320865e

2023-08-24 nscobie@google.com Fix missing allocUsage int cast in log
2023-08-24 johnstiles@google.com Make 'uniform' modifier on SkSL samplers/textures optional.
2023-08-24 nscobie@google.com Log VkResult != success when checkVkResult is called from lambda

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,lovisolo@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-24 16:34:54 +00:00
William Hesse
8f2e374f7a Remove package linter from DEPS (flutter/engine#45053) 
The linter package has been moved into the Dart SDK repo. It no longer needs to be checked out into
third_party/dart/third_party/pkg/linter.

Bug: https://github.com/dart-lang/linter/issues/4411
 2023-08-24 16:08:04 +00:00
Zachary Anderson
328f1fb459 Revert "[Impeller] Add debug captures and inspector." (flutter/engine#45062) 
Reverts flutter/engine#43764

Broke the wide gamut test on framework CI
https://github.com/flutter/flutter/pull/133255


https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_ios%20wide_gamut_ios/3186/overview
 2023-08-24 08:50:42 -07:00
Jonah Williams
3959803727 [Impeller] Don't place vertex buffer bindings in the Binding map. (flutter/engine#45040) 
The metal backend is the only backend that doesn't treat binding the vertex buffer specially. For the GLES and Vulkan backend, we can instead pull it out of the cmd map entirely.

This will make it easier to partially inline the map into the bindings object.

https://github.com/flutter/flutter/issues/133199
 2023-08-24 15:41:47 +00:00
skia-flutter-autoroll
601a3e581a Roll Skia from 994d5e03fa1c to e008ee76b890 (1 revision) (flutter/engine#45061) 
https://skia.googlesource.com/skia.git/+log/994d5e03fa1c..e008ee76b890

2023-08-24 johnstiles@google.com Reland "Disable Graphite SkSL tests on Linux in Release."

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,lovisolo@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-24 15:34:40 +00:00
Jonah Williams
6cbcea5081 Revert "[Impeller] add trace events for VkRenderPass and VkFrameBuffe… (flutter/engine#45047) 
…r creation. (#44837)"

This reverts commit 539e3833d2.

*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*

*List which issues are fixed by this PR. You must list at least one issue.*

These trace events aren't super useful, since we've tracked down the issues as either 1) phone is overloaded due to image decoding at large size or 2) https://github.com/flutter/flutter/issues/133198
 2023-08-24 15:33:33 +00:00
skia-flutter-autoroll
2a13456e11 Roll Fuchsia Linux SDK from XoUnFqSvX9mhbXqBJ... to 0kEa4JczTMD0Xus08... (flutter/engine#45060) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-24 15:14:04 +00:00
skia-flutter-autoroll
5070678e99 Roll Skia from 68700a1a2be9 to 994d5e03fa1c (1 revision) (flutter/engine#45059) 
https://skia.googlesource.com/skia.git/+log/68700a1a2be9..994d5e03fa1c

2023-08-24 brianosman@google.com Remove all Ganesh Dawn jobs

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,lovisolo@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-24 14:59:05 +00:00
skia-flutter-autoroll
71e70d3a77 Roll Skia from 13a050278b1a to 68700a1a2be9 (1 revision) (flutter/engine#45058) 
https://skia.googlesource.com/skia.git/+log/13a050278b1a..68700a1a2be9

2023-08-24 johnstiles@google.com Disable Metal warnings in SkSL.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,lovisolo@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-24 14:22:31 +00:00
skia-flutter-autoroll
00f9c7d7e7 Roll Skia from 317f4c2ba2ca to 13a050278b1a (1 revision) (flutter/engine#45054) 
https://skia.googlesource.com/skia.git/+log/317f4c2ba2ca..13a050278b1a

2023-08-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 16e38af9947d to 00368bd7466b (5 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,lovisolo@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-08-24 10:48:05 +00:00