Commit Graph

4424 Commits

Author SHA1 Message Date
Jason Simmons
d47e663efa Re-land "Hold a global reference to the AssetManager Java object backing the APKAssetProvider" (flutter/engine#5132)
Fixes https://github.com/flutter/flutter/issues/16222
2018-04-30 12:29:40 -07:00
skia-flutter-autoroll
63c38bf6fa Roll src/third_party/skia/ ba36572d1..44a8c74e3 (6 commits) (flutter/engine#5134)
Auto-roller completed checks. Merging.
2018-04-30 14:56:22 -04:00
Jason Simmons
8c9ef95bea Detach from JNI during shutdown of the UI thread on Android (flutter/engine#5120)
The APKAssetProvider will hold a reference to its Java peer
(see c2b081e229)

After dropping this reference, the UI thread must detach from JNI before exiting.
2018-04-30 10:44:01 -07:00
skia-flutter-autoroll
9e955689ea Roll src/third_party/skia/ 58b90f7f1..ba36572d1 (3 commits) (flutter/engine#5131)
Auto-roller completed checks. Merging.
2018-04-30 11:26:21 -04:00
skia-flutter-autoroll
845ff168bc Roll src/third_party/skia/ efb4d08dd..58b90f7f1 (1 commit) (flutter/engine#5130)
Auto-roller completed checks. Merging.
2018-04-30 07:53:21 -04:00
skia-flutter-autoroll
c7da854104 Roll src/third_party/skia/ cccafe8cf..efb4d08dd (1 commit) (flutter/engine#5129)
Auto-roller completed checks. Merging.
2018-04-29 04:44:21 -04:00
skia-flutter-autoroll
a87540e28d Roll src/third_party/skia/ 5b6d4a354..cccafe8cf (1 commit) (flutter/engine#5128)
Auto-roller completed checks. Merging.
2018-04-28 17:00:21 -04:00
skia-flutter-autoroll
8d5cd3e99a Roll src/third_party/skia/ 0f97bac4a..5b6d4a354 (1 commit) (flutter/engine#5127)
Auto-roller completed checks. Merging.
2018-04-28 11:07:21 -04:00
skia-flutter-autoroll
3dc85d8d9d Roll src/third_party/skia/ 7df62b559..0f97bac4a (1 commit) (flutter/engine#5126)
Auto-roller completed checks. Merging.
2018-04-28 03:18:22 -04:00
Alexander Aprelev
4b423d5456 Undo pub_rev update that seems to be breaking Flutter. (flutter/engine#5122) 2018-04-27 21:30:13 -07:00
skia-flutter-autoroll
965f88c26e Roll src/third_party/skia/ 275df2e87..7df62b559 (1 commit) (flutter/engine#5125)
Auto-roller completed checks. Merging.
2018-04-27 23:47:21 -04:00
skia-flutter-autoroll
7146600967 Roll src/third_party/skia/ cb3124813..275df2e87 (3 commits; 1 trivial rolls) (flutter/engine#5123)
Auto-roller completed checks. Merging.
2018-04-27 20:18:22 -04:00
Chinmay Garde
bdaa00232e In case of empty Dart data responses, don’t call the buffer method on null. (flutter/engine#5114)
Fixes regression introduced in https://github.com/flutter/engine/pull/5101.
2018-04-27 15:22:16 -07:00
skia-flutter-autoroll
cb6fa1def5 Roll src/third_party/skia/ cbdf5d5bf..cb3124813 (6 commits; 1 trivial rolls) (flutter/engine#5118)
Auto-roller completed checks. Merging.
2018-04-27 16:49:21 -04:00
Yegor
2b58565cee Revert "Hold a global reference to the AssetManager Java object backing the APKAssetProvider (#5078)" (flutter/engine#5116)
This reverts commit c2b081e229.

It causes engine crashes in some Android Espresso tests.
2018-04-27 13:47:26 -07:00
Alexander Aprelev
3610085650 Roll dart to cd0c4e4fe1e5b69ac15c0a670f9dde2ee9733fc7. (flutter/engine#5113)
* Roll dart to cd0c4e4fe1e5b69ac15c0a670f9dde2ee9733fc7.

Changes since last roll:

```
cd0c4e4fe1 Kernel service just returns errors. Leaves printing to the VM.
010d8144bc Add missing copyright notice
70547d8197 Change linter subscriptions from functions to AstVisitor(s).
88a098c71c Improve fasta parser field name recovery
bd76221d58 fix #31489, JS interop to `prototype` getter in dartdevk
ca419a9251 dart2js status refresh
da49615c2c Don't filter out references to constructors.
cc968df178 [test] Fix analyzer warning in the recently added test
1c5d1a56e7 Clean up some hints
5a9a479a73 Fix #32966 too little stack overflow context to be useful
2786b9ff43 [vm/aot] Add detailed error messages and stack traces for null checks
fbfe5691cb Change completionTarget.forOffset to accept & wrap dangling AstNodes.
cb15b43c32 Add support for getting parse results synchronously
e0ddab3c4c Fix bots after preview-dart2 was switched on by default.
88099ffcc3 Stop importing front_end into analyzer_plugin.
115850ca1d Revert "Clean up the use of deprecated API in the analyzer_plugin package"
f95df2a26b [dartfmt] Bump dart:style to 1.0.11
c97d36c127 Add all concrete AST nodes for lints to subscribe.
1afe71c08a Enable preview-dart-2 as default for analyzer.
45e390003f [kernel] Report error for dangling node reference in metadata
c1c90358a2 Record a missing file offset
16be5d1e33 [VM] Fix missing update of off-heap class sizes
c8ad75d44a [VM] Make classes movable in sliding compactor
c59b390806 Update status
93511d523c Track RTI for noSuchMethod
f6db874416 fix some dartdevk behavior to match dartdevc in more cases
c0015fe23f [gardening] Skip tests that are meaningless in AOT configuration.
9f7a247c33 Remove dangling pubspec.lock from pkg/dev_compiler/test/
004ee9cd12 Fix how we use Comparable.compare, so we have a function with the appropriate type in JSArray.sort
30b53ceaab fix #30852, cyclic init errors in some cases in dartdevc
94f45c8876 Bring in the latest pub
328163bba9 [kernel] CloneVisitor should preserve isDefault on switch cases.
613c6d066c [vm][windows] Implement VirtualMemory::FreeSubSegment
7c6594c0bd fix #32302, friendlier `Type.toString()` in dartdevc
e7848a8cda [vm/kernel] Avoid dangling references to DartTypes from constant pool
d47203a71b Fix a crash in type inference
1030189d56 Add NodeLintRule and UnitLintRule that replace AstVisitor in lints.
9e9b50d19d Improve error messages for annotations involving undefined names (issue 27788)
d7ff30c3e1 Add a missing call to greatestClosure
c844011647 Don't skip pkg/kernel/test/metadata_test
```

* Update license hash. No changes to the licenses.
2018-04-27 12:56:09 -07:00
skia-flutter-autoroll
1f85337cda Roll src/third_party/skia/ 82a334251..cbdf5d5bf (4 commits) (flutter/engine#5111)
Auto-roller completed checks. Merging.
2018-04-27 12:50:21 -04:00
skia-flutter-autoroll
5c4fc8129b Roll src/third_party/skia/ a886544a7..82a334251 (1 commit) (flutter/engine#5110)
Auto-roller completed checks. Merging.
2018-04-27 09:22:21 -04:00
skia-flutter-autoroll
cdbb4c475e Roll src/third_party/skia/ 414be9b33..a886544a7 (1 commit) (flutter/engine#5109)
Auto-roller completed checks. Merging.
2018-04-27 03:10:21 -04:00
skia-flutter-autoroll
5ff7f8bdc0 Roll src/third_party/skia/ a070ed7fc..414be9b33 (4 commits; 1 trivial rolls) (flutter/engine#5108)
Auto-roller completed checks. Merging.
2018-04-26 22:03:21 -04:00
Jason Simmons
cb86a973a7 Create message response external typed data objects as Uint8Lists (flutter/engine#5101)
PlatformMessageResponseDart will wrap large responses in Dart external typed
data objects in order to avoid copying the data into a new buffer.

Previously these objects were created with the Dart_TypedData_kByteData type.
A weak persistent handle is then associated with the ByteData to provide a
finalizer that deletes the raw buffer.  However, the Dart VM could call
finalizer on the ByteData even if references still existed to the Dart ByteBuffer
object backing the ByteData.  The ByteBuffer would then be referencing a deleted
raw buffer.

This PR prevents that scenario by creating a Dart_TypedData_kUint8 object,
attaching the finalizer to that object, and then wrapping it in a ByteData.
2018-04-26 17:49:51 -07:00
skia-flutter-autoroll
421b5577f6 Roll src/third_party/skia/ 47ed6f10e..a070ed7fc (21 commits; 1 trivial rolls) (flutter/engine#5106)
Auto-roller completed checks. Merging.
2018-04-26 18:34:21 -04:00
Jonah Williams
08d8e86ff1 Add tooltip method to Android AccessibilityBridge (flutter/engine#5103) 2018-04-26 15:03:47 -07:00
skia-flutter-autoroll
c2ed40a942 Roll src/third_party/skia/ c79e2d155..47ed6f10e (10 commits; 1 trivial rolls) (flutter/engine#5100)
Auto-roller completed checks. Merging.
2018-04-26 15:05:21 -04:00
Jason Simmons
dd83413e52 libtxt: post-process glyph positions in order to accurately right-justify text (flutter/engine#5093)
Previously libtxt was applying right justification during line layout based on
the line width returned by the Minikin line breaker.  However, this width does
not include the width of leading or trailing whitespace.

So in a right justified line the starting offset of the first glyph would not
account for the advance of the leading whitespace, resulting in text being
clipped.

This PR applies line justification after the glyphs are laid out and the full
advance of the text is known.

Fixes https://github.com/flutter/flutter/issues/16333
2018-04-26 09:42:38 -07:00
Alexander Aprelev
7bbee90efb Set file modified callback. (flutter/engine#5096)
This fixes dart1 hot reload regression caused by 82c5c8fed.
2018-04-26 08:43:28 -07:00
skia-flutter-autoroll
a7dfc1e16c Roll src/third_party/skia/ 5c9369eb1..c79e2d155 (7 commits) (flutter/engine#5099)
Auto-roller completed checks. Merging.
2018-04-26 11:34:21 -04:00
skia-flutter-autoroll
8b1b4f36cf Roll src/third_party/skia/ 643ab1bf5..5c9369eb1 (1 commit; 1 trivial rolls) (flutter/engine#5098)
Auto-roller completed checks. Merging.
2018-04-26 08:05:21 -04:00
skia-flutter-autoroll
fd755f18af Roll src/third_party/skia/ 6b043cb9c..643ab1bf5 (3 commits; 3 trivial rolls) (flutter/engine#5097)
Auto-roller completed checks. Merging.
2018-04-26 04:35:21 -04:00
skia-flutter-autoroll
dc3fc3f9ff Roll src/third_party/skia/ 1366282bc..6b043cb9c (2 commits) (flutter/engine#5095)
Auto-roller completed checks. Merging.
2018-04-26 01:05:21 -04:00
skia-flutter-autoroll
bf261935e4 Roll src/third_party/skia/ 580aee2fa..1366282bc (2 commits) (flutter/engine#5094)
Auto-roller completed checks. Merging.
2018-04-25 21:36:21 -04:00
Dan Field
4fc5359abc Path metrics/getBounds/combinations again (flutter/engine#4957)
* add path measure

* fix typo

* getBound and addPathWithMatrix

* Add myself to Authors, add PathOps

* fix linting issues

* update licenses_flutter to add new files

* Use matrix4 instead of matrix3 for consistency/interop

* put pubspec back

* fix bug in getSegment

* fix typo

* Add return value for PathOp

* refactoring from review

* refactoring from review - still TBD on computeMetrics()

* add doc

* lint issue

* fix computeMetrics, add Path.from

* add missing wireup for clone

* change PathMetrics to iterable, fix bug with angle on Tangent

* prefer std::make_unique

* cleanup docs

* add path measure

* fix typo

* getBound and addPathWithMatrix

* Add myself to Authors, add PathOps

* fix linting issues

* update licenses_flutter to add new files

* Use matrix4 instead of matrix3 for consistency/interop

* put pubspec back

* fix bug in getSegment

* fix typo

* Add return value for PathOp

* refactoring from review

* refactoring from review - still TBD on computeMetrics()

* add doc

* lint issue

* fix computeMetrics, add Path.from

* add missing wireup for clone

* change PathMetrics to iterable, fix bug with angle on Tangent

* prefer std::make_unique

* cleanup docs

* fix iterator bug

* remove unnecessary clone for computeMetrics

* fix some doc issues

* fix PathMeasure iterator, extendWithPath, isClosed, and pubspec.lock

* get rid of orElse; use StateException

* StateError, not StateException

* doc improvements and nits

* add unit tests, fix bugs found during testing

* fix two uncommited doc changes

* one more

* change sign of tangent angle, update docs

* update unit tests for inverted angle

* update tangent to include vector

* Doc fixes

* Fix MSVC compilation and unit test
2018-04-25 15:35:01 -07:00
skia-flutter-autoroll
0353af338c Roll src/third_party/skia/ de5cffbc4..580aee2fa (16 commits) (flutter/engine#5092)
Auto-roller completed checks. Merging.
2018-04-25 18:06:21 -04:00
Ben Konyi
e603014960 Initial plugin support for background downloads + content fetching (flutter/engine#5082)
* Added handleEventsForBackgroundURLSession and
performFetchWithCompletionHandler handlers in FlutterAppDelegate to
allow for plugins to perform background downloads and fetch small
amounts of data opportunistically.
2018-04-25 13:35:01 -07:00
Ryan Macnak
b8b7e8e829 [fuchsia] Changes for running Dart 2 on flutter_runner. (flutter/engine#5080)
- Remove assumption that we're in Dart 2 mode only if there's a platform kernel.
 - Load core snapshots from the package instead of linking them in.
2018-04-25 13:31:13 -07:00
skia-flutter-autoroll
007b8245bc Roll src/third_party/skia/ 77e95f706..de5cffbc4 (14 commits) (flutter/engine#5090)
Auto-roller completed checks. Merging.
2018-04-25 14:37:21 -04:00
Jason Simmons
13b1f11bfe Throw an exception if a secondary isolate tries to send a platform message (flutter/engine#5069)
Platform messages are only support in the UI isolate.  Secondary isolates
do not have a window that can receive incoming messages, and outgoing messages
are not tagged with a destination isolate and thus will always be dispatched
to the UI isolate.

Fixes https://github.com/flutter/flutter/issues/16846
2018-04-25 10:29:20 -07:00
Michael Goderbauer
890dd8c739 Roll Dart to 8d4074175fb95cd4da810b4bf652a956449bac37 (flutter/engine#5089) 2018-04-25 10:03:19 -07:00
skia-flutter-autoroll
fd3d2a8b75 Roll src/third_party/skia/ ec4e7358b..77e95f706 (1 commit) (flutter/engine#5088)
Auto-roller completed checks. Merging.
2018-04-25 11:03:43 -04:00
skia-flutter-autoroll
8ebad2420d Roll src/third_party/skia/ e1c37a7b8..ec4e7358b (1 commit) (flutter/engine#5087)
Auto-roller completed checks. Merging.
2018-04-25 10:18:17 -04:00
skia-flutter-autoroll
3515b6457f Roll src/third_party/skia/ 058f2e6ed..e1c37a7b8 (4 commits) (flutter/engine#5086)
Auto-roller completed checks. Merging.
2018-04-25 08:18:06 -04:00
Michael Goderbauer
fafddbcd6a Revert "Roll dart to 29d6e963702fcbb0ed0d5ca67d6b5f977ac0c328 (#5083)" (flutter/engine#5085)
This reverts commit efeed7c717.
2018-04-24 18:49:40 -07:00
Michael Goderbauer
efeed7c717 Roll dart to 29d6e963702fcbb0ed0d5ca67d6b5f977ac0c328 (flutter/engine#5083)
Picks up a fix for math on 32bit ARM devices running iOS, required for https://github.com/flutter/flutter/issues/2089.
2018-04-24 18:06:53 -07:00
Chinmay Garde
602b9b7c33 Add disabled failing test for floating point errors on matrix decomposition. (flutter/engine#5076) 2018-04-24 16:02:38 -07:00
Jason Simmons
c2b081e229 Hold a global reference to the AssetManager Java object backing the APKAssetProvider (flutter/engine#5078)
Fixes https://github.com/flutter/flutter/issues/16222
2018-04-24 15:50:52 -07:00
skia-flutter-autoroll
3db089f957 Roll src/third_party/skia/ 2d2c1e32c..058f2e6ed (35 commits; 1 trivial rolls) (flutter/engine#5077)
Auto-roller completed checks. Merging.
2018-04-24 18:02:07 -04:00
skia-flutter-autoroll
dd968eefe9 Roll src/third_party/skia/ 5209d7fce..2d2c1e32c (42 commits; 1 trivial rolls) (flutter/engine#5070)
Auto-roller completed checks. Merging.
2018-04-24 14:35:06 -04:00
Ryan Macnak
0c28a669f2 [fuchsia] Remove dead package file generation from core snapshots. (flutter/engine#5071) 2018-04-24 09:33:52 -07:00
Chinmay Garde
7293d4cef9 Fixup Fuchsia content handler post shell refactor. (flutter/engine#5072) 2018-04-23 20:16:01 -07:00
Yegor
82678dc356 replace nextNodeId/previousNodeId with hitTestPosition (flutter/engine#5066) 2018-04-23 16:16:17 -07:00