Commit Graph

16736 Commits

Author SHA1 Message Date
Kate Lovett
d0ea9ed244 SliverOffstage (#45128) 2019-11-25 12:49:10 -08:00
Kate Lovett
1160c8fd29 Re-Staged: Fixing ContinuousRectangleBorder bottom radius (#45304) 2019-11-25 12:43:58 -08:00
engine-flutter-autoroll
c64d91a03f Roll engine b6b54fd60631..b0d2caceab25 (2 commits) (#45564)
git@github.com:flutter/engine.git/compare/b6b54fd60631...b0d2caceab25

git log b6b54fd60631..b0d2caceab25 --first-parent --oneline
2019-11-25 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from Q9HKI... to 1nxSz... (#13995)
2019-11-25 30870216+gaaclarke@users.noreply.github.com Removed auto roll commits from auto_assign. (#13992)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-11-25 15:41:51 -05:00
Jonah Williams
cf37c2cd07 Add assert for negative child count in ListView.builder (#45506) 2019-11-25 12:04:30 -08:00
Jonah Williams
1888fa3526 Allow flutter run to run release/profile x64 (#45511) 2019-11-25 12:04:17 -08:00
Alexandre Ardhuin
e6935efdf6 remove avoid_as lint for the upcoming implicit-casts: false (#45527) 2019-11-25 21:03:29 +01:00
Emmanuel Garcia
81724bd60f Fallback to protocol discovery if mdns returns null (#45439) 2019-11-25 11:51:54 -08:00
Michael Klimushyn
901eb0fc81 Add a note to generated plugins files (#45557)
There has been some confusion about whether or not
.flutter-plugins-dependencies should be tracked in version control or
not. Added a comment to both it and .flutter-plugins explaining that
it's generated and shouldn't be.

.flutter-plugins-dependencies is parsed through JSON, and the JSON spec
doesn't support comments. So unfortunately the note is living in an
arbitrary "_info" key instead of an obvious top level comment.
2019-11-25 11:47:20 -08:00
Jenn Magder
4cc10a1fb8 Revert "Always compile with isysroot on iOS to point to SDK root (#45436)" (#45555)
Analyzer warning.
2019-11-25 10:46:42 -08:00
Jenn Magder
6b11f18bc0 Always compile with isysroot on iOS to point to SDK root (#45436) 2019-11-25 10:27:22 -08:00
Todd Volkert
bae92c32e5 Disable tests that fail on non-master branches from running on those branches (#45455)
https://github.com/flutter/flutter/issues/45453
2019-11-24 22:29:28 -08:00
Alexandre Ardhuin
980f14e0c5 implicit-casts:false on flutter_tools (#45153)
* implicit-casts:false on flutter_tools

* use castStringKeyedMap

* address review comments

* address review comments

* fix issues after rebase
2019-11-24 06:54:43 +01:00
engine-flutter-autoroll
033b897be5 b6b54fd60 PR (#45456)
git@github.com:flutter/engine.git/compare/591144dfef59...b6b54fd60631

git log 591144dfef59..b6b54fd60631 --no-merges --oneline
2019-11-23 chinmaygarde@google.com PR


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-11-23 04:05:54 -05:00
engine-flutter-autoroll
f87cbe05b9 591144dfe Roll src/third_party/dart 603fd7881f..16cbabec3a (1 commits) (flutter/engine#13994) (#45452)
git@github.com:flutter/engine.git/compare/d1cac77d5a4e...591144dfef59

git log d1cac77d5a4e..591144dfef59 --no-merges --oneline
2019-11-23 bkonyi@google.com Roll src/third_party/dart 603fd7881f..16cbabec3a (1 commits) (#13994)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-11-23 03:09:54 -05:00
engine-flutter-autoroll
f40dbf8ca0 d1cac77d5 Roll src/third_party/skia 47af12aa8331..c3ff97a98b74 (3 commits) (flutter/engine#13993) (#45450)
git@github.com:flutter/engine.git/compare/a6e890666d22...d1cac77d5a4e

git log a6e890666d22..d1cac77d5a4e --no-merges --oneline
2019-11-23 skia-flutter-autoroll@skia.org Roll src/third_party/skia 47af12aa8331..c3ff97a98b74 (3 commits) (#13993)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-11-23 01:02:54 -05:00
Takeshi Tsukamoto
a3eeb51a1b Fix draggable scrollable sheet scroll notification (#45083) 2019-11-22 21:48:38 -08:00
engine-flutter-autoroll
5fb790e6ed a6e890666 Roll src/third_party/dart 5b5f34f2e6..603fd7881f (11 commits) (flutter/engine#13991) (#45448)
git@github.com:flutter/engine.git/compare/584d95868875...a6e890666d22

git log 584d95868875..a6e890666d22 --no-merges --oneline
2019-11-23 bkonyi@google.com Roll src/third_party/dart 5b5f34f2e6..603fd7881f (11 commits) (#13991)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-11-23 00:10:54 -05:00
Kaushik Iska
144eb45aa4 Engine roll to include SkRRect fix (#45442)
584d95868 (HEAD -> master, upstream/master) [fuchsia] Capture SkRRect in scene_update_context by value (#13989)
0f530a7f2 Roll src/third_party/skia 078e8faa26d8..47af12aa8331 (22 commits) (#13987)
97a23a80e Made a way to turn off the OpenGL operations on the IO thread for backgrounded apps (#13908)
0d60e1a32 Do not default to downstream affinity on iOS insertText (#13852)
9c6836680 Added auto-reviewer config file (#13962)
a5f42905b Roll fuchsia/sdk/core/linux-amd64 from mvesW... to _7JyV... (#13983)
69f94a501 Roll src/third_party/dart 029e06b8d9..5b5f34f2e6 (10 commits) (#13982)
2019-11-22 19:07:11 -08:00
engine-flutter-autoroll
90960b1246 Roll engine 8df3eb80574e..0d60e1a324c8 (3 commits) (#45445)
git@github.com:flutter/engine.git/compare/8df3eb80574e...0d60e1a324c8

git log 8df3eb80574e..0d60e1a324c8 --no-merges --oneline
2019-11-22 garyq@google.com Do not default to downstream affinity on iOS insertText (#13852)
2019-11-22 30870216+gaaclarke@users.noreply.github.com Added auto-reviewer config file (#13962)
2019-11-22 bkonyi@google.com Roll src/third_party/dart 029e06b8d9..5b5f34f2e6 (10 commits) (#13982)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-11-22 21:45:54 -05:00
engine-flutter-autoroll
53343f8a68 Roll engine 89e395853c6b..8df3eb80574e (2 commits) (#45434)
git@github.com:flutter/engine.git/compare/89e395853c6b...8df3eb80574e

git log 89e395853c6b..8df3eb80574e --no-merges --oneline
2019-11-22 jonahwilliams@google.com Add dev_compiler and frontend_server to package uploading rule (#13926)
2019-11-22 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from l1EAN... to Q9HKI... (#13979)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-11-22 19:35:54 -05:00
chunhtai
f15f69a8b8 Drops detached message until we can handle it properly (#45430) 2019-11-22 16:10:46 -08:00
engine-flutter-autoroll
54aa53ab2e Roll engine ad14574949f5..89e395853c6b (2 commits) (#45429)
git@github.com:flutter/engine.git/compare/ad14574949f5...89e395853c6b

git log ad14574949f5..89e395853c6b --no-merges --oneline
2019-11-22 30870216+gaaclarke@users.noreply.github.com Refactor to passing functions by const ref (#13975)
2019-11-22 skia-flutter-autoroll@skia.org Roll src/third_party/skia 7a538b1eeccd..078e8faa26d8 (1 commits) (#13978)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-11-22 18:22:54 -05:00
Emmanuel Garcia
b6e92003c8 Add .flutter-plugins-dependencies to the project, which contains the app's plugin dependency graph (#45379) 2019-11-22 15:02:20 -08:00
engine-flutter-autoroll
161e4dfb04 ad1457494 Updated googletest to fix fuchsia build. (flutter/engine#13980) (#45421)
git@github.com:flutter/engine.git/compare/9f4341a2b869...ad14574949f5

git log 9f4341a2b869..ad14574949f5 --no-merges --oneline
2019-11-22 30870216+gaaclarke@users.noreply.github.com Updated googletest to fix fuchsia build. (#13980)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-11-22 17:27:54 -05:00
Jonah Williams
b54bb6abbb Dont crash if the tool cannot delete asset directory during debugging (#45407) 2019-11-22 14:06:05 -08:00
Jonah Williams
35b571ccfc Revert "Improve time to development by initializing frontend_server concurrently with platform build (#45236)" (#45422) 2019-11-22 13:36:12 -08:00
Jonah Williams
c63c576bca Reland handle corrupt config file (#45414) 2019-11-22 12:26:51 -08:00
Jonah Williams
60869e0a93 Improve time to development by initializing frontend_server concurrently with platform build (#45236) 2019-11-22 12:26:31 -08:00
Alexandre Ardhuin
0a66d8a7a4 implicit-casts:false in fuchsia_remote_debug_protocol (#45239) 2019-11-22 20:33:47 +01:00
Kate Lovett
e2cf2f0fa2 SliverOpacity (#44289) 2019-11-22 11:12:09 -08:00
xster
942707591d Revert "catch parse error from corrupt config (#45319)" (#45412) 2019-11-22 10:56:16 -08:00
Jonah Williams
6640c8b9b4 catch parse error from corrupt config (#45319) 2019-11-22 10:09:23 -08:00
Jonah Williams
497ae83c82 Fix experimental incremental web compiler for Windows (#45286) 2019-11-22 10:08:38 -08:00
Kate Lovett
9f17a43ebe SliverIgnorePointer (#45127) 2019-11-22 09:54:09 -08:00
engine-flutter-autoroll
33d302240d Roll engine 7e68097cc1d3..9f4341a2b869 (8 commits) (#45402)
git@github.com:flutter/engine.git/compare/7e68097cc1d3...9f4341a2b869

git log 7e68097cc1d3..9f4341a2b869 --no-merges --oneline
2019-11-22 bkonyi@google.com Roll src/third_party/dart 77ac3d0a5c..029e06b8d9 (4 commits) (#13974)
2019-11-22 skia-flutter-autoroll@skia.org Roll src/third_party/skia 0788481c63dc..7a538b1eeccd (3 commits) (#13973)
2019-11-22 bkonyi@google.com Roll src/third_party/dart 09d22a0509..77ac3d0a5c (14 commits) (#13970)
2019-11-22 iska.kaushik@gmail.com [fuchsia] Ensure we do not initialize nan RoundedRectangles (#13971)
2019-11-21 matthew-carroll@users.noreply.github.com Removed GET_ACTIVITIES flag from all manifest meta-data lookups. (#38891) (#13932)
2019-11-21 jason-simmons@users.noreply.github.com Remove the strace debug logging from the Fuchsia gen_package script (#13963)
2019-11-21 cstout@google.com [shell][fuchsia] Migrate away from deprecated async loop configs
2019-11-21 bkonyi@google.com Roll src/third_party/dart 521b168441..6fa41ae6f9 (1 commits) (#13961)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-11-22 12:28:33 -05:00
Yegor
aa3943316b Fix dartDefines in daemon mode (#45317)
* de-null dartDefines in daemon mode
* remove daemonCommand; pipe through dartDefines into Daemon
* pass dartDefiles in attach; add test for --machine mode
2019-11-22 08:57:14 -08:00
Greg Spencer
a60bf8e23a Spell check of Flutter docs (#45200)
No code changes, just comments: I spell-checked all the comments in the repo.
2019-11-22 08:43:55 -08:00
Alexandre Ardhuin
fcb40a05bb make some BuildContext methods generics (#44189)
* make BuildContext.{ancestorStateOfType,ancestorRenderObjectOfType,rootAncestorStateOfType} generic

* make BuildContext.inheritFromWidgetOfExactType generic

* make BuildContext.ancestorInheritedElementForWidgetOfExactType generic

* make BuildContext.ancestorWidgetOfExactType generic

* fix snippet

* bump scoped_model on temp version

* update names

* Revert "bump scoped_model on temp version"

This reverts commit d1fcbba028cdb07f44738d1652391692d1ea5ec0.

* address review comments

* fix ci

* address review comments

* repeat the deprecation notice

* fix uppercase

* use of recommanded deprecation syntax

* address review comment
2019-11-22 17:35:20 +01:00
Fedor Korotkov
7fcf030610 [ci] more resources to Windows tasks (#45392)
There was a bug in Cirrus that Cirrus always used 4CPU config for Windows Containers even though everything was billed according to the resources configured (in your case 2 CPUs).
2019-11-22 07:39:15 -08:00
Todd Volkert
4c64b715d9 Revert "Add option to delay rendering the first frame (#45135)" (#45385)
This reverts commit d285b8843f.
2019-11-21 22:12:24 -08:00
Todd Volkert
cb35c88b34 Add widget of the week video embeddings (#45362) 2019-11-21 22:07:03 -08:00
engine-flutter-autoroll
873e33c793 Roll engine 96fc607b8a54..7e68097cc1d3 (2 commits) (#45371)
git@github.com:flutter/engine.git/compare/96fc607b8a54...7e68097cc1d3

git log 96fc607b8a54..7e68097cc1d3 --no-merges --oneline
2019-11-21 ferhat@gmail.com [web] Fix line-height for Firefox (flutter/engine#13960)
2019-11-21 mouad.debbar@gmail.com [web] Allow users to enable canvas text measurement (flutter/engine#13929)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-11-22 01:03:51 -05:00
engine-flutter-autoroll
ae88f0190e Roll engine f91934073ee1..96fc607b8a54 (3 commits) (#45366)
git@github.com:flutter/engine.git/compare/f91934073ee1...96fc607b8a54

git log f91934073ee1..96fc607b8a54 --no-merges --oneline
2019-11-21 mouad.debbar@gmail.com [web] Refactor text editing to handle any order of platform messages gracefully (flutter/engine#13741)
2019-11-21 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from FQdiV... to l1EAN... (flutter/engine#13956)
2019-11-21 skia-flutter-autoroll@skia.org Roll src/third_party/skia f9291b8942d8..4e0255508749 (27 commits) (flutter/engine#13954)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-11-21 19:38:51 -05:00
Amir Hardon
e43a69a9fe Allow a no-op default_package key for a plugin platform (#45364) 2019-11-21 16:37:34 -08:00
engine-flutter-autoroll
90718da007 f91934073 Roll src/third_party/dart aa2b3a5eaa..521b168441 (15 commits) (flutter/engine#13958) (#45361)
git@github.com:flutter/engine.git/compare/a38839817cda...f91934073ee1

git log a38839817cda..f91934073ee1 --no-merges --oneline
2019-11-21 bkonyi@google.com Roll src/third_party/dart aa2b3a5eaa..521b168441 (15 commits) (flutter/engine#13958)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-11-21 18:14:50 -05:00
engine-flutter-autoroll
b4f4886a11 Roll engine 7a77e3625dd1..a38839817cda (4 commits) (#45355)
git@github.com:flutter/engine.git/compare/7a77e3625dd1...a38839817cda

git log 7a77e3625dd1..a38839817cda --no-merges --oneline
2019-11-21 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from VHWsK... to zgJ75... (flutter/engine#13957)
2019-11-21 bkonyi@google.com Roll src/third_party/dart 867a6e0e52..aa2b3a5eaa (15 commits) (flutter/engine#13955)
2019-11-21 30870216+gaaclarke@users.noreply.github.com Made the thread checker print out the thread names on Apple platforms. (flutter/engine#13943)
2019-11-21 liyuqian@google.com Fix picture raster cache throttling (flutter/engine#13710)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-11-21 16:30:51 -05:00
liyuqian
c61ef90f94 Upgrade gauge for debugging (#45212)
For https://github.com/flutter/flutter/issues/45194
and see also https://github.com/flutter/packages/pull/47.
2019-11-21 13:03:02 -08:00
Zachary Anderson
05226d2a61 Reland: [flutter_tool] Fuchsia AOT builds (#45350)
* Reland: [flutter_tool] Fuchsia AOT builds

* Fixes
2019-11-21 12:55:39 -08:00
Jonah Williams
785e557a43 remove Flags (#45320) 2019-11-21 12:52:52 -08:00
Kaushik Iska
1fae83cf2c [fuchsia] Reland use sky_engine from Topaz (#45282)
Testes on the Fuchsia tree by reverting it locally.

This reverts commit f45bd48cca.
2019-11-21 12:48:32 -08:00