firka/flutter
3
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
31,632 Commits 1 Branch 0 Tags
ca7fbf5166b3f26fdfc3d871ba0df6d1791ab8bf
Commit Graph

24040 Commits

Author SHA1 Message Date
skia-flutter-autoroll
ca7fbf5166 Roll Skia from 8d9e2cd32ec7 to 8752f3ac6e99 (1 revision) (flutter/engine#46186) 
https://skia.googlesource.com/skia.git/+log/8d9e2cd32ec7..8752f3ac6e99

2023-09-22 armansito@google.com [graphite] Ensure CoverageMaskShapes are created with a valid proxy

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,rmistry@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-22 08:29:46 +00:00
skia-flutter-autoroll
5422cccc4f Roll Skia from 3ae3bb0d40df to a3480a62e438 (1 revision) (flutter/engine#46183) 
https://skia.googlesource.com/skia.git/+log/3ae3bb0d40df..a3480a62e438

2023-09-22 jvanverth@google.com [Graphite] Fix typo in PathAtlasFlags

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,rmistry@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-22 06:59:27 +00:00
skia-flutter-autoroll
eeb6f85a38 Roll Skia from 97ec4dbabd05 to 3ae3bb0d40df (1 revision) (flutter/engine#46182) 
https://skia.googlesource.com/skia.git/+log/97ec4dbabd05..3ae3bb0d40df

2023-09-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from af63cb4763f0 to 8ddc74eefa73 (3 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,rmistry@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-22 06:11:23 +00:00
Bruno Leroux
87139861e6 [iOS] Disable spelling corrections when auto correction is disabled (flutter/engine#46144) 
## Description

This iOS PR disables spellchecking when auto correction is disabled.

## Related Issue

Fixes https://github.com/flutter/flutter/issues/134881.

## Tests

Adds 1 test.
 2023-09-22 06:00:58 +00:00
skia-flutter-autoroll
68c0f17e18 Roll Dart SDK from eaeca487c944 to 5d33f4c85b82 (1 revision) (flutter/engine#46176) 
https://dart.googlesource.com/sdk.git/+log/eaeca487c944..5d33f4c85b82

2023-09-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-188.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-22 01:36:24 +00:00
Dan Field
3ade44e1c7 [Impeller] fail if software backend is chosen and Impeller is enabled on iOS (flutter/engine#46124) 
Fixes https://github.com/flutter/flutter/issues/127408

This is also related to https://github.com/flutter/engine/pull/44346, which made it fatal to explicitly request both impeller and the software backend.

Before landing this, we need to update some google internal tests that end up in this state to explicitly request Skia (or to get into a mode where they can actually use metal).
 2023-09-22 00:31:00 +00:00
skia-flutter-autoroll
9dec78361a Roll Skia from 611f08987be3 to 5b2dae1a9b54 (2 revisions) (flutter/engine#46168) 
https://skia.googlesource.com/skia.git/+log/611f08987be3..5b2dae1a9b54

2023-09-21 jvanverth@google.com [graphite] Hook up software path renderer.
2023-09-21 jreck@google.com Add missing const

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,rmistry@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-21 23:26:06 +00:00
Matan Lurey
6aa20016ac Revert #46131, don't store vkImage, reset vkComandPool synchronously (flutter/engine#46166) 
Closes https://github.com/flutter/flutter/issues/135086.

Reverts https://github.com/flutter/engine/pull/46131.

This PR bundles together 3 changes that removes all validation errors on the `macrobenchmark` apps I could manually find:

1. Reverts https://github.com/flutter/engine/pull/46131, which did not fix the original issue.
2. Added `kResetOnBackgroundThread = false`, which drops performance benefits, but doesn't cause threading issues.
3. Stop tracking `image` for Swapchain presentation (was hitting Vulkan assertion errors about acquired images).

/cc @gaaclarke I'd love to talk about how we could run the macrobenchmarks app on CI, with validation errors, after landing.
 2023-09-21 23:10:37 +00:00
skia-flutter-autoroll
1515f2e53f Roll Skia from a0928a46b9c8 to 611f08987be3 (2 revisions) (flutter/engine#46165) 
https://skia.googlesource.com/skia.git/+log/a0928a46b9c8..611f08987be3

2023-09-21 brianosman@google.com Add working color space shader
2023-09-21 avi@chromium.org Remove deprecated API use

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,rmistry@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-21 22:39:04 +00:00
skia-flutter-autoroll
688a066626 Roll Skia from 0cf83a86c56d to a0928a46b9c8 (19 revisions) (flutter/engine#46164) 
https://skia.googlesource.com/skia.git/+log/0cf83a86c56d..a0928a46b9c8

2023-09-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 79912a37e72c to b7c710e0c890 (5 revisions)
2023-09-21 jlavrova@google.com Fixing Flutter roll build
2023-09-21 michaelludwig@google.com Remove extra semicolon after macro
2023-09-21 johnstiles@google.com Remove packDouble2x32 intrinsics from SkSL.
2023-09-21 johnstiles@google.com Add SkRuntimeEffectPriv::VarAsChild.
2023-09-21 robertphillips@google.com [graphite] Implement Image and Blend Shaders using the Blend helper
2023-09-21 johnstiles@google.com Split apart MeshSpec tests into separate DEF_TESTs.
2023-09-21 brianosman@google.com [graphite] Return transparent black when evaluating null child shader
2023-09-21 armansito@google.com [graphite][compute] Coverage mask format based on storage binding support
2023-09-21 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll ANGLE from e305459968f2 to 8fcd4a50ab47 (9 revisions)
2023-09-21 michaelludwig@google.com [skif] Combine isCropped() and modifiesPixelsBeyondImage()
2023-09-21 bungeman@google.com [skshaper] Use locale for line breaking
2023-09-21 jlavrova@google.com Set of utilities for Unicode comparison: Skia changes
2023-09-21 robertphillips@google.com [graphite] Implement DstReads w/ Blend helper
2023-09-21 johnstiles@google.com Disable DeadReturnES3 test on Radeon due to crashing.
2023-09-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from b4674d1b2f50 to bbf6a30f67f4
2023-09-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll jsfiddle-base from f4090760c770 to 3605928905e4
2023-09-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll shaders-base from c6e5b668b1a4 to 84356d9e8452
2023-09-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll debugger-app-base from b5dc6c526875 to 72a86e8cc35e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,rmistry@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-21 21:54:02 +00:00
John McCutchan
72c674cc1c Re-enable HardwareBuffer backed Platform Views on Android >= 29 (flutter/engine#46071) 2023-09-21 14:40:31 -07:00
Jonah Williams
eaa5fe4b74 [Impeller] Use final cmd buffer to present drawable. (flutter/engine#46023) 
If we're not running with a transaction then we don't need to block on waitUntilScheduled on any platform. I think this should always work, as the problems we had before were due to always using drawable present. But this helper method schedules the drawable presentation after the cmd buffer is scheduled - which is what we're doing with waitUntilScheduled anyway - just non blocking from our perspective.

Fixes https://github.com/flutter/flutter/issues/131520
 2023-09-21 21:16:18 +00:00
Matan Lurey
3cea82e53b More Clang Tidy --fix[es] to header files (flutter/engine#46151) 
More work towards https://github.com/flutter/flutter/issues/134969.

I decided not to touch the `LOG_X` variables since they are just used in macro expansion.
 2023-09-21 21:16:16 +00:00
Tong Mu
38b8ce1c29 Reland: Enforce the rule of calling FlutterView.Render (#45300) (flutter/engine#45555) 
This PR relands #45300 which was reverted in https://github.com/flutter/engine/pull/45525 due to hanging on a windows startup test. The culprit test still calls `FlutterView.render` in the illegal way, which is ignored, causing no frame being ever produced. This has been fixed in https://github.com/flutter/flutter/pull/134245. I've also searched through the framework repo for `render(` to ensure there are no other cases.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-09-21 21:11:03 +00:00
Yegor
df462f2b6e Revert "[web] fix clicks on merged semantic nodes (#43620)" (flutter/engine#46067) 
This reverts commit 6dee3dd14e.

The commit caused https://github.com/flutter/flutter/issues/134842. I'm going to try again, this time accounting for nested clickables/tappables.
 2023-09-21 19:57:55 +00:00
Matan Lurey
3d3a76280d Move git_repo_tools and process_fakes outside of clang_tidy. (flutter/engine#46017) 
Closes https://github.com/flutter/flutter/issues/134988.
 2023-09-21 12:16:42 -07:00
godofredoc
6fe6f6b086 Remove linux fuchsia from recipes cq. (flutter/engine#46153) 
With some recent changes led builds can only run if they use -real-build. The migration of fuchsia builds to use -real-build as involved as migrating it to engine v2 and we are implementing the second one.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-09-21 18:56:06 +00:00
skia-flutter-autoroll
e86f8269e5 Roll Dart SDK from d5d05146868a to eaeca487c944 (2 revisions) (flutter/engine#46138) 
https://dart.googlesource.com/sdk.git/+log/d5d05146868a..eaeca487c944

2023-09-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-187.0.dev
2023-09-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-186.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-21 09:31:22 +00:00
skia-flutter-autoroll
9734b3ddba Roll Skia from 81b9c7fd19b2 to c20aeee90da9 (3 revisions) (flutter/engine#46134) 
https://skia.googlesource.com/skia.git/+log/81b9c7fd19b2..c20aeee90da9

2023-09-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 918412e0912f to af63cb4763f0 (11 revisions)
2023-09-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 881dc3bb55fd to 2eae44a62806 (11 revisions)
2023-09-21 johnstiles@google.com Add new flags to sksl-minify usage string.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,rmistry@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-21 05:36:12 +00:00
Jonah Williams
98d9a51a31 [Impeller] temp work around for cmd pool validation issues. (flutter/engine#46131) 
I'm not able to reproduce most validation errors in the macrobenchmark app with this change. THe real fix seems to be to track this last cmd buffer but I'm struggling to find a way to do this.
 2023-09-21 03:48:47 +00:00
Matan Lurey
172411fc8e Tidy up DlPaint and friends. (flutter/engine#46120) 
Closes https://github.com/flutter/flutter/issues/135058.

Work towards https://github.com/flutter/flutter/issues/134969.

All fixes are generated by `clang-tidy --fix`, and manual search/replace
if that wasn't sufficient.
 2023-09-20 18:41:27 -07:00
gaaclarke
6d15ab00ed [Impeller] removed global mutable variable for tessellation allocation function pointers (flutter/engine#46127) 
issue: https://github.com/flutter/flutter/issues/125749

This removes a global mutable variable, instead giving each tesellator its own struct.  I suspect the root cause of the linked  issue is memory corruption but this is good cleanup anyways.  If for some reason libTess2 is mutating that global variable at cleanup, that could be the source of this problem and this would fix the issue.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-09-21 00:22:05 +00:00
Jonah Williams
9b906fb887 [Impeller] Remove removal of save layer from clip. (flutter/engine#46113) 
Fixes https://github.com/flutter/flutter/issues/134705

The save layer is observable so it isn't safe to optimize out.
 2023-09-20 22:55:51 +00:00
Jason Simmons
32d185de0f [Impeller] Apply the entity transformation when rendering FramebufferBlendContents (flutter/engine#46106) 
Fixes https://github.com/flutter/flutter/issues/134930
 2023-09-20 22:38:04 +00:00
Matan Lurey
2681bee9ca Clang tidy-ify DlColor and friends. (flutter/engine#46122) 
Closes https://github.com/flutter/flutter/issues/135057.

This is a fair bit more involved than previous changes, just due to the sheer number of implicit conversions.

Highlights:

- Made `public uint32_t argb` `private uint32_t argb_`, and added `argb()` instead.
- Added `ToSk(DlColor)` instead of using implicit conversions.

There were a bunch of places where I had to make a judgement call (particularly in tests) to keep the code a bit "messy", i.e. `DlColor(SK_RED)`, just to make the diff as small as possible and to prevent silly copy and paste bugs. I'd be open to filing a follow-up issue to reduce unnecessary wrapping.
 2023-09-20 22:08:07 +00:00
godofredoc
5b6044864e Apply the right tag for linux fuchsia cipd packages. (flutter/engine#46123) 
The cipd packages were all being uploaded and tagged with git:HEAD.

Bug: https://github.com/flutter/flutter/issues/126461

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-09-20 22:08:05 +00:00
skia-flutter-autoroll
a75aea7d29 Roll Skia from d923bab3d5fa to b78c91996051 (4 revisions) (flutter/engine#46119) 
https://skia.googlesource.com/skia.git/+log/d923bab3d5fa..b78c91996051

2023-09-20 kjlubick@google.com Revert "Revert "Make SKP deserialize null instead of PNG images by default.""
2023-09-20 johnstiles@google.com Remove PackUnorm2x16 from SkSL tests.
2023-09-20 kjlubick@google.com Tidy up public.bzl rules for iOS
2023-09-20 johnstiles@google.com Fix test disables for PowerVR Rogue GE8300.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,rmistry@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-20 21:00:04 +00:00
Matan Lurey
6178baa159 Make dl_color_(filter|source) tidy. (flutter/engine#46111) 
Closes https://github.com/flutter/flutter/issues/135060.
Closes https://github.com/flutter/flutter/issues/135061.

Bundled these two together as they are similar. Pretty boring `instance`
-> `kInstance`, and `explicit`/`std::move`.
 2023-09-20 13:24:59 -07:00
Matan Lurey
59aa61b3f3 Make dl_(image|mask|path)_(filter|effect).h tidy! (flutter/engine#46110) 
Closes https://github.com/flutter/flutter/issues/135064.
Closes https://github.com/flutter/flutter/issues/135063.
Closes https://github.com/flutter/flutter/issues/135062.

I bundled a few of these together because they didn't have side-effects
across the repo (self-contained).

**NOTE**: All changes were auto-generated by `clang-tidy --fix`.
 2023-09-20 13:24:26 -07:00
Matan Lurey
476b46954c Migrate from LOG_X to kLogX. (flutter/engine#46107) 
These should be entirely non-breaking, i.e. 1:1 and same backing `int`
value.

(See https://github.com/flutter/engine/pull/46052)
 2023-09-20 13:24:01 -07:00
skia-flutter-autoroll
002e1a2047 Roll Skia from b3c1f49821d8 to d923bab3d5fa (2 revisions) (flutter/engine#46118) 
https://skia.googlesource.com/skia.git/+log/b3c1f49821d8..d923bab3d5fa

2023-09-20 johnstiles@google.com Add pack/unpack intrinsics to WGSL code generator.
2023-09-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from b8fa58ef74a9 to 2aba50a6944f (14 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,rmistry@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-20 20:12:03 +00:00
Matan Lurey
e8e914e142 Make a variety of low-impact Clang tidy fixes in Impeller. (flutter/engine#46116) 
Work towards https://github.com/flutter/flutter/issues/134969.

These are all self-contained, so I bundled them all together.

All fixes are generated by `clang-tidy --fix`, and manual search/replace if that wasn't sufficient.
 2023-09-20 20:00:57 +00:00
Chris Yang
bc8e93271b [ios] fix asset url not found when loading app extension (flutter/engine#46073) 
In b3fc48b91b, I refactored the assetsPath to use NSURL. It turns out that when the app bundle is not loaded (during launching app exgtension), the assetURL will return nil using the `URLForResource`, but the `pathForResource` successfully returns the raw path.

This PR reverts back to the raw path solution.

part of https://github.com/flutter/flutter/issues/124287

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-09-20 19:55:47 +00:00
Matan Lurey
792830c13f Make a variety of low-impact Clang tidy fixes. (flutter/engine#46114) 
Work towards https://github.com/flutter/flutter/issues/134969.

These are all self-contained, so I bundled them all together.

All fixes are generated by `clang-tidy --fix`, and manual search/replace if that wasn't sufficient.
 2023-09-20 19:52:03 +00:00
skia-flutter-autoroll
4268df8794 Roll Skia from f4238844089f to c19115e8f712 (5 revisions) (flutter/engine#46108) 
https://skia.googlesource.com/skia.git/+log/f4238844089f..c19115e8f712

2023-09-20 johnstiles@google.com Re-enable existing SkSL tests.
2023-09-20 cmumford@google.com [infra] bump gsutil version to 5.25
2023-09-20 fmalita@chromium.org [mesh2d demo] Fix CK init URL
2023-09-20 bungeman@google.com [skshaper] Split off SkUnicode specific code
2023-09-20 johnstiles@google.com Remove dead code from SPIR-V code generator.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,rmistry@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-20 18:42:02 +00:00
Mouad Debbar
b827183108 [web] Move context menu handling to its own class (flutter/engine#46042) 
Remove all `contextmenu` responsibilities out of `FlutterViewEmbedder`/`EmbeddingStrategy`, and into its own `ContextMenu` class that's instantiated and managed by the view.

There's one major difference that this PR brings: the `contextmenu` event listener is now attached to the `<flutter-view>` element instead of `window`. Since the entire app is contained within `<flutter-view>`, I expect no issues with this change.

Part of https://github.com/flutter/flutter/issues/134443
 2023-09-20 18:35:03 +00:00
Matan Lurey
6b09ca7f44 Delete ci/lint.sh, which is no longer used. (flutter/engine#46049) 
Found out while working on
https://github.com/flutter/flutter/issues/134969.

I suspect this stopped being used when we sharded out the Clang Tidy
builders?
 2023-09-20 11:29:10 -07:00
Mouad Debbar
c8363b0127 [web] Make PlatformViewManager a clear singleton (flutter/engine#46044) 
Make it clear that `PlatformViewManager` is a singleton and follow the patterns that we use for other singleton classes.

Part of https://github.com/flutter/flutter/issues/134443
 2023-09-20 18:28:53 +00:00
skia-flutter-autoroll
0ba467c3d8 Roll Skia from 565d95f72f2e to f4238844089f (3 revisions) (flutter/engine#46105) 
https://skia.googlesource.com/skia.git/+log/565d95f72f2e..f4238844089f

2023-09-20 johnstiles@google.com Fix capitalization of ANGLE.
2023-09-20 brianosman@google.com Add GM to test working-color-space color filter
2023-09-20 johnstiles@google.com Remove IncompleteShortIntPrecision workaround flag.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,rmistry@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-20 17:53:22 +00:00
skia-flutter-autoroll
bc4138fee7 Roll Dart SDK from ed05ca364d5e to d5d05146868a (1 revision) (flutter/engine#46104) 
https://dart.googlesource.com/sdk.git/+log/ed05ca364d5e..d5d05146868a

2023-09-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-185.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-20 17:34:18 +00:00
skia-flutter-autoroll
2a0b54bc4d Roll Fuchsia Linux SDK from aHtib4LBcLwx7JwK-... to QcxgV9KlY7j3o3b4j... (flutter/engine#46102) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-20 17:11:04 +00:00
Chris Yang
110ec685de [ios] Reland "[ios] use python script to generate extension safe frameworks and code sign them" #46004" (flutter/engine#46014) 
Relands https://github.com/flutter/engine/pull/45781
The Flutter.framework and the sim folders are mistakenly added to the artifact, this PR removed those files along with re-landing the original changes 

https://github.com/flutter/flutter/pull/134966 should pass with this change. 

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-09-20 16:18:21 +00:00
skia-flutter-autoroll
18c48846db Roll Skia from 56ce5bb201c6 to f54c214a739b (4 revisions) (flutter/engine#46098) 
https://skia.googlesource.com/skia.git/+log/56ce5bb201c6..f54c214a739b

2023-09-20 michaelludwig@google.com [skif] Use optionals to track unbounded input/output bounds
2023-09-20 robertphillips@google.com [graphite] Use Compose helper to implement dithering
2023-09-20 kjlubick@google.com Revert "[Fontations] Test path equivalence for a set of test fonts and strings"
2023-09-20 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from bc9a66c04290 to 881dc3bb55fd (7 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,rmistry@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-20 15:27:00 +00:00
skia-flutter-autoroll
05774cbbbc Roll Skia from fd317812bd27 to 56ce5bb201c6 (4 revisions) (flutter/engine#46096) 
https://skia.googlesource.com/skia.git/+log/fd317812bd27..56ce5bb201c6

2023-09-20 drott@chromium.org [Fontations] Test path equivalence for a set of test fonts and strings
2023-09-20 johnstiles@google.com Migrate NVIDIA test disables into SkSLTest.cpp.
2023-09-20 brianosman@google.com [graphite] Adjust the working context inside working format color filter
2023-09-20 robertphillips@google.com [graphite] Add a PaintOption class to the precompilation system

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,rmistry@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-20 14:42:02 +00:00
skia-flutter-autoroll
058dcd40a5 Roll Skia from d7f2d1083979 to fd317812bd27 (2 revisions) (flutter/engine#46094) 
https://skia.googlesource.com/skia.git/+log/d7f2d1083979..fd317812bd27

2023-09-20 weiyuhuang@google.com Expose 5 more paragraph methods from Canvaskit for Flutter.
2023-09-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll jsfiddle-base from bc9bc348e2da to 5b50d4261358

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,rmistry@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-20 13:58:50 +00:00
skia-flutter-autoroll
65cbb8c06d Roll Skia from 7d9d5ac84d8f to d7f2d1083979 (1 revision) (flutter/engine#46091) 
https://skia.googlesource.com/skia.git/+log/7d9d5ac84d8f..d7f2d1083979

2023-09-20 maryla@google.com Fix default values for gain map metadata.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,rmistry@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-20 10:34:21 +00:00
skia-flutter-autoroll
799989c2b9 Roll Skia from e9b9e9a4f541 to e3aa86332255 (1 revision) (flutter/engine#46088) 
https://skia.googlesource.com/skia.git/+log/e9b9e9a4f541..e3aa86332255

2023-09-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 1b17251d0e2c to 918412e0912f (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,rmistry@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-20 06:31:34 +00:00
skia-flutter-autoroll
94959274b2 Roll Dart SDK from b8f006d88c07 to b3fd178ce59f (3 revisions) (flutter/engine#46087) 
https://dart.googlesource.com/sdk.git/+log/b8f006d88c07..b3fd178ce59f

2023-09-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-183.0.dev
2023-09-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-182.0.dev
2023-09-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-181.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-20 05:34:03 +00:00
Brandon DeRosier
9761621578 [Impeller] Ensure that reused textures are cleared before getting sampled by backdrop textures (flutter/engine#46084) 
Fix for https://github.com/flutter/flutter/issues/135053.

I'm going to try and optimize out this case later, since Wondrous is
inadvertently paying for a backdrop filter that contributes nothing to
the final image.
 2023-09-19 22:33:37 -07:00
Brandon DeRosier
2bc09e284c [Impeller] Use BlackTransparent clear color when backdrop filters are present. (flutter/engine#46085) 
Fix for https://github.com/flutter/flutter/issues/135053.

We already duck out of the Entity absorbing part of the optimization,
but we also need to duck here when computing clear colors, otherwise we
end up double-applying the effect of clearing entities at the beginning
of a pass in some cases.
 2023-09-19 22:13:37 -07:00