Files
flutter/engine
Matan Lurey 6aa20016ac Revert #46131, don't store vkImage, reset vkComandPool synchronously (flutter/engine#46166)
Closes https://github.com/flutter/flutter/issues/135086.

Reverts https://github.com/flutter/engine/pull/46131.

This PR bundles together 3 changes that removes all validation errors on the `macrobenchmark` apps I could manually find:

1. Reverts https://github.com/flutter/engine/pull/46131, which did not fix the original issue.
2. Added `kResetOnBackgroundThread = false`, which drops performance benefits, but doesn't cause threading issues.
3. Stop tracking `image` for Swapchain presentation (was hitting Vulkan assertion errors about acquired images).

/cc @gaaclarke I'd love to talk about how we could run the macrobenchmarks app on CI, with validation errors, after landing.
2023-09-21 23:10:37 +00:00
..