skia-flutter-autoroll
ca308ec45e
Roll Skia from 0eea0b277d7d to b3e896c2f9bf (2 revisions) ( flutter/engine#48391 )
...
https://skia.googlesource.com/skia.git/+log/0eea0b277d7d..b3e896c2f9bf
2023-11-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from df6df054b2af to 19a06c962732
2023-11-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from d45b02c819f7 to 2a21ac0c3b4f (21 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jacksongardner@google.com ,jcgregorio@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-27 06:08:29 +00:00
Brandon DeRosier
c49cfdc9a9
[Flutter GPU] Texture binding, index binding, attachments, depth state. ( flutter/engine#48386 )
...
Now rendering textured 3D models!
* Combined depth+stencil attachment.
* Allow for multiple color attachments.
* Add blend mode configuration.
* Fix uniform ordering for vertex shaders.
* Texture binding and sampling options.
* Index buffer binding.
* Depth configuration.
2023-11-26 19:47:16 -08:00
Jonah Williams
02ba2b7ff2
[Impeller] use spec constant for decal support in morph filter. ( flutter/engine#48288 )
...
Don't branch on uniform for decal support in GLES backend.
2023-11-27 03:03:15 +00:00
Jonah Williams
0ba4edc764
[Impeller] OES extension does not apply to regular textures for decal support ( flutter/engine#48388 )
...
This extension only implies decal support for OES textures. Remove it from the check for generic decal support.
In practice i think it would be unlikely that a driver supports this and not regular decal, but that would only make the bugs this may cause even harder to track down.
2023-11-27 03:03:13 +00:00
skia-flutter-autoroll
9cddd585ab
Roll Fuchsia Linux SDK from zHKuNuXtMPLbovc0j... to qyRH6zYfUEjo9L1x2... ( flutter/engine#48389 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jacksongardner@google.com ,rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-26 23:19:21 +00:00
skia-flutter-autoroll
ddef9843d6
Roll Skia from b18b594b230d to 0eea0b277d7d (7 revisions) ( flutter/engine#48387 )
...
https://skia.googlesource.com/skia.git/+log/b18b594b230d..0eea0b277d7d
2023-11-26 johnstiles@google.com Use SkToInt to avoid warning in Flutter roll.
2023-11-26 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version
2023-11-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 2e96f5c2b566 to 860dca03b6e7 (1 revision)
2023-11-26 bungeman@google.com IWYU for modules/skshaper
2023-11-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 95073d786075 to 2e96f5c2b566 (1 revision)
2023-11-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 2ddf0aa40843 to 95073d786075 (2 revisions)
2023-11-24 johnstiles@google.com Avoid combining extremely large meshes.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jacksongardner@google.com ,jcgregorio@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-26 18:19:02 +00:00
skia-flutter-autoroll
377e5f358e
Roll Fuchsia Linux SDK from P3HXI8K3eIeoBYhdX... to zHKuNuXtMPLbovc0j... ( flutter/engine#48376 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jacksongardner@google.com ,rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-25 22:38:37 +00:00
Brandon DeRosier
05f43a96aa
[Flutter GPU] Raster encoding. First triangle! ( flutter/engine#48314 )
...
First triangle, in the framework! 🎉
Adds shader libraries, pipelines, command buffers, render passes, etc.
* Light pipelines/shader objects. No optimization yet, pipeline warming
to come.
* "Dynamic" command style. Don't re-send bindings if you don't need to.
Essentially: https://github.com/flutter/flutter/issues/133179
* No need to explicitly encode passes.
* Minimal descriptor usage.
* Nothing is async, except for the optional command buffer completion
callback.
It took a bunch of experimenting to get here, but I think things are
starting to look pretty neat. :)
Todo:
* Land the shader bundle format/remove the testing hacks & fixtures that
piggyback off of the runtime effect system.
* Add remaining calls for blend config, clearing bindings, etc.
* Inconsistent error handling patterns that need cleanup.
* Maybe: Surface exceptions for validation errors.
* Handle the texture usage bitmask more elegantly.
2023-11-24 19:02:58 -08:00
skia-flutter-autoroll
1a0a4caee0
Roll Fuchsia Linux SDK from 4CZFCL5oL042nQihC... to P3HXI8K3eIeoBYhdX... ( flutter/engine#48365 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jacksongardner@google.com ,rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-24 21:43:23 +00:00
skia-flutter-autoroll
8b036c3412
Roll Skia from 201d0c8d83f0 to b18b594b230d (1 revision) ( flutter/engine#48356 )
...
https://skia.googlesource.com/skia.git/+log/201d0c8d83f0..b18b594b230d
2023-11-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from f0dc22ba8111 to 2ddf0aa40843 (1 revision)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jacksongardner@google.com ,jamesgk@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-24 13:44:27 +00:00
skia-flutter-autoroll
9d7bcf400d
Roll Skia from de1673ed1618 to 201d0c8d83f0 (1 revision) ( flutter/engine#48352 )
...
https://skia.googlesource.com/skia.git/+log/de1673ed1618..201d0c8d83f0
2023-11-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from fba482b7107c to aa3bebf94d2f (3 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jacksongardner@google.com ,jamesgk@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-24 07:32:23 +00:00
skia-flutter-autoroll
b01c2d8d6b
Roll Skia from b3d947126fd2 to de1673ed1618 (1 revision) ( flutter/engine#48350 )
...
https://skia.googlesource.com/skia.git/+log/b3d947126fd2..de1673ed1618
2023-11-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 045bb58be5e6 to df6df054b2af
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jacksongardner@google.com ,jamesgk@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-24 06:13:05 +00:00
skia-flutter-autoroll
4c7d997098
Roll Skia from 2c89bb28860b to b3d947126fd2 (1 revision) ( flutter/engine#48349 )
...
https://skia.googlesource.com/skia.git/+log/2c89bb28860b..b3d947126fd2
2023-11-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 1862fc490314 to d45b02c819f7 (34 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jacksongardner@google.com ,jamesgk@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-24 05:22:08 +00:00
skia-flutter-autoroll
3901005fa0
Roll Skia from 094c3d963ba0 to 2c89bb28860b (1 revision) ( flutter/engine#48341 )
...
https://skia.googlesource.com/skia.git/+log/094c3d963ba0..2c89bb28860b
2023-11-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms from 55204b9355dc to 3020b5f04bb1 (1 revision)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jacksongardner@google.com ,jamesgk@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-23 20:41:28 +00:00
skia-flutter-autoroll
fcd2169740
Roll Skia from fc9c5337e568 to 094c3d963ba0 (6 revisions) ( flutter/engine#48340 )
...
https://skia.googlesource.com/skia.git/+log/fc9c5337e568..094c3d963ba0
2023-11-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 05e2e582257c to f0dc22ba8111 (1 revision)
2023-11-23 michaelludwig@google.com [skif] Adjust blur engine tile mode support API
2023-11-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 20eff9db7dc8 to fba482b7107c (3 revisions)
2023-11-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from b9831128db04 to 045bb58be5e6
2023-11-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms from 111d4246b357 to 55204b9355dc (5 revisions)
2023-11-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from bd6600c1bba7 to 1862fc490314 (21 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jacksongardner@google.com ,jamesgk@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-23 19:45:04 +00:00
skia-flutter-autoroll
0802fdff66
Roll Skia from 5606ef899116 to fc9c5337e568 (1 revision) ( flutter/engine#48339 )
...
https://skia.googlesource.com/skia.git/+log/5606ef899116..fc9c5337e568
2023-11-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from fe7ac4762e47 to 05e2e582257c (4 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jacksongardner@google.com ,jamesgk@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-23 18:14:45 +00:00
skia-flutter-autoroll
294b3a70c1
Roll Fuchsia Linux SDK from IK4xyRtZkDwqT6pXA... to 4CZFCL5oL042nQihC... ( flutter/engine#48338 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jacksongardner@google.com ,rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-23 18:13:36 +00:00
林洵锋
23ed0d9d6a
Fix not being able to hide iOS status bar via setEnabledSystemUIMode ( flutter/engine#48271 )
...
Fix https://github.com/flutter/flutter/issues/138604 and https://github.com/flutter/flutter/issues/138671
Related PR https://github.com/flutter/engine/pull/45351
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-11-23 00:49:13 +00:00
Mouad Debbar
4c20a233a8
[web] Hook the new JS API to the FlutterViewManager ( flutter/engine#48283 )
...
- Auto-generate view IDs.
- Views don't auto-register/auto-unregister anymore.
- Remove `EnginePlatformDispatcher.registerView/unregisterView` methods.
- Add `FlutterViewManager.createAndRegisterView/disposeAndUnregisterView/dispose` methods.
- Hook the `addView`/`removeView` JS APIs to `FlutterViewManager`.
2023-11-22 21:27:56 +00:00
skia-flutter-autoroll
c1ccce2457
Roll Skia from 3a79d7a618aa to 5606ef899116 (1 revision) ( flutter/engine#48331 )
...
https://skia.googlesource.com/skia.git/+log/3a79d7a618aa..5606ef899116
2023-11-22 jvanverth@google.com Reland "[graphite] Use colorspace matrix to handle RGB swizzle."
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jacksongardner@google.com ,jamesgk@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-22 21:27:53 +00:00
LouiseHsu
faa3e610ac
Fix Share Screen Crash on iPad ( flutter/engine#48220 )
...
Fixes https://github.com/flutter/flutter/issues/138550
2023-11-22 20:49:58 +00:00
Dan Field
28fbba2098
Delete unused/test only code from FML ( flutter/engine#48327 )
...
This is more-or-less a revert of https://github.com/flutter/engine/pull/14011
This code never ended up being used outside of tests, and it's not how we handle asset loading at this point anyway.
I was hopeful we could kill off all runtime dependencies on Dart in `FML` when looking at this, but it looks like trace_event.h still wants to import dart_api_tools.h for some Dart enum types. This may or may not matter if we ever want to build FML for web/wasm. /cc @eyebrowsoffire. If we really need to do that, we can refactor the trace event stuff so that it has a web and Dart implementation that's selected at build time.
2023-11-22 20:49:56 +00:00
skia-flutter-autoroll
5bf972b2c7
Roll Skia from 30ecaac60b47 to 3a79d7a618aa (1 revision) ( flutter/engine#48328 )
...
https://skia.googlesource.com/skia.git/+log/30ecaac60b47..3a79d7a618aa
2023-11-22 johnstiles@google.com Replace STArray with trivial hand-written stack.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jacksongardner@google.com ,jamesgk@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-22 20:39:26 +00:00
auto-submit[bot]
4f2aeb7e76
Reverts "[Impeller] pass const ref to binding helpers." ( flutter/engine#48330 )
...
Reverts flutter/engine#48318
Initiated by: jonahwilliams
This change reverts the following previous change:
Original Description:
No point in passing by value and moving, just pass a const ref through. Trivial performance improvement.
# Before
```cpp
/// Bind uniform buffer for resource named FragInfo.
static bool BindFragInfo(ResourceBinder& command, BufferView view) {
return command.BindResource(ShaderStage::kFragment, kResourceFragInfo, kMetadataFragInfo, std::move(view));
}
/// Bind combined image sampler for resource named texture_sampler.
static bool BindTextureSampler(ResourceBinder& command, std::shared_ptr<const Texture> texture, std::shared_ptr<const Sampler> sampler) {
return command.BindResource(ShaderStage::kFragment, kResourceTextureSampler, kMetadataTextureSampler, std::move(texture), std::move(sampler));
}
```
# After
```cpp
/// Bind uniform buffer for resource named FragInfo.
static bool BindFragInfo(ResourceBinder& command, const BufferView& view) {
return command.BindResource(ShaderStage::kFragment, kResourceFragInfo, kMetadataFragInfo, view);
}
/// Bind combined image sampler for resource named texture_sampler.
static bool BindTextureSampler(ResourceBinder& command, const std::shared_ptr<const Texture>& texture, const std::shared_ptr<const Sampler>& sampler) {
return command.BindResource(ShaderStage::kFragment, kResourceTextureSampler, kMetadataTextureSampler, texture, sampler);
}
```
2023-11-22 20:09:17 +00:00
Jackson Gardner
7aba08366e
Revert "Manual roll Dart SDK from f1fd14505782 to df958dc1ca7b (6 revisions)" ( flutter/engine#48325 )
...
Reverts flutter/engine#48316
3.3.0-158 breaks customer testing because of https://dart-review.googlesource.com/c/sdk/+/336244
2023-11-22 19:27:17 +00:00
Jonah Williams
c453bac49b
[Impeller] cache render target properties on Render Pass. ( flutter/engine#48323 )
...
Otherwise we do three hashmap lookups everything we call OptionsFromPass(AndEntity) in a contents.
## Before
16 / 392 = 4%
## After
6/ 458 = 1.3%
2023-11-22 19:16:11 +00:00
Jonah Williams
2faace2ef2
[Impeller] pass const ref to binding helpers. ( flutter/engine#48318 )
...
No point in passing by value and moving, just pass a const ref through. Trivial performance improvement.
# Before
```cpp
/// Bind uniform buffer for resource named FragInfo.
static bool BindFragInfo(ResourceBinder& command, BufferView view) {
return command.BindResource(ShaderStage::kFragment, kResourceFragInfo, kMetadataFragInfo, std::move(view));
}
/// Bind combined image sampler for resource named texture_sampler.
static bool BindTextureSampler(ResourceBinder& command, std::shared_ptr<const Texture> texture, std::shared_ptr<const Sampler> sampler) {
return command.BindResource(ShaderStage::kFragment, kResourceTextureSampler, kMetadataTextureSampler, std::move(texture), std::move(sampler));
}
```
# After
```cpp
/// Bind uniform buffer for resource named FragInfo.
static bool BindFragInfo(ResourceBinder& command, const BufferView& view) {
return command.BindResource(ShaderStage::kFragment, kResourceFragInfo, kMetadataFragInfo, view);
}
/// Bind combined image sampler for resource named texture_sampler.
static bool BindTextureSampler(ResourceBinder& command, const std::shared_ptr<const Texture>& texture, const std::shared_ptr<const Sampler>& sampler) {
return command.BindResource(ShaderStage::kFragment, kResourceTextureSampler, kMetadataTextureSampler, texture, sampler);
}
```
2023-11-22 19:14:15 +00:00
skia-flutter-autoroll
4b6c2d512c
Roll Skia from 994558cd1fae to 30ecaac60b47 (1 revision) ( flutter/engine#48324 )
...
https://skia.googlesource.com/skia.git/+log/994558cd1fae..30ecaac60b47
2023-11-22 johnstiles@google.com Revert "Disable [[clang::musttail]] on clang-cl."
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jacksongardner@google.com ,jamesgk@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-22 19:09:14 +00:00
skia-flutter-autoroll
e9faeddd45
Roll Skia from 9086788fc341 to 994558cd1fae (1 revision) ( flutter/engine#48322 )
...
https://skia.googlesource.com/skia.git/+log/9086788fc341..994558cd1fae
2023-11-22 johnstiles@google.com Disable [[clang::musttail]] on clang-cl.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jacksongardner@google.com ,jamesgk@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-22 18:19:51 +00:00
LongCatIsLooong
59a5579465
Expose a few more glyph apis from ui.Paragraph ( flutter/engine#47698 )
...
Add 2 methods for querying glyph-related metrics
```dart
GlyphInfo? getClosestGlyphInfoForOffset(Offset offset);
GlyphInfo? getGlyphInfoAt(int codeUnitOffset);
```
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-11-22 18:04:13 +00:00
skia-flutter-autoroll
c39c4f24d8
Roll Skia from efdec1f459ce to 9086788fc341 (2 revisions) ( flutter/engine#48317 )
...
https://skia.googlesource.com/skia.git/+log/efdec1f459ce..9086788fc341
2023-11-22 jvanverth@google.com Use sk_ieee_float_divide in SkMatrix::setRectToRect.
2023-11-22 kjlubick@google.com Reland "Reland "Remove other uses of SkFontMgr::RefDefault""
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jacksongardner@google.com ,jamesgk@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-22 17:29:09 +00:00
skia-flutter-autoroll
925d1e8cb4
Manual roll Dart SDK from f1fd14505782 to df958dc1ca7b (6 revisions) ( flutter/engine#48316 )
...
Manual roll requested by jacksongardner@google.com
https://dart.googlesource.com/sdk.git/+log/f1fd14505782..df958dc1ca7b
2023-11-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-158.0.dev
2023-11-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-157.0.dev
2023-11-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-156.0.dev
2023-11-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-155.0.dev
2023-11-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-154.0.dev
2023-11-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-153.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-22 17:03:14 +00:00
skia-flutter-autoroll
f44004197c
Roll Skia from 2c68a803f497 to efdec1f459ce (2 revisions) ( flutter/engine#48315 )
...
https://skia.googlesource.com/skia.git/+log/2c68a803f497..efdec1f459ce
2023-11-22 jvanverth@google.com [graphite] Multiply by inverse texture size to normalize image localCoords
2023-11-22 nicolettep@google.com Revert "[graphite] Implement AHardwareBuffer BackendTexture creation for Vulkan"
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jacksongardner@google.com ,jamesgk@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-22 16:31:05 +00:00
skia-flutter-autoroll
679d6bec5d
Roll Skia from af2bd26a3a5e to 2c68a803f497 (1 revision) ( flutter/engine#48311 )
...
https://skia.googlesource.com/skia.git/+log/af2bd26a3a5e..2c68a803f497
2023-11-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 302d72df3db0 to fe7ac4762e47 (3 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jacksongardner@google.com ,jamesgk@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-22 14:17:31 +00:00
skia-flutter-autoroll
6a87533f61
Roll Skia from cc9006085362 to af2bd26a3a5e (1 revision) ( flutter/engine#48307 )
...
https://skia.googlesource.com/skia.git/+log/cc9006085362..af2bd26a3a5e
2023-11-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 1169f6b4ae5c to 20eff9db7dc8 (2 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jacksongardner@google.com ,jamesgk@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-22 08:19:06 +00:00
skia-flutter-autoroll
1e1dc3258d
Roll Skia from 143b6b5b91a5 to cc9006085362 (1 revision) ( flutter/engine#48306 )
...
https://skia.googlesource.com/skia.git/+log/143b6b5b91a5..cc9006085362
2023-11-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 7fa8c0ca8784 to 4141c194eb05
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jacksongardner@google.com ,jamesgk@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-22 06:34:48 +00:00
skia-flutter-autoroll
3ef86f89a4
Roll Skia from cebd44423589 to 143b6b5b91a5 (1 revision) ( flutter/engine#48305 )
...
https://skia.googlesource.com/skia.git/+log/cebd44423589..143b6b5b91a5
2023-11-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from b61659d71d46 to bd6600c1bba7 (18 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jacksongardner@google.com ,jamesgk@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-22 05:36:25 +00:00
skia-flutter-autoroll
e663563c6e
Roll Skia from 23b9316efd20 to cebd44423589 (1 revision) ( flutter/engine#48304 )
...
https://skia.googlesource.com/skia.git/+log/23b9316efd20..cebd44423589
2023-11-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms from c0be9bb8bc17 to 111d4246b357 (1 revision)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jacksongardner@google.com ,jamesgk@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-22 03:42:23 +00:00
Jonah Williams
811d365669
[Impeller] make host buffer state internally ref counted. ( flutter/engine#48303 )
...
std::shared_from_this is actually incredibly slow, and dominates the cost of host buffer allocation at 20x more expensive than the memcpy. We can remove the usage of shared_from_this by making an internal class hold the actual allocation/buffer state instead.
### Before
146 ms / 647ms = ~20%
### After
33 ms / 540 ms = ~6%
2023-11-22 03:24:18 +00:00
skia-flutter-autoroll
5fc94087d5
Roll Skia from b6f33389cefa to 23b9316efd20 (2 revisions) ( flutter/engine#48302 )
...
https://skia.googlesource.com/skia.git/+log/b6f33389cefa..23b9316efd20
2023-11-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from f23b91844a05 to ba1e7f5c1e82
2023-11-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 856d90fb41aa to 302d72df3db0 (5 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jacksongardner@google.com ,jamesgk@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-22 01:52:11 +00:00
skia-flutter-autoroll
651c54111c
Roll Skia from cac28f3634a3 to b6f33389cefa (1 revision) ( flutter/engine#48299 )
...
https://skia.googlesource.com/skia.git/+log/cac28f3634a3..b6f33389cefa
2023-11-22 johnstiles@google.com Revert "Reland "Remove other uses of SkFontMgr::RefDefault""
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jacksongardner@google.com ,jamesgk@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-22 01:00:05 +00:00
Jonah Williams
330c06a4f2
[Impeller] Dont copy the paint until we're sure that the RRect blur optimization will apply. ( flutter/engine#48298 )
...
Extremely minor micro optimization. Dont copy the paint too early.
Before
13/269 = ~5%
After:
3/262 = ~1%
2023-11-22 00:24:06 +00:00
Matan Lurey
d5b171165f
Finish making shell/platform/linux/... compatible with .clang-tidy. ( flutter/engine#48297 )
2023-11-21 15:35:36 -08:00
Matan Lurey
aa6fdad4cd
Finish making shell/platform/android/... compatible with .clang-tidy. ( flutter/engine#48296 )
2023-11-21 15:34:06 -08:00
Matan Lurey
b6f162e8b3
Finish making shell/common/... compatible with .clang-tidy. ( flutter/engine#48295 )
2023-11-21 15:33:43 -08:00
skia-flutter-autoroll
29e3f2edc7
Roll Fuchsia Linux SDK from Q3HcTitDF90ZOPWDa... to IK4xyRtZkDwqT6pXA... ( flutter/engine#48294 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jacksongardner@google.com ,rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-21 23:12:38 +00:00
skia-flutter-autoroll
f1f8c59fdf
Roll Skia from c6d971f87d12 to cac28f3634a3 (12 revisions) ( flutter/engine#48293 )
...
https://skia.googlesource.com/skia.git/+log/c6d971f87d12..cac28f3634a3
2023-11-21 jvanverth@google.com Revert "[graphite] Use colorspace matrix to handle RGB swizzle."
2023-11-21 jvanverth@google.com [graphite] Use colorspace matrix to handle RGB swizzle.
2023-11-21 nicolettep@google.com [graphite] Implement AHardwareBuffer BackendTexture creation for Vulkan
2023-11-21 nicolettep@google.com [graphite] Add public Recorder method to create a BackendTexture from an AHardwareBuffer
2023-11-21 johnstiles@google.com Revert "[graphite] Add no-yield option to ContextOptions."
2023-11-21 kjlubick@google.com Remove MutableTextureStateRef and sketch out Vulkan-specific functions
2023-11-21 kjlubick@google.com Reland "Remove other uses of SkFontMgr::RefDefault"
2023-11-21 kjlubick@google.com Assert if null fallbackMgr used in FontMgrRunIterator
2023-11-21 johnstiles@google.com Enable individual feature flags in skcms with clang-cl.
2023-11-21 jvanverth@google.com [graphite] Remove RRRR swizzle.
2023-11-21 briansalomon@gmail.com [graphite] Add no-yield option to ContextOptions.
2023-11-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms from 02a8c0638601 to c0be9bb8bc17 (2 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jacksongardner@google.com ,jamesgk@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-11-21 22:57:05 +00:00
gaaclarke
e80ecd9194
[Impeller] Switched to static linked libc++ in vulkan validation layers. ( flutter/engine#48290 )
...
fixes https://github.com/flutter/flutter/issues/138535
test coverage: existing integration tests in flutter repo which look for validation layers
I also verified locally that the `libc++.so` is no longer present and that it runs correctly.
```
$ find lib/arm64-v8a/
lib/arm64-v8a/
lib/arm64-v8a//libflutter.so
lib/arm64-v8a//libVkLayer_khronos_validation.so
```
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-11-21 22:06:05 +00:00
Matan Lurey
0b7f44c8c4
Yet more compliance with .clang_tidy, stragglers edition. ( flutter/engine#48291 )
...
Based off the
[failures](https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8763786250936903249/+/u/test:_test:_lint_host_debug/stdout )
in https://github.com/flutter/engine/pull/48145 .
Nothing particularly interesting.
2023-11-21 13:39:18 -08:00
Jackson Gardner
4dacd0341d
Update skia build file to account for new skcms changes. ( flutter/engine#48286 )
...
This should address https://github.com/flutter/flutter/issues/138838 which is blocking the skia roll.
This basically ports over the build rule changes from https://skia-review.googlesource.com/c/skia/+/777538
2023-11-21 21:12:05 +00:00
