Chris Yang
c27c8aaa15
Revert "[ios] use python script to generate extension safe frameworks and code sign them" ( flutter/engine#46004 )
...
Reverts flutter/engine#45781
Issue with engine roll https://github.com/flutter/flutter/pull/134964 .
We need to update the conductor and performa manual roll.
We also need to remove the Flutter.framework from the artifact.zip
2023-09-18 22:09:33 +00:00
John McCutchan
c74acc92aa
Disable HardwareBuffer backed Platform Views temporarily ( flutter/engine#45986 )
...
Necessary to unblock the GPay release
2023-09-18 12:36:16 -07:00
John McCutchan
4081d7d574
Tighten up ImageReaderPlatformViewRenderTarget code ( flutter/engine#45889 )
...
- Fix a missing Image close in an error path.
- Ensure we close the Image when the TextureEntry is finalized.
- Fix an inconsistency in the maxImages when running on Android < 33.
- Wrap acquireLatestImage in a try block and return a null image instead
of crashing the application.
2023-09-18 12:34:10 -07:00
Chris Yang
969d5e0d18
[ios] use python script to generate extension safe frameworks and code sign them ( flutter/engine#45781 )
...
Generates the fat framework for extension safe variants and add them to the code sign list.
Also reverts part of https://github.com/flutter/engine/pull/45664 where the variants are uploaded in separate archive. Now with this change, the extension safe is inside a "extension_safe" folder under existing archive.
fixes https://github.com/flutter/flutter/issues/124291
The destination folder after this change:
- An extension_safe folder is added, which includes the extension safe Flutter.frameworks and dsym
- The artifacts.zip now includes the `extension_safe` except the dysm
- A extension_safe_Flutter.dsym.zip is created (under ios/release/) , which includes the extension_safe/Flutter.dsym
<img width="508" alt="Screenshot 2023-09-13 at 3 26 23 PM" src="https://github.com/flutter/engine/assets/3756895/84901ef1-af89-413f-94c7-74ed0aa36da6 ">
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-09-18 18:02:54 +00:00
Brandon DeRosier
5dca938aa9
Bump impeller-cmake to HEAD. ( flutter/engine#45953 )
...
Weekly bump.
2023-09-18 10:38:47 -07:00
LongCatIsLooong
5b716552a7
[iOS] Remove selectionDidChange call in UndoManager ( flutter/engine#45657 )
...
Fixes https://github.com/flutter/flutter/issues/133424
The `-[TextInputDelegate selectionDidChange:]` call actually triggers some unwanted keyboard NLP actions that generate a bunch of candidates and automatically accept the first candidate. This causes `-[UITextInput setMarkedText:selection]` to be called with the first candidate and that inserts extraneous characters after the user types certain characters on the iPad software keyboard.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-09-18 17:18:57 +00:00
skia-flutter-autoroll
c15e1176e9
Roll Skia from f8065ca00d0c to 0c990ab9e097 (7 revisions) ( flutter/engine#45979 )
...
https://skia.googlesource.com/skia.git/+log/f8065ca00d0c..0c990ab9e097
2023-09-18 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from d00d8da6f58d to 02233e019c4e (69 revisions)
2023-09-18 robertphillips@google.com [graphite] Implement AddBlendModeColorFilter with the Blend helper
2023-09-18 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll vulkan-deps from dc9947ad4d2b to 53e6e021f9b7 (2 revisions)
2023-09-18 kjlubick@google.com Avoid direct call from SkPictureData -> Slug
2023-09-18 johnstiles@google.com Disable test PixelLocalStorage.sksl temporarily.
2023-09-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from 3d8e63c59919 to ac643e8ecce3
2023-09-18 kjlubick@google.com Remove shim includes
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com ,brianosman@google.com ,rmistry@google.com ,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-18 15:44:50 +00:00
Mouad Debbar
b470cd2ab1
[web] ScreenOrientation singleton ( flutter/engine#45304 )
...
One more piece moving out of `FlutterViewEmbedder`.
`ScreenOrientation` is a singleton class that can be used to control the screen orientation of the browser.
Part of https://github.com/flutter/flutter/issues/134443
2023-09-18 15:43:08 +00:00
Mouad Debbar
3ef852f5de
[web] De-singletonize MouseCursor for multi-view ( flutter/engine#45295 )
...
`MouseCursor` is a singleton that works by accessing `flutterViewEmbedder` directly. After this PR, `MouseCursor` becomes a non-singleton that takes a `FlutterView` and controls the mouse cursor for said view.
Part of https://github.com/flutter/flutter/issues/134443
2023-09-18 15:35:58 +00:00
skia-flutter-autoroll
cbfdb15c31
Roll Dart SDK from 5c56e0f3fe13 to 5b0e7bda1379 (1 revision) ( flutter/engine#45974 )
...
https://dart.googlesource.com/sdk.git/+log/5c56e0f3fe13..5b0e7bda1379
2023-09-18 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-174.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-18 13:24:32 +00:00
skia-flutter-autoroll
e0cca37d5e
Roll Dart SDK from 5eef4301567f to 5c56e0f3fe13 (1 revision) ( flutter/engine#45966 )
...
https://dart.googlesource.com/sdk.git/+log/5eef4301567f..5c56e0f3fe13
2023-09-18 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-173.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-18 09:20:56 +00:00
skia-flutter-autoroll
8ee38ff1e4
Roll Fuchsia Mac SDK from 2TJNsB32jPioIfFao... to 3_Lh8otTpmVuf-Zwb... ( flutter/engine#45963 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC bdero@google.com ,rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-18 08:31:22 +00:00
skia-flutter-autoroll
bb96ca3542
Roll Skia from eac827d9eed3 to f8065ca00d0c (2 revisions) ( flutter/engine#45962 )
...
https://skia.googlesource.com/skia.git/+log/eac827d9eed3..f8065ca00d0c
2023-09-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from b4852ef95ec1 to 22b6ca1c6191 (9 revisions)
2023-09-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 6e55411b61e1 to 4dfcc029292a
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com ,brianosman@google.com ,rmistry@google.com ,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-18 07:13:22 +00:00
skia-flutter-autoroll
050dc329d1
Roll Skia from 0d02aa8cb640 to eac827d9eed3 (1 revision) ( flutter/engine#45957 )
...
https://skia.googlesource.com/skia.git/+log/0d02aa8cb640..eac827d9eed3
2023-09-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 18fd0925a396 to 6e55411b61e1 (4 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com ,brianosman@google.com ,rmistry@google.com ,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-18 05:30:25 +00:00
skia-flutter-autoroll
8f37543828
Roll Dart SDK from a0ca39c63c16 to 5eef4301567f (1 revision) ( flutter/engine#45956 )
...
https://dart.googlesource.com/sdk.git/+log/a0ca39c63c16..5eef4301567f
2023-09-18 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-172.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-18 05:22:07 +00:00
skia-flutter-autoroll
9b3f70ce49
Roll Skia from a160e7fb80db to 0d02aa8cb640 (1 revision) ( flutter/engine#45952 )
...
https://skia.googlesource.com/skia.git/+log/a160e7fb80db..0d02aa8cb640
2023-09-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 54560bc26175 to dc9947ad4d2b (1 revision)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com ,brianosman@google.com ,rmistry@google.com ,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-18 04:22:17 +00:00
skia-flutter-autoroll
2ae3eac57f
Roll Fuchsia Mac SDK from AjL85L6CVMEuMWPVZ... to 2TJNsB32jPioIfFao... ( flutter/engine#45945 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC bdero@google.com ,rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-17 19:32:22 +00:00
skia-flutter-autoroll
90d2c51003
Roll Fuchsia Mac SDK from IJXVQbD3CpkL2_ihZ... to AjL85L6CVMEuMWPVZ... ( flutter/engine#45937 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC bdero@google.com ,rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-17 06:52:23 +00:00
skia-flutter-autoroll
e3d3ba7cdb
Roll Skia from 2eaaa5bf7dae to a160e7fb80db (1 revision) ( flutter/engine#45933 )
...
https://skia.googlesource.com/skia.git/+log/2eaaa5bf7dae..a160e7fb80db
2023-09-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from d94b7bab5be9 to 54560bc26175 (1 revision)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com ,brianosman@google.com ,jmbetancourt@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-17 03:58:12 +00:00
skia-flutter-autoroll
6f7325beba
Roll Fuchsia Mac SDK from 3Tb9CQTTiBv1lb673... to IJXVQbD3CpkL2_ihZ... ( flutter/engine#45928 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC bdero@google.com ,rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-16 18:16:29 +00:00
skia-flutter-autoroll
346e6545ff
Roll Skia from b33e0e6706b0 to 2eaaa5bf7dae (1 revision) ( flutter/engine#45926 )
...
https://skia.googlesource.com/skia.git/+log/b33e0e6706b0..2eaaa5bf7dae
2023-09-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 5060b88f0c23 to d94b7bab5be9 (5 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com ,brianosman@google.com ,jmbetancourt@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-16 14:59:21 +00:00
skia-flutter-autoroll
9435d9c043
Roll Skia from a1f8fb54299a to b33e0e6706b0 (1 revision) ( flutter/engine#45923 )
...
https://skia.googlesource.com/skia.git/+log/a1f8fb54299a..b33e0e6706b0
2023-09-16 egdaniel@google.com Add GrDirectCotnext querey to check if the we are in a device lost state
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com ,brianosman@google.com ,jmbetancourt@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-16 05:42:11 +00:00
skia-flutter-autoroll
350785c260
Roll Fuchsia Mac SDK from -_edKGA5GTkDFxVgl... to 3Tb9CQTTiBv1lb673... ( flutter/engine#45922 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC bdero@google.com ,rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-16 05:38:03 +00:00
skia-flutter-autoroll
860eaf97de
Roll Dart SDK from 029d6d73c860 to a0ca39c63c16 (1 revision) ( flutter/engine#45921 )
...
https://dart.googlesource.com/sdk.git/+log/029d6d73c860..a0ca39c63c16
2023-09-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-171.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-16 05:31:47 +00:00
Matan Lurey
6b489a6193
[Impeller] vk::CommandPool resets via ResourceManager ( flutter/engine#45654 )
...
Fixes https://github.com/flutter/flutter/issues/133198 .
Major changes:
- `CommandPoolVK` is now created indirectly through `CommandPoolRecyclerVK`.
- Via destructor, `CommandPoolVK` resets on a background thread via `ResourceManager`.
- Removed all of the code trying to reuse/reset individual command buffers (no longer needed).
- After every frame, the current/active command pool is recycled.
---
_Tests secured._
2023-09-16 04:20:21 +00:00
skia-flutter-autoroll
8a87d088b7
Roll Fuchsia Linux SDK from wWzXsy6kx1sp8Km34... to ZhY53WD7bFJSA3xoO... ( flutter/engine#45919 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC bdero@google.com ,rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-16 04:12:10 +00:00
Matan Lurey
5e0a53255f
Add a single MacOS+Vulkan+SwiftShader CI test ( flutter/engine#45918 )
...
Closes https://github.com/flutter/flutter/issues/133708 .
Will track why it's (a) blank and (b) times out in async presentation in https://github.com/flutter/flutter/issues/134852 .
2023-09-16 03:55:06 +00:00
skia-flutter-autoroll
64f6d56862
Roll Skia from 696ac041ea82 to a1f8fb54299a (1 revision) ( flutter/engine#45917 )
...
https://skia.googlesource.com/skia.git/+log/696ac041ea82..a1f8fb54299a
2023-09-16 johnstiles@google.com Fix Vulkan depth format flags for VK_FORMAT_D32_SFLOAT_S8_UINT.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com ,brianosman@google.com ,jmbetancourt@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-16 03:46:49 +00:00
skia-flutter-autoroll
2081fa7754
Roll Skia from 4851cd29e1dd to 696ac041ea82 (1 revision) ( flutter/engine#45915 )
...
https://skia.googlesource.com/skia.git/+log/4851cd29e1dd..696ac041ea82
2023-09-16 michaelludwig@google.com [graphite] Add TRACE_EVENTS throughout
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com ,brianosman@google.com ,jmbetancourt@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-16 03:02:07 +00:00
skia-flutter-autoroll
13a99ca01f
Roll Skia from c19cc483c619 to 4851cd29e1dd (1 revision) ( flutter/engine#45913 )
...
https://skia.googlesource.com/skia.git/+log/c19cc483c619..4851cd29e1dd
2023-09-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 1ab98511aaae to 5060b88f0c23 (5 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com ,brianosman@google.com ,jmbetancourt@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-16 02:11:23 +00:00
skia-flutter-autoroll
d34c38ffdb
Roll Dart SDK from e9452310189b to 029d6d73c860 (1 revision) ( flutter/engine#45912 )
...
https://dart.googlesource.com/sdk.git/+log/e9452310189b..029d6d73c860
2023-09-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-170.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-16 01:27:36 +00:00
Jonah Williams
83f48da122
Revert "[Impeller] construct text frames on UI thread." ( flutter/engine#45910 )
...
Reverts flutter/engine#45418
Some google3 tests are hitting the CHECK I added in the DlSkCanvasDispatcher::drawTextFrame, which indicates that the SkParagraph code likely thinks impeller is enabled, whereas other code might be running with Skia.
Perhaps this could happen if its software rendering? It should be a fatal error on startup so we can track this down.
2023-09-16 01:22:13 +00:00
skia-flutter-autoroll
080410ad70
Roll Skia from 7c179932cc06 to c19cc483c619 (1 revision) ( flutter/engine#45911 )
...
https://skia.googlesource.com/skia.git/+log/7c179932cc06..c19cc483c619
2023-09-16 michaelludwig@google.com Update SetTraceValue() to use a template, remove bitpun union
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com ,brianosman@google.com ,jmbetancourt@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-16 01:20:11 +00:00
skia-flutter-autoroll
670626779b
Roll Skia from 917fd16e6f26 to 7c179932cc06 (1 revision) ( flutter/engine#45907 )
...
https://skia.googlesource.com/skia.git/+log/917fd16e6f26..7c179932cc06
2023-09-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 18fd0925a396 to 76d21d4985f8
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com ,brianosman@google.com ,jmbetancourt@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-15 23:54:22 +00:00
skia-flutter-autoroll
39c160cc30
Roll Skia from 0057898979a1 to 917fd16e6f26 (1 revision) ( flutter/engine#45906 )
...
https://skia.googlesource.com/skia.git/+log/0057898979a1..917fd16e6f26
2023-09-15 johnstiles@google.com Add device-name to Caps when test-utils is active.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com ,brianosman@google.com ,jmbetancourt@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-15 22:56:27 +00:00
Matan Lurey
8ec1692298
Do not convert an open path to a closed rect. ( flutter/engine#45903 )
...
Fixes https://github.com/flutter/flutter/issues/134816 .
---
Confirmed this only happens when utilizing `DisplayListBuilder`.
Consider:
```cc
TEST_P(DisplayListTest, CanDrawAnOpenPath) {
flutter::DisplayListBuilder builder;
flutter::DlPaint paint;
paint.setColor(flutter::DlColor::kRed());
paint.setDrawStyle(flutter::DlDrawStyle::kStroke);
paint.setStrokeWidth(10);
builder.Translate(300, 300);
// Move to (50, 50) and draw lines from:
// 1. (50, height)
// 2. (width, height)
// 3. (width, 50)
SkPath path;
path.moveTo(50, 50);
path.lineTo(50, 100);
path.lineTo(100, 100);
path.lineTo(100, 50);
builder.DrawPath(path, paint);
ASSERT_TRUE(OpenPlaygroundHere(builder.Build()));
}
```
---
The bug is in `dl_dispatcher.cc`:
```cc
// |flutter::DlOpReceiver|
void DlDispatcher::drawPath(const SkPath& path) {
SkRect rect;
SkRRect rrect;
SkRect oval;
if (path.isRect(&rect)) {
canvas_.DrawRect(skia_conversions::ToRect(rect), paint_);
} else if (path.isRRect(&rrect) && rrect.isSimple()) {
canvas_.DrawRRect(skia_conversions::ToRect(rrect.rect()),
rrect.getSimpleRadii().fX, paint_);
} else if (path.isOval(&oval) && oval.width() == oval.height()) {
canvas_.DrawCircle(skia_conversions::ToPoint(oval.center()),
oval.width() * 0.5, paint_);
} else {
canvas_.DrawPath(skia_conversions::ToPath(path), paint_);
}
}
```
Note the documentation for `isRect`:
```cc
/** Returns true if SkPath is equivalent to SkRect when filled.
If false: rect, isClosed, and direction are unchanged.
If true: rect, isClosed, and direction are written to if not nullptr.
rect may be smaller than the SkPath bounds. SkPath bounds may include kMove_Verb points
that do not alter the area drawn by the returned rect.
@param rect storage for bounds of SkRect; may be nullptr
@param isClosed storage set to true if SkPath is closed; may be nullptr
@param direction storage set to SkRect direction; may be nullptr
@return true if SkPath contains SkRect
example: https://fiddle.skia.org/c/@Path_isRect
*/
bool isRect(SkRect* rect, bool* isClosed = nullptr, SkPathDirection* direction = nullptr) const;
```
... the `isClosed` is critical, without checking that we're doing an
incorrect optimization.
I'll send a fix and test.
2023-09-15 15:29:13 -07:00
skia-flutter-autoroll
c651db56c8
Roll Skia from 7f88bda24f7f to 0057898979a1 (1 revision) ( flutter/engine#45904 )
...
https://skia.googlesource.com/skia.git/+log/7f88bda24f7f..0057898979a1
2023-09-15 johnstiles@google.com Add unit test for shadowed variables in a loop-continue.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com ,brianosman@google.com ,jmbetancourt@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-15 22:10:59 +00:00
Matan Lurey
9859e989e1
[Impeller] Test FenceWaiterVK and fix termination bugs ( flutter/engine#45870 )
...
Fixes https://github.com/flutter/flutter/issues/134751 , and @jonahwilliams suspects it could be related to a number of other flaky/texture leak scenarios (https://github.com/flutter/flutter/issues/133506#issuecomment-1720275749 ) that only happen sometimes (i.e. on CI but not real devices), i.e. stuff like:
```txt
--- Vulkan Debug Report  ----------------------------------------
| Â Â Â Â Â Â Â Â Severity: Error
| Â Â Â Â Â Â Â Â Â Â Type: { Validation }
| Â Â Â Â Â Â Â Â ID Name: VUID-vkDestroyBuffer-buffer-00922
| Â Â Â Â Â Â Â ID Number: -464217071
| Â Â Â Queue Breadcrumbs: [NONE]
| Â CMD Buffer Breadcrumbs: [NONE]
| Â Â Â Â Related Objects: Device [94498356231456] [ImpellerDevice]
| Â Â Â Â Â Â Â Â Trigger: Validation Error: [ VUID-vkDestroyBuffer-buffer-00922 ] Object 0: handle = 0x55f21cf47d20, name = ImpellerDevice, type = VK_OBJECT_TYPE_DEVICE; | MessageID = 0xe4549c11 | Cannot call vkDestroyBuffer on VkBuffer 0xbb00000000bb[] that is currently in use by a command buffer. The Vulkan spec states: All submitted commands that refer to buffer, either directly or via a VkBufferView, must have completed execution (https://www.khronos.org/registry/vulkan/specs/1.3-extensions/html/vkspec.html#VUID-vkDestroyBuffer-buffer-00922 )
-----------------------------------------------------------------
```
---
~~This PR will look a bit like a mess until the last 2 PRs merge in, but locally it appears to fix fence races/segfaults that I was seeing on CI, including on Linux with validations enabled. We can test it further tomorrow.~~ EDIT: Updated.
2023-09-15 22:08:05 +00:00
skia-flutter-autoroll
1eff2d604e
Roll Dart SDK from a5ee0055cf20 to e9452310189b (1 revision) ( flutter/engine#45902 )
...
https://dart.googlesource.com/sdk.git/+log/a5ee0055cf20..e9452310189b
2023-09-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-169.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-15 21:36:23 +00:00
skia-flutter-autoroll
2ec372d9be
Roll Skia from 4f26f22daa4b to 7f88bda24f7f (5 revisions) ( flutter/engine#45901 )
...
https://skia.googlesource.com/skia.git/+log/4f26f22daa4b..7f88bda24f7f
2023-09-15 robertphillips@google.com [graphite] Make Blend helper take an addBlendToKey parameter
2023-09-15 egdaniel@google.com [Graphite] Fix setting depth load/store ops in Vulkan.
2023-09-15 michaelludwig@google.com [skif] Guard case when dst range starts and ends before src range
2023-09-15 jvanverth@google.com [graphite] Add rasterization and uploading to SoftwarePathAtlas.
2023-09-15 jvanverth@google.com [graphite] Move testing ContextOptions to private struct
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com ,brianosman@google.com ,jmbetancourt@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-15 21:30:21 +00:00
Jonah Williams
93cea4d0af
[Impeller] dont cache failed render target allocations. ( flutter/engine#45895 )
...
Otherwise we'll null de-ref when trying to create a texture with the same descriptor later on.
2023-09-15 20:15:23 +00:00
skia-flutter-autoroll
6926f92358
Roll Skia from c79441fc8016 to 4f26f22daa4b (1 revision) ( flutter/engine#45893 )
...
https://skia.googlesource.com/skia.git/+log/c79441fc8016..4f26f22daa4b
2023-09-15 brianosman@google.com Return transparent black when sampling null shader children
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com ,brianosman@google.com ,jmbetancourt@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-15 19:39:10 +00:00
skia-flutter-autoroll
99adc1cc30
Roll Skia from 58c509b1a24a to c79441fc8016 (1 revision) ( flutter/engine#45892 )
...
https://skia.googlesource.com/skia.git/+log/58c509b1a24a..c79441fc8016
2023-09-15 michaelludwig@google.com Delete unused SkSpecialSurface
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com ,brianosman@google.com ,jmbetancourt@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-15 18:26:14 +00:00
skia-flutter-autoroll
b52af18839
Roll Skia from fffef1047640 to 58c509b1a24a (2 revisions) ( flutter/engine#45888 )
...
https://skia.googlesource.com/skia.git/+log/fffef1047640..58c509b1a24a
2023-09-15 robertphillips@google.com [graphite] Add Compose helper
2023-09-15 kjlubick@google.com Add SkSerialProcs and SkDeserialProcs to Slug serialization
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com ,brianosman@google.com ,jmbetancourt@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-15 17:40:05 +00:00
skia-flutter-autoroll
46a719cbea
Roll Dart SDK from 65117290c3b0 to a5ee0055cf20 (1 revision) ( flutter/engine#45887 )
...
https://dart.googlesource.com/sdk.git/+log/65117290c3b0..a5ee0055cf20
2023-09-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-168.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-15 17:27:57 +00:00
skia-flutter-autoroll
51394bab15
Roll Fuchsia Mac SDK from --OUw__L3ekVTG-5c... to -_edKGA5GTkDFxVgl... ( flutter/engine#45886 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC bdero@google.com ,rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-15 16:58:17 +00:00
skia-flutter-autoroll
201cd45a73
Roll Skia from de56f293eb41 to fffef1047640 (2 revisions) ( flutter/engine#45885 )
...
https://skia.googlesource.com/skia.git/+log/de56f293eb41..fffef1047640
2023-09-15 egdaniel@google.com [Graphite] Fix Graphite Vk depth stencil.
2023-09-15 fmalita@chromium.org [mesh2d demo] Patch controls
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com ,brianosman@google.com ,jmbetancourt@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-15 16:50:06 +00:00
Zachary Anderson
191e0417ef
Adds a --quiet flag to run_tests.py ( flutter/engine#45880 )
...
This PR changes run_tests.py to use the python logging library to report
results instead of direct prints or writes to stdout/stderr. This change
simplifies adding a `--quiet` flag that causes the script to only
generate output if a log is emitted at WARNING or above.
Overall this is a bit of progress toward landing something like
https://github.com/flutter/engine/pull/45595
2023-09-15 09:31:55 -07:00
Reid Baker
a43cae2515
Update AGP and Kotlin for scenario app ( flutter/engine#45549 )
...
flutter/flutter/#134220
Command required to update lock files required not using the custom task and required matching the version of gradle in ci and passing a custom version of java.
`~/.gradle/wrapper/dists/gradle-7.5.1-bin/7jzzequgds1hbszbhq3npc5ng/gradle-7.5.1/bin/gradle -D=org.gradle.java.home=/Library/Java/JavaVirtualMachines/zulu-11.jdk/Contents/Home app:dependencies --write-locks` for app:dependencies and dependencies.
2023-09-15 15:54:04 +00:00
Kevin Lubick
7da278b05b
Migrate GrMipmapped->skgpu::Mipmapped ( flutter/engine#45881 )
...
Skia's Graphite and Ganesh backend coalesced two enums regarding mipmaps
into one and deprecated the public Ganesh version. This migrates Flutter
to use the preferred type.
No functional changes expected. See also
https://skia-review.googlesource.com/c/skia/+/753567
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-09-15 11:48:20 -04:00
