firka/flutter
3
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
31,254 Commits 1 Branch 0 Tags
bd481b5a0840285aef7cbdb45ba2bff06dcc91d1
Commit Graph

31254 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
skia-flutter-autoroll
bd481b5a08 Roll Skia from 9e86d3f6239a to 5b7a07a6356f (1 revision) (flutter/engine#45527) 
https://skia.googlesource.com/skia.git/+log/9e86d3f6239a..5b7a07a6356f

2023-09-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from cba82c7c6f4a to ab4cd777e0f0 (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com,brianosman@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-07 05:37:05 +00:00
Brandon DeRosier
a9a14d6ffa [Impeller] Gaussian blur: Remove lingering BlurStyle vertex data/uniforms. (flutter/engine#45524) 
Follow-up for https://github.com/flutter/engine/pull/45520.

Missed a few things... These were getting defaulted thanks to impeller's
header gen but don't have any purpose now that we've removed the old
blur style impl.
 2023-09-06 20:33:13 -07:00
Zachary Anderson
a1dcb39a45 Revert "Enforce the rule of calling FlutterView.Render" (flutter/engine#45525) 
Reverts flutter/engine#45300

Speculative revert for the post-submit framework CI failure in `windows_startup_test`: https://ci.chromium.org/ui/p/flutter/builders/prod/Windows%20windows_startup_test/6227/overview
 2023-09-07 01:35:09 +00:00
skia-flutter-autoroll
1c40a62d1f Roll Skia from 2b76d1113497 to 9e86d3f6239a (1 revision) (flutter/engine#45521) 
https://skia.googlesource.com/skia.git/+log/2b76d1113497..9e86d3f6239a

2023-09-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from fcc5a5e242db to 207e6df72c04 (7 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com,brianosman@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-07 00:52:20 +00:00
Brandon DeRosier
081b00ca5a [Impeller] Gaussian blur: Remove the current blur style implementation. (flutter/engine#45520) 
Resolves https://github.com/flutter/flutter/issues/122658.
Resolves remaining blur issues visible in: https://github.com/flutter/flutter/issues/132839

The current blur style implementation hasn't been working since we added the downscaling optimization, and it will continue not working after we switch to https://github.com/flutter/flutter/issues/131580.

In it's current state, it at best causes awful looking undesirable results that users are forced to work around anyhow. We should just remove it in the meantime.

Before:
![image](https://github.com/flutter/engine/assets/919017/fee57875-bd56-4a97-b8c7-353328935298)

After:
![image](https://github.com/flutter/engine/assets/919017/03d6a6dd-3789-4629-bae2-61cf6f5bb054)
 2023-09-07 00:42:13 +00:00
skia-flutter-autoroll
cfd027146d Roll Skia from 9c9757c5d17d to 2b76d1113497 (2 revisions) (flutter/engine#45518) 
https://skia.googlesource.com/skia.git/+log/9c9757c5d17d..2b76d1113497

2023-09-06 nicolettep@google.com [graphite] Add VulkanRenderPass wrapper class
2023-09-06 herb@google.com Basic comparison for two segments on sweepline

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com,brianosman@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-06 22:45:57 +00:00
skia-flutter-autoroll
1e4ca124a0 Roll Skia from 0039caadd635 to 9c9757c5d17d (1 revision) (flutter/engine#45516) 
https://skia.googlesource.com/skia.git/+log/0039caadd635..9c9757c5d17d

2023-09-06 bungeman@google.com [paragraph] Publicly depend on skia and skunicode

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com,brianosman@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-06 21:56:06 +00:00
skia-flutter-autoroll
c6bf1c48ef Roll ANGLE from 00daa451320c to 60b56591dee5 (1 revision) (flutter/engine#45517) 
00daa45132..60b56591de

2023-09-06 syoussefi@chromium.org Verify shader link correctness after looking up in program cache

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC flutter-engine@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-06 21:51:33 +00:00
skia-flutter-autoroll
deb658c4a5 Roll Fuchsia Linux SDK from 8dgICHnG28wNHzoz3... to SCoDb2m_zQDLrMhwT... (flutter/engine#45514) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-06 21:21:59 +00:00
skia-flutter-autoroll
b31dada16c Roll Skia from a274609c442c to 0039caadd635 (2 revisions) (flutter/engine#45513) 
https://skia.googlesource.com/skia.git/+log/a274609c442c..0039caadd635

2023-09-06 johnstiles@google.com Remove injection of sk_FragCoord in golden output shaders.
2023-09-06 jamesgk@google.com [graphite] Use LCD blend logic from Ganesh

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com,brianosman@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-06 21:07:04 +00:00
stuartmorgan
5dc4e70477 Add macOS support for plugin value publishing (flutter/engine#45502) 
These directly copy the iOS APIs, to minimize the branching needed in plugins with shared implementation code, and to facilitate the long-term goal of merging the iOS and macOS plugin headers. This does mean replicating the unfortunately non-idiomatic behavior of having `valuePublishedByPlugin:` sometimes return `nil` and sometimes return `NSNull`, instead of distinguishing between `nil` cases (if that's actually even necessary here) via a more specific API. In isolation I would definitely not design the API with this behavior, but consistency with iOS is the more important factor.

(Eventually I think we'll need a sort of "v2" of iOS plugin APIs since there are a number of strange behaviors that we're currently stuck with, but migrating iOS and macOS together to a new set of APIs won't be any harder than doing just iOS, and in the short to medium term consistency will help the ecosystem more that trying to pre-create better APIs as macOS-only.)

Also fixes `FlutterEngineRegistrar` to have a weak pointer to the engine. This should really already have been the case since plugins can retain the registrar, creating a likely cycle; it's now a guaranteed cycle (and failed unit tests designed to find cycles) without that since the engine itself is now keeping references to them.

Fixes https://github.com/flutter/flutter/issues/124721

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-09-06 20:44:02 +00:00
skia-flutter-autoroll
4a99ef108c Roll Skia from e5ed4ffaaaa4 to a274609c442c (2 revisions) (flutter/engine#45510) 
https://skia.googlesource.com/skia.git/+log/e5ed4ffaaaa4..a274609c442c

2023-09-06 herb@google.com Reland "Int96 intro and basic operations"
2023-09-06 robertphillips@google.com [graphite] Use kPremul alpha type when blurring

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com,brianosman@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-06 20:20:51 +00:00
Zachary Anderson
ba9fdc5ea2 Roll Fuchsia with license script fix (flutter/engine#45498) 
For https://github.com/flutter/flutter/issues/134042
 2023-09-06 12:57:58 -07:00
Tong Mu
0b39609150 Enforce the rule of calling FlutterView.Render (flutter/engine#45300) 
This PR enforces the rules as documented in `FlutterView.Render`, where
calls in illegal situations should be ignored - but have never been
enforced.

```
  /// This function must be called within the scope of the
  /// [PlatformDispatcher.onBeginFrame] or [PlatformDispatcher.onDrawFrame]
  /// callbacks being invoked.
  ///
  /// If this function is called a second time during a single
  /// [PlatformDispatcher.onBeginFrame]/[PlatformDispatcher.onDrawFrame]
  /// callback sequence or called outside the scope of those callbacks, the call
  /// will be ignored.
```

This rule is very important to implementing multi-view without having to
introduce new APIs. However, currently these illegal calls are not
ignored, and historically many tests (especially integration tests) were
unknowingly running based on this fact. @goderbauer did great work by
eliminating these cases in g3, and it's time for us to make sure these
calls are ignored.

Most effort of this PR goes to unit testing the changes. Some part of
`Shell::Create` is extracted into a static function to avoid duplicate
code.

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I signed the [CLA].
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-09-06 12:56:42 -07:00
skia-flutter-autoroll
ca9a250125 Roll ANGLE from 7b0bb0f6e785 to 00daa451320c (1 revision) (flutter/engine#45507) 
7b0bb0f6e7..00daa45132

2023-09-06 cnorthrop@google.com Vulkan: Include minImageCount in swapchain check

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC flutter-engine@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-06 19:41:54 +00:00
skia-flutter-autoroll
d366cb3e8a Roll Skia from 59e54ccf25a4 to e5ed4ffaaaa4 (4 revisions) (flutter/engine#45506) 
https://skia.googlesource.com/skia.git/+log/59e54ccf25a4..e5ed4ffaaaa4

2023-09-06 kjlubick@google.com Remove unnecessary gni groups
2023-09-06 kjlubick@google.com Move buffet rules to their respective packages
2023-09-06 bungeman@google.com [paragraph] Allow multiple unicode implementations
2023-09-06 jamesgk@google.com [graphite] Consider "need dst read" equivalent to "do in-shader blend"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com,brianosman@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-06 19:38:07 +00:00
skia-flutter-autoroll
c8defee2be Roll Fuchsia Mac SDK from dFe-t1SosqZwU5lZR... to hHwU6r12A0sy5Bq-0... (flutter/engine#45505) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-06 19:35:49 +00:00
skia-flutter-autoroll
d9ac9f2507 Roll ANGLE from 1b8ab5382ff6 to 7b0bb0f6e785 (2 revisions) (flutter/engine#45503) 
1b8ab5382f..7b0bb0f6e7

2023-09-06 syoussefi@chromium.org Properly "install" program executables
2023-09-06 ccameron@chromium.org rx::mtl::ColorBlitUtils: Use a hash map for shaders

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC flutter-engine@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-06 18:47:49 +00:00
skia-flutter-autoroll
a8f5d976bc Roll Skia from 487cd9240571 to 59e54ccf25a4 (1 revision) (flutter/engine#45504) 
https://skia.googlesource.com/skia.git/+log/487cd9240571..59e54ccf25a4

2023-09-06 johnstiles@google.com Add support for storage texture intrinsics in WGSL.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com,brianosman@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-06 18:46:18 +00:00
Zachary Anderson
538df236fe Roll clang to 576b184d6e3b633f51b908b61ebd281d2ecbf66f (flutter/engine#45499) 
Also rolls buildroot to pick up flags to silence new warnings.
 2023-09-06 11:33:05 -07:00
Nicholas Shahan
f7132b576d Update deps on DDC build targets (flutter/engine#45404) 
Update deps to use the new Dart SDK DDC build targets introduced in
these changes:
 - https://dart-review.googlesource.com/c/sdk/+/313081
 - https://dart-review.googlesource.com/c/sdk/+/315561

Fixes: https://github.com/flutter/flutter/issues/133606
 2023-09-06 11:10:39 -07:00
skia-flutter-autoroll
1ebafa2eda Roll Skia from 99bcee22f87d to 487cd9240571 (1 revision) (flutter/engine#45500) 
https://skia.googlesource.com/skia.git/+log/99bcee22f87d..487cd9240571

2023-09-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from 3e2b0ed75e49 to 22f26af5286f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com,brianosman@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-06 17:45:57 +00:00
gaaclarke
fbea251722 Remove android API 26 bump for validation layers (flutter/engine#45468) 
not necessary after: https://github.com/flutter/engine/pull/45350

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-09-06 17:40:05 +00:00
Zachary Anderson
f3d004d5a3 Roll buildroot (flutter/engine#45480) 
Just to pick up comments added in
https://github.com/flutter/buildroot/pull/761
 2023-09-06 09:16:14 -07:00
skia-flutter-autoroll
a1bce97a20 Roll Skia from 4468ef79f3d7 to 99bcee22f87d (5 revisions) (flutter/engine#45495) 
https://skia.googlesource.com/skia.git/+log/4468ef79f3d7..99bcee22f87d

2023-09-06 kjlubick@google.com Introduce enum class objects to GrDirectContext APIs instead of booleans
2023-09-06 herb@google.com Revert "Int96 intro and basic operations"
2023-09-06 sharaks@google.com Merge 7 release notes into RELEASE_NOTES.md
2023-09-06 sharaks@google.com Update Skia milestone to 119
2023-09-06 robertphillips@google.com Clean up some lingering makeWithFilter items

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com,brianosman@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-06 15:55:53 +00:00
skia-flutter-autoroll
3ab5ca85c2 Roll ANGLE from 55d3636b66e0 to 1b8ab5382ff6 (1 revision) (flutter/engine#45494) 
55d3636b66..1b8ab5382f

2023-09-06 geofflang@chromium.org Metal: Use a flat hash map for tracking resource ids.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC flutter-engine@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-06 15:49:58 +00:00
skia-flutter-autoroll
cc1a7262e1 Roll Skia from 596a1f192faa to 4468ef79f3d7 (2 revisions) (flutter/engine#45493) 
https://skia.googlesource.com/skia.git/+log/596a1f192faa..4468ef79f3d7

2023-09-06 herb@google.com Int96 intro and basic operations
2023-09-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from cba82c7c6f4a to d18edfe2c435

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com,brianosman@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-06 15:07:09 +00:00
skia-flutter-autoroll
e667f19c76 Roll Skia from a74a98890cc1 to 596a1f192faa (1 revision) (flutter/engine#45492) 
https://skia.googlesource.com/skia.git/+log/a74a98890cc1..596a1f192faa

2023-09-06 fmalita@chromium.org [skottie] Expose WYSIWYG editing functionality in WASM/CK

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com,brianosman@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-06 14:21:48 +00:00
skia-flutter-autoroll
70d4245659 Roll Skia from d603af2045ce to a74a98890cc1 (2 revisions) (flutter/engine#45491) 
https://skia.googlesource.com/skia.git/+log/d603af2045ce..a74a98890cc1

2023-09-06 kjlubick@google.com Reland "Remove SkTime from the public API"
2023-09-06 johnstiles@google.com Revert "Remove SkTime from the public API"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com,brianosman@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-06 13:34:05 +00:00
skia-flutter-autoroll
9b21a05df6 Roll Skia from 2cc5d8f0b0ef to d603af2045ce (1 revision) (flutter/engine#45490) 
https://skia.googlesource.com/skia.git/+log/2cc5d8f0b0ef..d603af2045ce

2023-09-06 kjlubick@google.com Remove unused SkTime include

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com,brianosman@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-06 12:57:55 +00:00
skia-flutter-autoroll
8dc25b8c35 Roll Skia from 0d91e2410d0e to 2cc5d8f0b0ef (1 revision) (flutter/engine#45489) 
https://skia.googlesource.com/skia.git/+log/0d91e2410d0e..2cc5d8f0b0ef

2023-09-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 041cc036f086 to fcc5a5e242db (2 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com,brianosman@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-06 12:11:22 +00:00
skia-flutter-autoroll
ca3e8b8c48 Roll ANGLE from 5116f54eca4f to 55d3636b66e0 (1 revision) (flutter/engine#45488) 
5116f54eca..55d3636b66

2023-09-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from f2f4bb6f20ec to fcc5a5e242db (14 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC flutter-engine@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-06 11:44:20 +00:00
skia-flutter-autoroll
dfd0a04523 Roll ANGLE from d664543f3e6d to 5116f54eca4f (1 revision) (flutter/engine#45487) 
d664543f3e..5116f54eca

2023-09-06 ccameron@chromium.org CopySubTexture: Handle sRGB source in GL backend

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC flutter-engine@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-06 10:41:28 +00:00
skia-flutter-autoroll
f3b018c8ec Roll Skia from a7f50692638d to 0d91e2410d0e (1 revision) (flutter/engine#45485) 
https://skia.googlesource.com/skia.git/+log/a7f50692638d..0d91e2410d0e

2023-09-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 69c94adeb4da to 59f488872a6e (9 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com,brianosman@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-06 08:57:35 +00:00
skia-flutter-autoroll
69420e1767 Roll Skia from 619eef2d0d67 to a7f50692638d (1 revision) (flutter/engine#45483) 
https://skia.googlesource.com/skia.git/+log/619eef2d0d67..a7f50692638d

2023-09-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from e691a4edb19a to d664543f3e6d (8 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com,brianosman@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-06 07:28:23 +00:00
skia-flutter-autoroll
28202e1440 Roll Skia from 72d57724bcb8 to 619eef2d0d67 (1 revision) (flutter/engine#45481) 
https://skia.googlesource.com/skia.git/+log/72d57724bcb8..619eef2d0d67

2023-09-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from f5590cb5133d to cba82c7c6f4a (5 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com,brianosman@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-06 05:38:04 +00:00
skia-flutter-autoroll
48250f55bc Roll Fuchsia Mac SDK from bHw1LzoikQJthLkTE... to dFe-t1SosqZwU5lZR... (flutter/engine#45479) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-06 03:54:49 +00:00
skia-flutter-autoroll
d2e6ec6c5e Roll ANGLE from 0ff71d5ecd25 to d664543f3e6d (1 revision) (flutter/engine#45477) 
0ff71d5ecd..d664543f3e

2023-09-06 syoussefi@chromium.org Metal: Move setupDraw and associated code to executable

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC flutter-engine@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-06 03:01:04 +00:00
skia-flutter-autoroll
ff543afd47 Roll Skia from 3a3a64670e08 to 72d57724bcb8 (1 revision) (flutter/engine#45476) 
https://skia.googlesource.com/skia.git/+log/3a3a64670e08..72d57724bcb8

2023-09-06 johnstiles@google.com Add support for write-only storage texture types in WGSL.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com,brianosman@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-06 02:29:04 +00:00
skia-flutter-autoroll
aacaf98197 Roll Skia from ce2da423cb5d to 3a3a64670e08 (1 revision) (flutter/engine#45475) 
https://skia.googlesource.com/skia.git/+log/ce2da423cb5d..3a3a64670e08

2023-09-06 johnstiles@google.com Add support for pixel-format flags in SPIR-V backend.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com,brianosman@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-06 01:44:48 +00:00
skia-flutter-autoroll
1b9c7351c3 Roll Skia from 0a253625a76a to ce2da423cb5d (1 revision) (flutter/engine#45473) 
https://skia.googlesource.com/skia.git/+log/0a253625a76a..ce2da423cb5d

2023-09-06 johnstiles@google.com Add WGSL support for compute barrier intrinsics.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com,brianosman@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-06 01:01:24 +00:00
Jonah Williams
62031173dd [Impeller] construct text frames on UI thread. (flutter/engine#45418) 
Conversion of SkTextBlobs to impeller::TextFrame objects is one of the most expensive operations in display list dispatching. While the rest of the engine and framework makes a reasonable attempt to cache the SkTextBlobs generated during paragraph construction, the design of the dl dispatcher means that these the Impeller backend will always reconstruct all text frames on each frame - even if the display list/picture that contained those text frames was unchanged.

Removing this overhead is one of the goals of https://github.com/flutter/engine/pull/45386 , however this patch is also fairly risky and will be difficult to land. As a more incremental solution, we can instead construct the impeller::TextFrame objects when performing paragraph painting and record them in the display list. This both moves the text frame construction to the UI thread and allows the framework/engine to cache unchanged text frames.

This also does not conflict with the dl_aiks_canvas patch directly, and is fine to land before or after it does. (though I'd argue we should land this first).

To compare the current performance levels, I ran the complex_layout_scroll perf test, since this is fairly text filled. On a Pixel 6 pro.   Across several runs this is a fairly consistent ~1ms raster time improvement.

### Skia
```
  "average_frame_build_time_millis": 1.497333333333333,
  "90th_percentile_frame_build_time_millis": 2.038,
  "99th_percentile_frame_build_time_millis": 17.686,
  "worst_frame_build_time_millis": 23.095,
  "missed_frame_build_budget_count": 3,
  "average_frame_rasterizer_time_millis": 5.5078589743589745,
  "stddev_frame_rasterizer_time_millis": 2.226343414420338,
  "90th_percentile_frame_rasterizer_time_millis": 7.481,
  "99th_percentile_frame_rasterizer_time_millis": 19.11,
  "worst_frame_rasterizer_time_millis": 79.799,
  "missed_frame_rasterizer_budget_count": 7,
  "frame_count": 234,
  "frame_rasterizer_count": 234,
  "new_gen_gc_count": 10,
  "old_gen_gc_count": 2,
 ```
 
 ### Impeller (ToT)
 
 ```
   "average_frame_build_time_millis": 1.431575000000001,
  "90th_percentile_frame_build_time_millis": 2.196,
  "99th_percentile_frame_build_time_millis": 14.486,
  "worst_frame_build_time_millis": 23.728,
  "missed_frame_build_budget_count": 2,
  "average_frame_rasterizer_time_millis": 6.536087499999999,
  "stddev_frame_rasterizer_time_millis": 1.9902712500000004,
  "90th_percentile_frame_rasterizer_time_millis": 9.705,
  "99th_percentile_frame_rasterizer_time_millis": 14.727,
  "worst_frame_rasterizer_time_millis": 17.838,
  "missed_frame_rasterizer_budget_count": 1,
  "frame_count": 240,
  "frame_rasterizer_count": 240,
  "new_gen_gc_count": 10,
  "old_gen_gc_count": 2,
  ```
  
  ### Impeller (Patched)
  
  ```
    "average_frame_build_time_millis": 1.4500167364016743,
  "90th_percentile_frame_build_time_millis": 2.478,
  "99th_percentile_frame_build_time_millis": 14.883,
  "worst_frame_build_time_millis": 18.782,
  "missed_frame_build_budget_count": 1,
  "average_frame_rasterizer_time_millis": 5.023033333333336,
  "stddev_frame_rasterizer_time_millis": 1.6445388888888894,
  "90th_percentile_frame_rasterizer_time_millis": 7.814,
  "99th_percentile_frame_rasterizer_time_millis": 13.497,
  "worst_frame_rasterizer_time_millis": 15.008,
  "missed_frame_rasterizer_budget_count": 0,
  "frame_count": 239,
  "frame_rasterizer_count": 240,
  "new_gen_gc_count": 8,
  "old_gen_gc_count": 0,
  ```
 2023-09-06 00:50:48 +00:00
Jia Hao
6aec1aa55e Add import for <unordered_map> to fix the g3 build (flutter/engine#45471) 
Fixes the following in G3 (b/299185514):

```
impeller/typographer/font_glyph_pair.h:27:27: error: no template named 'unordered_map' in namespace 'std'; did you mean 'unordered_set'?
using FontGlyphMap = std::unordered_map<ScaledFont, std::unordered_set<Glyph>>;
                     ~~~~~^
```

I don't really know why the lack of this import only breaks the g3 build, but not here. My guess is that it's being imported transitively in some other import that's being ifdef-ed out in g3. 

But since we're already using it in ee18450664/impeller/typographer/font_glyph_pair.h (L27), we probably want to use the import in this file anyway.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-09-06 00:12:39 +00:00
skia-flutter-autoroll
f3e5e15c38 Roll Skia from af473004622f to 0a253625a76a (2 revisions) (flutter/engine#45470) 
https://skia.googlesource.com/skia.git/+log/af473004622f..0a253625a76a

2023-09-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from f2f4bb6f20ec to 041cc036f086 (12 revisions)
2023-09-05 scroggo@google.com SkSharingProc: Use THashMap instead of unordered_map

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com,brianosman@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-06 00:04:34 +00:00
skia-flutter-autoroll
ee18450664 Roll Skia from 1019c10a2d38 to af473004622f (2 revisions) (flutter/engine#45469) 
https://skia.googlesource.com/skia.git/+log/1019c10a2d38..af473004622f

2023-09-05 briansalomon@gmail.com Port GrMemoryPool emscripten alignment fix to SkSL::MemoryPool
2023-09-05 johnstiles@google.com Reject local-size qualifier of zero.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com,brianosman@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-05 23:16:19 +00:00
Zachary Anderson
b672497bc9 Adds a comment on clang_arm64_apilevel26 toolchain usage (flutter/engine#45467) 
Companion comment to the one in https://github.com/flutter/buildroot/pull/761
 2023-09-05 22:56:47 +00:00
Chris Yang
a101546179 [iOS ] Fix errors in unittest and scenario tests running against iOS 17 simulators (details in the description) (flutter/engine#45391) 
1. New Mac version seems to have updated the locale data, to match the mac change, we can dynamically read the data when testing instead of hard coding.

2. "we are sending a UIImage type as parameter to `XCTAttachment attachmentWithScreenshot:`, which takes a `XCUIScreenshot` as parameter, this is not supposed to pass in old iOS versions." In this PR we updated the parameter to use the `XCUIScreenshot` type.

Fixes https://github.com/flutter/flutter/issues/133783

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-09-05 22:45:22 +00:00
skia-flutter-autoroll
702d8bce4f Roll Skia from 2b9fc6a2c250 to 1019c10a2d38 (2 revisions) (flutter/engine#45466) 
https://skia.googlesource.com/skia.git/+log/2b9fc6a2c250..1019c10a2d38

2023-09-05 johnstiles@google.com Add support for @workgroup_size to WGSL code generator.
2023-09-05 michaelludwig@google.com Remove unnecessary semicolon in SkTime.h

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com,brianosman@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-05 22:32:31 +00:00
Chris Yang
59ce383ddb Fix iOS unittests leak in shared.invoke method channel that causes crash (flutter/engine#45416) 
Fixes https://github.com/flutter/flutter/issues/133776

"The crash is due to testShareScreenInvoked presents the activityViewController, which prevents the engineViewController to be dealloc'd in the test: https://github.com/flutter/engine/blob/main/shell/platform/darwin/ios/framework/Source/FlutterPlatformPlugin.mm#L161C4-L161C24"

This fix stubbing the presentViewController call, which prevents the viewController being alloc'd, thus preventing the leak. It is probably sufficient for this test.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-09-05 22:08:10 +00:00
skia-flutter-autoroll
19ea7c2d6e Roll Skia from 7e80aedd05b6 to 2b9fc6a2c250 (1 revision) (flutter/engine#45465) 
https://skia.googlesource.com/skia.git/+log/7e80aedd05b6..2b9fc6a2c250

2023-09-05 lovisolo@google.com [bazel] Extract goldctl steps from bazel_test_gm.go into a common package.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com,brianosman@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-05 21:47:00 +00:00