firka/flutter
3
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
34,855 Commits 1 Branch 0 Tags
b18dfd5fa7dfe12956d9e7cd8431a3287f3c8e76
Commit Graph

34855 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Jonah Williams
b18dfd5fa7 [Impeller] add missing null check. (flutter/engine#51711) 
surface can return null if we failed to allocate MSAA or depth/stencil textures.
 2024-03-27 17:55:04 +00:00
Jonah Williams
d93f7f3275 [Impeller] fix remaining Validation errors. (flutter/engine#51692) 
Fixes https://github.com/flutter/flutter/issues/145039

Some of the errors were due to unconsumed fragment shader inputs. Enabling VK_KHR_maintenance4 relaxes this restriction.
 2024-03-27 17:37:51 +00:00
Jason Simmons
7ab0f69480 Add local paths for the Dart macros package, which is now a dependency of the analyzer package (flutter/engine#51709) 2024-03-27 17:27:02 +00:00
Brandon DeRosier
1cc55b8a1c [Impeller] Transform geometry to safe depth ranges instead of forcing discrete depth values. (flutter/engine#51673) 
Resolves https://github.com/flutter/flutter/issues/144333. (Specifically, this [follow-up issue](https://github.com/flutter/flutter/issues/144333#issuecomment-2002399870))

When drawing objects with a perspective transform, the rasterizer applies perspective correction for interpolated vertex attributes. By absorbing W and replacing Z with a discrete value, we were essentially removing all perspective information and disabling perspective correction.

Instead, we can manipulate the Entity transform to remap the output Z range to fit within the small depth slices that each Entity is allotted.

The golden draws a clip sandwich:
1. Draw and restore a difference clip _before_ drawing the airplane image. This clip will get drawn to the depth buffer behind the airplane image.
2. Draw an oval clip that applies to the airplane image. This clip will get drawn in front of the airplane image on the depth buffer.
3. Draw the airplane image with a 3D rotation and perspective transform.
4. Draw a semi-translucent blue circle atop all previous draws.

Before:

https://github.com/flutter/engine/assets/919017/c2a7d012-714e-4234-83ac-61c792172f30

After:

https://github.com/flutter/engine/assets/919017/de3b78ff-00bf-4bc9-8821-8e86b9a9e6bf
 2024-03-27 17:25:07 +00:00
Matan Lurey
c935c3ba36 Fail pre-submit if a negative image is encountered as part of goldctl imgtest add. (flutter/engine#51685) 
`flutter/engine`-side fix for https://github.com/flutter/flutter/issues/145043.

- Before this PR, if a negative image was encountered, we'd silently pass pre-submit, merge, and turn the tree red.
- After this PR, a negative image both makes pre and post-submit red.

Added tests, and fixed up some unrelated tests that were accidentally setting `pid` instead of `exitCode`. Oops!

/cc @zanderso and @eyebrowsoffire (current engine sheriff).
 2024-03-27 16:46:22 +00:00
hellohuanlin
34f5c82ffc [ios]ignore single edge pixel instead of rounding (flutter/engine#51687) 
The previous PR https://github.com/flutter/flutter/issues/143420 rounds out the layers and rounds in the platform views. This results in missing pixel on the edge of the intersection when there's fractional coordinate (as shown in the screenshot below), because platform view is below the layers. 

It turns out that we have to round out both platform view and layers, because: 
- rounding in platform view rects will result in missing pixels on the edge of the intersection. 
- rounding in layer rects will result in missing pixels on the edge of the layer that's on top of the platform view. 

This PR simply skips the single (or partial) pixel on the edge, which is a special case, while still preserve the `roundOut` behavior for general non-edge cases. 

Before the fix, notice a very thin gray line cutting through the purple box: 

<img src="https://github.com/flutter/engine/assets/41930132/1482d81a-337e-4841-ac08-eff08bbc71ef" height="500">

Then after the fix, the gray line is gone: 

<img src="https://github.com/flutter/engine/assets/41930132/0eddae69-ab62-4de6-8932-c67cc5aced73" height="500">

*List which issues are fixed by this PR. You must list at least one issue.*

https://github.com/flutter/flutter/issues/143420

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-03-27 16:46:19 +00:00
skia-flutter-autoroll
c6c2d991c2 Roll Skia from b69be9d75cdd to 5ed91aaa4cff (1 revision) (flutter/engine#51702) 
https://skia.googlesource.com/skia.git/+log/b69be9d75cdd..5ed91aaa4cff

2024-03-27 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from d03adea71fc0 to 3de0f00ef217 (3 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,jamesgk@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-27 13:37:14 +00:00
skia-flutter-autoroll
51776d2bd9 Roll Skia from 7cb8174ce166 to b69be9d75cdd (1 revision) (flutter/engine#51701) 
https://skia.googlesource.com/skia.git/+log/7cb8174ce166..b69be9d75cdd

2024-03-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from eacd6acdcb00 to 8e7d33793418 (11 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,jamesgk@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-27 08:11:21 +00:00
skia-flutter-autoroll
4ba16cd43f Roll Skia from 4a220d6ecac7 to 7cb8174ce166 (1 revision) (flutter/engine#51700) 
https://skia.googlesource.com/skia.git/+log/4a220d6ecac7..7cb8174ce166

2024-03-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from db77997f71e0 to 4f5c3553ddc3 (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,jamesgk@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-27 07:10:24 +00:00
skia-flutter-autoroll
fcd242c71e Roll Skia from 2aa9e6359a5c to 4a220d6ecac7 (2 revisions) (flutter/engine#51699) 
https://skia.googlesource.com/skia.git/+log/2aa9e6359a5c..4a220d6ecac7

2024-03-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 5de7eb219957 to d03adea71fc0 (8 revisions)
2024-03-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from f847b3c18c27 to a21b7442fbc2 (13 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,jamesgk@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-27 05:55:21 +00:00
skia-flutter-autoroll
2f0ca29a35 Roll Skia from ef6272ca7762 to 2aa9e6359a5c (1 revision) (flutter/engine#51697) 
https://skia.googlesource.com/skia.git/+log/ef6272ca7762..2aa9e6359a5c

2024-03-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from c18c48f0aba5 to a21b7442fbc2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,jamesgk@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-27 04:55:37 +00:00
skia-flutter-autoroll
be7aed0b9d Roll Skia from 23a5617e7f47 to ef6272ca7762 (1 revision) (flutter/engine#51696) 
https://skia.googlesource.com/skia.git/+log/23a5617e7f47..ef6272ca7762

2024-03-27 michaelludwig@google.com [graphite] Add NotifyInUse parallel to AddToKey

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,jamesgk@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-27 03:21:22 +00:00
skia-flutter-autoroll
947bc10acf Roll Fuchsia Linux SDK from uu8lffXkeJQ9PC96I... to Lk8KBU-c97ROj-YHm... (flutter/engine#51690) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-27 00:07:04 +00:00
Zachary Anderson
75fc553fe7 Turn off internal retries for Android scenario app tests (flutter/engine#51689) 
The idea is to make flakes more visible on the dashboard.
 2024-03-26 23:11:25 +00:00
skia-flutter-autoroll
66c88b1d01 Roll Skia from 1808016c7a6d to 23a5617e7f47 (1 revision) (flutter/engine#51688) 
https://skia.googlesource.com/skia.git/+log/1808016c7a6d..23a5617e7f47

2024-03-26 bungeman@google.com Roll recipe_bundle (5484 commits)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,jamesgk@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-26 22:49:16 +00:00
Chris Bracken
70867ee4d9 [macOS] Consolidate FlutterViewController static types/data (flutter/engine#51486) 
No semantic changes, just consolidates static functions in FlutterViewController.mm local to the translation unit into a single contiguous block at the top.

Also includes three minor (non-semantic) changes:
* Corrects static function naming to UpperCamelCase
* Adds doc comments for `OnKeyboardLayoutChanged`
* Adds a mark to help highlight the static data/function block at the top of the file in Xcode.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-03-26 21:46:53 +00:00
skia-flutter-autoroll
9945d244bb Roll Skia from 0590062821dc to 1808016c7a6d (3 revisions) (flutter/engine#51686) 
https://skia.googlesource.com/skia.git/+log/0590062821dc..1808016c7a6d

2024-03-26 michaelludwig@google.com [graphite] Use DrawTask to simplify Device flushing/snapping
2024-03-26 michaelludwig@google.com Fix expected clip count in picture playback
2024-03-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from c77c6203b5c8 to db77997f71e0 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,jamesgk@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-26 21:43:11 +00:00
Jonah Williams
7f3622ccea [iOS] remove arbitrary framerate cap. (flutter/engine#51663) 
This doesn't actually seem to be helping. For the most part, the frame time of the banners is steady with occassional spikes. Adding the framerate cap doesn't help the spikes, since those are in the 30+ ms frame time, and just results in everything else looking janky as well (especially if we dance around the cap, then we go 120 - 80)

Since this is based on an arbitrary number, from an arbitrary app, on an arbitrary point in time we should remove it and instead try to fix the performance problems
 2024-03-26 21:35:08 +00:00
Jonah Williams
92abaefe25 [Impeller] use screen space coordinates for dithering. (flutter/engine#51668) 
Currently we're using the canvas coordinate positions for dithering. This usually works, but if the gradient includes a transform, then we might end up with 1 canvas coordinate pt = multiple physical pixels. This can result dithering artifacts since larger blocks will get the same color weight.

instead we can use gl_FragCoord.xy to get the screenspace coordinates which aren't effect by this transform.

Fixes https://github.com/flutter/flutter/issues/145481

## Before

![flutter_04](https://github.com/flutter/engine/assets/8975114/5f5c19a5-575b-45fb-8f58-c5dc4e46dfb1)

## After

![flutter_05](https://github.com/flutter/engine/assets/8975114/8e80c967-a73d-433c-a16d-918f2aa042db)

Using the app from https://github.com/flutter/flutter/issues/145481 but with the scaling factor increased to 10.0.
 2024-03-26 20:48:04 +00:00
skia-flutter-autoroll
3eb642ef4c Roll Dart SDK from 09e56db7d600 to a600b67424a8 (5 revisions) (flutter/engine#51684) 
https://dart.googlesource.com/sdk.git/+log/09e56db7d600..a600b67424a8

2024-03-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-275.0.dev
2024-03-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-274.0.dev
2024-03-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-273.0.dev
2024-03-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-272.0.dev
2024-03-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-271.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-26 20:31:07 +00:00
Jason Simmons
bc7a98619d [Impeller] Do not apply mask filters to a DrawPaint cover geometry (flutter/engine#51670) 
The DisplayListBuilder only updates the paint attributes that are relevant to a given operation.  DrawPaint does not support mask filters, so DisplayListBuilder::DrawPaint will not modify the mask filter state. So a call to DrawPaint in the display list dispatcher may receive a paint containing a mask filter set by a previous call.

Aiks Canvas::DrawPaint should ignore any mask filter set on the paint (matching the spec for Skia's SkCanvas::drawPaint)

Fixes https://github.com/flutter/flutter/issues/145442
 2024-03-26 19:34:15 +00:00
Jim Graham
118bfc65c4 [Impeller] Simplify calculation of Matrix::GetMaxBasisXY() (flutter/engine#51664) 
Since 2D coordinates have a `Z` value of `0.0`, they don't need to include the Z basis vector in calculating a scale.
 2024-03-26 19:03:04 +00:00
Ryan Macnak
df1c571aec Stop rolling zlib with Dart SDK rolls. (flutter/engine#51667) 
The engine is not compatible with newer versions of zlib that Dart needs
to unblock toolchain rolls.
 2024-03-26 12:02:22 -07:00
skia-flutter-autoroll
fbf18e2491 Roll Skia from 90cfbf5fb91e to 0590062821dc (2 revisions) (flutter/engine#51680) 
https://skia.googlesource.com/skia.git/+log/90cfbf5fb91e..0590062821dc

2024-03-26 bungeman@google.com Fix NoDEPS builds
2024-03-26 kjlubick@google.com Add in sksl tracing flag that is still referred to externally

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,jamesgk@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-26 18:34:18 +00:00
Jackson Gardner
af3d972f03 Pass the flutter test font by default. (flutter/engine#51671) 
In the default case, where no fonts are specified, we should specify the flutter test font. This fixes a swath of framework tests in skwasm.
 2024-03-26 18:16:58 +00:00
Jonah Williams
4e9d202574 [Impeller] revert usage of foreground blend optimization. (flutter/engine#51679) 
Fixes https://github.com/flutter/flutter/issues/144109

The Foreground blend optimization attempts to combine what would be a composited operation directly into the parent pass. Unfortunately, this doesn't work if the entity has a non scale/translate transform. Since we don't actually know the entities geometry, we've been using the coverage rect - but the coverage rect is always an axis aligned rectangle. So we can't use it to determine the actual geometry.
 2024-03-26 18:09:28 +00:00
Jonah Williams
ca4544834a [Impeller] Refactor clip stack into separate testable class. (flutter/engine#51656) 
The clip coverage tracking has had some bugs, but its been difficult to test as it was mixed into the regular entity pass workflow. This change pulls this logic and the clip recorder logic into a new class that is responsible for managing the coverage stacks.

Adds an unbalanced restore unit test as well.
 2024-03-26 18:02:56 +00:00
Zachary Anderson
eee04ffd80 Roll buildroot to ba3ca696f4f95e998707523be755c15440c6bf3f (flutter/engine#51678) 
To pick up https://github.com/flutter/buildroot/pull/840
 2024-03-26 10:29:28 -07:00
Zachary Anderson
636764e33e Use RBE for Fuchsia CI builds (flutter/engine#51675) 
I'm not seeing the failures I had seen in these builds previously. I
suspect in the meantime we've rolled reclient forward in CI.
 2024-03-26 10:19:59 -07:00
skia-flutter-autoroll
5157fd60b2 Roll Skia from 7ffd936a66df to 90cfbf5fb91e (15 revisions) (flutter/engine#51677) 
https://skia.googlesource.com/skia.git/+log/7ffd936a66df..90cfbf5fb91e

2024-03-26 sunnyps@chromium.org graphite: Process mapped client buffers in checkAsyncWorkCompletion
2024-03-26 kjlubick@google.com Fix Docker and SwiftShader builds
2024-03-26 double1kai@gmail.com Add vector support for LoongArch in SkRasterPipeline
2024-03-26 bungeman@google.com Update depot_tools, recipes-py; use vpython3
2024-03-26 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll vulkan-deps from b573e0c2eee9 to c77c6203b5c8 (3 revisions)
2024-03-26 sky@chromium.org SkPath: reduces cost of addRect
2024-03-26 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from e1d1c2a9f534 to 5de7eb219957 (4 revisions)
2024-03-26 49699333+dependabot[bot]@users.noreply.github.com Bump express from 4.17.3 to 4.19.2 in /tools/run-wasm-gm-tests
2024-03-26 49699333+dependabot[bot]@users.noreply.github.com Bump express from 4.18.2 to 4.19.2 in /tools/perf-canvaskit-puppeteer
2024-03-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from d2cef82a8fd3 to eacd6acdcb00 (40 revisions)
2024-03-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 3a33a92e0392 to f847b3c18c27 (19 revisions)
2024-03-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 3c18c5b7edc5 to c18c48f0aba5
2024-03-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 992dea31b114 to e1d1c2a9f534 (13 revisions)
2024-03-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 2432e62f9cc1 to b573e0c2eee9 (9 revisions)
2024-03-26 michaelludwig@google.com [graphite] Add DrawTask stub

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,jamesgk@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-26 17:09:58 +00:00
Chris Bracken
6a902db197 [macOS] Disable FlutterEngineTest.CanOverrideBackgroundColor (flutter/engine#51669) 
This was re-enabled in https://github.com/flutter/flutter/issues/124677 after fixing leaks in https://github.com/flutter/engine/pull/50832. Since this test involves an NSWindow, there are separate fixes that should be landed to reduce flakes related to lack of NSWindow close calls in the tests. See related AppKit bug report filed at http://www.openradar.me/FB13291861.

Issue: https://github.com/flutter/flutter/issues/145728
Related issue: https://github.com/flutter/flutter/issues/124677

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-03-26 16:40:49 +00:00
Zachary Anderson
25275dfc89 Roll buildroot to 2a16784938d3be059014d4112f00ac70a386fa0c (flutter/engine#51674) 
To pick up https://github.com/flutter/buildroot/pull/841
 2024-03-26 09:20:01 -07:00
skia-flutter-autoroll
737e34478d Roll Dart SDK from a783a4a043ec to 09e56db7d600 (2 revisions) (flutter/engine#51666) 
https://dart.googlesource.com/sdk.git/+log/a783a4a043ec..09e56db7d600

2024-03-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-270.0.dev
2024-03-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-269.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-26 15:47:22 +00:00
Srujan Gaddam
f55ed6aa70 Change JSBoxedDartObject to JSAny (flutter/engine#51634) 
Closes https://github.com/dart-lang/sdk/issues/55256

d7ce346fba added code to avoid the less performant boxing of JSBoxedDartObject and instead use backend-specific logic to externalize and internalize the UniqueRef until we get a better solution from dart:js_interop. On the JS backends, this relied on casting to and from JSAny, as its representation type is just Object. However, this callback that takes in the UniqueRef as an arg is still typed as accepting JSBoxedDartObject, leading to a cast failure on the JS backends, since the representation type is JSObject.

The fix is to use JSAny. On dart2wasm, this makes no difference, as the underlying representation type does not change.
 2024-03-26 15:41:23 +00:00
Zachary Anderson
dcd7089bab Revert "Disable cleaning up ImageReaders in memory pressure callback" (flutter/engine#51665) 
Reverts flutter/engine#51391

Reason for revert: b/330184547 - I believe there is a good chance that the investigation on that issue was not really adequate to justify this revert, but this change can be easily relanded if reverting this was the wrong choice.
 2024-03-25 23:00:00 +00:00
skia-flutter-autoroll
3ada24d137 Roll Fuchsia Linux SDK from ySBsQPn-0UgTQaXIw... to uu8lffXkeJQ9PC96I... (flutter/engine#51660) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-25 22:38:08 +00:00
skia-flutter-autoroll
0f0427c077 Roll Skia from 625d04f3a7c5 to 7ffd936a66df (7 revisions) (flutter/engine#51657) 
https://skia.googlesource.com/skia.git/+log/625d04f3a7c5..7ffd936a66df

2024-03-25 michaelludwig@google.com [graphite] TaskList uses TArray, no more prepending
2024-03-25 sunnyps@chromium.org graphite: Better memory instrumentation traces
2024-03-25 jvanverth@google.com Update iOS deployment support.
2024-03-25 double1kai@gmail.com Add vector support for LoongArch in SkBlitter_ARGB32.cpp
2024-03-25 brianosman@google.com Remove SkBlurDrawLooper
2024-03-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from cc3b098a5d9f to 2432e62f9cc1 (3 revisions)
2024-03-25 brianosman@google.com Remove SkDrawLooper::asABlurShadow

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jamesgk@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-25 20:34:23 +00:00
lauren n. liberda
8e74e57981 font_subset tests: name correct variant in exception (flutter/engine#51492) 
font_subset tests now respect `--variant`, but the exception message hasn't been changed

*List which issues are fixed by this PR. You must list at least one issue.*
closes https://github.com/flutter/flutter/issues/145412

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-03-25 17:39:13 +00:00
skia-flutter-autoroll
e09fbfc91d Roll Skia from 8a587a10323f to 625d04f3a7c5 (5 revisions) (flutter/engine#51655) 
https://skia.googlesource.com/skia.git/+log/8a587a10323f..625d04f3a7c5

2024-03-25 kjlubick@google.com Enforce IWYU on src/gpu/ganesh/mock
2024-03-25 drott@chromium.org [Fontations-backend] Make Fontations understand named instance ttc index
2024-03-25 michaelludwig@google.com [graphite] Remove unnecessary Task declarations
2024-03-25 robertphillips@google.com [graphite] Improve PaintParamsKeyTest
2024-03-25 robertphillips@google.com [graphite] Add Alpha-only Image handling to Precompilation system

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jamesgk@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-25 17:23:05 +00:00
Jonah Williams
cac99a988a [Impeller] fix unbalanced restores. (flutter/engine#51648) 
Fixes https://github.com/flutter/flutter/issues/145528 by checking if the clip coverage stack is empty for restoring. Adds a protective empty check in clip replay.

I have a plan to pull the clip stack into something more testable to make this better, but opening this as a simpler fix first.
 2024-03-25 16:56:07 +00:00
skia-flutter-autoroll
7ffd143684 Roll Skia from e7ae039f5b1b to 8a587a10323f (1 revision) (flutter/engine#51654) 
https://skia.googlesource.com/skia.git/+log/e7ae039f5b1b..8a587a10323f

2024-03-25 lizeb@google.com [graphite] Free mapped buffers in submit() and performDeferredWork()

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jamesgk@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-25 15:12:22 +00:00
skia-flutter-autoroll
1330c292d1 Roll Skia from e6dc16a6d82d to e7ae039f5b1b (1 revision) (flutter/engine#51653) 
https://skia.googlesource.com/skia.git/+log/e6dc16a6d82d..e7ae039f5b1b

2024-03-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 3a33a92e0392 to 0b7a0ba8ebaa

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jamesgk@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-25 08:00:15 +00:00
skia-flutter-autoroll
21ba588ee9 Roll Skia from 7f2e8320bbfe to e6dc16a6d82d (1 revision) (flutter/engine#51652) 
https://skia.googlesource.com/skia.git/+log/7f2e8320bbfe..e6dc16a6d82d

2024-03-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 653bfbb0555b to 3a33a92e0392 (6 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jamesgk@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-25 06:42:29 +00:00
skia-flutter-autoroll
4000d603c0 Roll Skia from df5d7a960d34 to 7f2e8320bbfe (1 revision) (flutter/engine#51651) 
https://skia.googlesource.com/skia.git/+log/df5d7a960d34..7f2e8320bbfe

2024-03-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 76f1e9715c82 to 992dea31b114 (20 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jamesgk@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-25 05:39:28 +00:00
skia-flutter-autoroll
89223930f6 Roll Skia from fa486cd8b2d0 to df5d7a960d34 (1 revision) (flutter/engine#51650) 
https://skia.googlesource.com/skia.git/+log/fa486cd8b2d0..df5d7a960d34

2024-03-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 46287e4a45a7 to cc3b098a5d9f (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jamesgk@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-25 03:14:34 +00:00
Robert Ancell
ae2ac7f706 Add fl_standard_method_codec_new_with_message_codec() (flutter/engine#51599) 
Matches constructor in
https://api.flutter.dev/flutter/services/StandardMethodCodec-class.html
and is required to make method calls with custom value types.
 2024-03-25 14:06:27 +13:00
skia-flutter-autoroll
e2728c9e62 Roll Fuchsia Linux SDK from IPZvFWIGJFJnJ409e... to ySBsQPn-0UgTQaXIw... (flutter/engine#51649) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-24 21:32:22 +00:00
skia-flutter-autoroll
5e0fe41e50 Roll Dart SDK from 88f531b19ed5 to a783a4a043ec (1 revision) (flutter/engine#51647) 
https://dart.googlesource.com/sdk.git/+log/88f531b19ed5..a783a4a043ec

2024-03-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-268.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-24 18:01:16 +00:00
skia-flutter-autoroll
0b056f8b58 Roll Skia from 755ca0094a77 to fa486cd8b2d0 (2 revisions) (flutter/engine#51646) 
https://skia.googlesource.com/skia.git/+log/755ca0094a77..fa486cd8b2d0

2024-03-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 245a4567847f to 3a33a92e0392
2024-03-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 46742e2dbf18 to 46287e4a45a7 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jamesgk@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-24 07:33:25 +00:00
skia-flutter-autoroll
379eb6ddb8 Roll Dart SDK from 567a19adbe9a to 88f531b19ed5 (1 revision) (flutter/engine#51644) 
https://dart.googlesource.com/sdk.git/+log/567a19adbe9a..88f531b19ed5

2024-03-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-267.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-23 21:49:21 +00:00